On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D
Magnus, thanks for the meeting summary! Please see clarifications
below, to avoid any confusion.
On Tue, Apr 16, 2024 at 11:27 AM Magnus Ihse Bursie
wrote:
>
> This is my summary of what was said in today's meeting:
>
> * Jiangli reported that her team had done extensive testing and not seen
>
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
> 1479: int JAVA_23_VERSION = 67;
> 1480:
> 1481: /** 68 */
We need `@since 24` here.
-
PR Review Comment:
On Tue, 16 Apr 2024 18:00:50 GMT, Vicente Romero wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into JDK-8317376
>> - Merge branch 'master' into JDK-8317376
> Please review several fixes and improvements to the `this-escape` lint
> warning analyzer.
>
> The goal here is to apply some relatively simple logical fixes that improve
> the precision and accuracy of the analyzer, and capture the remaining
> low-hanging fruit so we can consider the
On Tue, Apr 16, 2024 at 9:20 AM Jiangli Zhou wrote:
>
> On Tue, Apr 16, 2024 at 8:30 AM Magnus Ihse Bursie
> wrote:
> >
> > Jiangli,
> >
> > First of all: I tried building the leyden branch "hermetic-java-runtime"
> > but failed. :-( I tried some various attempts to work around the failures,
>
On Tue, 9 Apr 2024 19:43:27 GMT, Erik Joelsson wrote:
> Since we are now able to update the autoconf build-aux files, I think it's
> prudent to semi regularly do just that. I'm not aware of any particular
> platform that has been improved that would affect OpenJDK and I don't think
> we can
On Tue, Apr 16, 2024 at 12:39 PM Jiangli Zhou wrote:
>
> Magnus, thanks for the meeting summary! Please see clarifications
> below, to avoid any confusion.
>
> On Tue, Apr 16, 2024 at 11:27 AM Magnus Ihse Bursie
> wrote:
> >
> > This is my summary of what was said in today's meeting:
> >
> > *
On Tue, 16 Apr 2024 21:21:43 GMT, Chen Liang wrote:
>> Get JDK 24 underway.
>
> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
>
>> 1479: int JAVA_23_VERSION = 67;
>> 1480:
>> 1481: /** 68 */
>
> We need `@since 24` here.
Ah, good catch; looks like I was
> Get JDK 24 underway.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Correct release date as observed in review feedback.
- Improve javadoc of class file update.
-
Changes:
- all:
On 2024-04-16 10:28, Volker Simonis wrote:
Hi, and sorry, I'm completely new to this discussion.
I just wonder how `static-libs-image` is related to the
`graal-builder-image` target which is available in mainline since JDK
11 and builds a static version of all the native libraries excluding
Jiangli,
First of all: I tried building the leyden branch "hermetic-java-runtime"
but failed. :-( I tried some various attempts to work around the
failures, but the javastatic file I ended up with were unable to start.
What kind of environment are you using to build this branch? (OS,
Hi, and sorry, I'm completely new to this discussion.
I just wonder how `static-libs-image` is related to the
`graal-builder-image` target which is available in mainline since JDK
11 and builds a static version of all the native libraries excluding
the Hotspot ones?
@Magnus: will the new, static
On Mon, 15 Apr 2024 13:10:22 GMT, Martin Doerr wrote:
>> It was too bad that I did not see and review this change in the makefiles.
>> :-(
>>
>> While you guys could have gone either way, I strongly dislike the choice to
>> include a redefinition in the makefiles. If this really should be
> The file to build most of the java.desktop native libraries,
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libraries. I also used this opportunity to change the order to be
The macros SHARED_LIBRARY and STATIC_LIBRARY are weird (they do not fit in with
naming and placement of other macros), and almost never used. We should just
get rid of them.
-
Commit messages:
- 8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros
Changes:
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>>
On Mon, 15 Apr 2024 14:21:08 GMT, Magnus Ihse Bursie wrote:
>> Instead of executing code directly in Link.gmk, we set variables that are
>> then evaluated to get the code we want. This is non-transparent and makes it
>> unnecessarily hard to work with the linking code base.
>>
>> This PR
> Instead of executing code directly in Link.gmk, we set variables that are
> then evaluated to get the code we want. This is non-transparent and makes it
> unnecessarily hard to work with the linking code base.
>
> This PR also contains some additional code cleanup/fixes.
Magnus Ihse Bursie
On Wed, 10 Apr 2024 22:14:33 GMT, Kim Barrett wrote:
>> That build failure in shared code does not happen with Xcode clang, gcc, or
>> Visual Studio, even though none of them appear to have a relevant define or
>> include. So the clang variant being used for AIX is different from the Xcode
>>
On Tue, 16 Apr 2024 09:14:25 GMT, Magnus Ihse Bursie wrote:
>> We can not use `#include ` in all files which use `alloca`,
>> because windows does not know this header. Maybe we can use `#include
>> ` unconditionally in globalDefinitions_gcc.hpp, if windows will
>> never use this file.
On Tue, 16 Apr 2024 08:49:02 GMT, Joachim Kern wrote:
>> Should also remove the `#pragma alloca` in os_aix.cpp.
>
> We can not use `#include ` in all files which use `alloca`, because
> windows does not know this header. Maybe we can use `#include `
> unconditionally in
> The file to build most of the java.desktop native libraries,
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libraries. I also used this opportunity to change the order to be
On Tue, 16 Apr 2024 09:15:19 GMT, Magnus Ihse Bursie wrote:
>> That was kind of where the discussion started, and which Kim did not like.
>> If I read him correctly, his suggestion was instead to place:
>>
>> #if defined(_AIX)
>> #include
>> #endif
>>
>> in the files where `alloca` is needed
On Fri, 12 Apr 2024 22:44:35 GMT, Phil Race wrote:
>> @prrace I will need your assistance in confirming that my understanding
>> about the AWT vs 2D split is correct. In particular, `libosxui` gave me some
>> headache, but after trying to dig into the code my understanding ended up
>> being
On Mon, 15 Apr 2024 12:34:53 GMT, Magnus Ihse Bursie wrote:
> Instead of executing code directly in Link.gmk, we set variables that are
> then evaluated to get the code we want. This is non-transparent and makes it
> unnecessarily hard to work with the linking code base.
>
> This PR also
On Tue, 16 Apr 2024 09:49:11 GMT, Magnus Ihse Bursie wrote:
>> Instead of executing code directly in Link.gmk, we set variables that are
>> then evaluated to get the code we want. This is non-transparent and makes it
>> unnecessarily hard to work with the linking code base.
>>
>> This PR
On Tue, 16 Apr 2024 09:31:19 GMT, Magnus Ihse Bursie wrote:
> The macros SHARED_LIBRARY and STATIC_LIBRARY are weird (they do not fit in
> with naming and placement of other macros), and almost never used. We should
> just get rid of them.
This pull request has now been integrated.
On Tue, 16 Apr 2024 11:59:12 GMT, Severin Gehwolf wrote:
> If I understand you correctly, this would be no longer a build-time only
> approach to produce the "linkable runtime"? It would be some-kind of
> jlink-option driven approach (as it would run some code that should only run
> when
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>>
On Tue, 16 Apr 2024 09:31:19 GMT, Magnus Ihse Bursie wrote:
> The macros SHARED_LIBRARY and STATIC_LIBRARY are weird (they do not fit in
> with naming and placement of other macros), and almost never used. We should
> just get rid of them.
Marked as reviewed by erikj (Reviewer).
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
This is my summary of what was said in today's meeting:
* Jiangli reported that her team had done extensive testing and not seen
any problems, both with just the static launcher as generated by the
leyden branch, and with bundled user applications using the One Jar (?)
tool. They tested JDK
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>>
On Tue, 9 Apr 2024 15:36:27 GMT, Archie Cobbs wrote:
>> Please review several fixes and improvements to the `this-escape` lint
>> warning analyzer.
>>
>> The goal here is to apply some relatively simple logical fixes that improve
>> the precision and accuracy of the analyzer, and capture the
On Tue, Apr 16, 2024 at 8:30 AM Magnus Ihse Bursie
wrote:
>
> Jiangli,
>
> First of all: I tried building the leyden branch "hermetic-java-runtime" but
> failed. :-( I tried some various attempts to work around the failures, but
> the javastatic file I ended up with were unable to start.
On Tue, Apr 16, 2024 at 5:40 PM Magnus Ihse Bursie
wrote:
>
> On 2024-04-16 10:28, Volker Simonis wrote:
>
> > Hi, and sorry, I'm completely new to this discussion.
> >
> > I just wonder how `static-libs-image` is related to the
> > `graal-builder-image` target which is available in mainline
Hi,
On Tue, 2024-04-16 at 17:40 +0200, Magnus Ihse Bursie wrote:
> On 2024-04-16 10:28, Volker Simonis wrote:
>
> > Hi, and sorry, I'm completely new to this discussion.
> >
> > I just wonder how `static-libs-image` is related to the
> > `graal-builder-image` target which is available in
41 matches
Mail list logo
