Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Julian Waters
On Mon, 14 Aug 2023 20:57:24 GMT, Phil Race wrote: > I have no time to look at the client changes for quite some time so do not > push it. No matter how many other people approve it. And in the meantime you > can (1) explain how many client tests you ran - and it had better be all of > them

RFR: 8313661: [REDO] Relax prerequisites for java.base-jmod target

2023-08-14 Thread Erik Joelsson
This is a redo of [pull/14561](https://git.openjdk.org/jdk/pull/14561). The change relaxes the prerequisites for the top level java.base-jmod target to not include targets for jmods of upgradable modules. The problem with the previous fix was that jdk.jdeps, which is a non upgradable module,

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Phil Race
On Mon, 14 Aug 2023 21:20:42 GMT, Dean Long wrote: > I had the same confusion, reading "-permissive-" the same as /permissive, but > the trailing "-" means disable. Ah, my brain just saw that trailing - as somebody's idea of hyphenation. That's questionable syntax by the compiler IMO.

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Dean Long
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Phil Race
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-14 Thread Phil Race
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad >

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-14 Thread Erik Joelsson
On Wed, 9 Aug 2023 12:36:59 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Use true/false for

Re: RFR: 8314166: Update googletest to v1.14.0

2023-08-14 Thread Erik Joelsson
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is

Integrated: 8314118: Update JMH devkit to 1.37

2023-08-14 Thread Aleksey Shipilev
On Thu, 10 Aug 2023 14:28:14 GMT, Aleksey Shipilev wrote: > Time to update JMH devkit to latest version. This time, the dependency > version of Commons Math 3 also changed. > https://github.com/openjdk/jmh/blob/362d6579e007f0241f05c1305f0b269fcc2cc27a/pom.xml#L284 > > Additional testing: > -

Re: RFR: 8314118: Update JMH devkit to 1.37

2023-08-14 Thread Aleksey Shipilev
On Thu, 10 Aug 2023 14:28:14 GMT, Aleksey Shipilev wrote: > Time to update JMH devkit to latest version. This time, the dependency > version of Commons Math 3 also changed. > https://github.com/openjdk/jmh/blob/362d6579e007f0241f05c1305f0b269fcc2cc27a/pom.xml#L284 > > Additional testing: > -

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-14 Thread Matthias Baesken
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad >

Re: RFR: 8314118: Update JMH devkit to 1.37

2023-08-14 Thread Claes Redestad
On Thu, 10 Aug 2023 14:28:14 GMT, Aleksey Shipilev wrote: > Time to update JMH devkit to latest version. This time, the dependency > version of Commons Math 3 also changed. > https://github.com/openjdk/jmh/blob/362d6579e007f0241f05c1305f0b269fcc2cc27a/pom.xml#L284 > > Additional testing: > -

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-14 Thread Alan Bateman
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad >

Re: RFR: 8314166: Update googletest to v1.14.0

2023-08-14 Thread Aleksey Shipilev
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is

Re: RFR: 8314118: Update JMH devkit to 1.37

2023-08-14 Thread Aleksey Shipilev
On Thu, 10 Aug 2023 14:28:14 GMT, Aleksey Shipilev wrote: > Time to update JMH devkit to latest version. This time, the dependency > version of Commons Math 3 also changed. > https://github.com/openjdk/jmh/blob/362d6579e007f0241f05c1305f0b269fcc2cc27a/pom.xml#L284 > > Additional testing: > -

RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-14 Thread Matthias Baesken
Currently there is a number of functionality that would be interesting to have for shared lib load operations in the JDK C code. Some examples : Events::log_dll_message for hs-err files reporting JFR event NativeLibraryLoad There is the need to update the shared lib Cache on AIX ( see