Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-16 Thread Julian Waters
On Wed, 16 Aug 2023 19:22:01 GMT, Sergey Bylokhov wrote: > Why initial patch was reverter using this comment: "unfortunately, did not > prove to be as useful as expected"? What was the problem? What about the > "pedantic" option which was added last time? Hi, the problem was that gcc and

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-16 Thread Sergey Bylokhov
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Julian Waters
On Mon, 14 Aug 2023 20:57:24 GMT, Phil Race wrote: > I have no time to look at the client changes for quite some time so do not > push it. No matter how many other people approve it. And in the meantime you > can (1) explain how many client tests you ran - and it had better be all of > them

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Phil Race
On Mon, 14 Aug 2023 21:20:42 GMT, Dean Long wrote: > I had the same confusion, reading "-permissive-" the same as /permissive, but > the trailing "-" means disable. Ah, my brain just saw that trailing - as somebody's idea of hyphenation. That's questionable syntax by the compiler IMO.

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Dean Long
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Phil Race
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-13 Thread Julian Waters
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-09 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done > with some effort, given that the significantly stricter gcc can now compile > an experimental