Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Matias Saavedra Silva
On Fri, 4 Aug 2023 17:29:36 GMT, Coleen Phillimore wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed field namnes to resolve error > > This looks good. Thank you for the reviews @coleenp,

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Dean Long
On Fri, 4 Aug 2023 17:05:55 GMT, Matias Saavedra Silva wrote: >> The recent change in >> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more >> -Wconversion warnings that are addressed in this patch. The aforementioned >> change has overlooked inconsistencies with the types

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Coleen Phillimore
On Fri, 4 Aug 2023 17:05:55 GMT, Matias Saavedra Silva wrote: >> The recent change in >> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more >> -Wconversion warnings that are addressed in this patch. The aforementioned >> change has overlooked inconsistencies with the types

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Matias Saavedra Silva
> The recent change in > [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more > -Wconversion warnings that are addressed in this patch. The aforementioned > change has overlooked inconsistencies with the types used by > `ResolvedFieldEntry` and the method `fill_in()`. Verified