[Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-24 Thread mp+438932
The proposal to merge hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~hwcert-jenkins/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/438932 -- Your team

[Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-24 Thread Paul Larson
The proposal to merge hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~hwcert-jenkins/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/438932 -- Your team

Re: [Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-24 Thread Kevin Yeh
Review: Approve LGTM +1 I think for Kivu project, we still hope you can use the machines that are provisionable. The machines you're using are provisionable at leaet. We also try to make more machines become provisionable that can be shared with you or other team need physical hardware to test.

Re: [Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-20 Thread Paul Larson
Review: Approve Sounds ok to me then. I saw the provisioning at the top and figured it was only happening on provisionable devices. I'd like to get Kevin's +1 also though, since he's a lot more familiar with these systems and the potential impact for SRU testing. --

Re: [Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-20 Thread Hector CAO
thanks ! see below Diff comments: > diff --git a/jobs/kivu/run-kivu.sh b/jobs/kivu/run-kivu.sh > index 4dd109a..559336c 100644 > --- a/jobs/kivu/run-kivu.sh > +++ b/jobs/kivu/run-kivu.sh > @@ -42,14 +42,22 @@ cat > job.yaml < mkdir -p artifacts > cp checkbox-launcher artifacts

Re: [Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-20 Thread Paul Larson
Review: Needs Information A couple of comments below Diff comments: > diff --git a/jobs/kivu/run-kivu.sh b/jobs/kivu/run-kivu.sh > index 4dd109a..559336c 100644 > --- a/jobs/kivu/run-kivu.sh > +++ b/jobs/kivu/run-kivu.sh > @@ -42,14 +42,22 @@ cat > job.yaml < mkdir -p artifacts >

[Canonical-hw-cert] [Merge] hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master

2023-03-14 Thread Hector CAO
Hector CAO has proposed merging hwcert-jenkins-jobs:dev-kivu-update-job into hwcert-jenkins-jobs:master. Commit message: Update for kivu project - Teardown cleanup - Update system provisioning to Ubuntu 22.04.2 - Update according to latest release of checkbox-kivu-provider KIVU-108