Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Egon Willighagen
Hi Nina, Tobias, On Sat, Oct 16, 2010 at 10:27 AM, Nina Jeliazkova jeliazkova.n...@gmail.com wrote: ---  Fixed ---     public boolean hasNext() {     if (!nextAvailableIsKnown) {     hasNext = false;     // now try to parse the next Molecule     try

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Nina Jeliazkova
Hi Egon, On 16 October 2010 11:58, Egon Willighagen egon.willigha...@gmail.comwrote: Hi Nina, Tobias, On Sat, Oct 16, 2010 at 10:27 AM, Nina Jeliazkova jeliazkova.n...@gmail.com wrote: --- Fixed --- public boolean hasNext() { if (!nextAvailableIsKnown) {

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Nina Jeliazkova
I have heard of similar things here... isReady() can indeed mean that the stream does not ended yet, but that there currently is no byte ready... (e.g. network lag)... readLine() is likely blocking, but makes perfect sense. Nina, please convert this into a git patch. Here it is.

[Cdk-user] a time out for CDK patch reviewing?

2010-10-16 Thread Egon Willighagen
Hi all, what should we do with 'old', 'unreviewed' patches? Those patches that have been in the tracker for a long time, and have not seen any comment by reviewers, and as such, patches that are not requested to be revised? Should we create a time out of, say, three months? So that patches that

Re: [Cdk-user] a time out for CDK patch reviewing?

2010-10-16 Thread Rajarshi Guha
On Sat, Oct 16, 2010 at 9:09 AM, Egon Willighagen egon.willigha...@gmail.com wrote: Hi all, what should we do with 'old', 'unreviewed' patches? Those patches that have been in the tracker for a long time, and have not seen any comment by reviewers, and as such, patches that are not requested

Re: [Cdk-user] a time out for CDK patch reviewing?

2010-10-16 Thread Egon Willighagen
On Sat, Oct 16, 2010 at 3:30 PM, Rajarshi Guha rajarshi.g...@gmail.com wrote: That is nice - but we're possibly going to get lots of merge failures if the patches have been lying around too long. In such a case I suspect that a patch will, by default, never get applied :) Good point. So, we