Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-18 Thread Nina Jeliazkova
All: any clue for a unit test here? I do not... I think this fix will go into the library without unit test... if someone does come up with one, we can always add that later... Actually, any of the existing IteratingMDLReader tests would do, by emulating broken InputStreamReader : +

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-18 Thread Egon Willighagen
On Mon, Oct 18, 2010 at 7:50 PM, Nina Jeliazkova jeliazkova.n...@gmail.com wrote: Actually, any of the existing IteratingMDLReader tests would do, by emulating broken InputStreamReader : Nice! I had no idea that creating a custom inputstream was so easy! Got a git patch? Egon -- Dr E.L.

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Egon Willighagen
Hi Nina, Tobias, On Sat, Oct 16, 2010 at 10:27 AM, Nina Jeliazkova jeliazkova.n...@gmail.com wrote: ---  Fixed ---     public boolean hasNext() {     if (!nextAvailableIsKnown) {     hasNext = false;     // now try to parse the next Molecule     try

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Nina Jeliazkova
Hi Egon, On 16 October 2010 11:58, Egon Willighagen egon.willigha...@gmail.comwrote: Hi Nina, Tobias, On Sat, Oct 16, 2010 at 10:27 AM, Nina Jeliazkova jeliazkova.n...@gmail.com wrote: --- Fixed --- public boolean hasNext() { if (!nextAvailableIsKnown) {

Re: [Cdk-user] [Cdk-devel] Problems with IteratingMDLReader

2010-10-16 Thread Nina Jeliazkova
I have heard of similar things here... isReady() can indeed mean that the stream does not ended yet, but that there currently is no byte ready... (e.g. network lag)... readLine() is likely blocking, but makes perfect sense. Nina, please convert this into a git patch. Here it is.