[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. In https://reviews.llvm.org/D48903#1188437, @malaperle wrote: > In https://reviews.llvm.org/D48903#1187605, @simark wrote: > > > If somebody else could run the tests on Windows, it would make me a bit > > more confident too. > > > Which tests/targets exactly? If you

[PATCH] D50291: [C++] Delay checking of constexpr-ness for special members.

Rakete updated this revision to Diff 159160. Rakete added a comment. Add missing test cases. :) Repository: rC Clang https://reviews.llvm.org/D50291 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp test/CXX/special/class.copy/p10.cpp Index:

[PATCH] D50205: [libc++] Add availability markup for aligned new/delete

EricWF added a comment. How does this work when a user provides their own definitions? Does the attribute from the declaration still produce a warning? If so, then I think an in-compiler approach is better. Repository: rCXX libc++ https://reviews.llvm.org/D50205

[PATCH] D50214: Add inherited attributes before parsed attributes.

Meinersbur added a comment. For this patch the goal is to have the attributes in the AST in an order that is less surprising to consumers (including out-of-tree). If we change it now, new/revised code/diagnostics will be written to match this order. I agree that ideally, most attributes

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

phosek added a comment. This change broke the acquire+release case. Concretely, in Flutter we have this code: https://github.com/flutter/engine/blob/master/lib/ui/isolate_name_server/isolate_name_server.h#L26. This worked fine previously, but after this change we're getting an error in

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. In https://reviews.llvm.org/D48903#1187605, @simark wrote: > If somebody else could run the tests on Windows, it would make me a bit more > confident too. Which tests/targets exactly? If you know Repository: rC Clang https://reviews.llvm.org/D48903

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

NoQ added a comment. Yay thx! Yeah, that's the best behavior i can imagine here. Repository: rC Clang https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r338947 - [clangd] Fix fuzzer build.

Author: morehouse Date: Fri Aug 3 18:51:10 2018 New Revision: 338947 URL: http://llvm.org/viewvc/llvm-project?rev=338947=rev Log: [clangd] Fix fuzzer build. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp

r338946 - [clang-fuzzer] Remove unused typedef.

Author: morehouse Date: Fri Aug 3 18:42:47 2018 New Revision: 338946 URL: http://llvm.org/viewvc/llvm-project?rev=338946=rev Log: [clang-fuzzer] Remove unused typedef. Modified: cfe/trunk/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Modified:

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

This revision was automatically updated to reflect the committed changes. rsmith marked an inline comment as done. Closed by commit rC338945: Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end… (authored by rsmith, committed by ). Repository: rC Clang

r338945 - Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

Author: rsmith Date: Fri Aug 3 18:25:06 2018 New Revision: 338945 URL: http://llvm.org/viewvc/llvm-project?rev=338945=rev Log: Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls When a non-extended temporary object is created in a conditional branch, the

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D50286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:521 + CGM.getCodeGenOpts().OptimizationLevel > 0 && + !CGM.getCodeGenOpts().SanitizeAddressUseAfterScope) { +OldConditional = OutermostConditional;

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rsmith updated this revision to Diff 159153. https://reviews.llvm.org/D50286 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/conditional-temporaries.cpp test/CodeGenCXX/lifetime-asan.cpp Index: test/CodeGenCXX/lifetime-asan.cpp

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

This revision was automatically updated to reflect the committed changes. Closed by commit rC338943: LLVM Proto Fuzzer - Run Functions on Suite of Inputs (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50194?vs=159151=159152#toc Repository: rC

r338943 - LLVM Proto Fuzzer - Run Functions on Suite of Inputs

Author: emmettneyman Date: Fri Aug 3 18:18:37 2018 New Revision: 338943 URL: http://llvm.org/viewvc/llvm-project?rev=338943=rev Log: LLVM Proto Fuzzer - Run Functions on Suite of Inputs Summary: Added corpus of arrays to use as inputs for the functions. Check that the two functions modify the

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

emmettneyman updated this revision to Diff 159151. emmettneyman added a comment. ready to land Repository: rC Clang https://reviews.llvm.org/D50194 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp clang/tools/clang-fuzzer/handle-llvm/handle_llvm.h

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:2123 +// This means that the array type is probably "IncompleteType" or some +// type that is not ConstantArray. +if (CAT == nullptr && CommonElementType == nullptr && !NumInitElts) {

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:521 + CGM.getCodeGenOpts().OptimizationLevel > 0 && + !CGM.getCodeGenOpts().SanitizeAddressUseAfterScope) { +OldConditional = OutermostConditional; Why only when

r338942 - [www] Update cxx_status and cxx_dr_status now that Clang 7 has branched.

Author: rsmith Date: Fri Aug 3 18:02:00 2018 New Revision: 338942 URL: http://llvm.org/viewvc/llvm-project?rev=338942=rev Log: [www] Update cxx_status and cxx_dr_status now that Clang 7 has branched. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_status.html

[PATCH] D50291: [C++] Delay checking of constexpr-ness for special members.

Rakete created this revision. Rakete added a reviewer: rsmith. Specific class layouts meant that the constexpr-ness of a special member could only be decided after every special member was seen. However, this was at odds with the implementation, which checked the constexpr-ness for each

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

On Wed, 1 Aug 2018 at 10:52, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We hit this in Chromium too, see crbug.com/869824 > > I've reverted in r338602 > Thanks, fixed and re-landed in r338941. > On Wed, Aug 1, 2018 at 5:26 PM, Benjamin Kramer via cfe-commits > wrote:

r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

Author: rsmith Date: Fri Aug 3 17:57:17 2018 New Revision: 338941 URL: http://llvm.org/viewvc/llvm-project?rev=338941=rev Log: [constexpr] Support for constant evaluation of __builtin_memcpy and __builtin_memmove (in non-type-punning cases). This is intended to permit libc++ to make std::copy

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

emmettneyman updated this revision to Diff 159146. emmettneyman added a comment. New input arrays and minor fixes Repository: rC Clang https://reviews.llvm.org/D50194 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp clang/tools/clang-fuzzer/handle-llvm/handle_llvm.h

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rsmith updated this revision to Diff 159143. rsmith added a comment. Add forgotten test file. https://reviews.llvm.org/D50286 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/conditional-temporaries.cpp test/CodeGenCXX/lifetime-asan.cpp Index: test/CodeGenCXX/lifetime-asan.cpp

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

morehouse accepted this revision. morehouse added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:132 +// Takes a string of IR and compiles it using LLVM's JIT Engine +static void

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

rsmith created this revision. rsmith added a reviewer: rjmccall. When a non-extended temporary object is created in a conditional branch, the lifetime of that temporary ends outside the conditional (at the end of the full-expression). If we're inserting lifetime markers, this means we can end

Re: r338667 - [analyzer] Extend NoStoreFuncVisitor to follow fields.

Should be fixed in trunk > On Aug 3, 2018, at 1:30 PM, George Karpenkov via cfe-commits > wrote: > > Yeah, saw that as well, fix coming. > >> On Aug 3, 2018, at 10:32 AM, Alexander Kornienko > > wrote: >> >> >> >> On Thu, Aug 2, 2018 at 4:03 AM George Karpenkov

[libcxx] r338936 - Mark LWG#2260 as complete. We already did the right thing, so I just added tests to ensure that we continue to DTRT.

Author: marshall Date: Fri Aug 3 16:28:48 2018 New Revision: 338936 URL: http://llvm.org/viewvc/llvm-project?rev=338936=rev Log: Mark LWG#2260 as complete. We already did the right thing, so I just added tests to ensure that we continue to DTRT. Modified:

r338935 - [analyzer] Do not crash in NoStoreFuncVisitor notes if an unexpected region is found.

Author: george.karpenkov Date: Fri Aug 3 16:19:07 2018 New Revision: 338935 URL: http://llvm.org/viewvc/llvm-project?rev=338935=rev Log: [analyzer] Do not crash in NoStoreFuncVisitor notes if an unexpected region is found. Just do not generate the note at all in that case. Modified:

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, zturner. Herald added a subscriber: cfe-commits. The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. In https://reviews.llvm.org/D45015#1188141, @EricWF wrote: > Hi, I'm in the process of moving cities. please take over. > > Thanks, and sorry No worries. Thanks for spending time on this issue and making the fix, committing is the easy part. Good luck with the move.

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338934: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r338934 - [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

Author: vsapsai Date: Fri Aug 3 16:12:37 2018 New Revision: 338934 URL: http://llvm.org/viewvc/llvm-project?rev=338934=rev Log: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable. Libc++ needs to know when aligned allocation is supported by clang, but is otherwise

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rsmith. leonardchan added a project: clang. Compiling the following causes clang to crash void cmp(char *x, __attribute__((address_space(2))) char *y) { 0 ? x : y; } with the message: "wrong cast for

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

rnkovacs added a comment. In https://reviews.llvm.org/D50211#1186630, @NoQ wrote: > I see, so that's how it's done! > > I also noticed that checker name was weird in exploded graph dumps, i.e. it > was showing regular new/delete stuff as if it was done by InnerPointer > checker. I'll check if

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. Hi, I'm in the process of moving cities. please take over. Thanks, and sorry https://reviews.llvm.org/D45015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50205: [libc++] Add availability markup for aligned new/delete

ldionne updated this revision to Diff 159110. ldionne added a comment. Only include availability markup in this patch, do not change whether and when aligned allocation functions are used by the library. This will be handled in a separate patch. Repository: rCXX libc++

[PATCH] D50276: [clang] Fix broken include_next in float.h

ldionne created this revision. ldionne added a reviewer: jfb. Herald added subscribers: cfe-commits, dexonsmith. The code defines __FLOAT_H and then includes the next , which is guarded on __FLOAT_H so it gets skipped entirely. This commit uses the header guard __CLANG_FLOAT_H, like other headers

[libcxx] r338933 - [NFC][libc++] Consistently use spaces to indent

Author: ldionne Date: Fri Aug 3 15:36:53 2018 New Revision: 338933 URL: http://llvm.org/viewvc/llvm-project?rev=338933=rev Log: [NFC][libc++] Consistently use spaces to indent rdar://problem/19988944 Modified: libcxx/trunk/include/__tree libcxx/trunk/include/any

[PATCH] D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

ldionne accepted this revision. ldionne added a comment. What are we waiting for to move forward with this change? Repository: rC Clang https://reviews.llvm.org/D37302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly… (authored by mboehme, committed by ). Changed prior to commit:

[clang-tools-extra] r338932 - [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

Author: mboehme Date: Fri Aug 3 15:20:04 2018 New Revision: 338932 URL: http://llvm.org/viewvc/llvm-project?rev=338932=rev Log: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while Summary: Fixes https://bugs.llvm.org/show_bug.cgi?id=36516.

[PATCH] D49223: [AST] Check described template at structural equivalence check.

a_sidorin added inline comments. Comment at: lib/AST/ASTStructuralEquivalence.cpp:958 + if (D1->isTemplated() != D2->isTemplated()) +return false; balazske wrote: > a_sidorin wrote: > > I think we can move the changes for both RecordDecl and FunctionDecl

[PATCH] D45712: Diagnose invalid cv-qualifiers for friend decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338931: Diagnose invalid cv-qualifiers for friend decls. (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r338931 - Diagnose invalid cv-qualifiers for friend decls.

Author: efriedma Date: Fri Aug 3 15:09:44 2018 New Revision: 338931 URL: http://llvm.org/viewvc/llvm-project?rev=338931=rev Log: Diagnose invalid cv-qualifiers for friend decls. Differential Revision: https://reviews.llvm.org/D45712 Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

emmettneyman updated this revision to Diff 159100. emmettneyman added a comment. Added static to some functions, made small fixes Repository: rC Clang https://reviews.llvm.org/D50194 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. Eric, will you have time to commit this patch? If you don't have time and don't have objections, I plan to land this change on your behalf. https://reviews.llvm.org/D45015 ___ cfe-commits mailing list

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/input_arrays.h:36 + {1, 1, 2, 3, 2, 3, 0, 11, 10, 0, 7, 5, 3, 1, 18, 18, 18, 18, 0, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18,

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 159099. JonasToth added a comment. - add better diagnostics about template instantiated exception types Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

rsmith added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1036 +return; + // That's it. We can't rule out any more cases with the data we have. + rsmith wrote: > lebedev.ri wrote: > > rsmith wrote: > > > I don't like the overlap between the

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

morehouse added a comment. In https://reviews.llvm.org/D50194#1187756, @emmettneyman wrote: > An unrelated question: > Right now I have a mix of `static` and non-`static` functions in > `handle_llvm.cpp`. Should they all be `static`? Any functions that are only used in the same file can and

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:75 +// Helper function to print error message and stop the fuzzer void ErrorAndExit(std::string message) { Unnecessary comment. The naming and implementation

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

rsmith added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1036 +return; + // That's it. We can't rule out any more cases with the data we have. + lebedev.ri wrote: > rsmith wrote: > > I don't like the overlap between the implicit truncation

[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

mboehme updated this revision to Diff 159093. mboehme added a comment. Apply clang-format. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918 Files: clang-tidy/utils/ExprSequence.cpp test/clang-tidy/bugprone-use-after-move.cpp Index:

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

kcc added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:128 +void RunFuncOnInputs(LLVMFunc f, int x) { + if (x) { +for (int i = 0; i < NumArrays; i++) looks like code duplication, also strange name for a variable: 'x'.

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett updated this revision to Diff 159091. juliehockett marked an inline comment as done. juliehockett added a comment. Herald added a subscriber: arphaman. Updating based on recent landed patches & updated tests https://reviews.llvm.org/D43424 Files:

[PATCH] D49796: [ASTImporter] Load external Decls when getting field index.

a_sidorin added a comment. Hi Balázs, The approach is OK but I have some minor comments inline. Comment at: lib/AST/ASTImporter.cpp:2840 - return Index; + assert(false && "Field was not found in its parent context."); + `llvm_unreachable`?

[PATCH] D50269: [compiler-rt][builtins] Don't #include CoreFoundation in os_version_check.c

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: Sanitizers, llvm-commits, dexonsmith, dberris. This breaks some configurations, so just forward declare everything that we need. rdar://35943793 Thanks for taking a look! Erik

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

JonasToth added a comment. @lebedev.ri and @alexfh i would change the tests in https://reviews.llvm.org/D48714 to use CHECK-NOTES. Is it ok, to commit this one? For testing purposes, you could change a single line of `hicpp-exception-baseclass.cpp` to use the CHECK-NOTES. I do the rest :)

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' +

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

emmettneyman updated this revision to Diff 159083. emmettneyman added a comment. Refactored code to avoid memcpy-ing function Repository: rC Clang https://reviews.llvm.org/D50194 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

Re: r338259 - [analyzer] Add support for more invalidating functions in InnerPointerChecker.

Thanks very much for the example! I committed it together with the design correction in r338918. Alexander Kornienko ezt írta (időpont: 2018. aug. 3., P, 5:36): > Thanks for the prompt fix, it solved the problem. > > In case you want to add a regression test, this is what I came up with: > $

[PATCH] D50154: [clangd] capitalize diagnostic messages

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE338919: [clangd] capitalize diagnostic messages (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50154?vs=159059=159080#toc Repository: rCTE Clang Tools

[clang-tools-extra] r338919 - [clangd] capitalize diagnostic messages

Author: arphaman Date: Fri Aug 3 13:43:28 2018 New Revision: 338919 URL: http://llvm.org/viewvc/llvm-project?rev=338919=rev Log: [clangd] capitalize diagnostic messages The diagnostic messages that are sent to the client from Clangd are now always capitalized. Differential Revision:

r338918 - [analyzer] Add test for a crash fixed in r338775.

Author: rkovacs Date: Fri Aug 3 13:42:02 2018 New Revision: 338918 URL: http://llvm.org/viewvc/llvm-project?rev=338918=rev Log: [analyzer] Add test for a crash fixed in r338775. Do not crash if a CXXRecordDecl cannot be obtained for an object. Special thanks for the reproduction to Alexander

Re: r338667 - [analyzer] Extend NoStoreFuncVisitor to follow fields.

Yeah, saw that as well, fix coming. > On Aug 3, 2018, at 10:32 AM, Alexander Kornienko wrote: > > > > On Thu, Aug 2, 2018 at 4:03 AM George Karpenkov via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: george.karpenkov > Date: Wed Aug 1 19:02:40 2018 > New Revision:

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. @erichkeane, @rsmith thanks for taking a look! Comment at: lib/CodeGen/CGExprScalar.cpp:1036 +return; + // That's it. We can't rule out any more cases with the data we have. + rsmith wrote: > I don't like the overlap between

r338916 - [OpenMP] Encode offload target triples into comdat key for offload initialization code

Author: sdmitriev Date: Fri Aug 3 13:19:28 2018 New Revision: 338916 URL: http://llvm.org/viewvc/llvm-project?rev=338916=rev Log: [OpenMP] Encode offload target triples into comdat key for offload initialization code Encoding offload target triples onto comdat group key for offload

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

rsmith added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1036 +return; + // That's it. We can't rule out any more cases with the data we have. + I don't like the overlap between the implicit truncation check and this check. I think you should

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

This revision was automatically updated to reflect the committed changes. Closed by commit rC338916: [OpenMP] Encode offload target triples into comdat key for offload… (authored by sdmitriev, committed by ). Repository: rC Clang https://reviews.llvm.org/D50218 Files:

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D50218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159074. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === ---

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:6187 +Record->dropAttr(); + } else if (Record->needsImplicitMoveConstructor() && + Record->defaultedMoveConstructorIsDeleted()) { Rakete wrote: > Rakete

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 159073. Quuxplusone marked 8 inline comments as done. Quuxplusone added a comment. Correctly drop the attribute from non-relocatable instantiations of class templates (even though they don't print the diagnostic). Repository: rC Clang

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett updated this revision to Diff 159071. juliehockett marked 2 inline comments as done. https://reviews.llvm.org/D48909 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeReader.h Index: clang-tools-extra/clang-doc/BitcodeReader.h

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett updated this revision to Diff 159070. https://reviews.llvm.org/D48909 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeReader.h Index: clang-tools-extra/clang-doc/BitcodeReader.h

[PATCH] D50255: Add test for changing build configuration

simark added a comment. In https://reviews.llvm.org/D50255#1187871, @arphaman wrote: > Thanks! This LGTM. Well, thanks for the hints! Repository: rL LLVM https://reviews.llvm.org/D50255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r338914 - [clangd] Add test for changing build configuration

Author: simark Date: Fri Aug 3 12:40:19 2018 New Revision: 338914 URL: http://llvm.org/viewvc/llvm-project?rev=338914=rev Log: [clangd] Add test for changing build configuration Summary: This patch adds tests for the two ways of changing build configuration (pointing to a particular

[PATCH] D50255: Add test for changing build configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rL338914: [clangd] Add test for changing build configuration (authored by simark, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50255 Files:

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay abandoned this revision. MaskRay added a comment. https://reviews.llvm.org/D50223 has been changed to improve zlib::compress's current SmallVectorImpl interface. This is no longer relevant. Repository: rC Clang https://reviews.llvm.org/D50267

[PATCH] D50110: Handle shared release attributes correctly

aaron.ballman closed this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D50110#1187828, @aaronpuchert wrote: > For now I think I'm done fixing things in the thread safety analysis, but if > I see myself contributing more in the longer term, I will definitely try to >

r338912 - Properly add shared locks to the initial list of locks being tracked, instead of assuming unlock functions always use exclusive locks.

Author: aaronballman Date: Fri Aug 3 12:37:45 2018 New Revision: 338912 URL: http://llvm.org/viewvc/llvm-project?rev=338912=rev Log: Properly add shared locks to the initial list of locks being tracked, instead of assuming unlock functions always use exclusive locks. Patch by Aaron Puchert.

[PATCH] D50255: Add test for changing build configuration

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! This LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50255 ___ cfe-commits mailing list

[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

hokein added a comment. nit: The patch description needs to be updated. https://reviews.llvm.org/D50154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. Sorry, that code got formatted strangely. Here's the same code block in more legible form: MyContainer container; T t; while (GetNextT()) { container.Add(t); if (SomeCondition()) { PassToConsumer(std::move(container)); container.Clear(); }

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. In https://reviews.llvm.org/D49910#1187809, @aaron.ballman wrote: > In https://reviews.llvm.org/D49910#1187492, @mboehme wrote: > > > In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote: > > > > > Are you going to propose adding this attribute to libc++, or

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth updated this revision to Diff 159064. JonasToth added a comment. - get check up to date Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40854 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159062. JonasToth added a comment. get check up to 8.0 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp

[PATCH] D50110: Handle shared release attributes correctly

aaronpuchert added a comment. For now I think I'm done fixing things in the thread safety analysis, but if I see myself contributing more in the longer term, I will definitely try to obtain commit access. Repository: rC Clang https://reviews.llvm.org/D50110

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay added a comment. This depends on https://reviews.llvm.org/D50223 Repository: rC Clang https://reviews.llvm.org/D50267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay created this revision. MaskRay added reviewers: ruiu, rsmith. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50267 Files: lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3828-3829 +RegFnNameParts[1] = "descriptor_reg"; +for (size_t I = 0; I < Devices.size(); ++I) + RegFnNameParts[I + 2U] = Devices[I].getTriple(); +llvm::sort(RegFnNameParts.begin() + 2,

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

aaron.ballman added a comment. In https://reviews.llvm.org/D49910#1187492, @mboehme wrote: > In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote: > > > Are you going to propose adding this attribute to libc++, or is this > > expected to only work with UDTs? > > > I don't have any

[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/Diagnostics.cpp:149 +/// Capitalizes the first word in the diagnostic's message. +std::string capitalizeDiagnosticText(std::string Message) { + if

[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

arphaman added inline comments. Comment at: test/clangd/capitalize-diagnostics.test:1 +# RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s +{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}

[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

arphaman updated this revision to Diff 159059. arphaman marked an inline comment as done. arphaman added a comment. Remove test and update unit test. https://reviews.llvm.org/D50154 Files: clangd/Diagnostics.cpp test/clangd/diagnostics.test

[PATCH] D50110: Handle shared release attributes correctly

aaron.ballman added a comment. In https://reviews.llvm.org/D50110#1187771, @aaronpuchert wrote: > Thanks for the review! Could you commit for me again? I can, but it might also be a good idea for you to obtain your own commit privileges at this point

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159058. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === ---

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

Looks like I missed that the inferred types for the returned tuple elements are references; I will rebuild with ASan and confirm my fix is correct, then commit again. Thanks, Scott On 2018-08-03 13:48, Vlad Tsyrklevich wrote: This change is causing ASan failures on the sanitizer bots:

  1   2   3   >