[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

rjmccall added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:448 mangleVariableEncoding(VD); - else + else if (!isa(D)) llvm_unreachable("Tried to mangle unexpected NamedDecl!"); I don't think we want `ObjCInterfaceDecl`s to enter this

[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D50099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added a comment. In https://reviews.llvm.org/D50152#1191777, @ahatanak wrote: > Since BlockVarCopyInits is a map with key `VarDecl *`, I think we want to add > a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy > expression can throw or not. Or is there a reason to

[libcxx] r339218 - [libcxx] [test] Avoid -Wunused-local-typedef in node_handle.pass.cpp.

Author: bion Date: Tue Aug 7 21:24:47 2018 New Revision: 339218 URL: http://llvm.org/viewvc/llvm-project?rev=339218=rev Log: [libcxx] [test] Avoid -Wunused-local-typedef in node_handle.pass.cpp. Modified: libcxx/trunk/test/std/containers/container.node/node_handle.pass.cpp Modified:

[PATCH] D50412: [libunwind] Fix pointer-to-integer cast warnings on LLP64.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339217: [libunwind] Fix pointer-to-integer cast warnings on LLP64. (authored by cdavis, committed by ). Repository: rL LLVM https://reviews.llvm.org/D50412 Files:

[libunwind] r339217 - [libunwind] Fix pointer-to-integer cast warnings on LLP64.

Author: cdavis Date: Tue Aug 7 21:21:24 2018 New Revision: 339217 URL: http://llvm.org/viewvc/llvm-project?rev=339217=rev Log: [libunwind] Fix pointer-to-integer cast warnings on LLP64. Summary: `long` is too short on LLP64. We have to use `intptr_t` to avoid truncating pointers. Reviewers:

[PATCH] D50412: [libunwind] Fix pointer-to-integer cast warnings on LLP64.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rUNW libunwind https://reviews.llvm.org/D50412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r339216 - Fixed a breaking test case

Author: bviyer Date: Tue Aug 7 19:47:28 2018 New Revision: 339216 URL: http://llvm.org/viewvc/llvm-project?rev=339216=rev Log: Fixed a breaking test case Modified: cfe/trunk/test/CodeGenCXX/empty-struct-init-list.cpp Modified: cfe/trunk/test/CodeGenCXX/empty-struct-init-list.cpp URL:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added a comment. Since BlockVarCopyInits is a map with key `VarDecl *`, I think we want to add a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy expression can throw or not. Or is there a reason to store the bit in `BlockDecl::Capture` instead? Repository: rC

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo updated this revision to Diff 159636. zhaomo added a comment. Fix mistakes and provide more information about the interleaving algorithm https://reviews.llvm.org/D50372 Files: clang/docs/ControlFlowIntegrityDesign.rst Index: clang/docs/ControlFlowIntegrityDesign.rst

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On 7 August 2018 at 17:40, Fangrui Song wrote: > > On 2018-08-07, David Blaikie wrote: > >> >> On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: >> >>On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: >> >>On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>On Tue, 7 Aug 2018

[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

sammccall added subscribers: ilya-biryukov, jkorous. sammccall added a comment. Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya review implementation and happy with whatever you decide) Enabling - negotiating LSP extensions is probably better done in the "capabilities"

Re: [PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya review implementation and happy with whatever you decide) Enabling - negotiating LSP extensions is probably better done in the "capabilities" message exchange than as a command-line flag. Generally, we want this extension on

r339215 - [NFC][VFS] Fix typos in comments.

Author: vsapsai Date: Tue Aug 7 18:28:37 2018 New Revision: 339215 URL: http://llvm.org/viewvc/llvm-project?rev=339215=rev Log: [NFC][VFS] Fix typos in comments. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL:

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a comment. Committed r339214 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r339214 - [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

Author: bion Date: Tue Aug 7 17:49:02 2018 New Revision: 339214 URL: http://llvm.org/viewvc/llvm-project?rev=339214=rev Log: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp (Still pending review at https://reviews.llvm.org/D47400 which has

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a comment. Committed r339213 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r339213 - [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

Author: bion Date: Tue Aug 7 17:47:29 2018 New Revision: 339213 URL: http://llvm.org/viewvc/llvm-project?rev=339213=rev Log: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char

Re: r339210 - PR38286: Don't crash when attempting to define a constructor for an

Would be good to get this into the Clang 7 release. On Tue, 7 Aug 2018 at 17:43, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Aug 7 17:42:42 2018 > New Revision: 339210 > > URL: http://llvm.org/viewvc/llvm-project?rev=339210=rev > Log: >

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal closed this revision. BillyONeal marked 2 inline comments as done. BillyONeal added a comment. Committed r339212 https://reviews.llvm.org/D50421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal updated this revision to Diff 159632. BillyONeal added a comment. Remove comma. https://reviews.llvm.org/D50421 Files: test/std/utilities/template.bitset/includes.pass.cpp Index: test/std/utilities/template.bitset/includes.pass.cpp

[libcxx] r339212 - [libcxx] [test] Remove asserts that and are included by

Author: bion Date: Tue Aug 7 17:43:38 2018 New Revision: 339212 URL: http://llvm.org/viewvc/llvm-project?rev=339212=rev Log: [libcxx] [test] Remove asserts that and are included by Reviewed as https://reviews.llvm.org/D50421 Modified:

r339210 - PR38286: Don't crash when attempting to define a constructor for an

Author: rsmith Date: Tue Aug 7 17:42:42 2018 New Revision: 339210 URL: http://llvm.org/viewvc/llvm-project?rev=339210=rev Log: PR38286: Don't crash when attempting to define a constructor for an incomplete class template. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r339209 https://reviews.llvm.org/D50420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On 2018-08-07, David Blaikie wrote: On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits <

[libcxx] r339209 - [libcxx] [test] Add missing in several tests.

Author: bion Date: Tue Aug 7 17:40:32 2018 New Revision: 339209 URL: http://llvm.org/viewvc/llvm-project?rev=339209=rev Log: [libcxx] [test] Add missing in several tests. Reviewed as https://reviews.llvm.org/D50420 Modified:

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130 +// ... and if that finds at least one declaration that is a function +// template whose first template parameter is a non-type parameter ... +LookupResult::Filter Filter

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington updated this revision to Diff 159629. erik.pilkington added a comment. Address review comments. https://reviews.llvm.org/D50418 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal added inline comments. Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11 +// test that includes , and #include template void test_typedef() {} Quuxplusone wrote: > grammar nit: comma NP: Oxford Comma by Vampire Weekend

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

Quuxplusone added inline comments. Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11 +// test that includes , and #include template void test_typedef() {} grammar nit: comma https://reviews.llvm.org/D50421

[PATCH] D50413: [libunwind][include] Add some missing definitions to .

krytarowski added a comment. NetBSD uses `typedef void *_Unwind_Ptr;` unconditionally in its ``... if that has to be matched. Additionally: `typedef long _Unwind_Word;`. Repository: rUNW libunwind https://reviews.llvm.org/D50413 ___

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This looks fine to me. https://reviews.llvm.org/D50421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r339207 - [CodeGen] IncompleteArray Support

Author: bviyer Date: Tue Aug 7 17:01:21 2018 New Revision: 339207 URL: http://llvm.org/viewvc/llvm-project?rev=339207=rev Log: [CodeGen] IncompleteArray Support Added code to support ArrayType that is not ConstantArray. https://reviews.llvm.org/D49952 rdar://42476155 Added:

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

craig.topper updated this revision to Diff 159627. craig.topper added a comment. Add the test case that I failed to pick up in the original diff. https://reviews.llvm.org/D50168 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtin_clrsb.c Index:

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130 +// ... and if that finds at least one declaration that is a function +// template whose first template parameter is a non-type parameter ... +LookupResult::Filter Filter =

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. [template.bitset] says only that and are included by , but libcxx tests are asserting that and are also included. Note that libcxx's nonstandard assertion of this is already handled by

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. https://reviews.llvm.org/D50420 Files: test/std/strings/basic.string/string.capacity/over_max_size.pass.cpp test/std/strings/string.conversions/stod.pass.cpp test/std/strings/string.conversions/stof.pass.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

shuaiwang added a comment. > - there seems to be a false positive with array-to-pointer decay. > ExprMutAnalyzer does think of it, but maybe there is a bug in it. Could you give a concrete example of this? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. Herald added a subscriber: dexonsmith. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0961r1.html I don't believe an actual defect report was filed for this, but the paper (in the "wording" section)

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: > On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > >> >> >> On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Tue, Aug 7,

[PATCH] D50408: [analyzer] Avoid querying this-pointers for static-methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339201: [analyzer] Avoid querying this-pointers for static-methods. (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D50408 Files:

r339201 - [analyzer] Avoid querying this-pointers for static-methods.

Author: mattd Date: Tue Aug 7 16:13:28 2018 New Revision: 339201 URL: http://llvm.org/viewvc/llvm-project?rev=339201=rev Log: [analyzer] Avoid querying this-pointers for static-methods. Summary: The loop-widening code processes c++ methods looking for `this` pointers. In the case of static

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > > > On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > >> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> >>> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >>>

[PATCH] D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339199: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D50118?vs=158420=159614#toc

r339199 - [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

Author: vsapsai Date: Tue Aug 7 16:00:40 2018 New Revision: 339199 URL: http://llvm.org/viewvc/llvm-project?rev=339199=rev Log: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended. First and subsequent iteration steps are similar, capture this similarity. Reviewers: bruno,

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL339198: [Sema] Ensure an auto non-type template parameter is dependent (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rC339198: [Sema] Ensure an auto non-type template parameter is dependent (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50088?vs=159449=159612#toc Repository:

r339198 - [Sema] Ensure an auto non-type template parameter is dependent

Author: epilk Date: Tue Aug 7 15:59:02 2018 New Revision: 339198 URL: http://llvm.org/viewvc/llvm-project?rev=339198=rev Log: [Sema] Ensure an auto non-type template parameter is dependent The dependent auto was getting stripped away while rebuilding the template parameter type, so substitute

[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

arphaman created this revision. arphaman added reviewers: jkorous, sammccall, ilya-biryukov. Herald added subscribers: dexonsmith, MaskRay, ioeric. This change extends the 'textDocument/publishDiagnostics' notification sent from Clangd to the client. The extension can be enabled using the

[PATCH] D50414: [libunwind][include] Add SEH declarations to .

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, chrib, christof. Make the `_Unwind_Exception` struct correct under SEH. Add a declaration of `_GCC_specific_handler()`, which is used by SEH versions of Itanium

[PATCH] D50413: [libunwind][include] Add some missing definitions to .

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, chrib, christof, krytarowski. Add these declarations which should be present in ``, but aren't. Not that it matters, since most of the time we'll be using Clang's ``

[PATCH] D50412: Fix pointer-to-integer cast warnings on LLP64.

cdavis5x updated this revision to Diff 159607. cdavis5x added a comment. Rebasing against HEAD. Repository: rUNW libunwind https://reviews.llvm.org/D50412 Files: src/UnwindLevel1-gcc-ext.c src/UnwindLevel1.c Index: src/UnwindLevel1.c

r339196 - [NFC] Improve auto-var-init alignment check

Author: jfb Date: Tue Aug 7 15:43:44 2018 New Revision: 339196 URL: http://llvm.org/viewvc/llvm-project?rev=339196=rev Log: [NFC] Improve auto-var-init alignment check We're not actually testing for alignment, we just want to know that whatever incoming alignment got propagated. Do that by

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo updated this revision to Diff 159606. zhaomo added a comment. Updated version of the patch https://reviews.llvm.org/D50372 Files: clang/docs/ControlFlowIntegrityDesign.rst Index: clang/docs/ControlFlowIntegrityDesign.rst

Re: r338301 - Avoid returning an invalid end source loc

*nod* Maybe consistency's enough for now. But yeah, if you can test whether the assertion fires (though for invalid locs, that usually means invalid code - and we don't have nice big repositories of weird invalid code - just the clang regression tests). On Tue, Aug 7, 2018 at 3:27 PM Stephen

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

vsapsai added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,

[PATCH] D50412: Fix pointer-to-integer cast warnings on LLP64.

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, christof. `long` is too short on LLP64. We have to use `intptr_t` to avoid truncating pointers. Repository: rUNW libunwind https://reviews.llvm.org/D50412

[PATCH] D50344: [libc++] Enable aligned allocation based on feature test macro, irrespective of standard

vsapsai added inline comments. Comment at: libcxx/include/__config:993 +!defined(_LIBCPP_BUILDING_LIBRARY) && \ +!defined(__cpp_aligned_new) +# define _LIBCPP_HAS_NO_ALIGNED_ALLOCATION I think I'd rather keep `__cpp_aligned_new >= 201606` check. I don't

Re: r338301 - Avoid returning an invalid end source loc

Ok, I can look into adding the assertion and run the tests with it to see if anything comes up. I made a tool which dumps SourceLocations reachable from an AST node (I intend to integrate it into clang-query), and I noticed the large amount of mixing of get{Start,End}Loc and

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

rsmith added a comment. Can you also add a test where the `auto` is not top-level (eg, `template`) and a test using `decltype(auto)`? https://reviews.llvm.org/D50088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r338301 - Avoid returning an invalid end source loc

If it never comes up, maybe an assertion would suffice? (& if the assertion ever does fire - hey, we've found a test case to use) How'd you find this/what motivated you to make the change? On Tue, Aug 7, 2018 at 3:11 PM Stephen Kelly wrote: > > Hi David, > > I'm happy to add a test case, but I

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. For reference, here is the output for llvm/lib. F6896569: const_correctness_2_llvm_lib_references F6896567: const_correctness_2_llvm_lib_values_pointers Things i noticed: - lambdas are warned

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. @delesley Did you have a chance to look at this yet? Repository: rC Clang https://reviews.llvm.org/D49885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50408: [analyzer] Avoid querying this-pointers for static-methods.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, fair enough. https://reviews.llvm.org/D50408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r338301 - Avoid returning an invalid end source loc

Hi David, I'm happy to add a test case, but I don't know how to catch this case. It's not obvious to me if any code path intentionally creates a DeclarationNameInfo with a valid start loc and an invalid end loc. Can you suggest a test case? Thanks, Stephen. On 07/08/18 03:23, David

[PATCH] D50408: [analyzer] Avoid querying this-pointers for static-methods.

george.karpenkov added a reviewer: NoQ. george.karpenkov added a subscriber: NoQ. george.karpenkov added a comment. Looks reasonable. @NoQ any further comments? https://reviews.llvm.org/D50408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans added a subscriber: probinson. acoomans added a comment. @probinson does this sound a plausible explanation? Do you have access to a PS4 SDK to confirm the `-debug-info-macro` isn't available at all? Repository: rC Clang https://reviews.llvm.org/D50410

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

acoomans created this revision. acoomans added reviewers: cfe-commits, modocache. Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini. https://reviews.llvm.org/D46776 added support for "did you mean ...?" command line option suggestions. One of the tests was checking against the

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

aaronpuchert added a comment. It seems @phosek was able to fix the issue in https://github.com/flutter/engine/pull/5944. By the way, a nice way to think about the attributes is that they encode state transitions as shown in the following table. This change fills the remaining two gaps. |

[PATCH] D50409: Remove obsolete set call

steveire created this revision. steveire added reviewers: rsmith, dblaikie. Herald added a subscriber: cfe-commits. Case case of the switch statement here makes the same call, but it is already done at the start of the function. Repository: rC Clang https://reviews.llvm.org/D50409 Files:

[PATCH] D50408: [analyzer] Avoid querying this-pointers for static-methods.

mattd created this revision. mattd added a reviewer: dcoughlin. Herald added subscribers: mikhail.ramalho, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. The loop-widening code processes c++ methods looking for `this` pointers. In the case of static methods (which do

r339191 - [NFC] CGDecl factor out constant emission

Author: jfb Date: Tue Aug 7 14:55:13 2018 New Revision: 339191 URL: http://llvm.org/viewvc/llvm-project?rev=339191=rev Log: [NFC] CGDecl factor out constant emission The code is cleaner this way, and with some changes I'm playing with it makes sense to split it out so we can reuse it.

[PATCH] D50389: [clang-tidy] new check for Abseil

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:37 +void DurationDivisionCheck::check(const MatchFinder::MatchResult& result) { + const auto* op = result.Nodes.getNodeAs("op"); + diag(op->getOperatorLoc(), JonasToth

r339188 - Fix one hard coded value I missed in r339185.

Author: dyung Date: Tue Aug 7 14:37:14 2018 New Revision: 339188 URL: http://llvm.org/viewvc/llvm-project?rev=339188=rev Log: Fix one hard coded value I missed in r339185. Modified: cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl Modified:

r339187 - Clean up and simplify RequireCompleteType.

Author: rsmith Date: Tue Aug 7 14:35:41 2018 New Revision: 339187 URL: http://llvm.org/viewvc/llvm-project?rev=339187=rev Log: Clean up and simplify RequireCompleteType. No functional change intended, except that we will now produce more "declared here" notes. Modified:

Re: r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

There's definitely scope for improving this diagnostic text further. Right now I don't think there's an easy way to figure out that the variable is the range variable in a range-based for loop, but I think that case is common enough that that's the level of special-case we should be looking at

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

vlad.tsyrklevich added inline comments. Comment at: clang/docs/ControlFlowIntegrityDesign.rst:283 +At the same time, it is also more efficient in terms of performance because in the interleaved virtual +table address points are consecutive, thus the validity check of a virtual

RE: r339185 - Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Douglas Yung via cfe-commits > Sent: Tuesday, August 07, 2018 5:23 PM > To: cfe-commits@lists.llvm.org > Subject: r339185 - Make test more robust by not checking hard coded debug > info

[PATCH] D50349: Port getStartLoc -> getBeginLoc

steveire added a comment. Thanks Hans. Yes, I made these patches with some simple sed oneliners. Once these are approved in principle, I'll re-generate them before pushing. I have also run clang-format on them, but didn't update Phab with the results to reduce noise. Repository: rC Clang

r339185 - Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

Author: dyung Date: Tue Aug 7 14:22:49 2018 New Revision: 339185 URL: http://llvm.org/viewvc/llvm-project?rev=339185=rev Log: Make test more robust by not checking hard coded debug info values, but instead check the relationships between them. Modified:

r339183 - [analyzer] [tests] Do not be verbose by default when updating reference results.

Author: george.karpenkov Date: Tue Aug 7 14:14:35 2018 New Revision: 339183 URL: http://llvm.org/viewvc/llvm-project?rev=339183=rev Log: [analyzer] [tests] Do not be verbose by default when updating reference results. Modified: cfe/trunk/utils/analyzer/SATestUpdateDiffs.py Modified:

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8377-8381 + } else if (D.hasTrailingRequiresClause()) { +// C++2a [class.virtual]p6 +// A virtual method shall not have a requires-clause. +

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer added a comment. Test case? Comment at: lib/CodeGen/CGBuiltin.cpp:1563 +Value *Result = Builder.CreateCall(F, {Tmp, Builder.getTrue()}); +if (Result->getType() != ResultType) + Result = Builder.CreateIntCast(Result, ResultType, /*isSigned*/true,

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159590. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

rnk added a subscriber: beanz. rnk added a comment. In https://reviews.llvm.org/D15225#1191304, @george.karpenkov wrote: > @rnk As discussed, would it be acceptable for you to just have empty > sanitizer runtime files in the resource directory? I was talking to @beanz, and he suggested adding

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, let's commit this and see how to fix it later. I still think it's more important to come up with clear rules of who is responsible for initializing fields than making sure our warnings are

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8377-8381 + } else if (D.hasTrailingRequiresClause()) { +// C++2a [class.virtual]p6 +// A virtual method shall not have a requires-clause. +

[PATCH] D49199: [analyzer][UninitializedObjectChecker] Pointer/reference objects are dereferenced according to dynamic type

NoQ accepted this revision. NoQ added a comment. This looks roughly correct, but at the same time none of the tests actually exercise the dynamic type propagation. In these tests all the necessary information is obtained from the structure of the MemRegion (directly or via the initial

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

It might be useful to know what other editors do here to know whether this should be a client transformation or baked into the server. Vim syntastic/ale, Emacs flycheck do not seem to do such transformation. What's the editor you are using? On 2018-08-07, Alex L wrote: On Tue, 7 Aug 2018 at

Re: r338732 - [analyzer] Make RegionVector use const reference

On 2018-08-07, David Blaikie wrote: Looks good! Though it may be useful in the future to describe, in the commit message, the motivation for a change - how'd you find this? What motivated you to make this particular fix just now, etc? ("identified using clang-tidy" or "spotted during post-commit

[PATCH] D50380: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

mstorsjo added a comment. @hans Can you merge this for 7.0? This is necessary for https://reviews.llvm.org/D49638 (merged well before the branch) to work properly without causing heap corruption. Repository: rL LLVM https://reviews.llvm.org/D50380

[PATCH] D50380: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL339170: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64 (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r339170 - [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

Author: mstorsjo Date: Tue Aug 7 13:02:40 2018 New Revision: 339170 URL: http://llvm.org/viewvc/llvm-project?rev=339170=rev Log: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64 This matches how GCC defines this struct. Differential Revision: https://reviews.llvm.org/D50380

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL339167: [Sema] Fix for crash on conditional operation with address_space pointer (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r339167 - [Sema] Fix for crash on conditional operation with address_space pointer

Author: leonardchan Date: Tue Aug 7 12:43:53 2018 New Revision: 339167 URL: http://llvm.org/viewvc/llvm-project?rev=339167=rev Log: [Sema] Fix for crash on conditional operation with address_space pointer Compiling the following causes clang to crash ``` char

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rC339167: [Sema] Fix for crash on conditional operation with address_space pointer (authored by leonardchan, committed by ). Repository: rL LLVM https://reviews.llvm.org/D50278 Files:

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea updated this revision to Diff 159574. gtbercea added a comment. Prevent math builtins from being used for nvptx toolchain. Repository: rC Clang https://reviews.llvm.org/D47849 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz added inline comments. Comment at: lib/Sema/SemaConcept.cpp:34 + Diag(ConstraintExpression->getExprLoc(), + diag::err_non_bool_atomic_constraint) + << ConstraintExpression << ConstraintExpression->getType(); saar.raz wrote: >

  1   2   3   >