Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

It seems to have been causing asserts to trip on 64-bit hosts while running tests (ppc64be, ppc64le and x86_64 were all affected), ie: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/9528/steps/test-suite/logs/test.log On Fri, May 17, 2019 at 6:51 AM via cfe-commits

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

I'm looking into this; feel free to revert, or I will if I don't find what's up shortly. Sorry for the problems! On Thu, 16 May 2019 at 22:51, via cfe-commits wrote: > > I'm not sure that is problem. Our internal linux build bot also hit the same > problem and it has a 64-bit CPU. > > Douglas

RE: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

I'm not sure that is problem. Our internal linux build bot also hit the same problem and it has a 64-bit CPU. Douglas Yung -Original Message- From: cfe-commits On Behalf Of Chris Bieneman via cfe-commits Sent: Thursday, May 16, 2019 22:45 To: Chris Bieneman Cc: Richard Smith ;

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

I did some digging before reverting. The bots your patch is failing on are 32-bit CPUs. It looks like your static_assert is assuming 8-byte aligned pointers, so it always fails on the 32-bit builders. -Chris > On May 16, 2019, at 10:14 PM, Chris Bieneman wrote: > > Sorry to do this, but I'm

r360988 - Revert Refactor constant evaluation of typeid(T) to track a symbolic type_info object rather than tracking the originating expression.

Author: cbieneman Date: Thu May 16 22:46:03 2019 New Revision: 360988 URL: http://llvm.org/viewvc/llvm-project?rev=360988=rev Log: Revert Refactor constant evaluation of typeid(T) to track a symbolic type_info object rather than tracking the originating expression. This reverts r360974 (git

r360987 - Revert [c++20] P1327R1: Support for typeid applied to objects of polymorphic class type in constant evaluation.

Author: cbieneman Date: Thu May 16 22:45:57 2019 New Revision: 360987 URL: http://llvm.org/viewvc/llvm-project?rev=360987=rev Log: Revert [c++20] P1327R1: Support for typeid applied to objects of polymorphic class type in constant evaluation. This reverts r360977 (git commit

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Thank you so much! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62050/new/ https://reviews.llvm.org/D62050

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

Sorry to do this, but I'm also reverting r360977, because it seems to be on top of this one. -Chris > On May 16, 2019, at 9:58 PM, Chris Bieneman via cfe-commits > wrote: > > Hey Richard, > > This change is tripping up a bunch of the bots: > >

Re: r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

Hey Richard, This change is tripping up a bunch of the bots: http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/1397 I'm going to revert it so that we don't leave the bots broken overnight. -Chris > On May 16, 2019, at 6:46 PM, Richard Smith via cfe-commits > wrote: > > Author:

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

jdoerfert added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:55-56 +#if defined(_OPENMP) && defined(__cplusplus) +__DEVICE__ const float abs(const float __x) { return ::fabsf((float)__x); } +__DEVICE__ const double abs(const double __x) { return

r360985 - Re-land: Add Clang shared library with C++ exports

Author: cbieneman Date: Thu May 16 21:20:01 2019 New Revision: 360985 URL: http://llvm.org/viewvc/llvm-project?rev=360985=rev Log: Re-land: Add Clang shared library with C++ exports Summary: This patch adds a libClang_shared library on *nix systems which exports the entire C++ API. In order to

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD360984: [ELF] Implement Dependent Libraries Feature (authored by bd1976llvm, committed by ). Changed prior to commit: https://reviews.llvm.org/D60274?vs=195495=199972#toc Repository: rLLD LLVM

Re: r360946 - Add Clang shared library with C++ exports

I’ll re-land disabling if PIC is off. This doesn’t replace the static libraries with object libraries, it just creates an object library target (named obj.${name}) for each static library. That allows the objects to be referenced separately from the archives, so we don’t have to do the

[libclc] r360979 - Creating release candidate rc1 from release_801 branch

Author: tstellar Date: Thu May 16 19:26:13 2019 New Revision: 360979 URL: http://llvm.org/viewvc/llvm-project?rev=360979=rev Log: Creating release candidate rc1 from release_801 branch Added: libclc/tags/RELEASE_801/ libclc/tags/RELEASE_801/rc1/ - copied from r360978,

[libunwind] r360979 - Creating release candidate rc1 from release_801 branch

Author: tstellar Date: Thu May 16 19:26:13 2019 New Revision: 360979 URL: http://llvm.org/viewvc/llvm-project?rev=360979=rev Log: Creating release candidate rc1 from release_801 branch Added: libunwind/tags/RELEASE_801/ libunwind/tags/RELEASE_801/rc1/ - copied from r360978,

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

phosek added a comment. @bd1976llvm do you plan on landing this? We'd really like to start using this feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list

r360977 - [c++20] P1327R1: Support for typeid applied to objects of polymorphic

Author: rsmith Date: Thu May 16 19:16:45 2019 New Revision: 360977 URL: http://llvm.org/viewvc/llvm-project?rev=360977=rev Log: [c++20] P1327R1: Support for typeid applied to objects of polymorphic class type in constant evaluation. Modified:

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda added a comment. After thinking about it, I agree with this change -- there's no way to provide an appropriate default at this level. So, LGTM, but wait for @alexfh's okay. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge edited reviewers, added: sammccall; removed: ilya-biryukov. nridge added a subscriber: sammccall. nridge added a comment. Herald added a subscriber: ilya-biryukov. Changing reviewer to @sammccall as the updates to the patch are closely related to the discussion in D60953

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199956. nridge added a comment. Update as per changes to dependent patch D60953 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

phosek created this revision. phosek added reviewers: smeenai, Szelethus, NoQ. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. When plugins aren't enabled, don't try to run plugins tests. Don't enable plugins unconditionally based on the platform,

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge updated this revision to Diff 199954. nridge marked 5 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 Files:

r360974 - Refactor constant evaluation of typeid(T) to track a symbolic type_info

Author: rsmith Date: Thu May 16 18:46:05 2019 New Revision: 360974 URL: http://llvm.org/viewvc/llvm-project?rev=360974=rev Log: Refactor constant evaluation of typeid(T) to track a symbolic type_info object rather than tracking the originating expression. This is groundwork for supporting

Re: r360946 - Add Clang shared library with C++ exports

To not keep the build broken over night, and since it's a small change that should be easy to reland, I've reverted this for now in r360973. On Thu, May 16, 2019 at 8:52 PM Nico Weber wrote: > Hello, > > this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target > shouldn't be build

r360973 - Revert r360946 "Add Clang shared library with C++ exports"

Author: nico Date: Thu May 16 18:42:37 2019 New Revision: 360973 URL: http://llvm.org/viewvc/llvm-project?rev=360973=rev Log: Revert r360946 "Add Clang shared library with C++ exports" It breaks LLVM_ENABLE_PIC=OFF builds, and it's not clear if the object library approach doesn't impact the

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.h:1 +//===--- CloexecPipeCheck.h - clang-tidy---*- C++ -*-===// +// Please extend to 80 characters. Same in source file. Repository:

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipe2Check.h:1 +//===--- CloexecPipe2Check.h - clang-tidy--*- C++ -*-===// +// Please extend to 80 characters. Same in source file. Repository:

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

efriedma added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:55-56 +#if defined(_OPENMP) && defined(__cplusplus) +__DEVICE__ const float abs(const float __x) { return ::fabsf((float)__x); } +__DEVICE__ const double abs(const double __x) { return

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny, srhines. Herald added a project: clang. pipe2() is better to set O_CLOEXEC flag to avoid file descriptor leakage. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62049 Files:

Re: r360946 - Add Clang shared library with C++ exports

Hello, this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target shouldn't be build in those builds? Also, if I read this right, this makes static libraries for clang always be object libraries. Is that correct? If so, this likely makes the normal clang binary larger and less

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. In D62047#1505838 , @sbc100 wrote: > Does it make sense to support the flags before we support the feature? > > Otherwise lgtm. I think this is OK; flags anyway should be added before actual feature implementation starts in

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. How about using `multi-value`/`MultiValue`/`MULTI-VALUE` (depending on positions)? The repo name is also multi-value. https://github.com/WebAssembly/multi-value Otherwise LGTM.

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_device_functions.h:1604 +#if defined(_OPENMP) && defined(__cplusplus) +__DEVICE__ double log(long double __a) { return __nv_log((double)__a); } +#endif

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:55-56 +#if defined(_OPENMP) && defined(__cplusplus) +__DEVICE__ const float abs(const float __x) { return ::fabsf((float)__x); } +__DEVICE__ const double

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199944. yaqiji added a comment. Changes matcher, test and removed fix it hint for global constants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn accepted this revision. Lekensteyn added a comment. This revision is now accepted and ready to land. Thanks, I have also verified this patch against the above test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

sbc100 added a comment. Does it make sense to support the flags before we support the feature? Otherwise lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62047/new/ https://reviews.llvm.org/D62047

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 199942. shixiao added a subscriber: Eugene.Zelenko. shixiao added a comment. edit doc, add note in release notes, extend unit test to test transitive header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. These features will both be implemented soon, so I thought I would save time by adding

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199939. yaqiji added a comment. Modified code to make it more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 199940. shixiao marked 2 inline comments as done. shixiao edited the summary of this revision. shixiao removed a subscriber: Eugene.Zelenko. shixiao removed a project: clang-tools-extra. shixiao added a comment. elide braces for single-stmt if-s, extend unit

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:55-56 +#if defined(_OPENMP) && defined(__cplusplus) +__DEVICE__ const float abs(const float __x) { return ::fabsf((float)__x); } +__DEVICE__ const double abs(const double __x) { return ::fabs((double)__x); }

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

gtbercea created this revision. gtbercea added reviewers: jdoerfert, hfinkel, tra, caomhin. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. When including the random header in C++, some of the math functions it relies on are not present in the CUDA headers. We

[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji updated this revision to Diff 199931. yaqiji added a comment. removed unnecessary lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji updated this revision to Diff 199932. yaqiji added a comment. Removed unncessary comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. yaqiji updated this revision to Diff 199931. yaqiji added a comment. yaqiji updated this revision to Diff 199932. removed unnecessary lines yaqiji added a comment. Removed unncessary comments.

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:27 +void CloexecPipeCheck::check(const MatchFinder::MatchResult ) { + const std::string = + (Twine("pipe2(") +

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 199926. jcai19 added a comment. Use non-const& type for readbility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files:

r360951 - Remove unneeded alignment spec from builtin_FUNCTION.cpp test

Author: ericwf Date: Thu May 16 16:07:45 2019 New Revision: 360951 URL: http://llvm.org/viewvc/llvm-project?rev=360951=rev Log: Remove unneeded alignment spec from builtin_FUNCTION.cpp test Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp Modified:

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/AST/ASTContext.cpp:6973 QualType PointeeTy = OPT->getPointeeType(); -if (!Options.EncodingProperty() && +if (getLangOpts().ObjCRuntime.isGNUFamily() && +

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505682 , @Szelethus wrote: > In that case, feel free to revert this. If around 11:00 CET time I tried to > recommit with a possible fix (while watching your bots), would that be an > issue? I managed to reproduce

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire updated this revision to Diff 199922. steveire added a comment. Herald added a subscriber: mgorny. Add basic traverser test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 Files:

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. In that case, feel free to revert this. If around 11:00 CET time I tried to recommit with a possible fix (while watching your bots), would that be an issue? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE Szelethus wrote: >

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked 2 inline comments as done. Szelethus added a comment. If there's a cmake variable for fuchsia, Could you please try to add them here? (see inlines) I don't have access to that particular platform. Comment at:

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto : DeclCache) { + auto *D = SP.first; djtodoro wrote: > aprantl wrote: > > Just looking at the type declarations in

r360947 - Fix failing source location test on Windows

Author: ericwf Date: Thu May 16 15:21:42 2019 New Revision: 360947 URL: http://llvm.org/viewvc/llvm-project?rev=360947=rev Log: Fix failing source location test on Windows Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp URL:

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:2611 + if (!CGM.getCodeGenOpts().ObjCNoBuiltinRetainRelease && !getInvokeDest()) +return EmitARCRetainAutoreleasedReturnValue(value, returnType); return

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

al3xtjames added a comment. Such nested structures work fine (no warnings generated). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits mailing list

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:2611 + if (!CGM.getCodeGenOpts().ObjCNoBuiltinRetainRelease && !getInvokeDest()) +return EmitARCRetainAutoreleasedReturnValue(value, returnType); return

[PATCH] D61909: Add Clang shared library with C++ exports

This revision was automatically updated to reflect the committed changes. Closed by commit rC360946: Add Clang shared library with C++ exports (authored by cbieneman, committed by ). Changed prior to commit: https://reviews.llvm.org/D61909?vs=199508=199912#toc Repository: rC Clang CHANGES

r360946 - Add Clang shared library with C++ exports

Author: cbieneman Date: Thu May 16 15:06:07 2019 New Revision: 360946 URL: http://llvm.org/viewvc/llvm-project?rev=360946=rev Log: Add Clang shared library with C++ exports Summary: This patch adds a libClang_shared library on *nix systems which exports the entire C++ API. In order to support

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. I will land this patch as-is today. I'll try and get a doc patch out for review today or tomorrow. @winksaville, I'm going to add a section to the document about building LLVM as a shared library for inclusion with tool distributions. That still shouldn't be done with

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505463 , @NoQ wrote: > Can we have a full build log? The full build log is here: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8913271285442739696 Repository: rL LLVM CHANGES SINCE LAST

r360943 - Fix PCC test failures for source location builtins

Author: ericwf Date: Thu May 16 14:51:39 2019 New Revision: 360943 URL: http://llvm.org/viewvc/llvm-project?rev=360943=rev Log: Fix PCC test failures for source location builtins Modified: cfe/trunk/test/CodeGenCXX/builtin-source-location.cpp cfe/trunk/test/CodeGenCXX/builtin_LINE.cpp

[PATCH] D62035: [AST] const-ify ObjC inherited class search

modocache created this revision. modocache added a reviewer: rjmccall. Herald added a project: clang. When writing an AST matcher to find inherited Objective-C classes, I noticed the returned `ObjCInterfaceDecl*` was mutable. It doesn't seem like it needs to be mutable, so this patch makes it

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 199905. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

r360939 - [clang/test] Add missing dependency on llvm-cxxfilt.

Author: dlj Date: Thu May 16 14:13:59 2019 New Revision: 360939 URL: http://llvm.org/viewvc/llvm-project?rev=360939=rev Log: [clang/test] Add missing dependency on llvm-cxxfilt. This tool is needed by clang/test/CodeGen/Output/ppc-mmintrin.c. Modified: cfe/trunk/test/CMakeLists.txt

r360938 - Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"

Author: kristina Date: Thu May 16 14:13:49 2019 New Revision: 360938 URL: http://llvm.org/viewvc/llvm-project?rev=360938=rev Log: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro" This relands commit rL360833 which caused issues on Win32 bots due to path handling/normalization

[PATCH] D61756: Add a __FILE_NAME__ macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360938: Reland [Clang][PP] Add the __FILE_NAME__ builtin macro (authored by kristina, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61756/new/

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360937: Implement __builtin_LINE() et. al. to support source location capture. (authored by EricWF, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Repository: rC

r360937 - Implement __builtin_LINE() et. al. to support source location capture.

Author: ericwf Date: Thu May 16 14:04:15 2019 New Revision: 360937 URL: http://llvm.org/viewvc/llvm-project?rev=360937=rev Log: Implement __builtin_LINE() et. al. to support source location capture. Summary: This patch implements the source location builtins `__builtin_LINE(),

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn added a comment. This looks reasonable to fix the problem at hand, but would it handle nested structures too? struct s1 { short f1; // "int f1" is fine. }; struct s2 { struct s1 f2; int x; }; struct s3 { struct s2 f3; int x; }; struct s2 x1 =

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. In D59464#1505435 , @phosek wrote: > In D59464#1505323 , @Szelethus wrote: > > > I started to land other patches as well that depend on this one -- I won't > > object, but I'd prefer to

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

NoQ added a comment. Can we have a full build log? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel marked 3 inline comments as done and an inline comment as not done. ymandel added a comment. Thanks for the review. Added the tests and undid changes to SourceCode. Comment at: clang/include/clang/Tooling/Refactoring/RangeSelector.h:29 + +namespace range_selector {

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 199896. ymandel marked 9 inline comments as done. ymandel added a comment. comment tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 Files:

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 199894. ymandel marked 3 inline comments as done. ymandel added a comment. Add tests and back out changes to SourceCode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 199893. EricWF marked an inline comment as done. EricWF added a comment. Merge with upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505323 , @Szelethus wrote: > I started to land other patches as well that depend on this one -- I won't > object, but I'd prefer to find a solution, mostly because I don't even know > how I could reproduce this error.

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF marked 14 inline comments as done. EricWF added a comment. Address review comments. Comment at: lib/AST/ExprConstant.cpp:3370-3371 + + assert((!Base || !isa(Base)) && + "Base should have already been transformed into a StringLiteral"); + rsmith

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

george.burgess.iv added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:27 +void CloexecPipeCheck::check(const MatchFinder::MatchResult ) { + const std::string = + (Twine("pipe2(") + getSpellingArg(Result, 0) + ", O_CLOEXEC)").str();

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire added a comment. In D61834#1505124 , @aaron.ballman wrote: > In D61834#1505056 , @steveire wrote: > > > In D61834#1504665 , @aaron.ballman > > wrote: > > > > >

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3359 +// Remember the original array subscript for bpf target +unsigned idx = cast(indices.back())->getZExtValue(); +eltPtr =

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505314 , @aaron.ballman wrote: > In D61835#1505280 , @steveire wrote: > > > In D61835#1505228 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall added a comment. Thanks! Down to minor stuff now. Comment at: clang/include/clang/Basic/Attr.td:291 + string CustomCode = customCode; } def MicrosoftExt : LangOpt<"MicrosoftExt">; Please add a comment here explaining how to use `CustomCode`. Can

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith added a comment. In D62009#1505263 , @Tyker wrote: > i added this bit because when we eventually store the result of evaluation in > ConstantExpr we will probably want to trail-allocate the APValue's possible > representations separately to limit

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Also, am I supposed to receive a mail from your buildbots? I unfortunately received none. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:718 +template +internal::Matcher traverse(ast_type_traits::TraversalKind TK, + const internal::Matcher ) { steveire wrote: > aaron.ballman

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 199885. slavapestov added a comment. Updated patch to address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked an inline comment as done. Szelethus added a comment. In D59464#1505200 , @phosek wrote: > All our bots are failing which seems to have been caused by the latest reland: > > FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) >

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:718 +template +internal::Matcher traverse(ast_type_traits::TraversalKind TK, + const internal::Matcher ) {

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

efriedma added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3359 +// Remember the original array subscript for bpf target +unsigned idx = cast(indices.back())->getZExtValue(); +eltPtr = CGF.Builder.CreatePreserveArrayAccessIndex(addr.getPointer(),

[PATCH] D61835: Extract ASTDumper to a header file

aaron.ballman added a comment. In D61835#1505280 , @steveire wrote: > In D61835#1505228 , @aaron.ballman > wrote: > > > In D61835#1505202 , @steveire > > wrote: > > > > >

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 199884. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: include/clang/AST/ASTContext.h include/clang/AST/ASTNodeTraverser.h

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505228 , @aaron.ballman wrote: > In D61835#1505202 , @steveire wrote: > > > 3. Anyone who wants traversal in the same way that dumping is done and who > > needs to call API on

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina updated this revision to Diff 199882. kristina edited the summary of this revision. kristina added a comment. Revised to use `llvm::sys::path::filename` to avoid issues on Windows hosts. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61756/new/

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. i added this bit because when we eventually store the result of evaluation in ConstantExpr we will probably want to trail-allocate the APValue's possible representations separately to limit memory consumption. but if we do this the ConstantExpr node will need to be

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:9 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC [android-cloexec-pipe] + //

  1   2   3   >