Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 11:49 PM Richard Smith wrote: > On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer >> wrote: >> >>> I'm not sure, but I do see that the call stack contains a call to >>>

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer > wrote: > >> I'm not sure, but I do see that the call stack contains a call to >> >> bool llvm::function_ref> bool)>::callback_fn >> const>(long,

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Thanks for catching that. On Thu, Mar 26, 2020 at 11:14 PM David Blaikie wrote: > > Usually this sort of thing is addressed with llvm_unreachable, rather than a > return statement that's not expected to be reached by any valid execution of > LLVM (it'd require a carefully hand-crafted CPU kind

[clang] 819e540 - Use llvm_unreachable after a fully covered/always-returning switch

Author: David Blaikie Date: 2020-03-26T20:09:57-07:00 New Revision: 819e540208d5d62e7841d0dbdef3580eecc2c2b6 URL: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6 DIFF: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6.diff

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the

[PATCH] D76757: Fix typo, targetFeature should be lowercase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64fe84185602: Fix typo, targetFeature should be lowercase. (authored by khchen, committed by Zakk Chen zakk.c...@sifive.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 64fe841 - Fix typo, targetFeature should be lowercase.

Author: Zakk Chen Date: 2020-03-26T19:40:04-07:00 New Revision: 64fe84185602b59c2e07c142b9772c6e855153cb URL: https://github.com/llvm/llvm-project/commit/64fe84185602b59c2e07c142b9772c6e855153cb DIFF: https://github.com/llvm/llvm-project/commit/64fe84185602b59c2e07c142b9772c6e855153cb.diff

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75779/new/ https://reviews.llvm.org/D75779

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/297 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76896 Files:

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer wrote: > I'm not sure, but I do see that the call stack contains a call to > > bool llvm::function_ref bool)>::callback_fn > const>(long, clang::Expr*&, bool) > > Notice that this is function_ref::callback_fn instantiated with > T=function_ref

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge requested review of this revision. nridge added a comment. Thanks for the suggested simplification. As the change is not completely trivial, could you have one more look before landing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 253005. nridge added a comment. Finish an incomplete variable extraction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files:

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 253004. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files:

[PATCH] D74324: Tools emit the bug report URL on crash

probinson added a comment. Hi @leonardchan Owen is on UK time so I took a look. I think Owen inadvertently put the new API in a place that is guarded by `#if ENABLE_BACKTRACES` and I'm guessing that your build has that turned off. I've posted D76893 because

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0da09498394: [Hexagon] Add support for Linux/Musl ABI (part 2) (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75638?vs=252950=253000#toc Repository: rG LLVM Github

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 252995. fhahn added a comment. Update according to comments on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/LanguageExtensions.rst

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 added a comment. I was thinking of dropping the new clang attr in favor of the `default` keyword in the current attr, but actually keeping the llvm attr, since it corresponds quite nicely to the existing EXPORTED symbol attribute in the binary format and avoid duplication in the `.ll`,

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#1944919 , @bbassi wrote: > @MyDeveloperDay Is someone working on fixing the breaking tests and merging > it? I need this feature so if someone isn't working on it already, I can take > it. as @stringham isn't

[clang] 5db37f3 - Make PS4 use -fno-use-init-array only as the ABI does not support .init_array.

Author: Douglas Yung Date: 2020-03-26T15:45:40-07:00 New Revision: 5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2 URL: https://github.com/llvm/llvm-project/commit/5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2 DIFF: https://github.com/llvm/llvm-project/commit/5db37f3bca3d404b0d7fcbe1dc764ee67665e6c2.diff

[clang] b0da094 - [Hexagon] Add support for Linux/Musl ABI (part 2)

Author: Sid Manning Date: 2020-03-26T17:19:46-05:00 New Revision: b0da094983948c8a82f1a26eaa0702920c2b2b36 URL: https://github.com/llvm/llvm-project/commit/b0da094983948c8a82f1a26eaa0702920c2b2b36 DIFF: https://github.com/llvm/llvm-project/commit/b0da094983948c8a82f1a26eaa0702920c2b2b36.diff

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sbc100 added a comment. What about your idea of using the `default` keyword rather than adding a new clang attr? I quite liked that approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76547/new/ https://reviews.llvm.org/D76547

[PATCH] D76452: Use LLD by default for Android.

srhines added a comment. In D76452#1945029 , @MaskRay wrote: > In D76452#1944786 , @srhines wrote: > > > In D76452#1944733 , @MaskRay wrote: > > > > > Another approach will

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added a comment. @bbassi, I don't have plans to address this, and am supportive of you finishing it up. The plan was to move this as one of the options in the `BracketAlignmentStyle` configuration (value of `AlwaysBreakWithDanglingParenthesis`) rather than have it be a brand new

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4984 +if (Q && isApprox(Q->getAsType(), T)) + addType(NNS->getAsIdentifier()); + } kadircet wrote: > sammccall

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

sunfish added a comment. Instead of creating a new LLVM-IR-level attribute here, could you have clang translate the attribute to "wasm-export-name", to keep the LLVM-IR level simpler? Also, I myself would be more comfortable with this change if it were restricted to Emscripten for now.

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

I'm not sure, but I do see that the call stack contains a call to bool llvm::function_ref::callback_fn const>(long, clang::Expr*&, bool) Notice that this is function_ref::callback_fn instantiated with T=function_ref itself; i.e., we do have a function_ref to a function_ref. This is the thing I

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. In D76452#1944786 , @srhines wrote: > In D76452#1944733 , @MaskRay wrote: > > > Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a > > default value for `-fuse-ld=`. > >

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252978. arsenm retitled this revision from "WIP: AMDGPU: Teach toolchain to link rocm device libs" to "AMDGPU: Teach toolchain to link rocm device libs". arsenm edited the summary of this revision. Herald added a subscriber: Anastasia. CHANGES SINCE LAST

[clang] 2a43a16 - [OPENMP50]Fix the checks for the nesting of scan directives.

Author: Alexey Bataev Date: 2020-03-26T17:30:02-04:00 New Revision: 2a43a1610db335afcccd1a179a33a0886a5a2c4d URL: https://github.com/llvm/llvm-project/commit/2a43a1610db335afcccd1a179a33a0886a5a2c4d DIFF: https://github.com/llvm/llvm-project/commit/2a43a1610db335afcccd1a179a33a0886a5a2c4d.diff

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

This revision was automatically updated to reflect the committed changes. sbc100 marked an inline comment as done. Closed by commit rG0731372ee25c: [clang] Allow -DDEFAULT_SYSROOT to be a relative path (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM. thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4984 +if (Q && isApprox(Q->getAsType(), T)) + addType(NNS->getAsIdentifier()); + }

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. In D76696#1944825 , @hubert.reinterpretcast wrote: > In D76696#1944784 , @sammccall wrote: > > > The general scheme is probably common: unresolved expr -> ??? -> an > > expression is

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. @MyDeveloperDay Is someone working on fixing the breaking tests and merging it? I need this feature so if someone isn't working on it already, I can take it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. arsenm added parent revisions: D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs, D76862: HIP: Ensure new denormal mode attributes are set. This

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

Hey Richard - could you help try to diagnose what's happening here? I reverted this patch in: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb But that did actually cause buildbot failures, such as these ones:

[clang] 0731372 - [clang] Allow -DDEFAULT_SYSROOT to be a relative path

Author: Sam Clegg Date: 2020-03-26T13:48:57-07:00 New Revision: 0731372ee25c8db93e0d976db4be4ffb7c7329c5 URL: https://github.com/llvm/llvm-project/commit/0731372ee25c8db93e0d976db4be4ffb7c7329c5 DIFF: https://github.com/llvm/llvm-project/commit/0731372ee25c8db93e0d976db4be4ffb7c7329c5.diff

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D76696#1944784 , @sammccall wrote: > The general scheme is probably common: unresolved expr -> ??? -> an > expression is dependent but not marked as such -> constant evaluation crashes. > > But the ??? matters,

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. In D76696#1944625 , @hubert.reinterpretcast wrote: > All of them appear to have unresolved names in constexpr evaluation. It is > likely to be the same issue. The general scheme is probably common: unresolved expr -> ??? ->

[PATCH] D76452: Use LLD by default for Android.

srhines added a comment. In D76452#1944733 , @MaskRay wrote: > Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a default > value for `-fuse-ld=`. How does that work for Darwin builds? Is lld fully supported for MachO at this point,

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym updated this revision to Diff 252950. sidneym added a comment. update for new tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 Files: clang/include/clang/Basic/TargetInfo.h

[clang] f9e71f4 - Revert "[OPENMP50]Add basic support for inscan reduction modifier."

Author: Alexey Bataev Date: 2020-03-26T15:57:19-04:00 New Revision: f9e71f4d9d39871390da48207d7fd6b116e370dc URL: https://github.com/llvm/llvm-project/commit/f9e71f4d9d39871390da48207d7fd6b116e370dc DIFF: https://github.com/llvm/llvm-project/commit/f9e71f4d9d39871390da48207d7fd6b116e370dc.diff

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. Another approach will be `-DCLANG_DEFAULT_LINKER=lld`. It provides a default value for `-fuse-ld=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452

[PATCH] D76452: Use LLD by default for Android.

danalbert reclaimed this revision. danalbert added a comment. This revision is now accepted and ready to land. It seems I'd goofed something in my testing earlier (I think I still had `-fuse-ld=lld` force on in my build system). While Clang will find `ld` in the driver directory and prefer it,

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. > In D76696#1944014 , > @hubert.reinterpretcast wrote: > >> We have also encountered crashes in downstream testing caused by this using >> just the vanilla source from trunk. When there is a proposed fix, please

[clang] 8099e0f - [OPENMP50]Add basic support for inscan reduction modifier.

Author: Alexey Bataev Date: 2020-03-26T14:51:09-04:00 New Revision: 8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5 URL: https://github.com/llvm/llvm-project/commit/8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5 DIFF: https://github.com/llvm/llvm-project/commit/8099e0fe82ce78c15bc6c4cf52caca5b6fbe28f5.diff

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9ad5f3f4ac: [cuda][hip] Add CUDA builtin surface/texture reference support. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D76365?vs=252828=252929#toc Repository: rG LLVM

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1944272 , @tra wrote: > LGTM. Next step is to figure out what various > __nv_tex_surf_handler(...) maps to for various strings (there are > ~110 of them in CUDA-10.2) and implement its replacement. I think we should >

[PATCH] D74324: Tools emit the bug report URL on crash

leonardchan added a comment. Hi. This patch seems to cause the undefined symbol error we're seeing when linking clang: FAILED: bin/clang-11 : && /b/s/w/ir/k/cipd/bin/clang++ --sysroot=/b/s/w/ir/k/cipd/linux-amd64 -I/b/s/w/ir/k/recipe_cleanup/clangzmv99P/zlib_install/include -fPIC

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76856/new/ https://reviews.llvm.org/D76856

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6a9ad5f - [cuda][hip] Add CUDA builtin surface/texture reference support.

Author: Michael Liao Date: 2020-03-26T14:44:52-04:00 New Revision: 6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6 URL: https://github.com/llvm/llvm-project/commit/6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6 DIFF: https://github.com/llvm/llvm-project/commit/6a9ad5f3f4ac66f0cae592e911f4baeb6ee5eca6.diff

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall added a comment. Thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4905 + // A requires(){...} lets us infer members from each requirement. + for (const concepts::Requirement *Req : RE->getRequirements()) { +if (!Req->isDependent())

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall updated this revision to Diff 252917. sammccall marked 13 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 Files:

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 updated this revision to Diff 252909. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 Files: clang/CMakeLists.txt clang/lib/Driver/Driver.cpp Index:

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:452 + const HighlightingToken *Last = nullptr; + for (const HighlightingToken : Tokens) { +Result.emplace_back(); hokein wrote: > note that we don't calculate

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall updated this revision to Diff 252906. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663 Files:

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 marked 3 inline comments as done. sbc100 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:143 + if (llvm::sys::path::is_relative(SysRoot)) { +// Prepend InstalledDir if SysRoot is relative phosek wrote: > Does this return `true` or

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:143 + if (llvm::sys::path::is_relative(SysRoot)) { +// Prepend InstalledDir if SysRoot is relative Does this return `true` or `false` when sysroot is empty? Comment

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. @ebevhan Thanks again for the testcase. I've added a reduced version in 47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6 to ensure this is fixed on re-land. This particular case can be fixed by marking the

[PATCH] D74324: Tools emit the bug report URL on crash

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:145 +static const char* customBugReportMsg; + MaskRay wrote: > jhenderson wrote: > > jhenderson wrote: > > > `static const char *BugReportMsg;` > > > > > > Why not just have this

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-workgroup-size.cu:2 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa \ +// RUN: -fcuda-is-device -emit-llvm -o - -x hip %s \ +// RUN: | FileCheck %s

[clang] 47e7bdb - Test that would have caught recovery-expr crashes in 0788acbccbec. NFC

Author: Sam McCall Date: 2020-03-26T18:43:29+01:00 New Revision: 47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6 URL: https://github.com/llvm/llvm-project/commit/47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6 DIFF: https://github.com/llvm/llvm-project/commit/47e7bdb10732e6f140adce39a1bc34e3ee2a6ea6.diff

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their

[PATCH] D74324: Tools emit the bug report URL on crash

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:145 +static const char* customBugReportMsg; + jhenderson wrote: > jhenderson wrote: > > `static const char *BugReportMsg;` > > > > Why not just have this set to the default in

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Next step is to figure out what various __nv_tex_surf_handler(...) maps to for various strings (there are ~110 of them in CUDA-10.2) and implement its replacement. I think we should be able

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

dblaikie added a comment. @gribozavr2 - hey, an annoying quirk of Phabricator is that it doesn't send mail to the mailing list on state changes with no text, which means reviews like these look like tehy were committed without approval (on the mailing list there's no record of the approval).

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:8 //===--===// // For each file, managed by TUScheduler, we create a single ASTWorker that +// manages an AST and a

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1687 + if (ArgValKnown) { +if (!KernelZeroSizePtrValue) + KernelZeroSizePtrValue = Szelethus wrote: > martong wrote: > > balazske wrote: > > > martong

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

Szelethus added inline comments. Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this correct? +// (recent kernel source code contains a `kfree(const void *)`) balazske wrote: > Szelethus wrote:

[PATCH] D76416: [WIP][ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

MaskRay added a comment. > Putting this on hold for now. Although this implementation works for ASan, it > would be have to be repeated for other tools like SourceBasedCoverage or > other sanitizers. (You can click "Add Action..."->"Plan Changes" so that this Differential will disappear from

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: kerbowa, tpr, nhaehnle, wdng, jvesely. Apparently HIPToolChain does not subclass from AMDGPUToolChain, so this was not applying the new denormal attributes. I'm not sure why this doesn't subclass.

[clang] 4dc8472 - [analyzer] Add the Preprocessor to CheckerManager

Author: Kirstóf Umann Date: 2020-03-26T17:29:52+01:00 New Revision: 4dc8472942ce60f29de9587b9451cc3d49df7abf URL: https://github.com/llvm/llvm-project/commit/4dc8472942ce60f29de9587b9451cc3d49df7abf DIFF: https://github.com/llvm/llvm-project/commit/4dc8472942ce60f29de9587b9451cc3d49df7abf.diff

[clang] 40076c1 - CUDA: Fix broken test run lines

Author: Matt Arsenault Date: 2020-03-26T12:19:34-04:00 New Revision: 40076c14fef509d0304cbdad49ba64113f4816fd URL: https://github.com/llvm/llvm-project/commit/40076c14fef509d0304cbdad49ba64113f4816fd DIFF:

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. We have also encountered crashes in downstream testing caused by this using just the vanilla source from trunk. When there is a proposed fix, please let us know so we can test. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 252868. anna added a comment. NFC w.r.t prev diff. Use VMap.lookup instead of a lambda which does the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 Files:

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this correct? +// (recent kernel source code contains a `kfree(const void *)`)

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

materi created this revision. materi added reviewers: ebevhan, leonardchan. Herald added a subscriber: kosarev. Herald added a project: clang. Unsigned types can alias the corresponding signed types. I don't see that this is explicitly mentioned in the Embedded-C specification, but I think it

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

Szelethus added a comment. In D76830#1943133 , @balazske wrote: > FIXME: There is a test file "kmalloc-linux.c" but it seems to be > non-maintained and buggy (has no //-verify// option so it passes always but > produces multiple warnings). Crap, even

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { +

[clang] 0766d1d - Make a windows buildbot happy

Author: Kirstóf Umann Date: 2020-03-26T17:04:23+01:00 New Revision: 0766d1dca8685e77e8672b13f26797a5d4c8b4d7 URL: https://github.com/llvm/llvm-project/commit/0766d1dca8685e77e8672b13f26797a5d4c8b4d7 DIFF: https://github.com/llvm/llvm-project/commit/0766d1dca8685e77e8672b13f26797a5d4c8b4d7.diff

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rG2aac0c47aed8: Reland [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D75360?vs=252073=252861#toc Repository:

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 252859. ABataev added a comment. Rebase + fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c/Index.h

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

krasimir added a comment. @MyDeveloperDay : sorry, I must have not refreshed this page and didn't realize you already gave an LGTM until I posted the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76850/new/ https://reviews.llvm.org/D76850

[PATCH] D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

krasimir accepted this revision. krasimir added a comment. I think this is an improvement. Accepting with a nit. Thank you! Comment at: clang/lib/Format/TokenAnnotator.cpp:2806 + if (Previous->is(tok::identifier) || Previous->isSimpleTypeSpecifier()) { +Previous =

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein added a comment. Thanks for the test case. Reverted in https://github.com/llvm/llvm-project/commit/62dea6e9be31b100962f9ad41c1b79467a53f6cd for now. Adding the error-bit to type looks like a right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { +

[PATCH] D31343: Add an attribute plugin example

john.brawn added a comment. Release note added: https://reviews.llvm.org/rG0cff81cff05d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 ___ cfe-commits mailing

[PATCH] D76197: clang-format: Use block indentation for braced initializations

DaanDeMeyer added a comment. Of course, if there's interest in adding this I'll fix all the tests but I wanted to make sure there was interest in adding this since it changes clang-format's behavior. Can you confirm that this change in behavior is a good thing and might be merged if I fix all

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus added a comment. Tried to recommit -- I'll keep a close eye on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 ___ cfe-commits mailing list

[clang] 62dea6e - Revert "[AST] Build recovery expressions by default for C++."

Author: Haojian Wu Date: 2020-03-26T16:25:32+01:00 New Revision: 62dea6e9be31b100962f9ad41c1b79467a53f6cd URL: https://github.com/llvm/llvm-project/commit/62dea6e9be31b100962f9ad41c1b79467a53f6cd DIFF: https://github.com/llvm/llvm-project/commit/62dea6e9be31b100962f9ad41c1b79467a53f6cd.diff

[clang] 2aac0c4 - Reland "[analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes"

Author: Kristóf Umann Date: 2020-03-26T16:12:38+01:00 New Revision: 2aac0c47aed8d1eff7ab6d858173c532b881d948 URL: https://github.com/llvm/llvm-project/commit/2aac0c47aed8d1eff7ab6d858173c532b881d948 DIFF: https://github.com/llvm/llvm-project/commit/2aac0c47aed8d1eff7ab6d858173c532b881d948.diff

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

sammccall added a comment. In D76696#1943657 , @ebevhan wrote: > However, this just means that `baz` has a very odd type; it's a variable of > closure type that contains a dependent member that will never be resolved. > Our diagnostic breaks, since the

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { +

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

njames93 added a comment. If you want to make it a general check, you should consider making the default module options set the correct namespace RequiredNamespace ClangTidyOptions getModuleOptions() override { ClangTidyOptions Options;

[PATCH] D76724: Prevent immediate evaluations inside of decltype

wchilders abandoned this revision. wchilders added a comment. Thanks Tyker, you're right, there is a general problem that needs handled, if this is to be handled; I had a bit of tunnel vision here. However, I'm retracting/abandoning this patch entirely as upon further review, it's not standard

[PATCH] D76197: clang-format: Use block indentation for braced initializations

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. > New implementation that breaks fewer tests. `fewer` is not an option, `no` is all thats going to get accepted. Please add tests for you own use case CHANGES

[clang] 0cff81c - Add a release note for attribute plugins

Author: John Brawn Date: 2020-03-26T15:01:57Z New Revision: 0cff81cff05d8e0a24391e3dec5b97174351ea55 URL: https://github.com/llvm/llvm-project/commit/0cff81cff05d8e0a24391e3dec5b97174351ea55 DIFF: https://github.com/llvm/llvm-project/commit/0cff81cff05d8e0a24391e3dec5b97174351ea55.diff LOG:

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

efriedma added subscribers: hfinkel, jdoerfert. efriedma added a comment. That makes sense. I would slightly lean towards not generating the assumptions, given the current state of assumptions and the likely benefit in this context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >