[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee added a comment. In D77621#1968437 , @dexonsmith wrote: > This is thanks to a commit of mine that shaved a word off of `SmallVector`. > Some options to consider: > > 1. Revert to word-size integers (`size_t`? `uintptr_t`?) for Size and >

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +} baloghadamsoftware

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee added inline comments. Comment at: llvm/include/llvm/Bitstream/BitstreamWriter.h:19 #include "llvm/ADT/Optional.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringRef.h" RKSimon wrote: > Can this be dropped? It is still used to construct

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5a16efbf59: [OpenMP] Specialize OpenMP calls after template instantiation (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85ae058f580: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D75788?vs=255050=255897#toc

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa19eb1de726c: [OpenMP] Add match_{all,any,none} declare variant selector extensions. (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D77414?vs=255212=255895#toc Repository:

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 255891. browneee added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D77705: [Driver] Forward pass plugin arguments to gold

ddcc created this revision. ddcc added a reviewer: tejohnson. Herald added a project: clang. Support forwarding `-fplugin` and `-fpass-plugin` arguments for loading pass plugins Depends on: D77704 Repository: rG LLVM Github Monorepo

[clang] f85ae05 - [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

Author: Johannes Doerfert Date: 2020-04-07T23:33:24-05:00 New Revision: f85ae058f580e9d74c4a8f2f0de168c18da6150f URL: https://github.com/llvm/llvm-project/commit/f85ae058f580e9d74c4a8f2f0de168c18da6150f DIFF:

[clang] a19eb1d - [OpenMP] Add match_{all,any,none} declare variant selector extensions.

Author: Johannes Doerfert Date: 2020-04-07T23:33:24-05:00 New Revision: a19eb1de726c1ccbf60dca6a1fbcd49b3157282f URL: https://github.com/llvm/llvm-project/commit/a19eb1de726c1ccbf60dca6a1fbcd49b3157282f DIFF:

[clang] eb5a16e - [OpenMP] Specialize OpenMP calls after template instantiation

Author: Johannes Doerfert Date: 2020-04-07T23:33:24-05:00 New Revision: eb5a16efbf59150af31bd4e3d37b8ea5976d780b URL: https://github.com/llvm/llvm-project/commit/eb5a16efbf59150af31bd4e3d37b8ea5976d780b DIFF:

[PATCH] D77688: [CUDA] Improve testing of libdevice detection.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77688/new/ https://reviews.llvm.org/D77688

[clang-tools-extra] 5303770 - [OpenMP] "UnFix" last layering problem with FrontendOpenMP

Author: Johannes Doerfert Date: 2020-04-07T22:47:41-05:00 New Revision: 530377018f624eadb8c07650511bbb9ca63608de URL: https://github.com/llvm/llvm-project/commit/530377018f624eadb8c07650511bbb9ca63608de DIFF:

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

NoQ added a comment. In D76768#1968023 , @ASDenysPetrov wrote: > Is there any way to get to buildbot file system to compare test files with > what is in the master branch? Particularly >

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The intention here is to allow clients to continue using a different color for each of our

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

nridge added reviewers: sammccall, kadircet, hokein. nridge added a comment. Adding some reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 ___

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

efriedma added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76269/new/ https://reviews.llvm.org/D76269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, dblaikie. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working in SemaStmt, I noticed a bunch of static functions are passed *this, which is a

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 255875. browneee marked 2 inline comments as done and an inline comment as not done. browneee added a comment. Build fixes in additional projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added inline comments. Comment at: clang/docs/UsersManual.rst:1684 + linkage symbols. The unique name is obtained by appending the hash of the + full module name to the original symbol. This option is particularly useful + in attributing profile information to the

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 255871. tmsriram marked 4 inline comments as done. tmsriram added a comment. Change description and handle -ffile-prefix-map/-fmacro-prefix-map. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files:

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

mehdi_amini added a comment. This seems like both over-fitting the general rule for a specific case and fuzzy/imprecise enough that it isn't clear to me how much useful it is in practice? Maybe we could step back: what is the concrete problem that this intends to address? Is there an area

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Requesting changes just to be sure we consider the other options. I don't think it's good that `SmallVector` is no longer useful for large byte streams; I would prefer to

[PATCH] D77697: libc++: adjust modulemap for non-modular C

dexonsmith added a comment. This SGTM in principle, but the patch makes me wonder: which other headers from the non-modularized C runtime change ownership? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697

[PATCH] D77669: [clangd] Run TUStatus test in sync mode to make output deterministic

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:849 + auto Opts = ClangdServer::optsForTest(); + Opts.AsyncThreadsCount = 0; + ClangdServer Server(CDB, FS, Opts, ); This seems unfortunate because it doesn't

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. This is thanks to a commit of mine that shaved a word off of `SmallVector`. Some options to consider: 1. Revert to word-size integers (`size_t`? `uintptr_t`?) for Size and Capacity for small-enough types. Could be just if `sizeof(T)==1`. Or maybe just for `char`

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Whoops, indeed. There should be a version of falsehoods programmers believe about names for the clang

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

sammccall added a comment. This is the perfect feature to start with (doesn't actually need any location transforms, lets us drop TUScheduler features), so well done for finding that. That said, high-level comments mostly about preamble patching in general rather than this particular case.

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd created this revision. compnerd added a reviewer: ldionne. Herald added subscribers: libcxx-commits, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. When building with a non-modularized C runtime, `csignal` would claim `time.h` and thus `timespec` rather

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Can reproduce test failure locally, reverted in 8fb7cfcea97af440830d256cc18ccd978f218e1d Thanks for noticing the problem and pointing me to it. > On Apr 6, 2020, at 23:28, Mikael Holmén wrote: > > We see flakiness in the test in our bots too. Fails one time and then > passes again. > >

[clang] 8fb7cfc - Revert "[ObjC generics] Fix not inheriting type bounds in categories/extensions."

Author: Volodymyr Sapsai Date: 2020-04-07T17:41:30-07:00 New Revision: 8fb7cfcea97af440830d256cc18ccd978f218e1d URL: https://github.com/llvm/llvm-project/commit/8fb7cfcea97af440830d256cc18ccd978f218e1d DIFF:

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

lattner added a comment. I don't really understand what this is getting at, so I'd recommend rewording this a bit for clarity. Would something along the lines of this capture the intended meaning?: If there is likely to be uncertainty, you should default to getting a patch reviewed prior to

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodeReview.rst:34 +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +significantly higher bar, e.g.,

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

arsenm added inline comments. Comment at: llvm/docs/CodeReview.rst:34 +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +significantly higher bar, e.g., fixes, to be

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 255856. browneee added a comment. Fix build errors. Missed -DLLVM_ENABLE_PROJECTS in previous local test builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea marked 4 inline comments as done. asbirlea added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:325 +auto = BUI ? BUI->PreViewCFG : EmptyGD; +return !empty(children({, N})); } kuhar wrote: > This pattern

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 255852. asbirlea marked an inline comment as done. asbirlea added a comment. Name anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 Files:

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/docs/CodeReview.rst:34 +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a

[PATCH] D77688: [CUDA] Improve testing of libdevice detection.

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. Added new testcases for libdevice in CUDA-9+ and removed unused checks. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77688 Files:

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

nickdesaulniers added a comment. In D77611#1968227 , @dblaikie wrote: > Looks like GCC warns on everything but the last unused expression (the last > one being the return statement) - only warning on that last one if it's > ultimately unused by the

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. > These are new tests how do you get the generic lld driver to work? It doesn't, Clang invokes the appropriate driver in `ToolChain::GetLinkerPath()`:

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

dblaikie added a comment. Looks like GCC warns on everything but the last unused expression (the last one being the return statement) - only warning on that last one if it's ultimately unused by the statement expression function call, as it were (& is annotated warn_unused_result). Basically,

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodeReview.rst:34 +uncertainty, a patch should be reviewed prior to being committed. If pre-commit +code reviewes in a particular area have been requested, code should clear a +significantly higher bar, e.g.,

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1968123 , @sidneym wrote: > Since this isn't something that can be always known in advance I think the > testcase should just be removed. Why not just check if `CLANG_DEFAULT_LINKER` is empty? const char

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

rsmith added inline comments. Comment at: clang/docs/ConstantInterpreter.rst:118 Memory management in the interpreter relies on 3 data structures: ``Block`` -object which store the data and associated inline metadata, ``Pointer`` objects -which refer to or into blocks, and

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:73 +// The end of this Node's edges is the beginning of the next node's edges. +const Edge *edges_end() const { return (this + 1)->Edges; } +ArrayRef edges() const {

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. Since this isn't something that can be always known in advance I think the testcase should just be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https://reviews.llvm.org/D77498

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

sidneym created this revision. sidneym added reviewers: bcain, kparzysz, nathanchance, bcahoon. Herald added a project: clang. Herald added a subscriber: cfe-commits. These values are not always known since there is a configuration option to set the default linker, CLANG_DEFAULT_LINKER.

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. These are new tests how do you get the generic lld driver to work? When I invoke it using just "lld" I need to add -flavor gnu or I get this error: Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld (WebAssembly) instead Repository: rG LLVM Github

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. I'll wait for current comments to be addressed before doing my next round here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 ___ cfe-commits mailing list

[PATCH] D77598: Integral template argument suffix printing

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template.cpp:34 -// CHECK: ![[TC]] = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "TC" +// CHECK: ![[TC]] = distinct !DICompositeType(tag: DW_TAG_structure_type, name:

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. Some more comments. FWIW, I'm doing rounds of review as I can in some evening quiet or during my son's nap. This is a huge change and it's really hard to get any part of it into my head at once in a reasonable amount of time. Comment at:

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. ptal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 255831. browneee added a comment. Fix more build errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: clang/include/clang/Serialization/ASTWriter.h

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert updated this revision to Diff 255830. jdoerfert added a comment. Add comma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 Files: llvm/docs/CodeReview.rst Index: llvm/docs/CodeReview.rst

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, ABataev, dblaikie, mehdi_amini, aaron.ballman, modocache, lattner, MaskRay, hubert.reinterpretcast, jhenderson, rengolin, kristina. Herald added a subscriber: bollu. Herald added a project: LLVM. jdoerfert updated this revision

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a subscriber: jdoerfert. njames93 added a comment. In D77085#1967883 , @nemanjai wrote: > Awesome, thanks. Certainly fixes the compile time failures in my local build. > There is still a link-time failure (undefined reference) with my

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. > Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, > though, right? I assume by baseline you mean the test before this change? It does not seem like it. > Is it a regression? I guess not but the test is still broken when

[PATCH] D77682: [clang-format] Always break line after enum opening brace

osandov created this revision. osandov added reviewers: MyDeveloperDay, krasimir. osandov added projects: clang-format, clang. Herald added a subscriber: cfe-commits. clang-format currently puts the first enumerator on the same line as the enum keyword and opening brace if it fits (for example,

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

nickdesaulniers updated this revision to Diff 255823. nickdesaulniers added a comment. - tighten up condition, eagerly emit diag, test with kernel before pushing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77611/new/

[libunwind] 82576d6 - [libunwind] Fix UB in EHHeaderParser::findFDE

Author: Jorge Gorbe Moya Date: 2020-04-07T14:44:42-07:00 New Revision: 82576d6fecfec71725eb900111c000d772002449 URL: https://github.com/llvm/llvm-project/commit/82576d6fecfec71725eb900111c000d772002449 DIFF:

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

mgehre created this revision. mgehre added reviewers: aaron.ballman, alexfh, hokein, njames93. Herald added a subscriber: xazax.hun. Herald added a project: clang. mgehre added a project: clang-tools-extra. mgehre edited the summary of this revision. Previously, the check would fix using fn =

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77670/new/ https://reviews.llvm.org/D77670

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. In D76768#1967129 , @Charusso wrote: > I believe it is very strange on a Windows system to have multiple dots in a > file. The other issue could be the wildcard `/*/` in a path full of `\`s. The > LLVM `lit`

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1967870 , @nathanchance wrote: > This does not take into account `CLANG_DEFAULT_LINKER`, resulting in a > `check-clang` failure: Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, though,

[PATCH] D77665: [CUDA] Simplify GPU variant handling. NFC.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77665/new/ https://reviews.llvm.org/D77665

[PATCH] D77611: [Sema] fix -Wunused-result in StmtExpr

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:252 + // CallExprs below. + if (isa(E) && Loc.isMacroID() && !isa(WarnExpr)) return; sigh, this again produces different from GCC for the kernel. Let me tighten this

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre updated this revision to Diff 255814. mgehre added a comment. Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre updated this revision to Diff 255812. mgehre added a comment. Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp

[PATCH] D77598: Integral template argument suffix printing

arisKoutsou updated this revision to Diff 255810. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp clang/test/CXX/lex/lex.literal/lex.ext/p12.cpp

[PATCH] D77611: [Sema] fix -Wunused-result in StmtExpr

nickdesaulniers updated this revision to Diff 255808. nickdesaulniers added a comment. - emit warning just for CallExprs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77611/new/ https://reviews.llvm.org/D77611 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre marked 6 inline comments as done. mgehre added a comment. In D77572#1965143 , @njames93 wrote: > I'm struggling to see the value of this check though. If it was reworked to > check for loop in the middle of a function it would have a lot more

[clang] dbe8678 - [OPENMP]Do not capture global marked as shared in OpenMP region.

Author: Alexey Bataev Date: 2020-04-07T17:33:17-04:00 New Revision: dbe86786f7f19c3f1338437f4275797e08501efd URL: https://github.com/llvm/llvm-project/commit/dbe86786f7f19c3f1338437f4275797e08501efd DIFF: https://github.com/llvm/llvm-project/commit/dbe86786f7f19c3f1338437f4275797e08501efd.diff

[clang] 9e6670b - [Driver] Only pass LTO remark arguments if the driver asks for it

Author: Francis Visoiu Mistrih Date: 2020-04-07T14:11:47-07:00 New Revision: 9e6670b03ceaa5980eccb06e2dd037e6a9584c66 URL: https://github.com/llvm/llvm-project/commit/9e6670b03ceaa5980eccb06e2dd037e6a9584c66 DIFF:

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. In D77085#1967864 , @njames93 wrote: > In D77085#1967807 , @nemanjai wrote: > > > A recent commit has taken down a whole bunch of bots. The build error > > messages all seem to point to

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

nathanchance added a comment. This does not take into account `CLANG_DEFAULT_LINKER`, resulting in a `check-clang` failure: $ cmake -GNinja \ -DCMAKE_C_COMPILER=clang \ -DCMAKE_CXX_COMPILER=clang++ \ -DLLVM_ENABLE_PROJECTS=clang \

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. In D77085#1967807 , @nemanjai wrote: > A recent commit has taken down a whole bunch of bots. The build error > messages all seem to point to code in this patch. If this is indeed the > cause, please revert. I was aware and

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. Herald added a subscriber: wuzish. A recent commit has taken down a whole bunch of bots. The build error messages all seem to point to code in this patch. If this is indeed the cause, please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0361798 - [clang-tidy] Fix buildbot failing with explicit specialization in class scope

Author: Nathan James Date: 2020-04-07T21:30:29+01:00 New Revision: 0361798dbeb6ead0a79ab7985f02da347fce988e URL: https://github.com/llvm/llvm-project/commit/0361798dbeb6ead0a79ab7985f02da347fce988e DIFF: https://github.com/llvm/llvm-project/commit/0361798dbeb6ead0a79ab7985f02da347fce988e.diff

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added a comment. Summary points for @craig.topper who has commandeered this diff: - fix the typo that Matt pointed out - `SizeT` should not be a template parameter, and `size_type` should be fixed to `int`. - Maybe have a member reference in `MachineGadgetGraph` to the associated

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9d558c87133: [OpenMP] UnFix layering problem with FrontendOpenMP (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77666/new/

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet planned changes to this revision. kadircet added a comment. this doesn't handle source locations correctly in presence of deleted headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https://reviews.llvm.org/D77644

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee updated this revision to Diff 255773. browneee marked an inline comment as done. browneee added a comment. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e0ae907 - [OPENMP][DOCS]Update status of oimplemented constructs, NFC.

Author: Alexey Bataev Date: 2020-04-07T15:45:08-04:00 New Revision: e0ae907ab5a15fe6d814f4794ab6f4c541149482 URL: https://github.com/llvm/llvm-project/commit/e0ae907ab5a15fe6d814f4794ab6f4c541149482 DIFF: https://github.com/llvm/llvm-project/commit/e0ae907ab5a15fe6d814f4794ab6f4c541149482.diff

[clang-tools-extra] f9d558c - [OpenMP] "UnFix" layering problem with FrontendOpenMP

Author: Johannes Doerfert Date: 2020-04-07T14:41:18-05:00 New Revision: f9d558c871337699d2815dbf116bae94025f5d90 URL: https://github.com/llvm/llvm-project/commit/f9d558c871337699d2815dbf116bae94025f5d90 DIFF:

[PATCH] D77611: [Sema] fix -Wunused-result in StmtExpr

dblaikie added a comment. In D77611#1967488 , @nickdesaulniers wrote: > Note your test case is related to `-Wunused-value`, mine is `-Wunused-result` > (via the use of `__attribute__((warn_result_unused))` which we should always > warn about. Right,

[PATCH] D76606: [clang-tidy] Change checks that take enum configurations to use a new access method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dff9ecdd113: [clang-tidy] Change checks that take enum configurations to use a new access… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77671: [clangd] Destroy context before resetting CurrentReq

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Our tests stash callbacks into request context and rely on it being invoked before

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D77229#1967269 , @NoQ wrote: > In D77229#1966888 , > @baloghadamsoftware wrote: > > > Not so strange, of course, they are

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. I opened https://github.com/ClangBuiltLinux/linux/issues/979 to see if we can fix this in Linux kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

jdoerfert added a comment. In D77666#1967506 , @aheejin wrote: > I don't know much about how this part works, but if this is purely a revert > of the previous patch, I don't think you need a review for that. It is not, as stated in the commit message.

[PATCH] D77665: [CUDA] Simplify GPU variant handling. NFC.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:61 +// clang-format off +SM2(20, "compute_20"), SM2(21, "compute_20"), // Fermi +SM(30), SM(32), SM(35), SM(37), // Kepler yaxunl wrote: > Thanks

[clang-tools-extra] 9dff9ec - [clang-tidy] Change checks that take enum configurations to use a new access method.

Author: Nathan James Date: 2020-04-07T20:04:31+01:00 New Revision: 9dff9ecdd113ca57b8c548ebcdb14121bfd1840c URL: https://github.com/llvm/llvm-project/commit/9dff9ecdd113ca57b8c548ebcdb14121bfd1840c DIFF: https://github.com/llvm/llvm-project/commit/9dff9ecdd113ca57b8c548ebcdb14121bfd1840c.diff

[PATCH] D77670: [CUDA] Add partial support for recent CUDA versions.

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: sanjoy.google, bixia, hiraditya, jholewinski. Herald added a project: clang. Generate PTX using newer versions of PTX and allow using sm_80 with CUDA-11. None of the new features of CUDA-10.2+ have been implemented

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf7cc268fe4: [clang-tidy] Added support for validating configuration options (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D77085?vs=255023=255764#toc Repository: rG

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

This revision was automatically updated to reflect the committed changes. Closed by commit rGaed2fdb1671c: [Hexagon] Update paths for linux/musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/

[PATCH] D77669: [clangd] Run TUStatus test in sync mode to make output deterministic

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Currently it doesn't matter because we run PreambleThread in sync mode. Once we

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

NoQ closed this revision. NoQ added a comment. Herald added a subscriber: ASDenysPetrov. Re-landed as rG0c27fd82e1e6 . I sorted the list of HTML files before deduplicating and the buildbots seem silent for now. Also fxd the

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

dexonsmith added a comment. In D77586#1967052 , @erik.pilkington wrote: > > This also adds the same feature to ObjC blocks under the assumption that > > ObjC wishes to follow the C standard in this regard. > > SGTM - thats generally been the idea for

  1   2   3   >