[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

2021-06-07 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 350307. mibintc added a comment. This patch addresses all of @craig.topper comments and adds documentation for the new intrinsic to the language reference as requested by @LuoYuanke nke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics

2021-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a subscriber: rsmith. sammccall added a comment. This seems sensible to me but hard to know if it's going to be an improvement in practice. Can you paste a realistic example? @rsmith any opinion about this diag? Comment at:

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

2021-06-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet abandoned this revision. gchatelet added a comment. In D102760#2802520 , @Quuxplusone wrote: > @gchatelet: Thanks for the link to D102679 > — that seems like very relevant background info I didn't have!

[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 350288. kadircet added a comment. - handle windows paths in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103797/new/ https://reviews.llvm.org/D103797 Files: clang/lib/Lex/ModuleMap.cpp

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

2021-06-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1da3297d253: [flang][driver] Add support for the -init-only option (authored by stuartellis, committed by awarzynski). Changed prior to commit:

[clang] e1da329 - [flang][driver] Add support for the "-init-only" option

2021-06-07 Thread Andrzej Warzynski via cfe-commits
Author: Stuart Ellis Date: 2021-06-07T15:40:26+01:00 New Revision: e1da3297d253b33be1ff941cf9ed9091dd332ea5 URL: https://github.com/llvm/llvm-project/commit/e1da3297d253b33be1ff941cf9ed9091dd332ea5 DIFF: https://github.com/llvm/llvm-project/commit/e1da3297d253b33be1ff941cf9ed9091dd332ea5.diff

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

2021-06-07 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan added a comment. In D101777#2802669 , @yaxunl wrote: > It seems this patch caused build failure: Yeah, I've pushed a fix -- I'd attached the fix to the wrong diff in the stack :( Should be good now. Repository: rG LLVM Github Monorepo

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

2021-06-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. It seems this patch caused build failure: FAILED: tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDeclCXX.cpp.o /usr/bin/c++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

2021-06-07 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. llvm discourages the use of std::map: https://llvm.org/docs/ProgrammersManual.html#map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103807/new/ https://reviews.llvm.org/D103807

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

2021-06-07 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd12000ca55d1: [clangd] Bump recommended gRPC version (1.33.2 -

[clang-tools-extra] d12000c - [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

2021-06-07 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-06-07T15:36:33+02:00 New Revision: d12000ca55d1cc8bc07f75457e3b4efbcd8ff657 URL: https://github.com/llvm/llvm-project/commit/d12000ca55d1cc8bc07f75457e3b4efbcd8ff657 DIFF:

[PATCH] D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion

2021-06-07 Thread Nathan Sidwell via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84ab31557409: [clang][NFC] Break out enum completion from other type context completion (authored by urnathan). Herald added a project: clang.

[clang] 84ab315 - [clang][NFC] Break out enum completion from other type context completion

2021-06-07 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-07T06:29:29-07:00 New Revision: 84ab315574099dcac8f9fb89fe8558f8ccfbce5f URL: https://github.com/llvm/llvm-project/commit/84ab315574099dcac8f9fb89fe8558f8ccfbce5f DIFF:

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

2021-06-07 Thread Nathan Sidwell via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. urnathan marked an inline comment as done. Closed by commit rGddda05add527: [clang][NFC] Break out BaseUsingDecl from UsingDecl (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang-tools-extra] ddda05a - [clang][NFC] Break out BaseUsingDecl from UsingDecl

2021-06-07 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-07T06:29:28-07:00 New Revision: ddda05add527f7f92a71f387b927f237334f46d9 URL: https://github.com/llvm/llvm-project/commit/ddda05add527f7f92a71f387b927f237334f46d9 DIFF:

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-07 Thread Markus Böck via Phabricator via cfe-commits
zero9178 added a comment. I shall do that. I do have commit access, but thanks for asking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103773/new/ https://reviews.llvm.org/D103773 ___ cfe-commits

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

2021-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D99540#2799159 , @kadircet wrote: >> Sorry I've lost my context - did we decide to move forward with this patch? > > I don't think we've came to a conclusion, just decided to postpone until > needed. I believe the `cases`

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

2021-06-07 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D102723#2790047 , @bjope wrote: > I relaxed the checks a bit again here: https://reviews.llvm.org/rGf0e10cc91bc4 > But it looks like the workers here > (https://lab.llvm.org/staging/#/workers/109) are paused so

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

2021-06-07 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. @gchatelet: Thanks for the link to D102679 — that seems like very relevant background info I didn't have! Having looked through D102679 , though, I don't see how it would benefit from D102760

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

2021-06-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: mgrang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Translation units with multiple direct modular

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:79 + if (!Deduced.isNull()) { +SourceRange R = D->getReturnTypeSourceRange(); +// For

[PATCH] D103806: [SystemZ][z/OS] Pass OpenFlags when creating tmp files

2021-06-07 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch https://reviews.llvm.org/D102876 caused

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

2021-06-07 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. (same comment as on https://reviews.llvm.org/D103773) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103771/new/ https://reviews.llvm.org/D103771

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-07 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Since it's motivated by a concrete file, this makes sense to me. Wait maybe a day or so to see if anyone objects, but I think this (and dependencies) are good. Do you have commit access?

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. looks like the https://lab.llvm.org/buildbot/#/builders/131 is green after the version bump. thanks for taking care of this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103393/new/

[PATCH] D103803: [analyzer] [NFC] Implement a wrapper SValBuilder::getCastedMemRegionVal for similar functionality on region cast

2021-06-07 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of

[clang] 721476e - [clang] Fix a crash during code completion

2021-06-07 Thread Adam Czachorowski via cfe-commits
Author: Adam Czachorowski Date: 2021-06-07T13:29:58+02:00 New Revision: 721476e6b2119a93033903109b54f429b6e8c91b URL: https://github.com/llvm/llvm-project/commit/721476e6b2119a93033903109b54f429b6e8c91b DIFF:

[PATCH] D103472: [clang] Fix a crash during code completion

2021-06-07 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721476e6b211: [clang] Fix a crash during code completion (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8b58092 - ExternalASTSource.h - remove unused StringRef and includes. NFCI.

2021-06-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2021-06-07T12:28:31+01:00 New Revision: 8b58092de49b8be964e760c161585665e8d8c48f URL: https://github.com/llvm/llvm-project/commit/8b58092de49b8be964e760c161585665e8d8c48f DIFF: https://github.com/llvm/llvm-project/commit/8b58092de49b8be964e760c161585665e8d8c48f.diff

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

2021-06-07 Thread Markus Böck via Phabricator via cfe-commits
zero9178 abandoned this revision. zero9178 added a comment. Thanks for the info, seems like I was mislead after testing it again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103772/new/ https://reviews.llvm.org/D103772 ___ cfe-commits

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-07 Thread Markus Böck via Phabricator via cfe-commits
zero9178 added a comment. > I think adding /permissive- to make things more conforming is great. The docs > say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option > implicitly sets the /permissive- option." so maybe we should do that too > (doesn't have to be in this

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4728aca9a8ad: [clangd] Drop TestTUs dependency on gtest (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103685/new/

[clang-tools-extra] 4728aca - [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2021-06-07T13:25:22+02:00 New Revision: 4728aca9a8adadc34590e3c930dcf8a32593d846 URL: https://github.com/llvm/llvm-project/commit/4728aca9a8adadc34590e3c930dcf8a32593d846 DIFF:

[PATCH] D103526: [clang][deps] Mark modules as file deps if they come from PCH

2021-06-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 350247. jansvoboda11 added a comment. Handle case when TU depends on a PCH module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103526/new/ https://reviews.llvm.org/D103526 Files:

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

2021-06-07 Thread Bradley Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60c9b5f35cae: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics (authored by bsmith). Repository: rG LLVM Github Monorepo CHANGES

[clang] 60c9b5f - [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

2021-06-07 Thread Bradley Smith via cfe-commits
Author: Bradley Smith Date: 2021-06-07T12:21:38+01:00 New Revision: 60c9b5f35caeb555f66d261bf5a657ab02a35fef URL: https://github.com/llvm/llvm-project/commit/60c9b5f35caeb555f66d261bf5a657ab02a35fef DIFF: https://github.com/llvm/llvm-project/commit/60c9b5f35caeb555f66d261bf5a657ab02a35fef.diff

[PATCH] D103802: [clang][modules][pch] Allow loading PCH with different modules cache path

2021-06-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 350245. jansvoboda11 added a comment. Remove CC1Option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103802/new/ https://reviews.llvm.org/D103802 Files: clang/include/clang/Driver/Options.td

[PATCH] D103802: [clang][modules][pch] Allow loading PCH with different modules cache path

2021-06-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 350243. jansvoboda11 added a comment. Mark as CC1Option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103802/new/ https://reviews.llvm.org/D103802 Files: clang/include/clang/Driver/Options.td

[PATCH] D103802: [clang][modules][pch] Allow loading PCH with different modules cache path

2021-06-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, akyrtzi. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's useful to be able to load explicitly-built

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

2021-06-07 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D103605#2801681 , @NoQ wrote: > Inlined defensive check suppressions are indeed pretty ugly; this problem > should ideally be solved in a completely different manner. > > That said, I strongly disagree that "when the

[PATCH] D97725: [OpenCL] Add const attribute to ctz() builtin

2021-06-07 Thread Stuart Brady via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b14670f3ca2: [OpenCL] Add const attribute to ctz() builtins (authored by stuart). Herald added subscribers: cfe-commits, ldrumm. Changed prior to

[clang] 9b14670 - [OpenCL] Add const attribute to ctz() builtins

2021-06-07 Thread Stuart Brady via cfe-commits
Author: Stuart Brady Date: 2021-06-07T11:41:52+01:00 New Revision: 9b14670f3ca287ce949c4157e0f673c84da255a3 URL: https://github.com/llvm/llvm-project/commit/9b14670f3ca287ce949c4157e0f673c84da255a3 DIFF: https://github.com/llvm/llvm-project/commit/9b14670f3ca287ce949c4157e0f673c84da255a3.diff

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 350231. kadircet added a comment. - Assert for daigs rather than abort. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103685/new/ https://reviews.llvm.org/D103685 Files:

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-07 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks @HsiangKai Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -std=c++11 -triple

[clang] aa0d717 - [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

2021-06-07 Thread Dmitry Polukhin via cfe-commits
Author: Dmitry Polukhin Date: 2021-06-07T03:05:00-07:00 New Revision: aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8 URL: https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8 DIFF:

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

2021-06-07 Thread Dmitry Polukhin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0d7179bbb3: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A header spelling in a source file could potentially mean multiple sources, especially in projects with multiple include search paths. We try to

[clang] 30a89a7 - ASTConcept.h - remove unused include. NFCI.

2021-06-07 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2021-06-07T10:58:32+01:00 New Revision: 30a89a754af4a7bc8afd485021f9e68d5d70 URL: https://github.com/llvm/llvm-project/commit/30a89a754af4a7bc8afd485021f9e68d5d70 DIFF: https://github.com/llvm/llvm-project/commit/30a89a754af4a7bc8afd485021f9e68d5d70.diff

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

2021-06-07 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

2021-06-07 Thread Andrew Savonichev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb31f41e78b27: [Clang] Support a user-defined __dso_handle (authored by asavonic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/

[clang] b31f41e - [Clang] Support a user-defined __dso_handle

2021-06-07 Thread Andrew Savonichev via cfe-commits
Author: Andrew Savonichev Date: 2021-06-07T12:54:08+03:00 New Revision: b31f41e78b2722785f3df1da0d77dfcd68125d15 URL: https://github.com/llvm/llvm-project/commit/b31f41e78b2722785f3df1da0d77dfcd68125d15 DIFF:

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

2021-06-07 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:122 if (!AST->getDiagnostics()) { -ADD_FAILURE() << "TestTU should always build an AST with a

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

2021-06-07 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:336 .Default(false); + Features["quadword-atomics"] = llvm::StringSwitch(CPU) + .Case("pwr10", true) What about `ppc64`? Also,

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

2021-06-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added a comment. @Quuxplusone thx a lot for the comment. It is very relevant and I agree that this addition may be dangerous. The intend was to prevent adding more constructors (and dependencies) to SmallVector in D102679 . I can try to see what it

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:75 + if (llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath)) +llvm_unreachable("Failed to create temp directory for module-cache");

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 350206. kadircet marked 3 inline comments as done. kadircet added a comment. - Use log + abort instead of llvm_unreachable to not rely on UB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103685/new/

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

2021-06-07 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 350205. DmitryPolukhin added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103722/new/ https://reviews.llvm.org/D103722 Files:

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

2021-06-07 Thread Ole Strohm via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG438cf5577e72: [OpenCL] Fix missing addrspace on implicit move assignment operator (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 438cf55 - [OpenCL] Fix missing addrspace on implicit move assignment operator

2021-06-07 Thread Ole Strohm via cfe-commits
Author: Ole Strohm Date: 2021-06-07T09:37:53+01:00 New Revision: 438cf5577e720f84d493a272c5a1cbaf6ce19e51 URL: https://github.com/llvm/llvm-project/commit/438cf5577e720f84d493a272c5a1cbaf6ce19e51 DIFF: https://github.com/llvm/llvm-project/commit/438cf5577e720f84d493a272c5a1cbaf6ce19e51.diff

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

2021-06-07 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

2021-06-07 Thread Graham Hunter via Phabricator via cfe-commits
huntergr added a comment. Apologies for not including more of the diff for context, but the test files are large enough that the full diff exceeds the maximum upload size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

2021-06-07 Thread Graham Hunter via Phabricator via cfe-commits
huntergr created this revision. huntergr added reviewers: ABataev, kkwli0. Herald added subscribers: guansong, yaxunl. huntergr requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The codegen for

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

2021-06-07 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D103472: [clang] Fix a crash during code completion

2021-06-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. we discussed offline but i forgot to stamp this one. it would be nice to have a test case, but fix is relatively safe and getting a repro turned out to be hard (since it depends on a

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

2021-06-07 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. In D101696#2800790 , @SaurabhJha wrote: > In D101696#2798713 , @SjoerdMeijer > wrote: > >> Perhaps for bonus points, update the Clang documentation in >>

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-07 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 ___ cfe-commits mailing list

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

2021-06-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

<    1   2