LLVM lab network outage

Hello, There is a network outage in the llvm lab. We are working with the technical support, but there is no ETA yet. I'll keep everyone updated. Sorry for the inconvenience. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105014: added some example code for llvm::Expected

lhames added a comment. I missed this thread earlier -- thanks to Dave for pointing me to it. @kuhnel -- Thanks very much for working on this. Out of interest, did you see https://llvm.org/docs/ProgrammersManual.html#error-handling ? If not (and if you find it helpful) then maybe we need to

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin abandoned this revision. sunlin added a comment. Close it for ignore these headers from command line. It is included from chain: "include/clang/Basic/TargetBuiltins.h" --> "clang/Basic/BuiltinsARM.def" --> "include/clang/Basic/arm_cde_builtins.inc"... Repository: rG LLVM Github

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:21-25 + # To allow testing with an untracked PLURAL_FILE + open(PLURAL_FILE, 'w').close() # TODO: remove this line when review is accepted + # TODO: use check_call when review is accepted +

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. From my point we can try that one, if there are problems we have plenty of time to revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 370751. FederAndInk added a comment. use correct python assignment from tuple, ask the user if they want to invoke git, use call instead of check_call to allow testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

ThePhD added a comment. Hi, my name is JeanHeyd Meneide. I'm the Project Editor for C, but more importantly I'm the author of this paper: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2728.htm This paper was accepted yesterday (September 3rd, 2021) into the C Standard, and (after I merge

[clang] 15cd16a - [Driver] Drop unnecessary const from return types (NFC)

Author: Kazu Hirata Date: 2021-09-04T08:05:27-07:00 New Revision: 15cd16aaf0b7a01e9f4f9f7ddfcf866c4db47199 URL: https://github.com/llvm/llvm-project/commit/15cd16aaf0b7a01e9f4f9f7ddfcf866c4db47199 DIFF: https://github.com/llvm/llvm-project/commit/15cd16aaf0b7a01e9f4f9f7ddfcf866c4db47199.diff

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added a comment. In D108003#2983609 , @xbolva00 wrote: > I think I will start with AND only as this is more error prone pattern. FWIW, I still see no reason //not// to warn on `|`-for-`||`. Again per

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1553 + "%select{references|destructors|block pointers|ref-qualified member functions}2">, + InGroup>; + @cjdb: I suggest splitting this diagnostic up, mainly for

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. Ping I think I will start with AND only as this is more error prone pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing list

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal added a comment. Looks great. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1636-1640 + // Technically, only i == length is guaranteed to be null. + // However, such overflows should be caught before reaching this point; + // the only time such an

[PATCH] D109237: [clang][AST] Add support for SubstTemplateTypeParmPackType to ASTImporter

steakhal added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1493 +const SubstTemplateTypeParmPackType *T) { + ExpectedType ReplacedOrErr = import(QualType(T->getReplacedParameter(), 0)); + if (!ReplacedOrErr) martong wrote: > steakhal wrote:

[PATCH] D109237: [clang][AST] Add support for SubstTemplateTypeParmPackType to ASTImporter

steakhal added a comment. In D109237#2982674 , @shafik wrote: > LGTM, please run the `check-lldb` before landing this since lldb can be > sensitive to `ASTImporter` changes and it is nice to catch regressions there > before landing. The patch did not

[PATCH] D109237: [clang][AST] Add support for SubstTemplateTypeParmPackType to ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6ca91ea4245: [clang][AST] Add support for SubstTemplateTypeParmPackType to ASTImporter (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D108824: [analyzer] SValBuilder should have an easy access to AnalyzerOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb97a96400a3f: [analyzer] SValBuilder should have an easy access to AnalyzerOptions (authored by steakhal). Herald added a project: clang. Herald

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG91c07eb8ee6e: [analyzer] Ignore single element arrays in getStaticSize() conditionally (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] d6ca91e - [clang][AST] Add support for SubstTemplateTypeParmPackType to ASTImporter

Author: Balazs Benics Date: 2021-09-04T10:19:57+02:00 New Revision: d6ca91ea42455453d08a7922e96fa6685827028d URL: https://github.com/llvm/llvm-project/commit/d6ca91ea42455453d08a7922e96fa6685827028d DIFF: https://github.com/llvm/llvm-project/commit/d6ca91ea42455453d08a7922e96fa6685827028d.diff

[clang] b97a964 - [analyzer] SValBuilder should have an easy access to AnalyzerOptions

Author: Balazs Benics Date: 2021-09-04T10:19:57+02:00 New Revision: b97a96400a3f9ec33b80d0726111aae1c7b24513 URL: https://github.com/llvm/llvm-project/commit/b97a96400a3f9ec33b80d0726111aae1c7b24513 DIFF: https://github.com/llvm/llvm-project/commit/b97a96400a3f9ec33b80d0726111aae1c7b24513.diff

[clang] 91c07eb - [analyzer] Ignore single element arrays in getStaticSize() conditionally

Author: Balazs Benics Date: 2021-09-04T10:19:57+02:00 New Revision: 91c07eb8ee6ea2d48158dce123bac7b7c30eb294 URL: https://github.com/llvm/llvm-project/commit/91c07eb8ee6ea2d48158dce123bac7b7c30eb294 DIFF: https://github.com/llvm/llvm-project/commit/91c07eb8ee6ea2d48158dce123bac7b7c30eb294.diff

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

kiszk added a comment. Thank you very much at https://github.com/llvm/llvm-project/commit/8f77dc459e31aad6daab89a124fa92067916274c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77470/new/ https://reviews.llvm.org/D77470

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f77dc459e31: [clang] NFC: Fix trivial typo in comments and document (authored by kiszk, committed by xgupta). Changed prior to commit:

[clang] 8f77dc4 - [clang] NFC: Fix trivial typo in comments and document

Author: Kazuaki Ishizaki Date: 2021-09-04T12:59:42+05:30 New Revision: 8f77dc459e31aad6daab89a124fa92067916274c URL: https://github.com/llvm/llvm-project/commit/8f77dc459e31aad6daab89a124fa92067916274c DIFF: