[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D109128#3097060 , @keith wrote: > @dexonsmith turns out the test I was adding is broken on main today too. If > it's alright with you I

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1032 + // the typename-specifier in a function-style cast expression may + // be 'auto' since C++2b Diag(Tok.getLocation(), Quuxplusone wrote: > rsmith wrote: > > Nice

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:951 + if (PreviousNonComment && PreviousNonComment->is(tok::l_paren)) { +State.Stack.back().BreakBeforeClosingParen = HazardyKnusperkeks wrote: > Remove the braces I

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

Quuxplusone added a comment. Comments on tests. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1032 + // the typename-specifier in a function-style cast expression may + // be 'auto' since C++2b Diag(Tok.getLocation(), rsmith wrote: > Nice catch

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

rsmith added a comment. I also wonder whether we should accept `decltype(auto)(x)` as an extension, but we can discuss that separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

rsmith added a comment. Thanks, this generally looks great. It looks like we'll need some additional work on disambiguation to handle cases like: struct A { int n; } a; void f() { auto()->n = 0; } I think that's valid, but right now we misparse it as a declaration of a variable ``. (This

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7611e16fce9c: [clang][objc][codegen] Skip emitting ObjC category metadata when the (authored by guitard0g, committed by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7611e16 - [clang][objc][codegen] Skip emitting ObjC category metadata when the

Author: Josh Learn Date: 2021-11-12T16:21:21-08:00 New Revision: 7611e16fce9ce36b6bd6dceda691f6bc7e754347 URL: https://github.com/llvm/llvm-project/commit/7611e16fce9ce36b6bd6dceda691f6bc7e754347 DIFF: https://github.com/llvm/llvm-project/commit/7611e16fce9ce36b6bd6dceda691f6bc7e754347.diff

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1101 Out << ", "; -Args[I].print(Policy, Out); +if (TemplOverloaded || !Params) + Args[I].print(Policy, Out, /*IncludeType*/ true); dblaikie wrote: > dblaikie wrote: > >

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g added a comment. @ahatanak I don't have commit access, any chance you could commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455 ___

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

ahatanak accepted this revision. ahatanak added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455 ___ cfe-commits mailing list

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

george.burgess.iv added inline comments. Comment at: clang/test/Sema/attr-diagnose-as-builtin.c:62 + +#ifdef __cplusplus +template mbenfield wrote: > george.burgess.iv wrote: > > nit: can we also add a non-templated overload check in here? > > > > if the diag

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

reames added a comment. Herald added a subscriber: jeroen.dobbelaere. @nikic ping on previous question. It's been a month, and this has been LGTMed. Without response, I plan to land this. In D110745#3038848 , @xbolva00 wrote: > This really needs to

[PATCH] D113761: [clang][modules] NFC: Factor out path-based submodule lookup

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113761/new/ https://reviews.llvm.org/D113761

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

modimo added a comment. Gentle ping @bruno Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/new/ https://reviews.llvm.org/D113523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g updated this revision to Diff 386949. guitard0g marked 5 inline comments as done. guitard0g added a comment. Nit: deleted empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455 Files:

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g marked 6 inline comments as done. guitard0g added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:6683 + values.add(classMethodList); + isEmptyCategory &= + instanceMethodList->isNullValue() && classMethodList->isNullValue();

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g updated this revision to Diff 386947. guitard0g added a comment. Abandon builder earlier before creating global variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455 Files:

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g updated this revision to Diff 386943. guitard0g added a comment. Address comments and fix fragile test to use -O0 and -disable-llvm-passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455

[PATCH] D113636: format_arg attribute does not support nullable instancetype return type

This revision was automatically updated to reflect the committed changes. Closed by commit rG12ab3e6c8402: format_arg attribute does not support nullable instancetype return type (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 12ab3e6 - format_arg attribute does not support nullable instancetype return type

Author: Félix Cloutier Date: 2021-11-12T13:35:43-08:00 New Revision: 12ab3e6c8402078f58959847277858eb47a43a19 URL: https://github.com/llvm/llvm-project/commit/12ab3e6c8402078f58959847277858eb47a43a19 DIFF:

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff created this revision. fwolff added reviewers: alexfh, whisperity. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#50990. Repository: rG

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

vsapsai added inline comments. Comment at: clang/test/Modules/missing-submodule.m:3 // RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs %s -verify +// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -F %S/Inputs %s

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith added a comment. In D113645#3126652 , @kadircet wrote: > I got a couple of concerns about the general ideas in the change. Even though > the convenience of using ~/.config/clangd/config.yaml seems nice, I think > it'll just end up creating

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

rnk added a comment. One alternative would be to control this setting with a pragma stack, like we do for warnings, struct packing, etc. Something like: // foo.h #pragma clang asm_dialect push "att" static inline ... foo { asm("..."); } #pragma clang asm_dialect pop The pragma really

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

aaronpuchert added a comment. Forget to run `clang-format`, will do this when I have to update or land. Comment at: clang/lib/AST/CommentSema.cpp:628 -void Sema::checkBlockCommandDuplicate(const BlockCommandComment *Command) { - const CommandInfo *Info =

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We make all predicates expect an already inspected DeclInfo, and introduce a function to run such a

[PATCH] D113794: Comment Sema: Use Name from CommandInfo for HeaderDoc diagnostics (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't have to figure out the name, we can just fetch it from the metadata table. Also there is

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of checking within the checks whether they apply, we check before calling them. This allows

[PATCH] D113691: Comment AST: Recognize function-like objects via return type (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3010883fc296: Comment AST: Recognize function-like objects via return type (NFC) (authored by aaronpuchert). Changed prior to commit:

[PATCH] D113690: Comment AST: Find out if function is variadic in DeclInfo::fill

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7df1ef7b67: Comment AST: Find out if function is variadic in DeclInfo::fill (authored by aaronpuchert). Changed prior to commit:

[clang] 3010883 - Comment AST: Recognize function-like objects via return type (NFC)

Author: Aaron Puchert Date: 2021-11-12T21:11:11+01:00 New Revision: 3010883fc296619def051e0a2f97d40fb15960d7 URL: https://github.com/llvm/llvm-project/commit/3010883fc296619def051e0a2f97d40fb15960d7 DIFF: https://github.com/llvm/llvm-project/commit/3010883fc296619def051e0a2f97d40fb15960d7.diff

[clang] 59b1e98 - Comment Sema: Make most of CommentSema private (NFC)

Author: Aaron Puchert Date: 2021-11-12T21:11:52+01:00 New Revision: 59b1e98137e961a61ffaeb609b6790999c461bec URL: https://github.com/llvm/llvm-project/commit/59b1e98137e961a61ffaeb609b6790999c461bec DIFF: https://github.com/llvm/llvm-project/commit/59b1e98137e961a61ffaeb609b6790999c461bec.diff

[clang] 4e7df1e - Comment AST: Find out if function is variadic in DeclInfo::fill

Author: Aaron Puchert Date: 2021-11-12T21:10:56+01:00 New Revision: 4e7df1ef7b679953c1501177539166876c4cbda4 URL: https://github.com/llvm/llvm-project/commit/4e7df1ef7b679953c1501177539166876c4cbda4 DIFF: https://github.com/llvm/llvm-project/commit/4e7df1ef7b679953c1501177539166876c4cbda4.diff

[PATCH] D113636: format_arg attribute does not support nullable instancetype return type

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113636/new/ https://reviews.llvm.org/D113636

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3066854 , @csmulhern wrote: > In D109557#3063681 , > @MyDeveloperDay wrote: > >> Personally I'm not convinced there wouldn't be people who want this for >>

[clang] 46a68c8 - Sema: const-qualify ParsedAttr::iterator::operator*()

Author: Duncan P. N. Exon Smith Date: 2021-11-12T11:47:16-08:00 New Revision: 46a68c85bfc99f0bc651e5096a641d5d4051e99d URL: https://github.com/llvm/llvm-project/commit/46a68c85bfc99f0bc651e5096a641d5d4051e99d DIFF:

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne requested changes to this revision. ldionne added a comment. Regarding the back-deployment target for Apple, I believe the first OSes where `libc++.dylib` had sized deallocation are `macOS 10.12`, `iOS 10.0`, `watchOS 3.0`, and `tvOS 10.0`. We should be able to enable reliance on sized

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 386904. CJ-Johnson marked 3 inline comments as done. CJ-Johnson added a comment. Address review comments from Yitzie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

ldionne added a comment. I think this should do it: diff --git a/libcxx/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.fail.cpp b/libcxx/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.verify.cpp similarity index 81% rename from

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson marked 5 inline comments as done. CJ-Johnson added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:75 + compoundLiteralExpr(has(StringViewConstructingFromNullExpr)), + changeTo(node("null_argument_expr"),

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

ldionne added a comment. In D110216#3127530 , @mizvekov wrote: > Exactly what Aaron said :-) > > Though might be a complication here if libcxx tests this with both ToT and > stable clang, so could be perhaps this needs to be changed in a way that >

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

pcc added a comment. Please see D63976 where we rejected a similar change in favor of just letting this be controllable at compile time. To the extent that the pass pipeline is affected by the size optimization level, I think we should change the passes so

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield added inline comments. Comment at: clang/test/Sema/attr-diagnose-as-builtin.c:62 + +#ifdef __cplusplus +template george.burgess.iv wrote: > nit: can we also add a non-templated overload check in here? > > if the diag isn't beautiful, that's fine IMO.

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386882. aeubanks added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM % 2 nits. Please feel free to commit after it LGT @aaron.ballman too. :) Thanks again! Comment at:

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. Thanks for pointing out built-in headers, that's a great point. I started adding .att_syntax lines where needed, but the I realized that that doens't work: it's too late for things taking memory, since %0 replacement is done with asm writer setting before getting to

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rjmccall added a comment. In D112921#3127767 , @rnk wrote: > Let's not bring back the weak function thunk approach. That approach caused > problems described in my commit, D8467 , > which is why the code was removed.

[clang-tools-extra] 4fb62e1 - [clangd] Mark completions as plain-text when there's no snippet part

Author: Sam McCall Date: 2021-11-12T18:44:20+01:00 New Revision: 4fb62e138398263dbefaa499c712929562bdf3bd URL: https://github.com/llvm/llvm-project/commit/4fb62e138398263dbefaa499c712929562bdf3bd DIFF: https://github.com/llvm/llvm-project/commit/4fb62e138398263dbefaa499c712929562bdf3bd.diff

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk added a comment. Let's not bring back the weak function thunk approach. That approach caused problems described in my commit, D8467 , which is why the code was removed. The next steps are to sort out right defaults for Apple and understand the libc++ test

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

sammccall updated this revision to Diff 386873. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments. While here, condense some long comments that repeated the code and seemed confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:517 +Completion.Kind == CompletionItemKind::Method || +Completion.Kind == CompletionItemKind::Text /*Macro*/) { // Functions snippets can be of 2 types:

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. Yeah, I think this either needs deployment restriction on Apple platforms or it needs the thunk / weak-linking approach from the original patch when the target OS isn't recent

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn created this revision. fhahn added reviewers: aemerson, ab, dmgreen, SjoerdMeijer, scanon. Herald added subscribers: dang, kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. This patch adds support for `-m[no]fpf16`, ` `-m[no]fpf16fml` and `-m[no]dotprod`

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

ymandel added a comment. This looks really good. An impressive effort! Just a few changes. Also, please ping Alex to get his opinion on the high level issue. Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:62 +

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

tschuett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:66 +typedef enum { Unset, True, False } OptState; +bool isUnset(OptState State) { return State == OptState::Unset; } This is almost an enum class. ``` enum class OptState

[PATCH] D103511: [clang-tidy] Special member functions check should allow sole dtors by default

steakhal abandoned this revision. steakhal added a comment. Herald added a subscriber: carlosgalvezp. I forgot to abandon this earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103511/new/ https://reviews.llvm.org/D103511

[PATCH] D113690: Comment AST: Find out if function is variadic in DeclInfo::fill

gribozavr2 added a comment. Thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113690/new/ https://reviews.llvm.org/D113690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#3126492 , @zixuan-wu wrote: > Is this going to be reviewed again or committed? This patch still requires approval by the libc++ group. The last build failed for multiple libc++ CI jobs, these should be fixed. (I

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4235 + for (const auto : Node.captures()) { +if (Finder->isTraversalIgnoringImplicitNodes() &&

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:94 + // Module map parsing initiated by header search. + if (HS.CurrentSearchPathIdx != ~0U) +HS.ModuleToSearchDirIdx[M] = HS.CurrentSearchPathIdx; ahoppen wrote: >

[PATCH] D51650: Implement target_clones multiversioning

danielkiss added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3290-3296 + // Ensure we don't combine these with themselves, since that causes some + // confusing behavior. + if (const auto *Other = D->getAttr()) { +S.Diag(AL.getLoc(),

[PATCH] D113691: Comment AST: Recognize function-like objects via return type (NFC)

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113691/new/ https://reviews.llvm.org/D113691

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, sdesmalen. Herald added subscribers: psnobl, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

ahoppen added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:94 + // Module map parsing initiated by header search. + if (HS.CurrentSearchPathIdx != ~0U) +HS.ModuleToSearchDirIdx[M] = HS.CurrentSearchPathIdx; jansvoboda11 wrote: >

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a subscriber: ldionne. mizvekov added a comment. Exactly what Aaron said :-) Though might be a complication here if libcxx tests this with both ToT and stable clang, so could be perhaps this needs to be changed in a way that works in both. I will check this much later today,

[clang] 05f34ff - [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

Author: Zarko Todorovski Date: 2021-11-12T15:46:16Z New Revision: 05f34ffa216975f132fa1bd4cbf8424053a19147 URL: https://github.com/llvm/llvm-project/commit/05f34ffa216975f132fa1bd4cbf8424053a19147 DIFF: https://github.com/llvm/llvm-project/commit/05f34ffa216975f132fa1bd4cbf8424053a19147.diff

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

This revision was automatically updated to reflect the committed changes. Closed by commit rG05f34ffa2169: [clang] Inclusive language: change instances of blacklist/whitelist to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

steakhal added inline comments. Comment at: clang/test/Analysis/initialization.cpp:295-299 +void glob_cast_opposite_sign1() { + auto *ptr = (unsigned int *)glob_arr2; + auto x1 = ptr[0]; // no-warning + auto x2 = ptr[1]; // expected-warning{{garbage or undefined}} +}

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 updated this revision to Diff 386847. jansvoboda11 added a comment. Re-run CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113775/new/ https://reviews.llvm.org/D113775 Files: clang/include/clang/Frontend/CompilerInstance.h

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Submodules not covered by existing umbrella header are being imported as

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/initialization.cpp:295-299 +void glob_cast_opposite_sign1() { + auto *ptr = (unsigned int *)glob_arr2; + auto x1 = ptr[0]; // no-warning + auto x2 = ptr[1]; // expected-warning{{garbage or undefined}} +}

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. There are some very minor nits that can be addressed on the commit. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1018 +unsigned Opcode2 =

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG388e8110db6f: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021 (authored by Topotuna). Herald added a subscriber: Naghasan.

[clang] 388e811 - [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-11-12T14:31:50Z New Revision: 388e8110db6f7b4ad9d655a70780f8698c4b9fd1 URL: https://github.com/llvm/llvm-project/commit/388e8110db6f7b4ad9d655a70780f8698c4b9fd1 DIFF: https://github.com/llvm/llvm-project/commit/388e8110db6f7b4ad9d655a70780f8698c4b9fd1.diff

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:476 Completion.Kind == CompletionItemKind::Method || Completion.Kind == CompletionItemKind::Constructor) { // If there is a potential template argument list, drop

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added a comment. To me at least, the patch looks good. Please post some comparative measurements to demonstrate it won't introduce runtime regression. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1144 +

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:378 + SVal simplifiedLhs = simplifySVal(state, lhs); + SVal simplifiedRhs = simplifySVal(state, rhs); + if (auto simplifiedLhsAsNonLoc = simplifiedLhs.getAs()) It

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. While here, unhide

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Great stuff. Have you checked the coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113754/new/ https://reviews.llvm.org/D113754

[clang-tools-extra] ebda5e1 - [clangd] Fix use-after-free in test

Author: Kadir Cetinkaya Date: 2021-11-12T14:50:23+01:00 New Revision: ebda5e1e521f4e7e47ccddb51a6a1d0d586b4265 URL: https://github.com/llvm/llvm-project/commit/ebda5e1e521f4e7e47ccddb51a6a1d0d586b4265 DIFF:

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1018 +unsigned Opcode2 = LiMI2->getOpcode(); +bool isOperand2Immeidate = MI.getOperand(2).isImm(); +// We can only do the optimization for the "reg + reg" form.

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff added a comment. In D103395#3105677 , @tambre wrote: > In D103395#3105668 , @sepavloff > wrote: > >> Strange, I see that it cannot be compiled neither by gcc nor by clang: >>

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff updated this revision to Diff 386823. sepavloff added a comment. Update the patch - Use more careful check for LHS expression, - Make a bit more precise LHS expression tracking, - Add comments, - Add the test from discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

aaronpuchert added a comment. Obviously the error message was just extended by the as-written type. Could have just adapted the expected results instead of reverting... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

MattDevereau marked 9 inline comments as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:732 + Type *VecTyPtr = II.getType()->getPointerTo(); + IRBuilder<> Builder(II.getContext()); + Builder.SetInsertPoint();

[PATCH] D113761: [clang][modules] NFC: Factor out path-based submodule lookup

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prep patch for Dxx that factors out the path-based submodule

[clang] ab6ef58 - [clang] NFC: Format a loop in CompilerInstance

Author: Jan Svoboda Date: 2021-11-12T14:16:06+01:00 New Revision: ab6ef5872763fd84e714c30467a49ad41d81bafc URL: https://github.com/llvm/llvm-project/commit/ab6ef5872763fd84e714c30467a49ad41d81bafc DIFF: https://github.com/llvm/llvm-project/commit/ab6ef5872763fd84e714c30467a49ad41d81bafc.diff

[PATCH] D113555: [clangd] Mark macros from preamble for code completion

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG7d668ae38d2d: [clangd] Mark macros from preamble for code completion (authored by kadircet). Changed prior to commit:

[clang-tools-extra] 7d668ae - [clangd] Mark macros from preamble for code completion

Author: Kadir Cetinkaya Date: 2021-11-12T14:01:14+01:00 New Revision: 7d668ae38d2d54ebd5eca5f66a8cf353c3526dc3 URL: https://github.com/llvm/llvm-project/commit/7d668ae38d2d54ebd5eca5f66a8cf353c3526dc3 DIFF:

[PATCH] D51650: Implement target_clones multiversioning

aaron.ballman added a comment. In D51650#3126569 , @akuegel wrote: > Since it is not clear whether the semantic change was intended, I think it > makes sense to revert the patch for now. If it is intended, it might be good > to mention it in the change

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 386806. martong edited the summary of this revision. martong added a comment. - Update in comments: `Unknown` -> `Undef` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner added a comment. Oh, are you concerned about staging this in? If you want to stage it (add the includes now, remove them later or something), that is totally fine with me. Maybe I don't understand the impact correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner added a comment. I think a few void's probably won't hurt anyone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.org/D113641 ___ cfe-commits mailing list

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle added inline comments. Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template struct DenseMapInfo; lattner wrote: > Is there a way to keep the forward declarations references here instead of > #include? DenseMapInfo.h pulls in a

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner accepted this revision. lattner added a comment. Herald added a subscriber: sdasgup3. Nice, I'm very excited about this - this will allow a lot of cleanups. Thank you for doing this! Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template struct

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ, Szelethus. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this revision.

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ, Szelethus. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this revision.

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 386797. sammccall added a comment. More conservative in changes to ActOnIfStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 Files:

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1155-1156 -// TODO: Support SymbolCast. Support IntSymExpr when/if we actually -// start producing them. ASDenysPetrov wrote: > ASDenysPetrov wrote: > >

  1   2   >