[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. There doesn't seem to be any objection to this approach, so I think you're free to land @housel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111863/new/ https://reviews.llvm.org/D111863

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam created this revision. zahiraam added reviewers: rjmccall, pengfei, andrew.w.kaylor. zahiraam requested review of this revision. Herald added a project: clang. The _Float16 type is supported on x86 systems with SSE2 enabled. Operations are emulated by software emulation and “float”

[clang] f1c159c - [Format, Sema] Use range-based for loops with llvm::reverse (NFC)

Author: Kazu Hirata Date: 2021-11-17T08:52:35-08:00 New Revision: f1c159cc908d23a381500c68ccabcd84bb6355c8 URL: https://github.com/llvm/llvm-project/commit/f1c159cc908d23a381500c68ccabcd84bb6355c8 DIFF: https://github.com/llvm/llvm-project/commit/f1c159cc908d23a381500c68ccabcd84bb6355c8.diff

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Quuxplusone accepted this revision as: Quuxplusone. Quuxplusone added a comment. FWIW, the problem with SpacesInAngles: Leave ^ is that the debian builder has an outdated (or maybe just 13.x?) `clang-format`; this option is super new. I don't know what the appropriate

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. @aprantl thank you for taking a look at this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 ___ cfe-commits mailing list

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb updated this revision to Diff 387956. krisb marked an inline comment as done. krisb added a comment. Applied the comment & silence clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 updated this revision to Diff 387952. jansvoboda11 added a comment. Rebase on top of extracted patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D114096: [clang][lex][modules] Stop tracking number of includes

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. Herald added a subscriber: mgrang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch stops tracking the number of

[PATCH] D114095: [clang][lex][modules] Move number of includes from HeaderFileInfo to Preprocessor

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. Herald added a subscriber: mgrang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves the number of times a file

[PATCH] D114093: [clang][lex] Refactor check for the first file include

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors the code that checks whether a file has just been included

[PATCH] D114092: [clang][lex] NFC: Remove unused HeaderFileInfo member

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes `HeaderFileInfo::isNonDefault`, which is not being used

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. This is already a lot of code with parse+sema. I wonder if we should split the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ? It should simplify maintenance of the patch and allow time to extend the OpenMP IR builder. Repository: rG LLVM Github

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. The clang binary size increases about +1.4%. Compared to +2.3% previously, it is better in the implementation. The test time of lit testing under `clang/test/CodeGen/RISCV/` is 25.59s. It spends 112.07s without this patch in my local environment. Repository: rG

[PATCH] D114090: [NFC] Inclusive language: rename master flag to main flag

quinnp created this revision. Herald added subscribers: pengfei, hiraditya. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch renames

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. Thanks for your patience with this review! I'm currently in WG14 meetings this week and out on vacation next week, so my review availability is a bit limited at the moment (sorry for that). I think this is heading in the right direction, but there are some

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax accepted this revision. beccadax added a comment. This revision is now accepted and ready to land. The diagnostics are now much better—thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature ==

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature == "sve2-bitperm" || Feature == "sve2-sha3" || + Feature == "sve2-aes" || Feature ==

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Headers/x86gprintrin.h:29 #define __SSC_MARK(Tag) \ - __asm__ __volatile__("movl %%ebx,

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. @NoQ > If we ever prove that strict aliasing is violated on a given execution path > (while being enabled), the ideal thing to do is to terminate the analysis > immediately by generating a sink. We can then optionally develop a checker > that emits a warning in

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

nemanjai created this revision. nemanjai added reviewers: bmahjour, PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. Support for builtins that use `bcdadd./bcdsub.` to add/subtract Binary Coded Decimal

[clang] 35ff3a0 - [analyzer][NFC] Make the API of CallDescription safer slightly

Author: Balazs Benics Date: 2021-11-17T15:55:35+01:00 New Revision: 35ff3a0095d5b2dafa2fc8dd762377342aef9c50 URL: https://github.com/llvm/llvm-project/commit/35ff3a0095d5b2dafa2fc8dd762377342aef9c50 DIFF: https://github.com/llvm/llvm-project/commit/35ff3a0095d5b2dafa2fc8dd762377342aef9c50.diff

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. Ping - any thoughts/concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. OK, that reasoning makes sense. I think my only outstanding request would be to ensure there's some test coverage for the case of .attribute arch with an experimental extension without version info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

This revision was automatically updated to reflect the committed changes. Closed by commit rG8924ba3bf8c6: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/ (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8924ba3 - [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

Author: Zarko Todorovski Date: 2021-11-17T09:43:02-05:00 New Revision: 8924ba3bf8c6b0e8d14dff455e4e449a426a2700 URL: https://github.com/llvm/llvm-project/commit/8924ba3bf8c6b0e8d14dff455e4e449a426a2700 DIFF:

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel abandoned this revision. kuhnel added a comment. thx for the explanation, makes sense --> abandoning this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113902/new/ https://reviews.llvm.org/D113902

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. > I agree, but having a field defined is different from it being used. It is > actually not uncommon to see SYCL functor passed with many unused fields > (Eigen is good example). Are you saying that it is better to diagnose just used fields? I believe it is safer to

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

This revision was automatically updated to reflect the committed changes. Closed by commit rGec4a2c956591: [NFC][clangd] cleanup llvm-else-after-return findings (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113892/new/

[clang-tools-extra] ec4a2c9 - [NFC][clangd] cleanup llvm-else-after-return findings

Author: Christian Kühnel Date: 2021-11-17T14:37:03Z New Revision: ec4a2c956591e97904eae5102022f343dadfb8f1 URL: https://github.com/llvm/llvm-project/commit/ec4a2c956591e97904eae5102022f343dadfb8f1 DIFF: https://github.com/llvm/llvm-project/commit/ec4a2c956591e97904eae5102022f343dadfb8f1.diff

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:3 +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + //===--- PathMapping.h - apply path mappings to LSP messages -===// Looks like the include guards were missing here. I

[PATCH] D113896: [NFC][clangd] cleanup of header guard names

kuhnel updated this revision to Diff 387929. kuhnel marked 3 inline comments as done. kuhnel added a comment. addresed Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113896/new/ https://reviews.llvm.org/D113896 Files:

[PATCH] D113999: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ea066acc928: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4ea066a - [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

Author: Haojian Wu Date: 2021-11-17T15:31:38+01:00 New Revision: 4ea066acc928d772c2a610024b7f0656b36e6afd URL: https://github.com/llvm/llvm-project/commit/4ea066acc928d772c2a610024b7f0656b36e6afd DIFF: https://github.com/llvm/llvm-project/commit/4ea066acc928d772c2a610024b7f0656b36e6afd.diff

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 387926. avogelsgesang marked an inline comment as not done. avogelsgesang added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 Files:

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature == "sve2-bitperm" || Feature == "sve2-sha3" || + Feature == "sve2-aes" || Feature ==

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Naghasan added a comment. In D114080#3137480 , @aaron.ballman wrote: > In D114080#3137462 , @Naghasan > wrote: > >> right, TIL `sizeof (ContainsArr)` is 0 according to clang. I can see trouble >> arising. >>

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

sammccall accepted this revision. sammccall added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113892/new/ https://reviews.llvm.org/D113892 ___ cfe-commits mailing list

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:504 bool TraverseDecl(Decl *X) { -if (X && isa(X)) +if (isa_and_nonnull(X)) return Base::TraverseDecl(X); // Already pushed by constructor. kadircet wrote: > while

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3137430 , @Naghasan wrote: > Why the need for this restriction ? Zero length arrays are not supported by pure C++. It is an extension supported by clang. They are also not allowed in OpenCL and SPIR-V, and I even

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

aaron.ballman added a comment. In D114080#3137462 , @Naghasan wrote: > right, TIL `sizeof (ContainsArr)` is 0 according to clang. I can see trouble > arising. > > @aaron.ballman maybe you know better, is that intended for the extension ? I don't

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

kuhnel updated this revision to Diff 387918. kuhnel marked 4 inline comments as done. kuhnel added a comment. addressed Sam's comments Sorry for the continued mess with automatic code formatting. Somehow VSCode forgot my settings :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Naghasan added a comment. right, TIL `sizeof (ContainsArr)` is 0 according to clang. I can see trouble arising. @aaron.ballman maybe you know better, is that intended for the extension ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/

[PATCH] D114011: Add a clang-transformer tutorial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG2b4948448f03: Add a clang-transformer tutorial (authored by ymandel). Repository: rG LLVM Github

[clang] 2b49484 - Add a clang-transformer tutorial

Author: Yitzhak Mandelbaum Date: 2021-11-17T13:40:46Z New Revision: 2b4948448f03104b4b957860dd8c019d0b9df2f0 URL: https://github.com/llvm/llvm-project/commit/2b4948448f03104b4b957860dd8c019d0b9df2f0 DIFF: https://github.com/llvm/llvm-project/commit/2b4948448f03104b4b957860dd8c019d0b9df2f0.diff

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported.

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971

[PATCH] D114011: Add a clang-transformer tutorial

ymandel marked 7 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/docs/ClangTransformerTutorial.rst:69 + +Assume you have an API which forbids functions from being named "MkX" and you +want to write a check that catches any violations

[PATCH] D114011: Add a clang-transformer tutorial

ymandel updated this revision to Diff 387914. ymandel added a comment. Responses to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114011/new/ https://reviews.llvm.org/D114011 Files: clang/docs/ClangTransformerTutorial.rst

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Naghasan added a comment. Why the need for this restriction ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 ___ cfe-commits mailing list

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

sammccall added a comment. Details below, but TL;DR is running only on files in `compile_commands.json` is definitely the established way to analyze a project. If you're proposing a *change* then that might be worth considering, but this probably isn't the place: mailing lists are more public

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman added a comment. In D112773#3137338 , @aaron.ballman wrote: > Thank you for diving into those details! I'm now sold on the idea that `any` > with no subjects is dangerous and we will diagnose if the user tries this. So > I think the only

[clang] 3874277 - Improve docs & test for #pragma clang attribute's any clause; NFC

Author: Aaron Ballman Date: 2021-11-17T08:24:26-05:00 New Revision: 3874277f415dca0bb222956983f117a6211c0e39 URL: https://github.com/llvm/llvm-project/commit/3874277f415dca0bb222956983f117a6211c0e39 DIFF: https://github.com/llvm/llvm-project/commit/3874277f415dca0bb222956983f117a6211c0e39.diff

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This is a WIP, to start the discussion. I've only turned on the X86 backend. Otherwise should be functional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/ https://reviews.llvm.org/D114082

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. Sorry, the attached file is here: F20424768: a.ii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. > I am not sure how to reproduce this. Attaching preprocessed source. With Clang built at 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: $ clang++ -c /tmp/a.ii ../../base/containers/span_unittest.cc:11:13: error: no viable conversion from

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. @jdoerfert , @yaxunl , please let me know if similar thing would be useful for OMP/HIP/CUDA as well. I can generalize it by using `targetDiag`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/

[PATCH] D114011: Add a clang-transformer tutorial

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangTransformerTutorial.rst:52 +Patterns in Transformer are expressed with +`clang's AST matchers

[PATCH] D114011: Add a clang-transformer tutorial

ymandel updated this revision to Diff 387906. ymandel added a comment. removed stray internal reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114011/new/ https://reviews.llvm.org/D114011 Files: clang/docs/ClangTransformerTutorial.rst

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D112773#3135975 , @beccadax wrote: >> My reading of >>

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon created this revision. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds diagnosing on attempt to use zero length arrays, pointers, refs, arrays of them

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel added a comment. In D113902#3131707 , @sammccall wrote: > Hmm, clang-tidy should only be running on entries in compile_commands.json. > are these files listed somehow? No, they are not. The question is: Do the tools our contributors use care

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

sammccall added a comment. This check was written specifically for the LLVM monorepo, I doubt there'll be consensus to disable it. https://reviews.llvm.org/D72217 has some previous discussion - some people want the consts spelled out, but we don't do this in clangd. And I don't particularly

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. Based on Sam's comments and our offline discussion, I would propose: 1. abandon this patch 2. start a discussion on the mailing list to disable this check for all of the llvm monorepo. Other thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith updated this revision to Diff 387900. bsmith added a comment. - Use more brute force approach to ensure ordering is accounted for - This massively simplifies things and removes what was becoming very confusing logic - Add tests for missing cases Repository: rG LLVM Github Monorepo

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

ahoppen added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:95 + if (HS.CurrentSearchPathIdx != ~0U) +HS.ModuleToSearchDirIdx[M] = HS.CurrentSearchPathIdx; +} These indices will be out of date if the search paths are changed via

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There are some

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

gribozavr2 added a comment. Sorry, here I also find the old code to be more readable. - I don't see a problem with checks that are only used once. They are encapsulated in functions with meaningful names, making the code more readable. Compare `Sema::checkFunctionDeclVerbatimLine` before and

[PATCH] D113793: Comment Sema: Run checks only when appropriate (NFC)

gribozavr2 added a comment. I find the code more readable and robust when the `check*` function checks its applicability itself. After this refactoring, it is not so clear when each check functions applies, what are the correct conditions to call them. To ensure correct usage, probably we

[PATCH] D114073: [clang-format][NFC] Add a default value to parseBlock()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM I like it being cleaner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114073/new/ https://reviews.llvm.org/D114073

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

sammccall added a comment. Added a bit of analysis on https://github.com/clangd/clangd/issues/888. The short version is we built a PCH. When consuming it, the parser decides to re-lex and this means sources must be loaded from disk. These sources are inconsistent with the PCH, so the

[PATCH] D113999: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113999/new/ https://reviews.llvm.org/D113999

[PATCH] D114073: [clang-format][NFC] Add a default value to parseBlock()

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

kadircet added a comment. I agree with Nathan on this one. It's unclear why there are two functions that does the same thing in different ways and some usages in sema looks suspicious enough to require caution (there are subtle checks for shadowing and whatnot and I don't know how these rules

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will allow the

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei added a comment. > It might be nice to add an llvm-link test that produces an error when this > module metadata doesn't match. Basically, it would be nice to error if during > LTO we link together two modules that differ in their use of -mskip-rax-setup > since that has ABI

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei updated this revision to Diff 387874. pengfei marked 3 inline comments as done. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112413/new/ https://reviews.llvm.org/D112413 Files:

[PATCH] D114034: [clang-tidy] fix debug-only test failure

dstenb added a comment. In D114034#3136057 , @mattbeardsley wrote: > @dstenb - wanted to check with you too to make sure that this change to > pr37091.cpp seems like it won't interfere with the original intent of the > test

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

nridge added a comment. Thanks for the patch. Could you add a test exercising call hierarchy for obj-c methods to CallHierarchyTests.cpp please? In terms of the actual change, this function has some other callers

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:279 + CCIfNotSubtarget<"hasX87()", +CCIfType<[f32], CCAssignToReg<[EAX, EDX, ECX]>>>, CCIfType<[f16], CCAssignToReg<[XMM0,XMM1,XMM2]>>, nickdesaulniers wrote: > Is there a

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei updated this revision to Diff 387855. pengfei added a comment. 1. Add support for f80. 2. Add test case for 3 return values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 Files:

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

pengfei added a comment. > Disabled double or float return for x86 targets Sorry, I think we still need to match GCC's behavior. I.e., we shouldn't diagnosticate any FP type (float, double, long double) on 32-bits. https://godbolt.org/z/KrbhfWc9o We have users who require of that. Noticed this

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu added a comment. The CI fails. But I guess it would be irrelevant with this diff: /var/lib/buildkite-agent/builds/llvm-project/libcxx/.clang-format:6:17: error: invalid boolean SpacesInAngles: Leave ^ Error reading

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf updated this revision to Diff 387851. qiucf marked an inline comment as done. qiucf added a comment. Fix C++ tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/D109751 Files:

<    1   2