[PATCH] D121042: [clang-format] Handle goto labels for RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire updated this revision to Diff 413195. junaire added a comment. This update proibit any use of ({}) in the default argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files:

[clang] fa9c8ba - [RISCV] Support k-ext clang intrinsics

Author: Shao-Ce SUN Date: 2022-03-05T13:57:18+08:00 New Revision: fa9c8bab0c7a7aed423191baa8a980533ae5602a URL: https://github.com/llvm/llvm-project/commit/fa9c8bab0c7a7aed423191baa8a980533ae5602a DIFF: https://github.com/llvm/llvm-project/commit/fa9c8bab0c7a7aed423191baa8a980533ae5602a.diff

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. In D23934#3355355 , @emaste wrote: > The original author appears to have given up on it. Someone will need to > rebase and work on pushing it forward Please see: https://reviews.llvm.org/D121040 CHANGES SINCE LAST ACTION

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() +

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

tlively added a comment. @dyung, this should be fixed by https://reviews.llvm.org/rGc01ec3083026f7e24e6c06f48a05d413e2c697d4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121014/new/ https://reviews.llvm.org/D121014

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

mcgrathr added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeStackSize();

[clang] c01ec30 - [WebAssembly] Update Preprocessor/init.c test after 3be9e0ba972c

Author: Thomas Lively Date: 2022-03-04T18:40:10-08:00 New Revision: c01ec3083026f7e24e6c06f48a05d413e2c697d4 URL: https://github.com/llvm/llvm-project/commit/c01ec3083026f7e24e6c06f48a05d413e2c697d4 DIFF: https://github.com/llvm/llvm-project/commit/c01ec3083026f7e24e6c06f48a05d413e2c697d4.diff

LLVM build master will be restarted at 9pm PST today

Hello, LLVM build master will be restarted at 9pm PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

dyung added a comment. This change seems to be causing many bots to fail when running the clang :: Preprocessor/init.c test, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/18081 https://lab.llvm.org/buildbot/#/builders/216/builds/881

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth created this revision. Herald added a subscriber: hiraditya. paulkirth updated this revision to Diff 409705. paulkirth added a comment. paulkirth updated this revision to Diff 409797. tstellar added a subscriber: serge-sans-paille. paulkirth edited the summary of this revision. paulkirth

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd860ac5da6d7: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm… (authored by vvereschaka). Repository: rG LLVM

[clang] d860ac5 - [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file. NFC.

Author: Vladimir Vereschaka Date: 2022-03-04T16:39:28-08:00 New Revision: d860ac5da6d71dd759d347a3c7d5e63705443694 URL: https://github.com/llvm/llvm-project/commit/d860ac5da6d71dd759d347a3c7d5e63705443694 DIFF:

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:123 + if (Constraints1.empty() || Constraints2.empty()) { +// Disjunction of empty set and non-empty set is represented as empty set. +return JoinedConstraints;

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file.

vvereschaka created this revision. vvereschaka added a reviewer: vvereschaka. Herald added subscribers: kristof.beyls, mgorny. Herald added a project: All. vvereschaka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid using

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3be9e0ba972c: [WebAssembly] Check bulk-memory when adjusting lang opts (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3be9e0b - [WebAssembly] Check bulk-memory when adjusting lang opts

Author: Thomas Lively Date: 2022-03-04T16:07:16-08:00 New Revision: 3be9e0ba972cc3486971f745a606e2c44472b655 URL: https://github.com/llvm/llvm-project/commit/3be9e0ba972cc3486971f745a606e2c44472b655 DIFF: https://github.com/llvm/llvm-project/commit/3be9e0ba972cc3486971f745a606e2c44472b655.diff

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers added a comment. Is it ok to land this change? Or shall we continue to wait on @NoQ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers added a comment. Is it ok to land this change? Or shall we continue to wait on @NoQ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 ___

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5705767aad: [clang-format] fix namepsace format when the name is macro expansion (authored by zequanwu). Repository: rG LLVM Github Monorepo

[clang] be57057 - [clang-format] fix namepsace format when the name is macro expansion

Author: Zequan Wu Date: 2022-03-04T16:01:17-08:00 New Revision: be5705767aad8d8eafd40225f7dba8e7e661c6b5 URL: https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5 DIFF: https://github.com/llvm/llvm-project/commit/be5705767aad8d8eafd40225f7dba8e7e661c6b5.diff

[clang] 9129743 - [Docs] List __has_feature(dataflow_sanitizer) in LanguageExtensions docs.

Author: Andrew Browne Date: 2022-03-04T15:48:07-08:00 New Revision: 9129743dde267f7ff678441c64bdfb9e24f7b448 URL: https://github.com/llvm/llvm-project/commit/9129743dde267f7ff678441c64bdfb9e24f7b448 DIFF: https://github.com/llvm/llvm-project/commit/9129743dde267f7ff678441c64bdfb9e24f7b448.diff

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw marked 7 inline comments as done. sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type,

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 413152. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert added a comment. Herald added a project: All. @saiislam Ok to postpone the bundle entry usage to a follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271

[PATCH] D120288: [OpenMP] Implement dense map info for device file

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added a project: All. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120288/new/ https://reviews.llvm.org/D120288

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM, but please wait for other reviewers in case they have more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 413149. sstwcw marked 2 inline comments as done. sstwcw added a comment. Herald added a project: All. Take out things in other revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S <

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

vvereschaka added a comment. @phosek @rovka no need those changes for `CrossWinToARMLinux.cmake`. `TARGET_TRIPLE` is using to parametrize the cache file only. But if there is a goal to completely remove `TARGET_TRIPLE` from the source tree I will update the cache file and the buildbot

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like I hit submit too early... I wanted to say the path thing is a pre-existing issue, and it seems reasonable to address that as a separate patch. If you don't have plans to do a follow up

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:72 SmallString<256> FilePath(SP.getDirectory()); sys::path::append(FilePath, SP.getFilename()); sys::path::native(FilePath); These sys::path calls introduce host-dependence, and

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen marked 2 inline comments as done. ychen added a comment. @rnk, thanks for taking a look. Patch updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen updated this revision to Diff 413146. ychen added a comment. Herald added a subscriber: dang. - Address Reid's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 Files:

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 413141. phosek added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413139. zequanwu marked 2 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files:

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59-60 + +// Use the string after `namespace` until `{` or `::` or `(` as a name +// candidate. If the name is empty, use the candicate. +std::string FirstNSName;

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:45-54 + int NestLevel = 1; + while (Tok && NestLevel > 0) { +Tok = Tok->getNextNonComment(); +if (Tok) { + if (Tok->is(tok::l_square)) +

[clang] 22b6e81 - Fix test failure in openmp-offload.c

Author: Yaxun (Sam) Liu Date: 2022-03-04T16:32:30-05:00 New Revision: 22b6e8173cb258fae5a7d332b6f9eb19e9ddf86f URL: https://github.com/llvm/llvm-project/commit/22b6e8173cb258fae5a7d332b6f9eb19e9ddf86f DIFF:

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: >

[clang] e5eb365 - [CUDA][HIP] Fix offloading kind for linking C++ programs

Author: Yaxun (Sam) Liu Date: 2022-03-04T15:56:54-05:00 New Revision: e5eb365069cce7bb642421d53a1d3964f8d5bdb7 URL: https://github.com/llvm/llvm-project/commit/e5eb365069cce7bb642421d53a1d3964f8d5bdb7 DIFF:

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5eb365069cc: [CUDA][HIP] Fix offloading kind for linking C++ programs (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a reviewer: hokein. probinson added a subscriber: hokein. probinson added a comment. Herald added a project: All. + @hokein who has done work in the one place where `replaceNestedName` is used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" zequanwu wrote: >

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if (DebugInfoKind >=

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" MyDeveloperDay wrote: > Is

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

zequanwu updated this revision to Diff 413109. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931 Files:

[PATCH] D120910: [HIP] Fix job action offloading kind for mixed HIP/C++ compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbde13a8102ba: [HIP] Fix job action offloading kind for mixed HIP/C++ compilation (authored by yaxunl). Herald added a project: clang. Repository:

[clang] bde13a8 - [HIP] Fix job action offloading kind for mixed HIP/C++ compilation

Author: Yaxun (Sam) Liu Date: 2022-03-04T15:34:02-05:00 New Revision: bde13a8102baef4d79723064e6bd27cd39124d91 URL: https://github.com/llvm/llvm-project/commit/bde13a8102baef4d79723064e6bd27cd39124d91 DIFF:

[clang] e22e277 - [RGT] DistroTest: Separate environment-specific test functions

Author: Paul Robinson Date: 2022-03-04T12:28:38-08:00 New Revision: e22e2774d93379d6bad41ae20194b076fdb44915 URL: https://github.com/llvm/llvm-project/commit/e22e2774d93379d6bad41ae20194b076fdb44915 DIFF: https://github.com/llvm/llvm-project/commit/e22e2774d93379d6bad41ae20194b076fdb44915.diff

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, njames93, ymandel. LegalizeAdulthood added a project: clang-tools-extra. Herald added a project: All. LegalizeAdulthood requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5d03135a716: [tooling] Explain how to create a compilation database on Windows [NFC] (authored by LegalizeAdulthood). Repository: rG LLVM Github

[clang] d5d0313 - [tooling] Explain how to create a compilation database on Windows [NFC]

Author: Richard Date: 2022-03-04T13:06:08-07:00 New Revision: d5d03135a7160586e2b09dc47c7021379252fbbd URL: https://github.com/llvm/llvm-project/commit/d5d03135a7160586e2b09dc47c7021379252fbbd DIFF: https://github.com/llvm/llvm-project/commit/d5d03135a7160586e2b09dc47c7021379252fbbd.diff LOG:

[PATCH] D120947: [tooling] Explain how to create a compilation database on Windows [NFC]

LegalizeAdulthood updated this revision to Diff 413093. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120947/new/ https://reviews.llvm.org/D120947 Files:

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone updated this revision to Diff 413089. Quuxplusone added a comment. Herald added a project: All. Rebased after landing D119184 . I'm no longer necessarily trying to land this note (it's not directly relevant to my interests anymore), but I'd like to

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); tra wrote: > JonChesterfield

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 413087. jhuber6 added a comment. Herald added a subscriber: dexonsmith. Addressing nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files:

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Herald added a project: All. Thanks for working on this! It's worth noting that http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2935.pdf was what was adopted by WG14 a few weeks ago, so you should be checking against that one, not the initial version of the

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Amir accepted this revision. Amir added a comment. LGTM from BOLT side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120934/new/ https://reviews.llvm.org/D120934

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); JonChesterfield wrote: > tra

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

ldionne added a comment. Herald added a project: All. Shall we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

tlively created this revision. tlively added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang.

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99 + const Environment , Value , + Environment ) { return false; `MergedEnv`? Also, the documentation

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

JonChesterfield added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4132-4134 + Archs.insert(CudaArchToString(CudaArch::SM_35)); +else if (Kind == Action::OFK_HIP) + Archs.insert(CudaArchToString(CudaArch::GFX803)); tra wrote: > If we do

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from two formatting nits, thank you for the cleanup! Comment at: clang/lib/Parse/ParsePragma.cpp:1373 - PragmaAttributeInfo(ParsedAttributes ) :

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4107 + options::OPT_no_offload_arch_EQ)) { +C.getDriver().Diag(diag::err_opt_not_valid_with_opt) << "--offload-arch" + <<

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. I think it'd potentially go somewhere in `DWARFDebugLine::LineTable::getFileLineInfoForAddress` for instance - which could inspect the candidate row in the line table, and if it's line zero, it could go back one row in the table. This would avoid probing addresses

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( xazax.hun

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added a comment. > Its assignment only happens in MacroExpander which is never used This is something that @klimek was working on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120931/new/ https://reviews.llvm.org/D120931

[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:112 + EXPECT_EQ("#define M(x) x##x\n" +"namespace [[deprecated(\"foo\")]] A::inline M(x)::A {\n" +"int i;\n" Is this 2 bugs in

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( Consider the

[PATCH] D120931: [clang-format] fix namepsace format when the name is macro expansion

curdeius added a comment. Please update the summary, the name is no longer empty. Also, if you can add some info in the summary about how it looked before (copying a part of the Chromium bug report seems enough), it would be awesome. Otherwise, some small comments only.

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:624 + (mask_type true_mask), + VLOpFrag, (XLenVT undef))), +(!cast(inst#"_"#kind#"_"#vlmul.MX)

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0891cd61b2f: [clang] [concepts] Check constrained-auto return types for void-returning… (authored by arthur.j.odwyer). Changed prior to commit: https://reviews.llvm.org/D119184?vs=413006=413046#toc

[clang] f0891cd - [clang] [concepts] Check constrained-auto return types for void-returning functions

Author: Arthur O'Dwyer Date: 2022-03-04T12:43:06-05:00 New Revision: f0891cd61b2f7cd57d906406ae785722bfd87603 URL: https://github.com/llvm/llvm-project/commit/f0891cd61b2f7cd57d906406ae785722bfd87603 DIFF:

[clang] adf6703 - [clang] [NFC] Add `const` to a parameter that's not modified.

Author: Arthur O'Dwyer Date: 2022-03-04T12:43:05-05:00 New Revision: adf6703f75b09564ca887b0eea0c3b37e65237d7 URL: https://github.com/llvm/llvm-project/commit/adf6703f75b09564ca887b0eea0c3b37e65237d7 DIFF:

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

craig.topper added a comment. In D103313#3359628 , @ksyx wrote: > In D103313#3359310 , > @JiahaoChenConor wrote: > >> Hi, do you still continue working on this patch? > > In fact, not pretty sure what else I

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

MyDeveloperDay added a comment. Herald added a project: All. Did you add somewhere what dependency we need in order to build the documentation now as mine is having problems with "recommonmark" /usr/bin/sphinx-build -n ./docs ./html Running Sphinx v3.4.3 Configuration error: There is

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

MyDeveloperDay added a comment. Herald added a project: All. Can we drop the git from everywhere? F22325692: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/ https://reviews.llvm.org/D112181

[PATCH] D120900: [clang][dataflow] Add `MatchSwitch` utility library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc88deef0a721: [clang][dataflow] Add `MatchSwitch` utility library. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c88deef - [clang][dataflow] Add `MatchSwitch` utility library.

Author: Yitzhak Mandelbaum Date: 2022-03-04T17:19:51Z New Revision: c88deef0a7218dd5c30500e7d3f58fc23283d3e5 URL: https://github.com/llvm/llvm-project/commit/c88deef0a7218dd5c30500e7d3f58fc23283d3e5 DIFF: https://github.com/llvm/llvm-project/commit/c88deef0a7218dd5c30500e7d3f58fc23283d3e5.diff

[PATCH] D120967: [NFC] Divide tests into smaller files

jrtc27 added a comment. With one exception, every RISC-V Clang CodeGen test (and with 9 exceptions, every RISC-V LLVM CodeGen test) is kebab-case not snake_case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ee97c24efab: [clang][dataflow] Add a lattice to track source locations. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7ee97c2 - [clang][dataflow] Add a lattice to track source locations.

Author: Yitzhak Mandelbaum Date: 2022-03-04T17:13:24Z New Revision: 7ee97c24efab4b2617da7f188760b0ad2dcc2125 URL: https://github.com/llvm/llvm-project/commit/7ee97c24efab4b2617da7f188760b0ad2dcc2125 DIFF: https://github.com/llvm/llvm-project/commit/7ee97c24efab4b2617da7f188760b0ad2dcc2125.diff

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

khchen added a comment. Makes sense to me, but I'd appreciate someone else for a final LGTM. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683 +Ops.push_back(VL); +Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy + } arcbbb wrote: >

[clang-tools-extra] e86324f - [clang-tidy][NFC] Document bugprone-narrowing-conversions check alias

Author: Balazs Benics Date: 2022-03-04T16:47:11+01:00 New Revision: e86324f80031fb5596f9f7437cb8c0b24fcf3143 URL: https://github.com/llvm/llvm-project/commit/e86324f80031fb5596f9f7437cb8c0b24fcf3143 DIFF: https://github.com/llvm/llvm-project/commit/e86324f80031fb5596f9f7437cb8c0b24fcf3143.diff

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 413006. Quuxplusone added a comment. Herald added a project: All. Rebased, poke CI one last time. If this is green, imma land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119184/new/

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

bsmith added a comment. Herald added a project: All. This all looks reasonable to me, but I'll let @peterwaller-arm have the final say. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 412996. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

steakhal added a comment. Looks great. I'm loving it! BTW what is the semantics of `[p retain]` in ObjC? Can `p` be null in that context? Or does it count as a dereferences, hence it constraints the pointer? Why did you touch the `AnalysisOrderChecker`, should we separate those changes?

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412994. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder marked an inline comment as done. tbaeder added a comment. In D120888#3359798 , @aaron.ballman wrote: > Thank you for working on this! We've (very) slowly been working towards all > of the attribute parsing functions taking a

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

steakhal added a comment. In addition to the excellent summary, I'd like to highlight that this is intended to catch only the cases where the use of the constrained pointer is in the very same stack frame where it was constrained. This leads to a really nice property: local reasoning, which

  1   2   >