[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman updated this revision to Diff 451051. mwyman added a comment. Fixed assert due to mis-matched number of expected parameters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

inclyc updated this revision to Diff 451049. inclyc edited the summary of this revision. inclyc added a comment. Address reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131466/new/ https://reviews.llvm.org/D131466 Files:

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

shafik added a comment. I wonder if `APValue` needs a member function to verify the underlying type of an `Array` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131466/new/ https://reviews.llvm.org/D131466

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

shafik added inline comments. Comment at: clang/lib/AST/APValue.cpp:658 for (auto : Inits) { int64_t Char64 = Val.getInt().getExtValue(); if (!isASCII(Char64)) I believe to be fully correct we also need to add: ``` if (!Val.isInt()) return

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. Updated D86049 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list

[PATCH] D131466: [clang] add APValue type check in `TryPrintAsStringLiteral`

inclyc created this revision. Herald added a project: All. inclyc added reviewers: rsmith, aaron.ballman, shafik. inclyc updated this revision to Diff 451047. inclyc added a comment. inclyc edited the summary of this revision. inclyc published this revision for review. Herald added a project:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

junaire added a comment. I wonder what's the difference between this patch and https://reviews.llvm.org/D124434 ? Also add some reviewers that get involved in the previous discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default dialect

MaskRay updated this revision to Diff 451044. MaskRay added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/LangStandards.cpp

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default dialect

MaskRay created this revision. MaskRay added reviewers: clang-language-wg, probinson, rjmccall. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang's default C++

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 451041. plotfi added a comment. Herald added a reviewer: aaron.ballman. Updating implementation to use an objc_direct_visible attr to explicitly mark when we want objc_direct to be exposed outside of the link unit. Work on dropping the selector param has

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay created this revision. MaskRay added a reviewer: clang-language-wg. Herald added subscribers: bzcheeseman, StephenFan, mstorsjo. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5307 // T t(create()...); +if (Args.empty()) + return false; I don't believe this is the right fix, the assert below is saying that we should not be here if

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc added a comment. GCC MSVC ICC seems to have some different behavior, clang after introducing this patch will think there is no problem with the code and output binary files, and `x` evaluates to `false` https://godbolt.org/z/hvbqTYMsx Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e207e4c096e: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue} (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES

[clang] 8e207e4 - [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

Author: Kazu Hirata Date: 2022-08-08T21:33:09-07:00 New Revision: 8e207e4c096e89fa5410b519715aba8c20701061 URL: https://github.com/llvm/llvm-project/commit/8e207e4c096e89fa5410b519715aba8c20701061 DIFF: https://github.com/llvm/llvm-project/commit/8e207e4c096e89fa5410b519715aba8c20701061.diff

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3708542 , @dblaikie wrote: > Sounds good - I'd be probably OK with removing these outright as they're so > niche/generally only for use by `llvm::Optional` anyway - but not much harm > in keeping them around for the

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

shafik accepted this revision. shafik added a comment. LGTM as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 ___ cfe-commits mailing list

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 451030. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/CPlusPlus20Modules.rst

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu marked 8 inline comments as done. ChuanqiXu added a comment. In D131388#3706072 , @h-vetinari wrote: > Thanks! Repeating a point that might have been overlooked from D131062 > (this time not as comments in

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added inline comments. Comment at: clang/test/Driver/riscv-arch.c:410 // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s +// RUN: %clang --target=riscv32-unknown-elf -mcpu=sifive-s21 -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:18-23 +template constexpr T zero = 0; // expected-error-re {{declaration{{.*}}in

[PATCH] D131455: [Driver] Add -Xclang= as an alias for -Xclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d9d27db4759: [Driver] Add -Xclang= as an alias for -Xclang (authored by MaskRay). Changed prior to commit:

[clang] 8d9d27d - [Driver] Add -Xclang= as an alias for -Xclang

Author: Fangrui Song Date: 2022-08-08T19:05:24-07:00 New Revision: 8d9d27db475943954fce00db47f8c9daf4dae600 URL: https://github.com/llvm/llvm-project/commit/8d9d27db475943954fce00db47f8c9daf4dae600 DIFF: https://github.com/llvm/llvm-project/commit/8d9d27db475943954fce00db47f8c9daf4dae600.diff

[PATCH] D131455: [Driver] Add -Xclang= as an alias for -Xclang

MaskRay added a comment. In D131455#3708621 , @jhuber6 wrote: > LG > > `-Xopenmp-target=` is somewhat different. The first joined argument is used > to select a toolchain and the second, separate argument is the argument to > pass. So something like

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:487 SmallVector argTys; SmallVector extParamInfos(2); argTys.push_back(Context.getCanonicalParamType(receiverType)); In order to fix the assert try this instead on line 487: ```

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :) Repository: rG LLVM Github Monorepo

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv-arch.c:410 // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s +// RUN: %clang --target=riscv32-unknown-elf -mcpu=sifive-s21 -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3706654 , @asb wrote: > @zixuan-wu we discussed this a bit in the last community sync call > . > One aspect that makes this patch a

[PATCH] D131455: [Driver] Add -Xclang= as an alias for -Xclang

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG `-Xopenmp-target=` is somewhat different. The first joined argument is used to select a toolchain and the second, separate argument is the argument to pass. So something like

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. This needs rebase. Comment at: flang/lib/Lower/Bridge.cpp:203 //them. for (Fortran::lower::pft::Program::Units : pft.getUnits()) { std::visit(Fortran::common::visitors{ jpenix-quic wrote: > peixin wrote: > > Doing

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. I tried running the following on some example code and got a stacktrace: // RUN: clang -cc1 -no-opaque-pointers -emit-llvm -fobjc-arc -triple x86_64-apple-darwin10 -o - %s -O0 @interface C - (int)getInt __attribute__((objc_direct)); @end @implementation

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - I'd be probably OK with removing these outright as they're so niche/generally only for use by `llvm::Optional` anyway - but not much harm in keeping them around for the same

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ronlieb added a comment. thanks for the analysis , i agree its a coding error in our library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___ cfe-commits

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D131307#3708413 , @ronlieb wrote: > hi, latest commit seems to have broken buildbot for amdgpu > https://lab.llvm.org/buildbot/#/builders/193/builds/16651 This looks like a real bug, the enum which has a typedef

[PATCH] D131455: [Driver] Add -Xclang= as an alias for -Xclang

MaskRay created this revision. MaskRay added reviewers: jhuber6, rnk. Herald added subscribers: jeroen.dobbelaere, StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu updated this revision to Diff 451002. kazu added a comment. Updated to use LLVM_DEPRECATED instead of [[deprecated]]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 Files:

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3707265 , @dblaikie wrote: > Update this to use something like https://reviews.llvm.org/D131381 ? Great idea! Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw marked 2 inline comments as done. brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment =

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451001. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ronlieb added a comment. hi, latest commit seems to have broken buildbot for amdgpu https://lab.llvm.org/buildbot/#/builders/193/builds/16651 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc104113ddec: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed… (authored by shafik). Herald added a project: clang.

[clang] cc10411 - [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

Author: Shafik Yaghmour Date: 2022-08-08T16:23:07-07:00 New Revision: cc104113ddecbdcec2cca848adbb6afa1214e9de URL: https://github.com/llvm/llvm-project/commit/cc104113ddecbdcec2cca848adbb6afa1214e9de DIFF:

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment = Context.getRawCommentForDeclNoCache(D);

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 450989. ivanmurashko added a comment. stop search if we could not load an entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files:

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk accepted this revision. rnk added a comment. In D130123#3708309 , @Ariel-Burton wrote: > - Add case to deal with ElaboratedTypes. Let's still stick with this code, but I at least feel justified raising the concern that perhaps we should look

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton updated this revision to Diff 450982. Ariel-Burton added a comment. - Add case to deal with ElaboratedTypes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 Files:

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. In D129694#3708214 , @ssquare08 wrote: > If that's the preference I can make changes as suggested. You mentioned CUDA > and HIP mangle the declaration directly. To me it looks like they mangle it > on host and device

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer ) { + const unsigned CBufferAddressSpace = 4; Anastasia wrote: >

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added a comment. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:354 +template <> llvm::Expected getCommentInfo(MemberTypeInfo *I) { + I->Description.emplace_back(); + return >Description.back(); paulkirth wrote: > So, I see that this uses

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 450978. python3kgae added a comment. Add more test and comment. Also use getTargetAddressSpace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3707533 , @clementval wrote: > In D105255#3707495 , @raghavendhra > wrote: > >> In D105255#3707088 , >>

[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

barannikov88 added inline comments. Comment at: clang/include/clang/AST/Expr.h:3832 + llvm::Optional getICEKind() const { return IK; } + Does it need to be Optional? It seems that it is never checked that it does not hold a value except for the setter

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9439 const Decl *D, llvm::GlobalValue *GV, CodeGen::CodeGenModule ) const { + // Make sure any variable with OpenMP declare target is visible to runtime + // except for those with hidden

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:177-178 + diag(NonMemberLoc, "ignoring the result of '%0', did you mean 'clear()'?") + << llvm::dyn_cast(NonMemberCall->getCalleeDecl()) +

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

rusyaev-roman created this revision. Herald added subscribers: mtrofin, carlosgalvezp, ormris, wenlei, okura, jdoerfert, bmahjour, kuter, arphaman, rogfer01, hiraditya. Herald added a project: All. rusyaev-roman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450967. brettw added a comment. Herald added subscribers: usaxena95, arphaman. Added some tests (with one open question). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added a comment. In D129694#3685207 , @jhuber6 wrote: > I still think we shouldn't bother making all the noise containing the > original name. Just mangle it and treat it like every other declare target > variable without introducing any

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3708204 , @davrec wrote: > This corrects a genuine deficiency in the AST, and the patch LGTM. Can we > knock this off Matheus' stack? Thanks :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

smeenai added a comment. In D130058#3708209 , @ayermolo wrote: > +2 turning it in to warning. It's breaking our builds, due to boost. :( This was done by D131307 , which I'm hoping will land soon :) CHANGES SINCE

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

ayermolo added a comment. +2 turning it in to warning. It's breaking our builds, due to boost. :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.org/D130058 ___ cfe-commits mailing list

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

davrec accepted this revision. davrec added a comment. This revision is now accepted and ready to land. This corrects a genuine deficiency in the AST, and the patch LGTM. Can we knock this off Matheus' stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:177-178 + diag(NonMemberLoc, "ignoring the result of '%0', did you mean 'clear()'?") + << llvm::dyn_cast(NonMemberCall->getCalleeDecl()) +

[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

justinstitt updated this revision to Diff 450966. justinstitt retitled this revision from "[Clang][BinaryOperator] cache ICEKind" to "[Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs". justinstitt edited the summary of this revision. justinstitt added a comment. Herald added a

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt updated this revision to Diff 450964. justinstitt added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/ https://reviews.llvm.org/D131416 Files: clang/include/clang/AST/Expr.h

[PATCH] D131447: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

justinstitt created this revision. Herald added a subscriber: pengfei. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building the Linux Kernel (x86_64) CheckICE is a particularly slow method

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith accepted this revision. rsmith added a comment. A handful more comments, but I think we've basically converged here. I'm happy to take another look after you address these if you'd like (or you could ask someone else for a final pass), or for you to land this once you're happy. Before

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth requested changes to this revision. paulkirth added a comment. This revision now requires changes to proceed. I agree w/ @phosek on unit testing. Additionally, while we don't have many of them in clang-doc, an end-to-end test would also be welcome. In this case, it will also probably

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt updated this revision to Diff 450961. justinstitt marked 7 inline comments as done. justinstitt added a comment. create getter/setter for optional ICEKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131416/new/

[PATCH] D130689: [LLVM] Update C++ standard to 17

mstorsjo added a comment. In D130689#3700094 , @thakis wrote: > In D130689#3696186 , @thieta wrote: > >> @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it >> can be built with

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

ymandel added a comment. Looks good overall. I want to think a bit more about potential additional tests... Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:232 +// This case is disallowed by the precondition from the method docstring. +

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep updated this revision to Diff 450951. samestep added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h

[libunwind] cc8edbe - [libunwind][AIX] Save/restore errno before/after system calls dlopen/dlsym/dlclose

Author: Xing Xue Date: 2022-08-08T17:21:30-04:00 New Revision: cc8edbea7a5f26906ae3d1f7ba0dc5da8fc5afb5 URL: https://github.com/llvm/llvm-project/commit/cc8edbea7a5f26906ae3d1f7ba0dc5da8fc5afb5 DIFF: https://github.com/llvm/llvm-project/commit/cc8edbea7a5f26906ae3d1f7ba0dc5da8fc5afb5.diff

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. @tmsriram Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep updated this revision to Diff 450944. samestep added a comment. Tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin marked an inline comment as done. denis-fatkulin added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1276 (R.Availability == CXAvailability_Available || R.Availability ==

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin updated this revision to Diff 450929. denis-fatkulin added a comment. Patch is updatetd according to remarks by @kadircet. @kadircet, could you please also merge my pacth to code base? I haven't such permissions yet. My git user name and address: Denis Fatkulin

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

tschuett added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:202 +class ForestNode::RecursiveIterator +: public std::iterator { + llvm::DenseSet Seen; `std::iterator` is deprecated in C++17 and creates warnings.

[PATCH] D90275: [clang][IR] Add support for leaf attribute

nlopes added a comment. In D90275#3671983 , @gulfem wrote: > In D90275#3671019 , @nlopes wrote: > >> Could you please add a description of this attribute to LangRef? >> We need the semantics of this. >> >> Thank

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3707635 , @efriedma wrote: > If the declaration we're redeclaring is a builtin, should the diagnostic be > in the "-Wincompatible-library-redeclaration" warning group? With this > patch, we treat redefinitions

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228-237 + case ToolChain::RLT_CompilerRT: { +const std::string fileName = getCompilerRT(Args, "builtins"); +std::string baseName = llvm::sys::path::filename(fileName).str(); +

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450910. manojgupta added a comment. Address more style lints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3707735 , @manojgupta wrote: > Address style nits. Neat, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta updated this revision to Diff 450908. manojgupta added a comment. Address style nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 Files: clang/lib/Driver/Driver.cpp

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: llvm/lib/Support/Triple.cpp:1936 +bool Triple::isARMBareMetal() const { + if (getArch() != llvm::Triple::arm && getArch() != Triple::thumb) +return false; (nit) at least `llvm::` qualification is redundant,

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

NoQ added a comment. Aha great, I see you've found that there's already an existing solution for this problem! I'm questioning this solution though, maybe a more general solution could have helped us avoid this problem altogether. Comment at:

[PATCH] D131412: [clang][deps] Stop sharing FileManager across module builds in scanner

This revision was automatically updated to reflect the committed changes. Closed by commit rG33af4b22f8ea: [clang][deps] Stop sharing FileManager across module builds in scanner (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 33af4b2 - [clang][deps] Stop sharing FileManager across module builds in scanner

Author: Ben Langmuir Date: 2022-08-08T12:13:54-07:00 New Revision: 33af4b22f8ea5dc8340002833802be95ae9f83a1 URL: https://github.com/llvm/llvm-project/commit/33af4b22f8ea5dc8340002833802be95ae9f83a1 DIFF: https://github.com/llvm/llvm-project/commit/33af4b22f8ea5dc8340002833802be95ae9f83a1.diff

[PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. > There should be a better way than this. Comprehensive pre-merge testing of > all PRs etc. We already have pre-commit tests on Phabricator on Windows and Linux, but that's not exhaustive and for many reasons I don't believe this is realistic in any way: we will

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

NoQ added a comment. Thanks! I've seen a couple false positives like this and I'm shocked that this wasn't already how things worked. I agree with @steakhal, we should add a test case that demonstrates an actual false positive suppressed by this patch. The tests that you've added are "FIXME"

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with the style issues fixed, but I'd like someone else to take a look. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228-237 + case

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

efriedma added a comment. If the declaration we're redeclaring is a builtin, should the diagnostic be in the "-Wincompatible-library-redeclaration" warning group? With this patch, we treat redefinitions of builtins without a prototype differently from redefinitions with a prototype, for

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman created this revision. mwyman added reviewers: dmaclach, plotfi. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. When `objc_direct` methods were implemented, the implicit `_cmd` parameter was

[clang] b71b22e - [LinkerWrapper] Use C++17 structured bindings

Author: Joseph Huber Date: 2022-08-08T15:07:03-04:00 New Revision: b71b22e48ddcf98ada78dc1e98c2fbdb562e0bd2 URL: https://github.com/llvm/llvm-project/commit/b71b22e48ddcf98ada78dc1e98c2fbdb562e0bd2 DIFF: https://github.com/llvm/llvm-project/commit/b71b22e48ddcf98ada78dc1e98c2fbdb562e0bd2.diff

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added inline comments. Comment at: flang/lib/Lower/Bridge.cpp:203 //them. for (Fortran::lower::pft::Program::Units : pft.getUnits()) { std::visit(Fortran::common::visitors{ peixin wrote: > Doing this can avoid add one variable

[PATCH] D131422: [lldb] Remove include/lldb/lldb-private.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdeb50c32155: [lldb] Remove include/lldb/lldb-private.h (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >