[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451731. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files:

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

MaskRay added a comment. Nit: I think it is useful mentioning `-Wincompatible-function-pointer-types` in the commit message, not just in `clang/docs/ReleaseNotes.rst`, so that `git log --grep incompatible-function-pointer-types` will reveal something when the user knows

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

brooksmoses added a comment. For the record, so far we've seen this showing up in the following: - A case in a notoriously warning-heavy third-party library where we'd backported a file from a newer version and didn't quite fix all the internal API mismatches. - A ten-year-old bug in a local

[PATCH] D131644: [clang][dataflow] Don't skip the entry block

li.zhe.hua updated this revision to Diff 451721. li.zhe.hua added a comment. Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131644/new/ https://reviews.llvm.org/D131644 Files:

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When navigating a loop block, we call the

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

li.zhe.hua created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In order to better support convergence in

[PATCH] D131644: [clang][dataflow] Don't skip the entry block

li.zhe.hua created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In DXXX, we implement widen by taking

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:182 // CHECK-LABEL: test_mm256_castsi128_si256 - // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

lattner added a comment. I haven't reviewed this in detail, but oh my I love LOVE LOVE this! `llvm::scc_traversal(x)` is so nice, great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131448/new/ https://reviews.llvm.org/D131448

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

tianshilei1992 added a comment. `bool` is used by a function declaration `__ockl_fdot2` in `clang/lib/Headers/__clang_hip_libdevice_declares.h`, which is included by `clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

glandium added a comment. Also not caught: a cast of 0 when 0 is not a valid value in the enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.org/D130058 ___ cfe-commits mailing list

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

glandium added a comment. In D130058#3714672 , @glandium wrote: > This catches > https://searchfox.org/mozilla-central/rev/c77834ec635c523f2ba0092fcd1728c9b1c3005b/third_party/rust/glslopt/glsl-optimizer/src/compiler/glsl/ir_reader.cpp#732 > but not >

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. I think this is a reasonable step for improving compile times. I put some suggestions for more descriptive names below (he said, after suggesting those names in the first place). The

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

craig.topper added a comment. Yes AMX is only supported in 64-bit mode but I doubt CPUID checks which mode the program is running in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131134/new/ https://reviews.llvm.org/D131134

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11522 + if (NewFD->getFriendObjectKind() == Decl::FriendObjectKind::FOK_None || + !NewFD->isDependentContext()) { +QualType ClassType = Destructor->getThisObjectType();

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

pengfei added a comment. I have the same impression. I checked ISE says AMX instructions are `N.E.` on 32-bit mode. And seems Linux Kernel only enables AMX on 64-bit too

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11518-11520 + // FIXME: We still don't diagnose on this case + // template + // struct A { friend T::S::~V(); }; There's nothing we can diagnose about this

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

LiuChen3 added a comment. In D131134#3707397 , @craig.topper wrote: > What problem are we trying to solve here? CPUID reports AMX as supported even > in 32-bit mode. Why can't the user pass it to the compiler? I thought AMX is only supported on 64-bit

[PATCH] D131635: [RISCV] Remove sifive-7-rv32/rv64 CPU names.

craig.topper abandoned this revision. craig.topper added a comment. I'm going to rethink this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131635/new/ https://reviews.llvm.org/D131635 ___ cfe-commits

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f801e07fa82: [clang-format] git-clang-format --staged should format the index (authored by Gergely Meszaros meszaros.gergel...@gmail.com, committed by owenpan). Repository: rG LLVM Github Monorepo

[clang] 3f801e0 - [clang-format] git-clang-format --staged should format the index

Author: Gergely Meszaros Date: 2022-08-10T19:30:41-07:00 New Revision: 3f801e07fa82055de98278d3ebeaade68fbacee9 URL: https://github.com/llvm/llvm-project/commit/3f801e07fa82055de98278d3ebeaade68fbacee9 DIFF:

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:19 #include "clang/Basic/TargetOptions.h" +#include "llvm/IR/IntrinsicsDirectX.h" #include "llvm/IR/Metadata.h" python3kgae wrote: > Does this mean CGHLSLRuntime is only for DirectX

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11875 + for (const auto Param : FD->parameters()) { +if (!Param->hasAttr()) { + Diag(Param->getLocation(), diag::err_hlsl_missing_parameter_annotation) << Param; python3kgae wrote: >

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128 +// to the function itself; it points to a stub for the compiler. +// FIXME: We also need to emit an entry thunk. +SmallString<256> MangledName; efriedma wrote: >

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

dblaikie added a comment. > I use something like > > // RUN: %clang_cc1 %s -fsyntax-only -verify=expected,precxx17 -std=c++14 > -fdata-sections -fcolor-diagnostics > // RUN: %clang_cc1 %s -fsyntax-only -verify -std=c++17 -fdata-sections > -fcolor-diagnostics > > ... >

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

dblaikie added a comment. Direction seems pretty good - some of the details I'm fuzzy on. If there's easy ways to keep some of the existing syntax (like I see at least one loop that I think was querying the incremented iterator for "isAtEnd" - maybe that can be preserved initially) to reduce

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

glandium added a comment. This catches https://searchfox.org/mozilla-central/rev/c77834ec635c523f2ba0092fcd1728c9b1c3005b/third_party/rust/glslopt/glsl-optimizer/src/compiler/glsl/ir_reader.cpp#732 but not

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. In D130516#3710972 , @MaskRay wrote: > I have only taken very brief look at the new version. Having an enum class > `CompressionKind` with a parallel `CompressionAlgorithm` seems redundant. > `friend CompressionAlgorithm

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Still waiting for the pre-merge checks to complete, but hopefully this is clean now. Realized maybe we don't need a separate driver flag for this at all, and rely only on the abi-compat flag? That seems to be how (at least some) other ABI compat changes have been

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:19 #include "clang/Basic/TargetOptions.h" +#include "llvm/IR/IntrinsicsDirectX.h" #include "llvm/IR/Metadata.h" Does this mean CGHLSLRuntime is only for DirectX backend?

[PATCH] D131625: [HLSL] Entry functions require param annotation

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11875 + for (const auto Param : FD->parameters()) { +if (!Param->hasAttr()) { + Diag(Param->getLocation(), diag::err_hlsl_missing_parameter_annotation) << Param; When param

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D131307#3713011 , @sberg wrote: > With this commit, > > $ cat test.cc > #include "boost/numeric/conversion/cast.hpp" > int main() { return boost::numeric_cast(0L); } > > $ clang++ test.cc > > succeeds without any

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. Added the description in https://reviews.llvm.org/D131628 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 ___ cfe-commits mailing list

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:290 + } + return PromotedTy; + } Indentation is off Comment at: clang/lib/CodeGen/CGExprComplex.cpp:305 +result.second =

[PATCH] D131635: [RISCV] Remove sifive-7-rv32/rv64 CPU names.

craig.topper created this revision. craig.topper added reviewers: kito-cheng, arcbbb, asb, luismarques. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

justinstitt updated this revision to Diff 451687. justinstitt added a comment. use @rtrieu 's suggestion regarding not invoking isNullPointerConstant as opposed to checking for C++ lang opt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131532/new/ https://reviews.llvm.org/D131532

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 451686. dblaikie added a comment. Remove driver flag (just rely on ABI compat) & tidy up testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files:

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. @h-vetinari Do these updates look OK to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list

[PATCH] D131632: [WIP] Enable SARIF Diagnostics

abrahamcd created this revision. Herald added a subscriber: mgorny. Herald added a project: All. abrahamcd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Work in progress to enable Clang to emit SARIF diagnostics. Repository: rG LLVM

[PATCH] D129570: Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 updated this revision to Diff 451666. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth added a comment. Thanks. Can we get the small changes to the assert + the TODO in Serialize.cpp? I'll be happy to land this for you after that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

beanz updated this revision to Diff 451660. beanz added a comment. This is a fairly significant reworking of this patch to handle entry functions being called (which I hadn't anticipated). There may be some additional tweaks required, but the general flow here is: (1) Don't prevent mangling of

[clang] d5fcf8a - [clang][deps] NFC: Move dependency consumer into header file

Author: Jan Svoboda Date: 2022-08-10T15:25:09-07:00 New Revision: d5fcf8a5e2e03c9c8e375876a2127d90db7efe13 URL: https://github.com/llvm/llvm-project/commit/d5fcf8a5e2e03c9c8e375876a2127d90db7efe13 DIFF: https://github.com/llvm/llvm-project/commit/d5fcf8a5e2e03c9c8e375876a2127d90db7efe13.diff

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz created this revision. beanz added reviewers: bogner, aaron.ballman, python3kgae, pow2clk, tex3d. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL entry function parameters must have parameter

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

shafik added a comment. In D131423#3712083 , @inclyc wrote: > @aaron.ballman @shafik (Help wanted). These type traits will not cause clang > to crash if current patch applied, but the `bool x` in the test case will > evaluate to `false`. I think the

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

barannikov88 added a comment. The diff seems to be restricted to few lines. It should include the full context. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49 + std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu"; + * `!isMusl()` does not

[PATCH] D130969: [clang] [HLSL] Fix GCC warnings about virtual methods that are hidden

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. This is a really unfortunate interface that causes this :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130969/new/

[PATCH] D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c

lei created this revision. lei added reviewers: nemanjai, amyk, power-llvm-team. Herald added a subscriber: shchenz. Herald added a project: All. lei requested review of this revision. Herald added a project: clang. Followup patch to address request from https://reviews.llvm.org/D124093

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451635. vaibhav.y added a comment. Run git-clang-format Rebase on upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 Files:

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451633. vaibhav.y added a comment. Autofix clang-tidy readability warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131084/new/ https://reviews.llvm.org/D131084 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451632. brettw added a comment. New patch up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131438: [clang][dataflow] Analyze constructor bodies

eugenis added a comment. Sorry but I had to revert this because of the conflicts with another revert: https://reviews.llvm.org/D131065 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131438/new/ https://reviews.llvm.org/D131438

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

eugenis added a comment. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131065/new/ https://reviews.llvm.org/D131065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 8d3c960 - Revert "[clang][dataflow] Store DeclContext of block being analysed in Environment if available."

Author: Evgenii Stepanov Date: 2022-08-10T14:22:04-07:00 New Revision: 8d3c9602959df4caadfade1f40512231f7d6bbe8 URL: https://github.com/llvm/llvm-project/commit/8d3c9602959df4caadfade1f40512231f7d6bbe8 DIFF:

[clang] 7587065 - Revert "[clang][dataflow] Analyze constructor bodies"

Author: Evgenii Stepanov Date: 2022-08-10T14:21:56-07:00 New Revision: 75870650433de9e7bfbe86adc1bef2f2a23fe7a3 URL: https://github.com/llvm/llvm-project/commit/75870650433de9e7bfbe86adc1bef2f2a23fe7a3 DIFF:

[clang] 26089d4 - Revert "[clang][dataflow] Don't crash when caller args are missing storage locations"

Author: Evgenii Stepanov Date: 2022-08-10T14:21:46-07:00 New Revision: 26089d4da489dc17711213f917779e480a78ed51 URL: https://github.com/llvm/llvm-project/commit/26089d4da489dc17711213f917779e480a78ed51 DIFF:

[PATCH] D131065: [clang][dataflow] Store DeclContext of block being analysed in Environment if available.

eugenis added a comment. MSan is not happy: https://lab.llvm.org/buildbot/#/builders/74/builds/12717 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131065/new/ https://reviews.llvm.org/D131065 ___

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin updated this revision to Diff 451624. denis-fatkulin added a comment. Broken tests are deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131091/new/ https://reviews.llvm.org/D131091 Files:

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3714062 , @nikic wrote: > This seems to break the test-suite build: > > FAILED: CTMark/ClamAV/CMakeFiles/clamscan.dir/libclamav_readdb.c.o > /root/llvm-compile-time-tracker/llvm-test-suite-build/tools/timeit

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

nikic added a comment. This seems to break the test-suite build: FAILED: CTMark/ClamAV/CMakeFiles/clamscan.dir/libclamav_readdb.c.o /root/llvm-compile-time-tracker/llvm-test-suite-build/tools/timeit --summary CTMark/ClamAV/CMakeFiles/clamscan.dir/libclamav_readdb.c.o.time

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D131614

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128 +// to the function itself; it points to a stub for the compiler. +// FIXME: We also need to emit an entry thunk. +SmallString<256> MangledName; bcl5980 wrote: >

[PATCH] D131553: [analyzer] exploded-graph-rewriter: Fix python3 string encoding issues

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks for figuring all of this out! Looks great! That's right, we can't and probably shouldn't test graphviz. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:862

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rGc843c921a1a3: [clang] Require strict matches for defines for PCH in GCC style directories (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D126676?vs=451434=451605#toc

[clang] c843c92 - [clang] Require strict matches for defines for PCH in GCC style directories

Author: Martin Storsjö Date: 2022-08-10T22:47:27+03:00 New Revision: c843c921a1a385bb805b2338d980436c94f83f19 URL: https://github.com/llvm/llvm-project/commit/c843c921a1a385bb805b2338d980436c94f83f19 DIFF:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 451604. furkanusta added a comment. - [clangd] D130363 (CodeCompletion/overrides.cpp) Move tests to bottom Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128807/new/ https://reviews.llvm.org/D128807

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

vladimir.plyashkun added a comment. In D131590#3713731 , @njames93 wrote: > Can this be backported as well. I guess someone needs to do it, because i haven't got commit/write access in LLVM repository. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131388: [docs] Add "C++20 Modules"

dblaikie added a comment. (I'll +1 to @ruoso's comments about using BMI - I think it might be best not to introduce a different term ("Module file") as it might confuse people as it's fairly close to "module source file", etc. BMI makes it clear/unambiguous that it's the binary file, not the

[PATCH] D131420: [clang][deps] Always generate module paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG71e32d5cf005: [clang][deps] Always generate module paths (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D131420?vs=450887=451593#toc Repository: rG LLVM Github

[clang] 71e32d5 - [clang][deps] Always generate module paths

Author: Jan Svoboda Date: 2022-08-10T11:58:28-07:00 New Revision: 71e32d5cf0053090aaad62d946fcfd00f1915f26 URL: https://github.com/llvm/llvm-project/commit/71e32d5cf0053090aaad62d946fcfd00f1915f26 DIFF: https://github.com/llvm/llvm-project/commit/71e32d5cf0053090aaad62d946fcfd00f1915f26.diff

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

njames93 accepted this revision. njames93 added a comment. Can this be backported as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131590/new/ https://reviews.llvm.org/D131590 ___ cfe-commits

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:256 std::string HelpURI; + SarifReportingConfiguration DefaultConfiguration; Is this form preferred for expressing a statically known default value? Repository: rG LLVM

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added a comment. It will take some time to fix all tests properly. Let's have a guideline how to fix them properly. I tried fixing some using several patterns in the last revision. I didn't fix all, because it would likely lead to an unsatisfactory result and I would spend more time :)

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 451586. MaskRay marked 5 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Add lit substitutions Repository: rG LLVM Github

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. Sorry, I somehow missed the big obvious checkbox to mark the comments, fixed now. I don't have commit access could you commit if the last change seems okay to you? Name: Gergely Meszaros Email: meszaros.gergel...@gmail.com Repository: rG LLVM Github Monorepo

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y updated this revision to Diff 451585. vaibhav.y added a comment. Update diff: - Create class `SarifReportingConfiguration`: This should allow rules to specify the `defaultConfiguration` property Add tests for: - Creating rules with custom reporting configuration - Death test for

[PATCH] D131479: Handle explicitly defaulted consteval special members.

shafik added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:812 + fail1 = good0; // expected-error-re {{call to consteval function '{{.*::copy<.*::foo>}}::operator=' is not a constant expression}} \ + expected-note {{in

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis updated this revision to Diff 451584. Maetveis marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 Files: clang/tools/clang-format/git-clang-format Index:

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:812 + fail1 = good0; // expected-error-re {{call to consteval function '{{.*::copy<.*::foo>}}::operator=' is not a constant expression}} \ +

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. This is generally looking good to me, thank you! Just a few minor points and I think this will be ready. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:7551 + // expression. + if (isa(RD) &&

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e458765aaef: [Clang] Restrict non fixed enum to a value outside the range of the enumeration… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4e45876 - [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

Author: Shafik Yaghmour Date: 2022-08-10T11:12:01-07:00 New Revision: 4e458765aaef7988e687e190d865f331727825c0 URL: https://github.com/llvm/llvm-project/commit/4e458765aaef7988e687e190d865f331727825c0 DIFF:

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

listout updated this revision to Diff 451572. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131563/new/ https://reviews.llvm.org/D131563 Files: clang/lib/Driver/ToolChains/Linux.cpp Index: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

thakis added a comment. Can this land? Our bots have been red since the default-error-mapped-warning patch landed... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https://reviews.llvm.org/D131528 ___ cfe-commits mailing list

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM, no issues on our side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126676/new/ https://reviews.llvm.org/D126676 ___ cfe-commits

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf01f717c48f: Default implicit function pointer conversions diagnostic to be an error (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D131351?vs=451094=451561#toc

[clang-tools-extra] af01f71 - Default implicit function pointer conversions diagnostic to be an error

Author: Aaron Ballman Date: 2022-08-10T13:54:17-04:00 New Revision: af01f717c48f0fd2481600ed6c00441763365b62 URL: https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62 DIFF: https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62.diff

[clang] ec08114 - [NFC][Clang] make AtomicConstraint::ParameterMapping const

Author: Yuanfang Chen Date: 2022-08-10T10:51:39-07:00 New Revision: ec0811413375bfe75a9361264f98ad9b5dab85b6 URL: https://github.com/llvm/llvm-project/commit/ec0811413375bfe75a9361264f98ad9b5dab85b6 DIFF: https://github.com/llvm/llvm-project/commit/ec0811413375bfe75a9361264f98ad9b5dab85b6.diff

[PATCH] D131600: [clang][dataflow] Don't crash when caller args are missing storage locations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43b298ea1282: [clang][dataflow] Dont crash when caller args are missing storage locations (authored by samestep). Repository: rG LLVM Github

[clang] 43b298e - [clang][dataflow] Don't crash when caller args are missing storage locations

Author: Sam Estep Date: 2022-08-10T17:50:34Z New Revision: 43b298ea1282f29d448fc0f6ca971bc5fa698355 URL: https://github.com/llvm/llvm-project/commit/43b298ea1282f29d448fc0f6ca971bc5fa698355 DIFF: https://github.com/llvm/llvm-project/commit/43b298ea1282f29d448fc0f6ca971bc5fa698355.diff LOG:

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman added a comment. In D130933#3713437 , @OfekShilon wrote: > @aaron.ballman 'Ofek Shilon', ofekshi...@gmail.com is fine. > Thanks! Thank you! I've landed on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130933: Add docs for function attributes hot/cold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73a1b162a4cd: Add docs for function attributes hot/cold (authored by OfekShilon, committed by aaron.ballman). Repository: rG LLVM Github Monorepo

[clang] 73a1b16 - Add docs for function attributes hot/cold

Author: Ofek Shilon Date: 2022-08-10T13:48:43-04:00 New Revision: 73a1b162a4cd5850a474b7cf8497aef3006094e2 URL: https://github.com/llvm/llvm-project/commit/73a1b162a4cd5850a474b7cf8497aef3006094e2 DIFF: https://github.com/llvm/llvm-project/commit/73a1b162a4cd5850a474b7cf8497aef3006094e2.diff

[PATCH] D131600: [clang][dataflow] Don't crash when caller args are missing storage locations

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D130933: Add docs for function attributes hot/cold

OfekShilon added a comment. @aaron.ballman 'Ofek Shilon', ofekshi...@gmail.com is fine. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130933/new/ https://reviews.llvm.org/D130933 ___ cfe-commits mailing list

[PATCH] D130933: Add docs for function attributes hot/cold

aaron.ballman accepted this revision. aaron.ballman added a comment. In D130933#3713277 , @OfekShilon wrote: > My apologies for the mess, hopefully the diff I just uploaded includes all > the right fixes. No worries! If I had a nickel for every time

[PATCH] D131598: [Clang][BPF]: Force sign/zero extension for return values in caller

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently bpf

  1   2   3   >