[clang] 79fa0ec - [C++20] [Modules] Make member functions with a in-class definition in HU implicitly inline

Author: Chuanqi Xu Date: 2022-09-13T13:11:56+08:00 New Revision: 79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798 URL: https://github.com/llvm/llvm-project/commit/79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798 DIFF: https://github.com/llvm/llvm-project/commit/79fa0ec8c4bfeeb21f7b44ebd9a66e7ec9781798.diff

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList ) const override; + jhuber6 wrote: > JonChesterfield wrote: > > Why hip device libs? There's a

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat updated this revision to Diff 459642. OfekShochat added a comment. Clang, increase upper bound of partially initialized array sizes fixes issue with emitting partially initialized constant arrays larger than 2^32. issue #57353 on github. Repository: rG LLVM Github Monorepo

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ dreachem wrote: > ye-luo wrote: > > doru1004 wrote: > > > doru1004 wrote: > > > >

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3784605 , @tra wrote: >> Archives passed by -l: should not be prefixed with >> prefix lib and appended with '.a', but still need to be prefixed with >> paths in -L options. >> Archives passed as input files should

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459634. inclyc added a comment. git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459633. inclyc added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

dreachem added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > >

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu added a comment. @nhaehnle @jyknight @nikic @efriedma @fhahn ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. @ychen @rjmccall ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341/new/ https://reviews.llvm.org/D133341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459620. VincentWu added a comment. add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files:

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 459617. VincentWu edited the summary of this revision. VincentWu added a reviewer: asb. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/

[PATCH] D133741: [IR] Add alignment for llvm.threadlocal.address

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: ChuanqiXu, nikic, aeubanks. alexander-shaposhnikov created this object with visibility "All Users". Herald added a subscriber: hiraditya. Herald added a project: All. alexander-shaposhnikov requested review of

[PATCH] D133659: [Clang] P1169R4: static operator()

shafik added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15934 + // or a reference to an enumeration. + // Note: Before C++23, a member function also has to not be static. if (CXXMethodDecl *MethodDecl = dyn_cast(FnDecl)) {

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3785240 , @alexfh wrote: > In D111283#3783627 , @alexfh wrote: > >> Hi Matheus, an early heads up: this commit is causing clang crashes on some >> of our code. I'll post more

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3783627 , @alexfh wrote: > Hi Matheus, an early heads up: this commit is causing clang crashes on some > of our code. I'll post more details a bit later. The stack trace of the failure looks like this: #0

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > >

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > >

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 459589. Amir added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modules/ClangBootstrap.cmake Index:

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459588. Amir added a comment. Add an ability to pass extra cmake flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added a comment. In D133726#3785040 , @JonChesterfield wrote: > We can do this but should expect an increase in code size from having > multiple internalised copies of the same function. There may be an incidental > benefit if we can

[clang-tools-extra] 651ceb1 - [test][clangd] Another try to fix bots after 72142fbac4

Author: Vitaly Buka Date: 2022-09-12T16:14:07-07:00 New Revision: 651ceb1ee7a257225bed1dc78693ff99fae9e571 URL: https://github.com/llvm/llvm-project/commit/651ceb1ee7a257225bed1dc78693ff99fae9e571 DIFF: https://github.com/llvm/llvm-project/commit/651ceb1ee7a257225bed1dc78693ff99fae9e571.diff

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. @xur Gentle reminder. Just want to make sure I'm not missing anything obvious since I've made some somewhat substantial changes since your sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132991/new/

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, fhahn, RKSimon. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rG6f9c4851ab7c: [MinGW] Reject explicit hidden visibility applied to dllexport and… (authored by MaskRay). Changed prior to commit:

[clang] 6f9c485 - [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

Author: Fangrui Song Date: 2022-09-12T15:56:36-07:00 New Revision: 6f9c4851ab7c729812bc8f48b19de3f84a64f6f0 URL: https://github.com/llvm/llvm-project/commit/6f9c4851ab7c729812bc8f48b19de3f84a64f6f0 DIFF: https://github.com/llvm/llvm-project/commit/6f9c4851ab7c729812bc8f48b19de3f84a64f6f0.diff

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6480 + // Process Windows runtime flags (equivalent to cl flags /MD, /MDd, /MT, /MTd) + if (Triple.isOSWindows()) { hans wrote: > Could we somehow re-use the logic in

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 459577. akhuang marked 2 inline comments as done. akhuang added a comment. Clean up test, add doc brief to new flag, try to put the flag logic in a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1116 +if (GV->hasDLLExportStorageClass()) { + // Reject explicit hidden visibility on dllexport. + if (LV.getVisibility() == HiddenVisibility)

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList ) const override; + JonChesterfield wrote: > Why hip device libs? There's a common set, plus a hip.bc plus

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.h:58 + llvm::SmallVector + getHIPDeviceLibs(const llvm::opt::ArgList ) const override; + Why hip device libs? There's a common set, plus a hip.bc plus a opencl.bc. I'd

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield added a comment. We can do this but should expect an increase in code size from having multiple internalised copies of the same function. There may be an incidental benefit if we can specialise some functions to the call site without additional cloning. Address of the same

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

bd1976llvm added a comment. In D133266#3776164 , @MaskRay wrote: > In D133266#3776051 , @bd1976llvm > wrote: > >> In D133266#3775832 , @MaskRay >> wrote: >> >>> In

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds support for default arguments in the internal representation and reads

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation =

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > >

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

davrec added inline comments. Comment at: clang/include/clang/AST/Type.h:5530-5537 /// Represents a type that was referred to using an elaborated type /// keyword, e.g., struct S, or via a qualified name, e.g., N::M::type, /// or both. /// /// This type is used to keep

[PATCH] D133586: [clang] do not hash undefined qualifiers for FunctionNoProtoType

rmaz planned changes to this revision. rmaz added a comment. I think it is probably safer to zero out the FastTypeQuals instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, arsenm, yaxunl, tianshilei1992, ye-luo. Herald added subscribers: kosarev, kerbowa, guansong, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this

[clang] ab56719 - [clang, llvm] Add __declspec(safebuffers), support it in CodeView

Author: David Majnemer Date: 2022-09-12T21:15:34Z New Revision: ab56719acd98778fb2e48fa425ac7c8d27bdea86 URL: https://github.com/llvm/llvm-project/commit/ab56719acd98778fb2e48fa425ac7c8d27bdea86 DIFF: https://github.com/llvm/llvm-project/commit/ab56719acd98778fb2e48fa425ac7c8d27bdea86.diff

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

efriedma added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorElement) ElementEntity.setElementIndex(Init); shafik wrote: > `setElementIndex(...)` takes `unsigned` as well and

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3784702 , @mizvekov wrote: > In D111283#3784663 , @ychen wrote: > >> Thanks for the link. I'm not blocked by any of these patches, instead just >> trying to have a mental model

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > doru1004 wrote: > > > >

[PATCH] D133725: Searching for tokens including comments

barcisz created this revision. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a small diff that adds an optional argument to the Lexer::findNextToken that allows for searching for the token

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorElement) ElementEntity.setElementIndex(Init); `setElementIndex(...)` takes `unsigned` as well and therefore

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code MyDeveloperDay wrote: > HazardyKnusperkeks

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1965 (Style.JavaScriptQuotes == FormatStyle::JSQS_Double && - !Input.startswith("\'"))) { + !Input.startswith("\'"))) continue;

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

benlangmuir added a comment. Reverted due to failure on a bot https://lab.llvm.org/buildbot/#/builders/214/builds/3252 I'm not sure how to deal with missing `env -u`. - We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's interpretation of empty string for this variable. I'm

[PATCH] D133574: [C2x] reject type definitions in offsetof

shafik added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2283 case DeclSpecContext::DSC_top_level: +case DeclSpecContext::DSC_offsetof: return true; Why `true` for this case? What does this allow that we want? Do we test it?

[clang] 4a72459 - Revert "[clang][test] Disallow using the default module cache path in lit tests"

Author: Ben Langmuir Date: 2022-09-12T13:10:22-07:00 New Revision: 4a72459ed639e3eb7188565c758181c43d3192aa URL: https://github.com/llvm/llvm-project/commit/4a72459ed639e3eb7188565c758181c43d3192aa DIFF: https://github.com/llvm/llvm-project/commit/4a72459ed639e3eb7188565c758181c43d3192aa.diff

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as not done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459539. Amir added a comment. Address @phosek's comment about dependency on shell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

akyrtzi added a comment. In D133674#3784602 , @jansvoboda11 wrote: > Could you explain why this is necessary and even correct? I'd expect Clang to > give an error when seeing `##` in this position, and I'd expect the scanner > to do the same. `##` is

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784663 , @ychen wrote: > Thanks for the link. I'm not blocked by any of these patches, instead just > trying to have a mental model of when to expect the sugared type :-). For > partial ordering, the

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3784648 , @mizvekov wrote: > In D111283#3784615 , @ychen wrote: > >> `A` is currently modeled as ElaboratedType. It was >> `TemplateSpecializationType` before. Reading comments

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 459534. hctim added a comment. Remove unnecessary hasSanitizerMetadata() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/test/Driver/memtag-stack.c

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3784615 , @ychen wrote: > `A` is currently modeled as ElaboratedType. It was > `TemplateSpecializationType` before. Reading comments for `ElaboratedType`, > it looks like sugar type might not be needed here? Ah you

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. In D133668#3784636 , @python3kgae wrote: > In D133668#3784607 , @aaron.ballman > wrote: > >> In D133668#3783975 , @beanz wrote: >> >>> In

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. In D133668#3784607 , @aaron.ballman wrote: > In D133668#3783975 , @beanz wrote: > >> In D133668#3783489 , >> @aaron.ballman wrote: >> >>>

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Mon, Sep 12, 2022 at 12:17 PM David Blaikie wrote: > > On Sat, Sep 10, 2022 at 3:01 PM Kazu Hirata wrote: > > > > Thank you Aaron and David for your inputs. > > > > First and foremost, I apologize if I made your job harder by increasing the > > number of commits you have to peel to get to

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ychen added a comment. In D111283#3783338 , @mizvekov wrote: > In D111283#3783250 , @ychen wrote: > >> Hi @mizvekov , I noticed that deduction for partial ordering also inherits >> this new behavior. Do you

[PATCH] D133611: [clang] sort additional module maps when serializing

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c1b42347b3a: [clang] sort additional module maps when serializing (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133611/new/

[clang] 3c1b423 - [clang] sort additional module maps when serializing

Author: Richard Howell Date: 2022-09-12T12:00:43-07:00 New Revision: 3c1b42347b3a0666c93948ade2f420a20e060c1a URL: https://github.com/llvm/llvm-project/commit/3c1b42347b3a0666c93948ade2f420a20e060c1a DIFF:

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added a comment. In D133668#3783975 , @beanz wrote: > In D133668#3783489 , @aaron.ballman > wrote: > >> Okay, that's good to know! If you don't intend to *ever* conform to the >> standard in this

[PATCH] D133705: [HIP] Fix unbundling archive

tra added a comment. > Archives passed by -l: should not be prefixed with > prefix lib and appended with '.a', but still need to be prefixed with > paths in -L options. > Archives passed as input files should not be prefixed > or appended with anything. I'm not sure I understand the

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

jansvoboda11 added a comment. Could you explain why this is necessary and even correct? I'd expect Clang to give an error when seeing `##` in this position, and I'd expect the scanner to do the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133659: [Clang] P1169R4: static operator()

lichray added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-static-call-operator.cpp:5 +struct Functor { + static int operator()(int x, int y) { +return x + y; I want to see some tests that diagnose `extern operator()`. Comment

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > In my

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > ye-luo wrote: > > > In my understanding of the

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 459525. royjacobson marked an inline comment as done. royjacobson added a comment. Add note in diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files:

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson marked 6 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1265 + if (Intro.hasLambdaCapture()) +P.Diag(StaticLoc, diag::err_static_lambda_captures); +} cor3ntin wrote: > We might want to

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff marked 4 inline comments as done. sepavloff added a comment. In D133325#3771275 , @MaskRay wrote: > For a config file, `--search-config-dirs` is introduced to change how `@cfg` > is resolved > (relative to `--config-system-dir` or

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ doru1004 wrote: > ye-luo wrote: > > In my understanding of the spec. > >

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132643/new/ https://reviews.llvm.org/D132643

[PATCH] D133705: [HIP] Fix unbundling archive

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 ___ cfe-commits mailing list

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 459519. python3kgae marked an inline comment as done. python3kgae added a comment. Fix test fail caused by not add HLSL builtin Resource type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a reviewer: aaron.ballman. efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2406 + + if (Size.isZero() || Size >= Context.getTypeAlignInChars(EltTy)) +return false; I think you need to check that the size is a multiple

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

doru1004 added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > In my understanding of the spec. > `map(tofrom:x[0:256])` only maps

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff updated this revision to Diff 459508. sepavloff added a comment. Rebased, addressed reviewers' notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133325/new/ https://reviews.llvm.org/D133325 Files: clang/docs/UsersManual.rst

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak created this revision. ahatanak added reviewers: efriedma, rjmccall, rnk, sepavloff. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. In the following code, the first element is aligned on a 16-byte boundary, but the remaining

[PATCH] D133703: [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eead180b92d: [Clang] NFC: Make UnqualifiedId::Kind private for

[clang] 7eead18 - [Clang] NFC: Make UnqualifiedId::Kind private for consistency.

Author: Corentin Jabot Date: 2022-09-12T19:14:06+02:00 New Revision: 7eead180b92dcff7eaf9d71df14e33936ec4dbe5 URL: https://github.com/llvm/llvm-project/commit/7eead180b92dcff7eaf9d71df14e33936ec4dbe5 DIFF:

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459502. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Siu Chi's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959 + if (FoundAOB) +break; } scchan wrote: > The AOBFileNames small vector needs to be cleared if !FoundAOB or just

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

ye-luo added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ In my understanding of the spec. `map(tofrom:x[0:256])` only maps the memory segment

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked 2 inline comments as done. yusuke-kadowaki added a comment. So other than the naming, does the struct look good? Comment at: clang/include/clang/Format/Format.h:406 +/// Specifies the way to align trailing comments +TrailingCommentsAlignmentKinds

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGd96f526196ac: [clang][test] Disallow using the default module cache path in lit tests (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d96f526 - [clang][test] Disallow using the default module cache path in lit tests

Author: Ben Langmuir Date: 2022-09-12T09:54:56-07:00 New Revision: d96f526196ac4cebfdd318473816f6d4b9d76707 URL: https://github.com/llvm/llvm-project/commit/d96f526196ac4cebfdd318473816f6d4b9d76707 DIFF: https://github.com/llvm/llvm-project/commit/d96f526196ac4cebfdd318473816f6d4b9d76707.diff

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:406 +/// Specifies the way to align trailing comments +TrailingCommentsAlignmentKinds Kind; +/// How many empty lines to apply alignment Kind? doesn't feel like the

[PATCH] D133611: [clang] sort additional module maps when serializing

rmaz updated this revision to Diff 459492. rmaz added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133611/new/ https://reviews.llvm.org/D133611 Files: clang/lib/Serialization/ASTWriter.cpp Index:

[PATCH] D133705: [HIP] Fix unbundling archive

scchan requested changes to this revision. scchan added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1959 + if (FoundAOB) +break; } The AOBFileNames small vector needs to

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. One thought that occurred to me is that the way C has this specified is awfully effectively the same way implicit int worked. It may be worth exploring a change to our implicit int functionality to instead generate an implicit `auto` type when in C2x mode.

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. FYI: regarding `auto auto`, I've heard back from the author of N3007 and the intent was to disallow this construct ("others" was meant to exclude `auto` and "except typedef" was meant to add onto the list of exclusions). Repository: rG LLVM Github Monorepo

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Sat, Sep 10, 2022 at 3:01 PM Kazu Hirata wrote: > > Thank you Aaron and David for your inputs. > > First and foremost, I apologize if I made your job harder by increasing the > number of commits you have to peel to get to the real author. > > I hear that we are moving toward github pull

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

shafik added inline comments. Comment at: clang/test/Sema/c2x-auto.c:49 +auto b = 9; +auto c = a + b; + } When I made the comment about the example from the proposal, this was what I was thinking about. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459484. yaxunl added a comment. remove debug output CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. This is awesome, thank you for working on it! @to268 and I had a really good discussion during my office hours and what we decided for next steps were: 0) Next time you upload a patch, please use `-U` to give the patch more context for reviewers to see. 1.

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 459482. yaxunl added a comment. Herald added subscribers: sstefan1, MaskRay. Herald added a reviewer: jdoerfert. sorry. update with the correct patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files:

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. HIP is able to unbundle archive of bundled bitcode. However currently there are two bugs: 1. archives passed by -l: are not unbundled. 2. archives passed as input

  1   2   >