[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

dblaikie updated this revision to Diff 460637. dblaikie marked an inline comment as done. dblaikie added a comment. Add the three test cases. Verified they failed without the patch and pass with it. Testing them across all the Windows ABI variants, since they seem to apply equally.

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/coroutine-alloc-4.cpp:49 +void return_value(int) {} +void *operator new(std::size_t, std::align_val_t) noexcept; +void *operator new(std::size_t) noexcept; ychen wrote: > ChuanqiXu

[clang] 45b85ae - [Driver][test] Disable hip-link-bc-to-bc.hip

Author: Fangrui Song Date: 2022-09-15T21:41:18-07:00 New Revision: 45b85aebdbb08fed26cb5976401cddcf51625533 URL: https://github.com/llvm/llvm-project/commit/45b85aebdbb08fed26cb5976401cddcf51625533 DIFF: https://github.com/llvm/llvm-project/commit/45b85aebdbb08fed26cb5976401cddcf51625533.diff

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Give it a few days in case @rjmccall have comments. Comment at: clang/test/SemaCXX/coroutine-alloc-4.cpp:49 +void return_value(int) {} +void *operator

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. AFAIK, --target is clang-specific and transparent for compiler user in RV side. -m is also undefined or less used by RV user. It just uses -march to specify 32 or 64 mode and extensions. Is the convention specified in RV Spec? CHANGES SINCE LAST ACTION

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

MaskRay added a comment. In D129824#3794229 , @jrtc27 wrote: > In D129824#3794221 , @MaskRay wrote: > >> Both D54214 and this look like a >> surprising behavior to me. Do we

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

jrtc27 added a comment. In D129824#3794221 , @MaskRay wrote: > Both D54214 and this look like a surprising > behavior to me. Do we still have time to go back the state before D54214 >

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

MaskRay added a comment. Both D54214 and this look like a surprising behavior to me. Do we still have time to go back the state before D54214 and make mismatching --target & -march= an error? > clang -target=riscv32--

[PATCH] D133954: [clang-format] Fix template arguments in macros

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9793-9795 + verifyFormat("#define FOO(typeName, realClass) " + "\\\n" + " { #typeName,

[PATCH] D134007: [Clang][CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder.

Jimerlife created this revision. Jimerlife added reviewers: sfantao, tra, ABataev, benshi001. Jimerlife added a project: LLVM. Herald added subscribers: mattd, yaxunl. Herald added a project: All. Jimerlife requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan,

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

MaskRay added a comment. In the long term we should just remove the `CLANG_INSTALL_LIBDIR_BASENAME` customization. This is supposed for GCC multilib lib32 lib64 names but we don't necessarily use it for Clang + compiler-rt files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133998: [HIP][test] Avoid %T

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1c1ecb148e: [HIP][test] Avoid %T (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D133998?vs=460569=460608#toc

[clang] 9e1c1ec - [HIP][test] Avoid %T

Author: Fangrui Song Date: 2022-09-15T19:58:42-07:00 New Revision: 9e1c1ecb148eb4e530467e178973e870945e6602 URL: https://github.com/llvm/llvm-project/commit/9e1c1ecb148eb4e530467e178973e870945e6602 DIFF: https://github.com/llvm/llvm-project/commit/9e1c1ecb148eb4e530467e178973e870945e6602.diff

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] d6aed77 - [InstrProfiling] No runtime hook for unused funcs

Author: Gulfem Savrun Yeniceri Date: 2022-09-16T02:05:09Z New Revision: d6aed77f0d19664be48d531552692520ae2a6f1a URL: https://github.com/llvm/llvm-project/commit/d6aed77f0d19664be48d531552692520ae2a6f1a DIFF:

[clang] 3eca0b3 - [lit] Set shlibpath_var on OpenBSD

Author: Brad Smith Date: 2022-09-15T21:43:54-04:00 New Revision: 3eca0b395ff07d0428f4179e33a6ae295e608f47 URL: https://github.com/llvm/llvm-project/commit/3eca0b395ff07d0428f4179e33a6ae295e608f47 DIFF: https://github.com/llvm/llvm-project/commit/3eca0b395ff07d0428f4179e33a6ae295e608f47.diff

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ aaron.ballman wrote: > inclyc wrote: > > inclyc wrote: > > > aaron.ballman wrote: >

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 460595. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov updated this revision to Diff 460594. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 460593. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 460592. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 460591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 460590. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 460589. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index:

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 460588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460587. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3786678 , @mizvekov wrote: > @alexfh This new revision that I just pushed should be good. > > Do you want to give it a look / test, or should we go ahead and merge it? Thanks for the fix! If it fixes the test case I

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3793931 , @MaskRay wrote: > I know very little about HIP, but I am concerned with relying on extensions > as well. For example, I've seen `libc++.a.1` (we use this for the real > archive while `libc++.a` is a linker

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3793702 , @tra wrote: > In D133705#3785470 , @yaxunl wrote: > >>> Also, using `lib*.a` as pattern to tell device libraries from the host-ony >>> one will be insufficient. There

[PATCH] D133732: [clang-doc] Support default args for functions.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 ___ cfe-commits mailing list

[PATCH] D133705: [HIP] Fix unbundling archive

MaskRay added a comment. I know very little about HIP, but I am concerned with relying on extensions as well. For example, I've seen `libc++.a.1` (we use this for the real archive while `libc++.a` is a linker script) and `.la` (libtool). A `.so` file is sometimes a linker script and it may

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay updated this revision to Diff 460569. MaskRay added a comment. fix all hip-* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133998/new/ https://reviews.llvm.org/D133998 Files: clang/test/Driver/hip-link-bc-to-bc.hip

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay created this revision. MaskRay added reviewers: tra, yaxunl. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. %T is a deprecated lit feature. It refers to

[PATCH] D132984: Set HOME for tests that use module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fe475756b26: Set HOME for tests that use module cache path (authored by ccross, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7fe4757 - Set HOME for tests that use module cache path

Author: Colin Cross Date: 2022-09-15T23:58:57Z New Revision: 7fe475756b26080fe0bb02e8e317662ccc9a01f1 URL: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1 DIFF: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1.diff LOG:

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

nridge added a comment. In D131853#3792985 , @logankaser wrote: > Is there anything I can do as a random member of the public that wants this > and knows C++? Maybe apply the patch locally, use it for a bit, and provide feedback? I haven't forgotten

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: sammccall wrote: > I have a couple of concerns with

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After generated call for

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cuda/unsafe-kernel-call-macro-handler.cu:53 + } + auto err = cudaGetLastError(); + tra wrote: > barcisz wrote: > > tra wrote: > > > Just curious -- is it sufficient to just

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 updated this revision to Diff 460552. jansvoboda11 added a comment. Replace `std::shared_ptr` by `Optional` stored on `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz updated this revision to Diff 460551. barcisz added a comment. Misplaced diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 Files: clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

barcisz updated this revision to Diff 460550. barcisz added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133956/new/ https://reviews.llvm.org/D133956 Files: clang-tools-extra/clang-tidy/cuda/CMakeLists.txt

[PATCH] D133991: add new function to release notes

anderslanglands added a comment. Sorry, this was supposed to update https://reviews.llvm.org/D13392. How do I delete this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133991/new/ https://reviews.llvm.org/D133991

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz added a comment. In D133942#3793618 , @njames93 wrote: > Would I be correct in assuming you have uploaded the wrong diff here? Yes, sorry, got mixed up with D133956 (6 diffs ain't easy to shuffle :-/)

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460549. anderslanglands added a comment. Updating based on review - Add new function to release notes - Fix failing test and add a new test specifically for this function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133991: add new function to release notes

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix copy/paste error in doc comment fix failing test now deleted is

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 460546. python3kgae added a comment. Fix warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 added a comment. Another option would be to store `ScanInstance` as member of `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D133988

[PATCH] D133705: [HIP] Fix unbundling archive

tra added a comment. In D133705#3785470 , @yaxunl wrote: >> Also, using `lib*.a` as pattern to tell device libraries from the host-ony >> one will be insufficient. There will be libraries with other extensions >> (e.g. `.lo` is fairly common) and there

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ScanInstance` is a local variable in

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw updated this revision to Diff 460538. brettw marked 4 inline comments as done. brettw added a comment. There is no usage change for this. It just adds another field to the YAML. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 Files:

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 +return this->emitConst( +E, Ctx.getASTContext().getTypeSizeInChars(ArgType).getQuantity()); + } aaron.ballman wrote: > erichkeane wrote: > > shafik wrote: > > >

[PATCH] D133634: [clang] Allow vector of BitInt

efriedma added a comment. I think the worst of the backend issues with vectors of non-byte-size integers have been resolved? Work on that has progressed slowly for a very long time. There have been a constant stream of issues. (See, for example, D129164 .)

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

njames93 added a comment. In D132461#3773792 , @carlosgalvezp wrote: > @njames93 Friendly ping. The patch has addressed all comments and remained > unchanged for 2 weeks. I would like to land it latest next week. If you are > happy with the patch,

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

tra added a comment. > The intention with this check is to work a lot in tandem with the one in > D133804 , which therefore prevents most > such cases. > Thus, the check is optimized for lowering false positives during static > checking and for a practice

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:127 + // Default implementation is a Noop. + virtual void branchTransfer(bool Branch, const Stmt *S, Lattice , + Environment ) {}

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

njames93 added a comment. Would I be correct in assuming you have uploaded the wrong diff here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 ___ cfe-commits

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e52c0926c22: Add -fsanitizer-coverage=control-flow (authored by Navidem, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[clang] 3e52c09 - Add -fsanitizer-coverage=control-flow

Author: Navid Emamdoost Date: 2022-09-15T15:56:04-07:00 New Revision: 3e52c0926c22575d918e7ca8369522b986635cd3 URL: https://github.com/llvm/llvm-project/commit/3e52c0926c22575d918e7ca8369522b986635cd3 DIFF:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:155 +cl::desc("collect control flow for each function"), cl::Hidden, +cl::init(false)); + MaskRay wrote: > false can be

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka updated this revision to Diff 460525. vitalybuka added a comment. clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

MaskRay accepted this revision. MaskRay added inline comments. Herald added a subscriber: StephenFan. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:155 +cl::desc("collect control flow for each function"), cl::Hidden, +

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz updated this revision to Diff 460522. barcisz added a comment. Herald added a subscriber: mgorny. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 Files:

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

sammccall created this revision. sammccall added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When we aim

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460520. barcisz added a comment. moved size_t definition to an stddef.h stub Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9449-9450 + !(Features & llvm::AMDGPU::FEATURE_WAVE32) || + llvm::is_contained(CGM.getTarget().getTargetOpts().FeaturesAsWritten, + "+wavefrontsize64"); +

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460519. barcisz added a comment. Dummy definition for size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka updated this revision to Diff 460518. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem added a comment. Thanks @kcc @vitalybuka, I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___ cfe-commits mailing list

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 460514. ayzhao added a comment. hacky fix for the test CXX/module/module.interface/p2-2.cpp If anyone has a better idea on how to fix this test, feedback is **very** welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:362 +// allow this as an extension. +if (AllowImplicitTypename == ImplicitTypenameContext::No && +!isClassName && !IsCtorOrDtorName) ayzhao wrote: > Status update:

[PATCH] D133725: Searching for tokens including comments

barcisz added a comment. In D133725#3792787 , @aaron.ballman wrote: > Can you help me understand the expected use for these change? Changed the description to answer your question - it's a prerequisite to D133942 and

[PATCH] D133956: git push Cuda Check for ignored errors after calling a CUDA kernel

barcisz added a comment. In D133956#3793022 , @tra wrote: > I think ultimately the checker should be generalized to flag all unchecked > CUDA runtime calls. The problem is that that is going to be exceedingly noisy > in practice as a lot of real code

[PATCH] D133732: [clang-doc] Support default args for functions.

paulkirth added a comment. Thanks for the patch. This is mostly LGTM modulo a few nits. My one question is regarding documentation. Do you think this needs to be described in the clang-tools-extra/doc/clang-doc.rst? And are there any changes in workflow or tool usage that we should document? I

[PATCH] D133979: [clangd] XRef functions treat visible class definitions as primary.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis updated this revision to Diff 460507. Maetveis retitled this revision from "[Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs" to "[Clang] Change -ftime-trace storing path and support multiple compilation jobs". Maetveis added a comment. Remove inline

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3792518 , @aaron.ballman wrote: > I'm wondering what the goal is for these changes. ... Are you intending to > add semantics for these attributes in follow-up patches? To be honest, I wasn't planning to do any of

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans added a comment. Could the new flag be marked as an Alias in the tablegen, so that we don't need to do any code changes for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I think we had no expectation that DXC-mode would be supported by the tooling APIs at this point. For context, DXC is the HLSL compiler that is based on clang-3.7. The DXC mode provides interface compatibility with it. DXC doesn't work with any of the clang tooling

[clang] 9ada3d5 - Fix error in clang /MT equivalent flag patch.

Author: Amy Huang Date: 2022-09-15T20:24:51Z New Revision: 9ada3d5a137f5edba7a599ca83e488c76681bbf9 URL: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9 DIFF: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9.diff LOG:

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/include/clang/Driver/Options.td: dll version.}]>; +def fms_omit_default_lib_name : Joined<["-"], "fms-omit-default-lib-name">, + Group, Flags<[NoXarchOption, CoreOption]>, Initially, I'm not entirely sure

[PATCH] D133968: [clangd] Enable standard library index by default.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D133807: Update Unicode to 15.0

tahonermann added a comment. > I considered it, and I can add a few if you insist but... I'm not sure adding > random tests tell us much except that the specific tested characters are > supported. I wouldn't expect to learn anything from doing so; it would just provide regression protection

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please add a release note for the fix when you land the changes. Comment at: clang/test/SemaCXX/remove-nested-immediate-invocation-crash.cpp:4 + +a,

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a comment. BTW, I am not sure when the new DXC driver mode was introduced but ATM it isn't properly handled by clang-tooling APIs, especially clangd. As the logic there wasn't updated accordingly, and it also resulted in regressions for clang-cl mode. I've sent out

[clang] 49832b7 - Stop trying to fixup 'overloadable' prototypeless functions.

Author: Erich Keane Date: 2022-09-15T12:10:54-07:00 New Revision: 49832b7a928d4971417d8dba9aba932d62e447e3 URL: https://github.com/llvm/llvm-project/commit/49832b7a928d4971417d8dba9aba932d62e447e3 DIFF: https://github.com/llvm/llvm-project/commit/49832b7a928d4971417d8dba9aba932d62e447e3.diff

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat marked 2 inline comments as done. azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:7 +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=PLUGIN_GARANGE %s +// GARANGE:

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat updated this revision to Diff 460475. azat added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133875/new/ https://reviews.llvm.org/D133875 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D133887: [Clang] Support label at end of compound statement

aaron.ballman added a comment. In D133887#3790414 , @cor3ntin wrote: > Thanks for doing that work. > > Given that this paper was touted as a C compatibility feature, I think we > should implement the C feature at the same time >

[PATCH] D133956: git push Cuda Check for ignored errors after calling a CUDA kernel

tra added a comment. > Our linter cannot easily check whether the error was reset It can not in principle. Many CUDA errors are 'sticky' and can only be cleared by resetting the GPU or exiting the application and the former is virtually never used beyond toy examples (resetting a GPU would

[PATCH] D133962: [clang(d)] Include/Exclude CLDXC options properly

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This handles

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:15 +// RUN: %clang -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s -o - | llvm-dwarfdump --debug-aranges - | FileCheck -check-prefix=ARANGES %s +// ARANGES: Address Range

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460470. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D133920: [X86][fastcall] Move capability check before free register update

rnk added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1781 + + return (Ty->isIntegralOrEnumerationType() || Ty->isPointerType() || + Ty->isReferenceType()); I think we could improve readability here with some named variable

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. yusuke-kadowaki wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

logankaser added a comment. Is there anything I can do as a random member of the public that wants this and knows C++? My organization is trying to move to clangd for the default config, and the lack of docstring parsing is common feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: I have a couple of concerns with this interface:

[PATCH] D133924: add clang_CXXMethod_isDeleted function

aaron.ballman added a comment. Thanks for this! Can you add a release note to clang/docs/ReleaseNotes.rst and some test coverage for the change to clang/test/Index for the change? Also, it looks like precommit CI found a relevant failure that needs to be fixed: TEST

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang created this revision. akhuang added reviewers: mstorsjo, hans. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The /Zl flag omits default C runtime library name from obj files. This

  1   2   3   >