[PATCH] D133634: [clang] Allow vector of BitInt

craig.topper added a comment. In D133634#3795044 , @erichkeane wrote: > The CFE Changes look correct, but @eli.friedman/@craig.topper should comment > as to whether this is acceptable. This is acceptable to me. Comment at:

[PATCH] D134103: [clang-format] Skip token annotation in passes that don't need it

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D134077: [RISCV] Support -mno-implicit-float.

rui.zhang accepted this revision. rui.zhang added a comment. This revision is now accepted and ready to land. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134077/new/ https://reviews.llvm.org/D134077

[PATCH] D133634: [clang] Allow vector of BitInt

python3kgae updated this revision to Diff 460958. python3kgae added a comment. Allow BitInt vector for Microsoftmangle and add codeGen tests for BitInt vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133634/new/

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added inline comments. Comment at: flang/runtime/environment.cpp:77 +#else + envp = environ; +#endif jpenix-quic wrote: > peixin wrote: > > What is `environ` used for? Should we try to keep as less extern variable > > as possible in runtime for

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel updated this revision to Diff 460947. rymiel added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

mizvekov added a comment. Oh by the way, it's missing the Release notes, but otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik added a comment. ping, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose missing // 'template' keywords within SS

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG52dce8900c46: [clang] Fix AST representation of expanded template arguments. (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D128113?vs=460907=460941#toc Repository: rG

[clang] 52dce89 - [clang] Fix AST representation of expanded template arguments.

Author: Matheus Izvekov Date: 2022-09-17T01:24:46+02:00 New Revision: 52dce8900c46d5842a021619537ede598983dfde URL: https://github.com/llvm/llvm-project/commit/52dce8900c46d5842a021619537ede598983dfde DIFF:

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. The reverse indexing worked great for that problem, the patch has no perf impact now on that `reproduction.cpp`. That doesn't mean it doesn't have any impact in general, or that it can't be further improved, but other solutions will take more time to develop and we

[PATCH] D134055: [clang-doc] Export enum type and value information.

paulkirth added a comment. I think maybe you made the title the first line of the summary instead of the other way around. I was looking for this as the title: `[clang-doc] Add support for explicitly typed enums` Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:71

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468 + // Control constants for math operations. + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); jhuber6

[PATCH] D133930: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel`.

wyt updated this revision to Diff 460928. wyt added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Update UncheckedOptionalAccessCheck.cpp. Remove deprecated `runDataflowAnalysis`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

craig.topper created this revision. craig.topper added reviewers: efriedma, reames. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As far as I understand,

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3779997 , @aaron.ballman wrote: > Please be sure to add a release note for the changes! Any opinion as to what the release note might say? I'm asking since we dropped the documentation changes. Perhaps I

[PATCH] D134081: [clang][dataflow] Remove deprecated overloads of `checkDataflow` in `TestingSupport.h`.

wyt created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D134081

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 460910. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 460909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 460908. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460907. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille updated this revision to Diff 460899. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Address minor nits, plus add a test case that showcases the extra (legitimate!) warning we now get when accessing a "struct hack" field with an index

[PATCH] D134077: [RISCV] Support -mno-implicit-float.

craig.topper created this revision. craig.topper added reviewers: asb, reames, compnerd, rui.zhang. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook,

[PATCH] D134067: [HLSL] Enable availability attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10378c45055f: [HLSL] Enable availability attribute (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 10378c4 - [HLSL] Enable availability attribute

Author: Chris Bieneman Date: 2022-09-16T16:04:27-05:00 New Revision: 10378c45055fabe291138a93d79f287586948e91 URL: https://github.com/llvm/llvm-project/commit/10378c45055fabe291138a93d79f287586948e91 DIFF:

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 460890. mitchell-stellar added a comment. Added context and use verifyFormat(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > do you need to do all of this? APSInt

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw updated this revision to Diff 460882. brettw marked 2 inline comments as done. brettw retitled this revision from "[clang-doc] Export more enum information" to "[clang-doc] Export enum type and value information.". brettw edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D134067: [HLSL] Enable availability attribute

erichkeane added a comment. Still looks good to me, no nits. As far as using the bookmarks, I tend to use them for things that are 'far away' instead of 'right here', and stick to the @+/@- bits for 'local' ones. Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:13

[PATCH] D134067: [HLSL] Enable availability attribute

beanz updated this revision to Diff 460879. beanz added a comment. Updating test cases to use labels and sort the matches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134067/new/ https://reviews.llvm.org/D134067 Files:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:2615 + if (Current->isOneOf(tok::period, tok::arrow) && +

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added inline comments. Comment at: clang/docs/UsersManual.rst:878 Another way to specify a configuration file is to encode it in executable name. For example, if the Clang executable is named `armv7l-clang` (it may be a +symbolic link to `clang`), then Clang will search

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny updated this revision to Diff 460877. mgorny retitled this revision from "[clang][Driver] Default to loading clang.cfg if config file not specified" to "[clang] [Driver] Fall back to default.cfg when calling clang w/o prefix". mgorny edited the summary of this revision. mgorny added a

[PATCH] D134067: [HLSL] Enable availability attribute

beanz added inline comments. Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:15 +void fn() { +// expected-warning@+2 {{'fn6_0' is only available on HLSL ShaderModel 6.0 or newer}} +// expected-note@+1 {{enclose 'fn6_0' in a __builtin_available check to silence

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks added a comment. Please reupload the diff with the context. Comment at: clang/unittests/Format/FormatTest.cpp:5785 + "}"; +EXPECT_EQ(Expected, format(ToFormat, Style)); +EXPECT_EQ(Expected, format(Expected, Style));

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

MaskRay added a subscriber: joerg. MaskRay added a comment. Thanks for taking over the patch! I've CCed (in https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606/33) some folks who had strong opinions in the initial support patch. (Cc @joerg manually whom

[PATCH] D134063: [clang] Make --ld-path= work with -fuse-ld=lld

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134063/new/ https://reviews.llvm.org/D134063 ___ cfe-commits mailing list

[PATCH] D134067: [HLSL] Enable availability attribute

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Besides the request for re-organizing the the test files, LGTM. Comment at: clang/test/SemaHLSL/AvailabilityMarkup.hlsl:15 +void fn() { +// expected-warning@+2

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin added a comment. Thanks for your suggestion @aaron.ballman , also I have added a new test case for C++ polymorphism classes Comment at: clang/test/Sema/builtin-redecl.cpp:5-6 +#include + // Redeclaring library builtins is OK. aaron.ballman wrote:

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin updated this revision to Diff 460870. yronglin added a comment. Add test case for C++ polymorphism class Use `typedef __typeof__(sizeof(0)) size_t;` instead of `#include ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/new/

[PATCH] D134067: [HLSL] Enable availability attribute

beanz updated this revision to Diff 460869. beanz added a comment. Updating based on feedback from @erichkeane. Thank you for the fast feedback! - Moved ShaderModel check into a switch case. - Added additional self-contained test case with more variations. Repository: rG LLVM Github Monorepo

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:878 Another way to specify a configuration file is to encode it in executable name. For example, if the Clang executable is named `armv7l-clang` (it may be a +symbolic link to `clang`), then Clang will

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands added a comment. Yes it's probably safest if someone commits on my behalf, unless someone's got time to walk me through it. Just use Anders Langlands anderslanga...@gmail.com for attribution please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460865. anderslanglands added a comment. Adding missing backtick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 Files:

[PATCH] D134067: [HLSL] Enable availability attribute

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaAvailability.cpp:198 +return Triple.getVendor() == llvm::Triple::Apple || + Triple.getOS() == llvm::Triple::ShaderModel; } This should jsut be a 'case' label added above, we are

[PATCH] D134067: [HLSL] Enable availability attribute

beanz created this revision. beanz added reviewers: MaskRay, erichkeane, rnk, arphaman, python3kgae, pow2clk, tex3d. Herald added a reviewer: aaron.ballman. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a

[clang] c0bc461 - [Clang] Give error message for invalid profile path when compiling IR

Author: Aiden Grossman Date: 2022-09-16T19:45:57Z New Revision: c0bc461999fdac918dd26867947c24eb6235c8d0 URL: https://github.com/llvm/llvm-project/commit/c0bc461999fdac918dd26867947c24eb6235c8d0 DIFF: https://github.com/llvm/llvm-project/commit/c0bc461999fdac918dd26867947c24eb6235c8d0.diff

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0bc461999fd: [Clang] Give error message for invalid profile path when compiling IR (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8a868d8 - Revert "Revert "[clang, llvm] Add __declspec(safebuffers), support it in CodeView""

Author: David Majnemer Date: 2022-09-16T19:39:48Z New Revision: 8a868d8859f9da23ee051848863045208c17ab47 URL: https://github.com/llvm/llvm-project/commit/8a868d8859f9da23ee051848863045208c17ab47 DIFF: https://github.com/llvm/llvm-project/commit/8a868d8859f9da23ee051848863045208c17ab47.diff

[PATCH] D134055: [clang-doc] Export more enum information

paulkirth added a comment. Can you make the first line of the summary the commit title? It's a bit more descriptive. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

thakis added a comment. > Yes, specify both options. -fuse-ld= specifies the flavor while --ld-path= > specifies a path the Clang Driver does not want to detect. Thanks, made D134063 for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134063: [clang] Make --ld-path= work with -fuse-ld=lld

thakis created this revision. thakis added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. thakis requested review of this revision. This allows using --ld-path= to set a custom linker path, while still informing clang that the binary at that path is an

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:316 + // Base above gives us a pointer on the stack. + const auto *FD = dyn_cast(Member); + assert(FD); erichkeane wrote: > I THINK Member is a ValueDecl because it could be a

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:50 explicit operator unsigned() const { return V; } + explicit operator int8_t() const { return V; } tbaeder wrote: > aaron.ballman wrote: > > At some point, do we want to rename

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:861 + +return this->emitConst(T, getIntWidth(ECD->getType()), ECD->getInitVal(), + E); shafik wrote: > If I check out

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:50 explicit operator unsigned() const { return V; } + explicit operator int8_t() const { return V; } aaron.ballman wrote: > At some point, do we want to rename this (and int) to use

[PATCH] D134034: [test] Use host platform specific error message substitution

This revision was automatically updated to reflect the committed changes. Closed by commit rGce193431141d: [test] Use host platform specific error message substitution (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ce19343 - [test] Use host platform specific error message substitution

Author: Abhina Sreeskantharajan Date: 2022-09-16T15:13:45-04:00 New Revision: ce193431141d8f16d6b511a9114879105b0739e1 URL: https://github.com/llvm/llvm-project/commit/ce193431141d8f16d6b511a9114879105b0739e1 DIFF:

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

tahonermann added inline comments. Comment at: clang/test/CodeGenHLSL/float3.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - %s | FileCheck %s + Does this need to use driver mode? That is odd for a code gen test. Repository: rG LLVM Github

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic marked 2 inline comments as done. jpenix-quic added inline comments. Comment at: flang/runtime/environment.cpp:77 +#else + envp = environ; +#endif peixin wrote: > What is `environ` used for? Should we try to keep as less extern variable as >

[PATCH] D134020: [clang][Interp] Handle enums

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:861 + +return this->emitConst(T, getIntWidth(ECD->getType()), ECD->getInitVal(), + E); If I check out `IntExprEvaluator::CheckReferenceDecl(...)` it

[PATCH] D134034: [test] Use host platform specific error message substitution

abhina.sreeskantharajan updated this revision to Diff 460828. abhina.sreeskantharajan added a comment. Move subsitution outside regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134034/new/ https://reviews.llvm.org/D134034 Files:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante updated this revision to Diff 460827. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133249/new/ https://reviews.llvm.org/D133249 Files:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 24 inline comments as done. Mordante added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of +

[clang] a4f8e3d - Revert "[clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel`."

Author: Wei Yi Tee Date: 2022-09-16T18:07:35Z New Revision: a4f8e3d24087356ba75eb6f3bd4e1af436c83270 URL: https://github.com/llvm/llvm-project/commit/a4f8e3d24087356ba75eb6f3bd4e1af436c83270 DIFF: https://github.com/llvm/llvm-project/commit/a4f8e3d24087356ba75eb6f3bd4e1af436c83270.diff LOG:

[clang] 41f235d - [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel`.

Author: Wei Yi Tee Date: 2022-09-16T17:54:12Z New Revision: 41f235d26887946f472d71a8417507c35d5f9074 URL: https://github.com/llvm/llvm-project/commit/41f235d26887946f472d71a8417507c35d5f9074 DIFF: https://github.com/llvm/llvm-project/commit/41f235d26887946f472d71a8417507c35d5f9074.diff LOG:

[PATCH] D133930: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41f235d26887: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const… (authored by wyt). Repository: rG LLVM Github

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468 + // Control constants for math operations. + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); yaxunl

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. Any updates from the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134057: [clang][Interp] Start implementing record types

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:316 + // Base above gives us a pointer on the stack. + const auto *FD = dyn_cast(Member); + assert(FD); I THINK Member is a ValueDecl because it could be a member function,

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

This revision was automatically updated to reflect the committed changes. Closed by commit rG587729c3ad78: [clang] [Driver] Add an option to disable default config filenames (authored by mgorny). Herald added a project: clang. Changed prior to commit:

[clang] 587729c - [clang] [Driver] Add an option to disable default config filenames

Author: Michał Górny Date: 2022-09-16T19:38:11+02:00 New Revision: 587729c3ad78aec6ec5a295331b16f21e340feb1 URL: https://github.com/llvm/llvm-project/commit/587729c3ad78aec6ec5a295331b16f21e340feb1 DIFF: https://github.com/llvm/llvm-project/commit/587729c3ad78aec6ec5a295331b16f21e340feb1.diff

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Program.h:48 +// here manually so they are properly freeing their resources. +for (auto It : Records) +

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Program.h:48 +// here manually so they are properly freeing their resources. +for (auto It : Records) + It.second->~Record(); erichkeane wrote: > I SUSPECT that by a reading of our

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 460819. jpenix-quic added a comment. Remove unneeded braces and unnecessary changes to NameUniquer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 Files: clang/include/clang/Driver/Options.td

[PATCH] D134057: [clang][Interp] Start implementing record types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a humble beginning of course.

[PATCH] D133732: [clang-doc] Support default args for functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe191086bfcb7: [clang-doc] Support default args for functions. (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e191086 - [clang-doc] Support default args for functions.

Author: Brett Wilson Date: 2022-09-16T17:26:07Z New Revision: e191086bfcb72a98a9e299fd30dd3f69c5de5b64 URL: https://github.com/llvm/llvm-project/commit/e191086bfcb72a98a9e299fd30dd3f69c5de5b64 DIFF: https://github.com/llvm/llvm-project/commit/e191086bfcb72a98a9e299fd30dd3f69c5de5b64.diff LOG:

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

phosek added a comment. I agree with @tianshilei1992, I think we should avoid introducing new `CMAKE_` variables to avoid confusion. The same applies to module names, for example I don't think we should be introducing `GNUBinaryDirs` which can be easily confused for `GNUInstallDirs`. I would

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

mgorny planned changes to this revision. mgorny added a reviewer: MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. So far my plan is to go for `default-{ModeSuffix}.cfg` instead (e.g. `default-clang.cfg`, `default-clang++.cfg`, etc.). If I'm not mistaken, this will

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

mgorny commandeered this revision. mgorny added a reviewer: asymptotically. mgorny added a comment. After discussing privately with @asymptotically, I'm going to try to finish this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

erichkeane added a comment. Other than the pedantry above, LGTM. Comment at: clang/lib/AST/Interp/Program.h:48 +// here manually so they are properly freeing their resources. +for (auto It : Records) + It.second->~Record(); I SUSPECT that by a

[PATCH] D134055: [clang-doc] Export more enum information

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Add support for explicitly typed enums: enum Foo : unsigned { ... }; to

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468 + // Control constants for math operations. + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); jhuber6

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468-9472 + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); + AddGlobal("__oclc_finite_only_opt", FiniteOnly || RelaxedMath,

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468 + // Control constants for math operations. + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); yaxunl wrote:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9468-9472 + AddGlobal("__oclc_wavefrontsize64", Wavefront64, /*Size=*/8); + AddGlobal("__oclc_daz_opt", DenormAreZero, /*Size=*/8); + AddGlobal("__oclc_finite_only_opt", FiniteOnly || RelaxedMath,

[PATCH] D134054: [clang][Interp] Properly destruct allocated Records

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed with @aaron.ballman on IRC. This

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 460812. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel updated this revision to Diff 460810. rymiel added a comment. Also test the annotated value of the arrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049 Files:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:448 + EXPECT_EQ(Tokens[11]->FakeLParens.size(), 0u); + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); + MyDeveloperDay wrote: > should you not check that

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e637fcb2550: [clang][deps] Make sure ScanInstance outlives collector (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/

[clang] 4e637fc - [clang][deps] Make sure ScanInstance outlives collector

Author: Jan Svoboda Date: 2022-09-16T09:44:12-07:00 New Revision: 4e637fcb25503cc9b3bb9af54453ac2ebc7299b1 URL: https://github.com/llvm/llvm-project/commit/4e637fcb25503cc9b3bb9af54453ac2ebc7299b1 DIFF: https://github.com/llvm/llvm-project/commit/4e637fcb25503cc9b3bb9af54453ac2ebc7299b1.diff

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:448 + EXPECT_EQ(Tokens[11]->FakeLParens.size(), 0u); + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); + should you not check that Tokens[21] is a

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGe456d2ba8bca: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e456d2b - [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Author: Michael Buch Date: 2022-09-16T12:38:50-04:00 New Revision: e456d2ba8bcadaa63386b339a4f2abcb39505502 URL: https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502 DIFF: https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502.diff

[PATCH] D133931: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `clang/Analysis/FlowSensitive`.

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp:137-140 +auto CS = E->getAs(); +if (!CS) + return; +auto S = CS->getStmt(); martong wrote: > This is exactly the same code that

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9449-9450 + !(Features & llvm::AMDGPU::FEATURE_WAVE32) || + llvm::is_contained(CGM.getTarget().getTargetOpts().FeaturesAsWritten, +

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I understand your frustration with the regression, but let’s try to constructive. We all care about quality and we’re all working hard to do the best we can. In D128462#3794868 , @kadircet wrote: > My main complaint here's

  1   2   3   >