[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands added a comment. I ended up modifying c-index-test to print out the template arguments in the same way it does for FunctionDecl, which ends up working all cases in the existing test suite. The only other thing I added was a specific case in index-templates.cpp to check whether

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands updated this revision to Diff 462392. anderslanglands marked 7 inline comments as done. anderslanglands added a comment. Add testing, address style notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134416/new/

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. The regression and test-suite pass using a bootstrap build. I'll provide performance data tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

serge-sans-paille added a comment. Shouldn't this be a situation where `-Wmisexpect` shold / could trigger? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rtrieu added inline comments. Comment at: clang/include/clang/AST/Type.h:3947 + Info) { +FunctionTypeBits.FastTypeQuals = 0; + } rmaz wrote: > aaron.ballman wrote: > > It seems a bit odd to me that we only want to initialize one member

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1958 + // constraints while the official register name is prefixed with a '$'. + // So we manually select general purpose registers here. + // For now, no need to support ABI

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining updated this revision to Diff 462388. SixWeining added a comment. Address @rengolin's comments. 1. Clip the '$' from original constraint string and match table-gen'd names. 2. Delete unnecessary check prefix in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5d12e9a - [Clang][NFC] Make unused flag `-fopenmp-new-driver` help hidden

Author: Joseph Huber Date: 2022-09-22T21:34:33-05:00 New Revision: 5d12e9a5717c738522cd5ec98f098fbf4ce1aec2 URL: https://github.com/llvm/llvm-project/commit/5d12e9a5717c738522cd5ec98f098fbf4ce1aec2 DIFF: https://github.com/llvm/llvm-project/commit/5d12e9a5717c738522cd5ec98f098fbf4ce1aec2.diff

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

eopXD created this revision. eopXD added reviewers: nlopes, khchen, craig.topper. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 462376. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2907-2908 +// which are not object files. Files with extension ".lib" is classified +// as TY_Object but they are actually archives, therefore should

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} MaskRay wrote: > You may use BLAKE3 instead of

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} You may use BLAKE3 instead of MD5. BLAKE3 is

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a comment. Anytime there's a Clang ABI version check, I have to wonder whether PS4/PS5 need an exception. (And I'm sorry I missed the earlier patches in this series.) We are pretty much locked to however things worked for Clang 3.2. Is this specific to C++20 (or later)? In

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. Address comments in https://reviews.llvm.org/D128745/new/#3809692. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134507/new/ https://reviews.llvm.org/D134507 ___ cfe-commits

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10409bf86e58: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless (authored by eopXD). Repository: rG LLVM Github Monorepo

[clang] 10409bf - [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

Author: eopXD Date: 2022-09-22T18:13:16-07:00 New Revision: 10409bf86e58320443db5c5ea2adf5e437104ee9 URL: https://github.com/llvm/llvm-project/commit/10409bf86e58320443db5c5ea2adf5e437104ee9 DIFF: https://github.com/llvm/llvm-project/commit/10409bf86e58320443db5c5ea2adf5e437104ee9.diff LOG:

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the same spirit of da6187f566b7881cb

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added a comment. In D125418#3806720 , @efriedma wrote: >> Sometimes we will emit the alias here but later the function will be inlined >> or eliminated by DCE. > > If the alias is externally visible, it can't be eliminated; the compiler > can't

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3283f71069a0: Add clang flag equivalent to clang-cl /Zl flag (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/

[clang] 3283f71 - Add clang flag equivalent to clang-cl /Zl flag

Author: Amy Huang Date: 2022-09-22T23:08:52Z New Revision: 3283f71069a0d91593c81a610a710979fb655d7f URL: https://github.com/llvm/llvm-project/commit/3283f71069a0d91593c81a610a710979fb655d7f DIFF: https://github.com/llvm/llvm-project/commit/3283f71069a0d91593c81a610a710979fb655d7f.diff LOG:

[clang] 794b7ea - Revert "[MemProf] Memprof profile matching and annotation"

Author: Teresa Johnson Date: 2022-09-22T16:08:03-07:00 New Revision: 794b7ea960ccc3222f2af582efadbc5e5c464292 URL: https://github.com/llvm/llvm-project/commit/794b7ea960ccc3222f2af582efadbc5e5c464292 DIFF:

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

rjmccall added a comment. Having some sort of reliable marker here emitted after the call is currently a correctness condition for using the ObjC ARC autorelease optimization. Apple's x86_64 ObjC runtime is constrained by ABI limitations, so we sniff for a particular, fairly reasonable code

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth accepted this revision. paulkirth added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { brettw wrote: >

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. that was fixed and I've relanded the patch hopefully there aren't any more CGSCC issues this uncovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad2e6c830de: [HLSL] clang codeGen for HLSLNumThreadsAttr (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/

[clang] bad2e6c - [HLSL] clang codeGen for HLSLNumThreadsAttr

Author: Xiang Li Date: 2022-09-22T15:30:52-07:00 New Revision: bad2e6c830de8c6ddc72f7ba3ace068fb62448ff URL: https://github.com/llvm/llvm-project/commit/bad2e6c830de8c6ddc72f7ba3ace068fb62448ff DIFF: https://github.com/llvm/llvm-project/commit/bad2e6c830de8c6ddc72f7ba3ace068fb62448ff.diff

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked 4 inline comments as done. ayzhao added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5592 +bool Parser::isConstructorDeclarator(bool IsUnqualified, bool DeductionGuide, + bool IsFriend) { TentativeParsingAction

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { paulkirth wrote: > nit: can we avoid unrelated changes to whitespace here and elsewhere in the > patch?

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462317. ayzhao added a comment. fix spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462315. ayzhao added a comment. Add FriendSpecified enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 462313. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added a comment. In D133983#3808302 , @aaron.ballman wrote: > In D133983#3807284 , @python3kgae > wrote: > >> In D133983#3805761 , >> @aaron.ballman wrote:

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

STL_MSFT added a comment. A couple of notes/reminders that may help you make a decision here (I have no particular opinion as this doesn't impact how VS and microsoft/STL use Clang): 1. VS 2013's support lifecycle, documented at

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462311. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

hans added a comment. > If we're all using `clang` for the command, we'd all get the same behavior, > right? There's no expectation that `clang` and `cl` behave the same way, > that's what `clang-cl` is for. I guess I don't see why we care about how MSVC > behaves unless passing

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462308. python3kgae marked 8 inline comments as done. python3kgae added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files:

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

hans added a comment. I'm conflicted about this. I see where you're coming from, but I could imagine people using clang-cl with old VS versions e.g. to target old Windows. I agree we shouldn't go out of our way to support that, but do we think it's too much effort to keep the functionality we

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

beanz updated this revision to Diff 462299. beanz added a comment. Updating documentation for `hlsl.uavs`, thanks @python3kgae! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134304/new/ https://reviews.llvm.org/D134304 Files:

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Matt added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1112 + FeatureNEON, FeatureSVE2BitPerm, FeatureFP16FML, + FeatureMTE, FeatureRandGen]; list Saphira= [HasV8_4aOps,

[PATCH] D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'

RIscRIpt planned changes to this revision. RIscRIpt added a comment. TODO: add proper ABI tests of `[[msvc::no_unique_address]]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134458/new/ https://reviews.llvm.org/D134458

[PATCH] D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'

RIscRIpt updated this revision to Diff 462297. RIscRIpt retitled this revision from "[AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'" to "[AST] Add C++11 attribute 'msvc::no_unique_address'". RIscRIpt added a comment. Add naive implementation ABI of [[msvc::no_unique_address]]

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 ___

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

rnk added a subscriber: aaron.ballman. rnk added a comment. There are a lot more hits for `isCompatibleWithMSVC` used with 2015 across the codebase. Do you want to handle them in a follow up? That's fine with me. I would like to get a second opinion before doing this. +@aaron.ballman

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. In D134456#3809581 , @aaron.ballman wrote: > I'm on the fence about this... the attributes were added as optimization > hints, but for somewhat interesting use cases. The obvious one of "I think > this path is

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth added a comment. Can we also add support for some of these changes to the other backends? I'm fine w/ us delaying that a bit, and tackling those in separate patches, but we shouldn't let one backend get wildly ahead of the others. Comment at:

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay updated this revision to Diff 462292. MaskRay retitled this revision from "[Driver] Drop MSVC<2015 tweaking" to "[Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19". MaskRay edited the summary of this revision. MaskRay added a comment. . Repository: rG

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 462289. python3kgae marked 2 inline comments as done. python3kgae edited the summary of this revision. python3kgae added a comment. Create issue for FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

manojgupta created this revision. manojgupta added reviewers: MaskRay, barannikov88, abidh. Herald added subscribers: StephenFan, ki.stfu. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently

[PATCH] D132379: [Support] Class for response file expansion

rnk added a comment. This makes sense to me. This probably affects nobody, but this reminds me of my first LLVM change: https://github.com/llvm/llvm-project/commit/fc8a2d5a8390952029e1c47a623e046b744f44d4 Comment at: llvm/include/llvm/Support/CommandLine.h:2098 +public: +

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e25284dbc94: [AMDGPU] Emit module flag for all code object versions (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM

[clang] 5e25284 - [AMDGPU] Emit module flag for all code object versions

Author: Yaxun (Sam) Liu Date: 2022-09-22T16:51:33-04:00 New Revision: 5e25284dbc947781fcd3f2230bea14c48f43ec50 URL: https://github.com/llvm/llvm-project/commit/5e25284dbc947781fcd3f2230bea14c48f43ec50 DIFF:

[PATCH] D134458: [AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'

RIscRIpt added a comment. In D134458#3809570 , @aaron.ballman wrote: > Can you split this out into two separate reviews? Sure, done: https://reviews.llvm.org/D134475 Comment at: clang/include/clang/Basic/Attr.td:3497 + +def

[PATCH] D134475: [AST] Add C++11 attribute msvc::constexpr

RIscRIpt created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added a comment. This is looking great. Thank you for all your work iterating on this. Please update the description to reflect the changes in implementation. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:120 + +void addResourceBinding(GlobalVariable *GV,

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw updated this revision to Diff 462281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 462280. python3kgae marked 8 inline comments as done. python3kgae added a comment. Code cleanup to match comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:815 // Prefer the PGO based weights over the likelihood attribute. // When the build isn't optimized the metadata isn't used, so don't generate I lean towards implementing the intended

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

efriedma added a comment. How much code does this break? How much does this help performance? (My instinct here is that the tradeoff is not worth it, but I'm willing to be convinced otherwise.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134468: [Driver] Drop MSVC<2015 tweaking

rnk added a comment. I don't see the MSVC build requirement as being related to the version of MSVC that clang-cl supports targeting. Those can be separate. That said, this might be the right time to sunset this compatibility logic. If we do this, I'd like it to be a policy change. We should

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

paulkirth added a comment. @brettw Thanks for the clarification. While I'm more familiar w/ these set of patches, I have to say that that I was also unsure/surprised by some of these changes. If you have concrete plans for cleanups letting us know about those plans in the initial review will

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz updated this revision to Diff 462275. rmaz added a comment. add -std=c89 to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 Files: clang/include/clang/AST/Type.h

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz added inline comments. Comment at: clang/include/clang/AST/Type.h:3947 + Info) { +FunctionTypeBits.FastTypeQuals = 0; + } aaron.ballman wrote: > It seems a bit odd to me that we only want to initialize one member of the > bits and

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

tahonermann added a comment. This change appears to be responsible for the following test case now being rejected. That seems right and is consistent with the intent, but use of `-fclang-abi-compat=14` doesn't seem to restore the prior behavior. https://godbolt.org/z/ad1TPjTza struct map

[PATCH] D134458: [AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'

RIscRIpt updated this revision to Diff 462274. RIscRIpt retitled this revision from "[AST] Add msvc-specific C++11 attributes" to "[AST] Add msvc-specific C++11 attribute 'msvc::no_unique_address'". RIscRIpt added a comment. Remove msvc::constexpr commit Repository: rG LLVM Github Monorepo

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134407/new/ https://reviews.llvm.org/D134407 ___ cfe-commits mailing list

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt abandoned this revision. RIscRIpt added a comment. Closing in favor of https://reviews.llvm.org/D134458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133853/new/ https://reviews.llvm.org/D133853

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz added a comment. In D133586#3809475 , @aaron.ballman wrote: > This is why I'm wondering how we're hitting this problem in the first place. > C++ shouldn't be able to create a function without a prototype so why does > the ODR hash matter (do we

[clang] 52708be - [RISCV] Remove support for the unratified Zbe, Zbf, and Zbm extensions.

Author: Craig Topper Date: 2022-09-22T13:04:41-07:00 New Revision: 52708be182e57dbe98972815ca807dc762dced12 URL: https://github.com/llvm/llvm-project/commit/52708be182e57dbe98972815ca807dc762dced12 DIFF: https://github.com/llvm/llvm-project/commit/52708be182e57dbe98972815ca807dc762dced12.diff

[PATCH] D134248: [clang][modules][deps] Preserve module map load order

This revision was automatically updated to reflect the committed changes. Closed by commit rG20fa87c7e87f: [clang][modules][deps] Preserve module map load order (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D134248?vs=461433=462271#toc Repository: rG LLVM

[clang] 20fa87c - [clang][modules][deps] Preserve module map load order

Author: Jan Svoboda Date: 2022-09-22T12:54:51-07:00 New Revision: 20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1 URL: https://github.com/llvm/llvm-project/commit/20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1 DIFF: https://github.com/llvm/llvm-project/commit/20fa87c7e87fcb2fca403c7a73f8acc7e4dd5fa1.diff

[clang] a212d8d - [MemProf] Memprof profile matching and annotation

Author: Teresa Johnson Date: 2022-09-22T12:48:31-07:00 New Revision: a212d8da94d08e229aa8d65283e4b116310bba10 URL: https://github.com/llvm/llvm-project/commit/a212d8da94d08e229aa8d65283e4b116310bba10 DIFF:

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa212d8da94d0: [MemProf] Memprof profile matching and annotation (authored by tejohnson). Changed prior to commit:

[PATCH] D115169: Create a generic ABI document for _BitInt

aaron.ballman added a comment. In D115169#3808463 , @gustedt wrote: >>> Also discussing consequences for `va_arg` functions such as `printf` would >>> be nice. >> >> Does the information in the `Passing and Returning an Object` section >> suffice, or

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl added a comment. In D134355#3809471 , @b-sumner wrote: > In D134355#3809294 , @yaxunl wrote: > >> In D134355#3807435 , @cfang wrote: >> >>> LGTM >>> >>> Should the

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf35230ae0a69: [clang][modules][deps] Report modulemaps describing excluded headers (authored by jansvoboda11). Changed prior to commit:

[clang] f35230a - [clang][modules][deps] Report modulemaps describing excluded headers

Author: Jan Svoboda Date: 2022-09-22T12:36:05-07:00 New Revision: f35230ae0a69bbdd74a4faa3ae0b69a46796dc12 URL: https://github.com/llvm/llvm-project/commit/f35230ae0a69bbdd74a4faa3ae0b69a46796dc12 DIFF: https://github.com/llvm/llvm-project/commit/f35230ae0a69bbdd74a4faa3ae0b69a46796dc12.diff

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 ___ cfe-commits mailing list

[PATCH] D134468: [Driver] Drop MSVC<2015 tweaking

MaskRay created this revision. MaskRay added reviewers: aganea, hans, rnk, STL_MSFT, zequanwu. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. I'm on the fence about this... the attributes were added as optimization hints, but for somewhat interesting use cases. The obvious one of "I think this path is likely/unlikely and so I'll help the compiler figure it out" was one such use case, but honestly

[PATCH] D134458: [AST] Add msvc-specific C++11 attributes

aaron.ballman added a comment. Can you split this out into two separate reviews? That makes it easier for the reviewers so we don't mix up context as well as when we do code archeology for changes. (I also made some quick comments as I noticed things in the file, but I've not done a full

[clang] 0b12efc - [clang][dataflow] Add support for nested method calls.

Author: Yitzhak Mandelbaum Date: 2022-09-22T19:16:31Z New Revision: 0b12efc7a42c187400f7df18d5fd629d92d2747e URL: https://github.com/llvm/llvm-project/commit/0b12efc7a42c187400f7df18d5fd629d92d2747e DIFF: https://github.com/llvm/llvm-project/commit/0b12efc7a42c187400f7df18d5fd629d92d2747e.diff

[PATCH] D134432: [clang][dataflow] Add support for nested method calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b12efc7a42c: [clang][dataflow] Add support for nested method calls. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134432/new/

[PATCH] D133705: [HIP] Fix unbundling archive

tra added a comment. It's still not quite clear to me what the patch is intended to do. The description describes the existing issues (we don't unbundle some libraries), but is not clear what we do want to have in the end. Are all library arguments expected to be unbundled? If we do not want

[PATCH] D134432: [clang][dataflow] Add support for nested method calls.

ymandel updated this revision to Diff 462263. ymandel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134432/new/ https://reviews.llvm.org/D134432 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

jcranmer-intel accepted this revision. jcranmer-intel added a comment. This revision is now accepted and ready to land. This looks fine to me, but as clang is not normally my wheelhouse, I'd still prefer to see someone else approve this as well. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. If you have more questions, I can schedule a meeting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned

[clang] 9dc0b16 - [clang][deps] Report module map describing compiled module

Author: Jan Svoboda Date: 2022-09-22T12:06:02-07:00 New Revision: 9dc0b1674841243110f95cdc9c9d97bcf30c1544 URL: https://github.com/llvm/llvm-project/commit/9dc0b1674841243110f95cdc9c9d97bcf30c1544 DIFF: https://github.com/llvm/llvm-project/commit/9dc0b1674841243110f95cdc9c9d97bcf30c1544.diff

[PATCH] D134222: [clang][deps] Report module map describing compiled module

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dc0b1674841: [clang][deps] Report module map describing compiled module (authored by jansvoboda11). Herald added subscribers: Sanitizers, Enna1. Herald added a project: Sanitizers. Changed prior to

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

J-Camilleri marked 2 inline comments as done. J-Camilleri added a comment. In D134339#3808998 , @dblaikie wrote: > I'll commit this shortly. Ok, thanks for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

aaron.ballman added a comment. In D133586#3787814 , @rmaz wrote: > I took a look at writing a test to cover this, but hit the following problem: > function qualifiers are only valid on c++ members, and there we cannot create > FunctionNoProtoTypes. I

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

b-sumner added a comment. In D134355#3809294 , @yaxunl wrote: > In D134355#3807435 , @cfang wrote: > >> LGTM >> >> Should the module flag name be amdgpu_code_object_version or >> amdhsa_code_object_version? > >

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fd0b20731f: [HLSL] Add resource binding attribute for HLSL. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e3fd0b2 - [HLSL] Add resource binding attribute for HLSL.

Author: Xiang Li Date: 2022-09-22T11:51:21-07:00 New Revision: e3fd0b20731f559ba90a9a32f6489499a63cf2b5 URL: https://github.com/llvm/llvm-project/commit/e3fd0b20731f559ba90a9a32f6489499a63cf2b5 DIFF: https://github.com/llvm/llvm-project/commit/e3fd0b20731f559ba90a9a32f6489499a63cf2b5.diff

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

rnk added a comment. Right, last time I think MSVC moved first to C++14. I think it's OK for Clang to be the first mover to C++17. Ultimately, users have many options if they run into breakage: pass `/std:c++14`, if you are a vendor (Microsoft), reconfigure with `CLANG_DEFAULT_STD_CXX`. Maybe

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21b03bf97061: [llvm] Handle dso_local_equivalent in FunctionComparator (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. In D131465#3809413 , @hans wrote: > In D131465#3808381 , @aaron.ballman > wrote: > >> In D131465#3806709 , @MaskRay >> wrote: >> >>> In

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

erichkeane added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1792 + bool *NotPrimaryExpression = nullptr, + bool IsAfterAmp = false); ExprResult ParseCastExpression(CastParseKind ParseKind,

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. I'd like to block this on `-fsanitize-memory-param-retval` (aka msan eager checks) being enabled by default. It seems pretty clear that there is a *lot* of UB due to uninitialized

  1   2   3   >