[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune added a comment. The updates are analogous to how `GNUNullExprClass` is processed because `UnspecifiedValueExprClass` and it is similar (have no operand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune created this revision. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: shafik. Herald added a reviewer: NoQ. Herald added a project: All. aqjune requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470702. lime added a comment. Update for the format check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_dom_canvas0.cpp:65: /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted function 'IdByMethod' const auto id = IdByMethod();

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_editor_txmgr0.cpp:2: In file included from /tmp/gecko/editor/txmgr/TransactionItem.cpp:6: In file included from /tmp/gecko/editor/txmgr/TransactionItem.h:9: In file included from

[PATCH] D104963: [ODR] Fix using uninitialized FunctionTypeBits.FastTypeQuals in FunctionNoProtoType.

vsapsai abandoned this revision. vsapsai added a comment. Herald added a project: All. The issue is addressed in D133586 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104963/new/ https://reviews.llvm.org/D104963

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470686. lime added a comment. Solve the conflicts, and the issue about `CMakeLists.txt` had been solved by upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2106-2107 +TARGET_BUILTIN(__builtin_ia32_vcvtneoph2ps256, "V8fV16xC*", "nV:256:", "avxneconvert") +TARGET_BUILTIN(__builtin_ia32_vcvtneps2bf16128, "V8sV4f", "nV:128:", "avxneconvert")

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 470684. jz10 added a comment. Thanks Shilei 1. "Can you check all resolved comments to make sure there is no open comments?" checked through the comments you and Johannes made, no more issues 2. "Since this function is not part of `libomp` and it's not gonna

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. (And specifically, FuzzerFork.cpp doesn't use any of those declared things. Its only sin is to `#include `, which happens to have /some/ methods (std::filesystem-related) only available on macos 10.15+.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. > In either case, this seems to be an issue with libc++ that is out there in > the wild. I don't think it is, actually. I think it's doing something legitimate. That is, it's declaring in its headers that some things are only available on some versions of macos,

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470679. lime added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Update as required. Also, I need the following modification to complete `ninja check-all`. Maybe, I should submit another

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added a comment. Generally looks good to me. Can you check all resolved comments to make sure there is no open comments? Comment at: openmp/libomptarget/src/api.cpp:206 +// The helper function that calls omp_target_memcpy or omp_target_memcpy_rect +static int

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a subscriber: jdoerfert. jz10 added a comment. hi Johannes and Shilei, is there revision that needs to be done on this patch? please let me know CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a6de59c780: [clang] Instantiate concepts with sugared template arguments (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D136566?vs=470013=470671#toc Repository: rG LLVM

[clang] d0a6de5 - [clang] Instantiate concepts with sugared template arguments

Author: Matheus Izvekov Date: 2022-10-26T03:24:20+02:00 New Revision: d0a6de59c78010118fea811514e03ed9f400215a URL: https://github.com/llvm/llvm-project/commit/d0a6de59c78010118fea811514e03ed9f400215a DIFF:

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/

[clang] 4c44c91 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-26T03:23:24+02:00 New Revision: 4c44c91ad980304c5cca3792115349e68cfafd2b URL: https://github.com/llvm/llvm-project/commit/4c44c91ad980304c5cca3792115349e68cfafd2b DIFF:

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2560c1266993: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo

[clang] 2560c12 - [clang] Instantiate NTTPs and template default arguments with sugar

Author: Matheus Izvekov Date: 2022-10-26T03:22:22+02:00 New Revision: 2560c1266993af6e6c15900ce673c6db23132f8b URL: https://github.com/llvm/llvm-project/commit/2560c1266993af6e6c15900ce673c6db23132f8b DIFF:

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c4c2a3c - [clang] Implement sugared substitution changes to infrastructure

Author: Matheus Izvekov Date: 2022-10-26T03:21:15+02:00 New Revision: c4c2a3c65684e062efcd101a957c6cae0a304a7a URL: https://github.com/llvm/llvm-project/commit/c4c2a3c65684e062efcd101a957c6cae0a304a7a DIFF:

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. (In other words, all known people who care about clang's determinism do not care about having the command recorded in the debug data -- and some (me :) ) mentioned concerns about determinism about the patch adding that feature. It seems weird to put those people on the

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > This is true, but the cc1 flag isn't inherently non-deterministic. I would > prefer to fix the determinism bugs instead of adding flags and more > divergence. See https://reviews.llvm.org/D136474#3875546 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

Allen added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:186 + !eq(name, "v2f16"): Float16x2Regs, + !eq(name, "bf16"): Float16Regs, + !eq(name, "v2bf16"): Float16x2Regs, tra wrote: > tra wrote: > > Allen wrote: > > > sorry for

[PATCH] D136725: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

sammccall added a comment. (I'm sure this doesn't matter much, I just ran into it while trying to understand lifetimes of various macro description objects) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136725/new/

[PATCH] D136725: [Lex] Stop allocating/deallocating MacroInfo on a linked list. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This list was originally used for to make sure MacroInfo's clever memory management

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5d9e802e50d: [clang] Perform sugared substitution of builtin templates (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/

[clang] e5d9e80 - [clang] Perform sugared substitution of builtin templates

Author: Matheus Izvekov Date: 2022-10-26T02:34:42+02:00 New Revision: e5d9e802e50dd55a326e31a0d562e5263b208f3b URL: https://github.com/llvm/llvm-project/commit/e5d9e802e50dd55a326e31a0d562e5263b208f3b DIFF:

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:75 +// - for a logical file like , we check Spelled +llvm::SmallVector match(Header H) const; + in the prototype I reimplemented this

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The occurrences are roots for finding used headers, like

[PATCH] D136715: [NFC][Offload Bundler] Formatting clang offloadbundler source file

raghavmedicherla added a comment. @jdoerfert Sorry for the inconvenience! I had no idea that you would be added as a reviewer by default, so I was trying to remove you as a reviewer. I'll be careful next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. > Hey @dongjunduo, > Are you still interested in finishing this? If not I was thinking that I > would pick it up, so I can work on the follow ups. @Maetveis Sorry for delaying the issue due to some personal trifles... This part of the implementation has been

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce78940b4c: [clang] Changes to produce sugared converted template arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

efriedma added a comment. It's not really a regression, just a bug in the feature. The rpmalloc code is checking `__has_builtin(__builtin_memset_inline)`, so older versions of clang aren't seeing the same source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

steven_wu added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3002 +// The format of the stat cache is (pseudo-code): +// struct stat_cache { +//char Magic[4]; // "STAT" or "Stat" Few comments about stats representation. 1.

[PATCH] D136715: formatting clang offloadbundler source file

jdoerfert accepted this revision. jdoerfert added a comment. I'm not sure why you fight with phabricator so much. I was going to edit your revision metadata but you for some reason disallowed that. I would generally suggest against that. --- The patch itself is fine, the commit subject line

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

aganea added a comment. Hello @gchatelet! This patches introduces a regression in a two-stage build using rpmalloc on Windows. Bisection lead me here. Would you have a chance to take a look please? Thanks in advance. To reproduce, I used the following script (rename to make_llvm.bat)

[PATCH] D136715: formatting clang offloadbundler source file

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136715/new/ https://reviews.llvm.org/D136715

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470645. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 470644. friss added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7966 } + unsigned DwarfVersion = GetDwarfVersion(getToolChain(), Args); RenderDebugEnablingArgs(Args, CmdArgs, DebugInfoKind, DwarfVersion, Consider `const` if this variable

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers updated this revision to Diff 470638. nickdesaulniers added a comment. - more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136707/new/ https://reviews.llvm.org/D136707 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:2179 + for (unsigned I = 0; I < E->NumExprs; I++) +E->getTrailingObjects()[I] = Record.readSubExpr(); +} ilya-biryukov wrote: > FYI: I think this is where the crash comes

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great to me, thanks!! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-notes.cpp:32-33 __buf_size_arg_constraint_concrete(buf); // \ -//

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5196-5206 + std::function FormatBadBranches = + [&](std::string Prefix, unsigned Lines) { +const std::string Directives[] = {"", "#if X\n",

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 470623. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

yaxunl added a comment. In general, I think parallelizing the linking workload for multiple GPU's in the linker wrapper is a useful feature. I am not sure whether the workload to be parallelized includes the LLVM passes and codegen, which is usually the bottleneck. Parallelizing this workload

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

rnk added a comment. In D136474#3883629 , @thakis wrote: > FWIW we do have precedent of deviating from cl.exe for determinism reasons. I > think having deterministic output is a good default. This is true, but the cc1 flag isn't inherently

[PATCH] D136293: [IncludeCleaner] Add public API

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:27 + Symbol(Decl ) : Storage() {} + Symbol(tooling::stdlib::Symbol S) : Storage(S) {} + Doh, I was skimming and missed that you removed the

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay added a comment. In D133998#3883517 , @probinson wrote: > @MaskRay I see that you restored the `clang-driver` keyword in > hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so > the test is never being run. > Is there an

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. In D136701#3883416 , @tra wrote: > In D136701#3883300 , @jhuber6 wrote: > >> However, as an opt-in feature it would be very helpful in some cases. > > I'm OK with the explicit opt-in.

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 470611. manojgupta added a comment. Removed c++ limitation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D136638: [clang-doc] Fix typedef/using output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7231c9966e52: [clang-doc] Fix typedef/using output. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 7231c99 - [clang-doc] Fix typedef/using output.

Author: Brett Wilson Date: 2022-10-25T13:47:24-07:00 New Revision: 7231c9966e523a6fa20aa63b9a9245aff49cf881 URL: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881 DIFF: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881.diff

[PATCH] D136638: [clang-doc] Fix typedef/using output.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397 +template <> llvm::Expected getCommentInfo(TypedefInfo *I) { + I->Description.emplace_back();

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. FWIW we do have precedent of deviating from cl.exe for determinism reasons. I think having deterministic output is a good default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

sammccall accepted this revision. sammccall added a comment. LG other than removing the redundant same-sloc-address check again (sorry!) Comment at: clang/lib/Lex/TokenLexer.cpp:1010 +unsigned distance = +T.getLocation().getRawEncoding() -

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

tomhughes added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:697-698 Builder.defineMacro("__ELF__"); +if (Opts.CPlusPlus) + Builder.defineMacro("_GNU_SOURCE"); + } I think this should apply to both C and C++ Repository: rG LLVM

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) {

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. Also this should have a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits mailing list

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. We have tooling that uses this command line from the PDB. I think the conservative approach is to emit the command line by default since this is how MSVC behaves. I don't mind this flag now that I know about it, but I think we should keep the default to what MSVC does

[PATCH] D136615: [Instrumentation] Remove legacy passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef37504879ee: [Instrumentation] Remove legacy passes (authored by aeubanks). Changed prior to commit:

[clang] ef37504 - [Instrumentation] Remove legacy passes

Author: Arthur Eubanks Date: 2022-10-25T13:11:07-07:00 New Revision: ef37504879eecab1af98c70888bee0be403b9c60 URL: https://github.com/llvm/llvm-project/commit/ef37504879eecab1af98c70888bee0be403b9c60 DIFF:

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta created this revision. manojgupta added reviewers: abidh, tomhughes. Herald added subscribers: kristof.beyls, ki.stfu, dschuff. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein added a comment. In D136539#3882922 , @sammccall wrote: > In D136539#3882316 , @hokein wrote: > >>> This is a subtle change that needs careful review, and honestly should have >>> a test. >> >> I agree,

[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

hokein updated this revision to Diff 470599. hokein marked an inline comment as not done. hokein added a comment. refine the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136539/new/ https://reviews.llvm.org/D136539 Files:

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw updated this revision to Diff 470598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136638/new/ https://reviews.llvm.org/D136638 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) {

[PATCH] D133998: [HIP][test] Avoid %T

probinson added subscribers: lamb-j, probinson. probinson added a comment. @MaskRay I see that you restored the `clang-driver` keyword in hip-link-bc-to-bc.hip, and of course that keyword is not defined anywhere so the test is never being run. Is there an issue filed to track this? Or is the

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet added a comment. In D135340#3882280 , @thakis wrote: > This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` > on mac. I'm reverting this again for now. Sorry about that, I've tested it locally and it should be good to go

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 470597. abrachet added a comment. Use sed to filter nm output instead of grep. grep exits with exit code 1 because there are no matching lines. This is expected because there are no more external symbols other than `_main` and `__mh_execute_header`, note

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D136658#3883372 , @rymiel wrote: > Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? I'm all

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Maetveis added a comment. In D131469#3808758 , @dongjunduo wrote: > I'm sorry that I didn't see the comments until now because of some personal > work... Thank you for your kindness and suppot, I will improve this part of > work according to your idea

[PATCH] D136703: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4981a186b3aa: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia (authored by abrachet). Herald added a project: clang.

[clang] 4981a18 - [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia

Author: Alex Brachet Date: 2022-10-25T19:17:52Z New Revision: 4981a186b3aa5fbe207dce4902d4dce504974f3f URL: https://github.com/llvm/llvm-project/commit/4981a186b3aa5fbe207dce4902d4dce504974f3f DIFF: https://github.com/llvm/llvm-project/commit/4981a186b3aa5fbe207dce4902d4dce504974f3f.diff LOG:

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

rjmccall added inline comments. Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-property.m:89 + +// CHECK: call void @__destructor_8_s0(ptr %[[AGG_TMP_ENSURED]]) + It looks like we're copying `a` into a temporary and then copying out of that temporary

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

tra added a comment. In D136701#3883300 , @jhuber6 wrote: > However, as an opt-in feature it would be very helpful in some cases. I'm OK with the explicit opt-in. > Like consider someone creating a static library that supports every GPU > architecture

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4e2433bcd1: [WebAssembly] Update supported features in the generic CPU configuration (authored by sunfish). Changed prior to commit:

[clang] 1e4e243 - [WebAssembly] Update supported features in the generic CPU configuration

Author: Dan Gohman Date: 2022-10-25T11:44:22-07:00 New Revision: 1e4e2433bcd1a0296ef1043c462252f0d087d90c URL: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c DIFF: https://github.com/llvm/llvm-project/commit/1e4e2433bcd1a0296ef1043c462252f0d087d90c.diff

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

rymiel added a comment. Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136658/new/ https://reviews.llvm.org/D136658 ___

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:107 unsigned ParseDebugDefaultVersion(const ToolChain , const llvm::opt::ArgList ); This can be made static to the .cpp file now.

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4206-4214 // If a -gdwarf argument appeared, remember it. const Arg *GDwarfN = getDwarfNArg(Args); bool EmitDwarf = false; if (GDwarfN) { if (checkDebugInfoOption(GDwarfN,

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, probinson. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've been

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D134902#3883209 , @void wrote: > In D134902#3882255 , @aaron.ballman > wrote: > >> One

[PATCH] D136615: [Instrumentation] Remove legacy passes

MaskRay added a comment. In D136615#3883220 , @aeubanks wrote: > did you mean to point to a different patch? My fault. Updated my previous comment. Pushed it:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] effd75b - [M68k][Driver] Rename target features and macros test files

Author: Min-Yih Hsu Date: 2022-10-25T11:24:48-07:00 New Revision: effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8 URL: https://github.com/llvm/llvm-project/commit/effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8 DIFF: https://github.com/llvm/llvm-project/commit/effd75bda4b1a9b26e554c1cda3e3b4c72fa0aa8.diff

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:24 +/// Indicates the relation between the reference and the target. +enum class RefType { as discussed I moved the other vocab types into

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. In D136701#3883218 , @tra wrote: > I would argue that parallel compilation and linking may need to be disabled > by default. I believe similar patches were discussed in the past regarding > sub-compilations, but they are

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8a414ab3d3: [CUDA, NVPTX] Added basic __bf16 support for NVPTX. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0e8a414 - [CUDA, NVPTX] Added basic __bf16 support for NVPTX.

Author: Artem Belevich Date: 2022-10-25T11:08:06-07:00 New Revision: 0e8a414ab3d330ebb2996ec95d8141618ee0278b URL: https://github.com/llvm/llvm-project/commit/0e8a414ab3d330ebb2996ec95d8141618ee0278b DIFF:

[PATCH] D136668: [clang][dataflow] Add initial sign analysis

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice!! Just nits. At a high level, I'm a little concerned about this as a demo, since I wouldn't recommend this implementation in practice (for various reasons, e.g. I would encode with

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added a comment. In D128372#3883214 , @denik wrote: > @Eugene.Zelenko , could you please stamp the patch if you don't have any > other concerns? Please wait for developers approval. I look only for trivial issues. Repository: rG LLVM

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

tra added a comment. @yaxunl - Found it: D69582 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 ___ cfe-commits mailing list

[PATCH] D136615: [Instrumentation] Remove legacy passes

aeubanks added a comment. did you mean to point to a different patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136615/new/ https://reviews.llvm.org/D136615 ___ cfe-commits mailing list

  1   2   3   >