[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3909722 , @MaskRay wrote: > Thank Ray for your guidance! > We need a regression test. See `clang/test/SemaCXX/using-decl*` for some > other using declaration tests. Study some tests, find a file which is >

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

MaskRay added a comment. We need a regression test. See `clang/test/SemaCXX/using-decl*` for some other using declaration tests. Find a file which is appropriate and add a reduced case there. Use `ninja check-clang-semacxx` to run `clang/test/SemaCXX` tests. Use `$build/bin/llvm-lit -v

[PATCH] D125860: [clang] Only use major version in resource dir

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Considering https://discourse.llvm.org/t/should-we-continue-embed-the-full-llvm-version-in-lib-clang/62094 and this thread, I think overall people favor this patch. If a

[PATCH] D137475: Explicitely initialize opaque pointer mode when -fthinlto-index is used

MatzeB created this revision. MatzeB added reviewers: weiwang, aeubanks, nikic, MaskRay. Herald added subscribers: ormris, StephenFan, modimo, wenlei, arphaman, steven_wu, hiraditya, inglorion, mcrosier. Herald added a project: All. MatzeB requested review of this revision. Herald added a

[PATCH] D137474: [clang-format] Defer formatting of operator< to honor paren spacing

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not exactly sure what the intent of that section of

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

rymiel updated this revision to Diff 473380. rymiel added a comment. Remove format test, relying only on annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137223/new/ https://reviews.llvm.org/D137223 Files:

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

rymiel marked 3 inline comments as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:441-456 + Tokens = annotate("int operator+(int);"); + ASSERT_EQ(Tokens.size(), 8u) << Tokens; + EXPECT_TOKEN(Tokens[1], tok::kw_operator,

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei created this revision. haowei added reviewers: phosek, abrachet. Herald added a subscriber: hiraditya. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. VFS overlay file allow

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. Thank Ray for editing the summary for me ;-) I learned to use fenced code blocks now from your example. Thank you both! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou added a comment. In D119493#3403458 , @efriedma wrote: > Thank Eli for your comment and guidance and sorry to have carelessly neglected your comment for 7 months! > I'm not sure this is the right fix. If we were handling the

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ronlieb added a comment. [AMD Official Use Only - General] Please look into AMDGPU bot fail https://lab.llvm.org/buildbot/#/builders/193/builds/21319 Get Outlook for iOShttps://aka.ms/o0ukef From: Jennifer Yu via Phabricator Sent: Friday, November 4, 2022

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3909488 , @dblaikie wrote: > fwiw, @rsmith came up with a crasher reproducer from this patch here: > > template struct F { > template F(const U&) {} > }; > > struct A { > static constexpr auto x =

[PATCH] D136554: Implement CWG2631

dblaikie added a comment. Looks like it's distinct from the other reported crash, this one crashes with: clang-16: /usr/local/google/home/blaikie/dev/llvm/src/clang/lib/CodeGen/CGExpr.cpp:2811: clang::CodeGen::LValue clang::CodeGen::CodeGenFunction::EmitDeclRefLValue(const

[PATCH] D136554: Implement CWG2631

dblaikie added subscribers: rsmith, dblaikie. dblaikie added a comment. fwiw, @rsmith came up with a crasher reproducer from this patch here: template struct F { template F(const U&) {} }; struct A { static constexpr auto x = [] {}; F f = x; }; void f(A a = A())

[PATCH] D137470: [Offloading] Initial support for registering offloading entries on COFF targets

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, tianshilei1992, JonChesterfield, yaxunl, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 closed this revision. jyu2 added a comment. de14befa7730093ff3d46c7628fa1084f251e98d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/

[clang] de14bef - Remove redundant loads.

Author: Jennifer Yu Date: 2022-11-04T15:22:25-07:00 New Revision: de14befa7730093ff3d46c7628fa1084f251e98d URL: https://github.com/llvm/llvm-project/commit/de14befa7730093ff3d46c7628fa1084f251e98d DIFF: https://github.com/llvm/llvm-project/commit/de14befa7730093ff3d46c7628fa1084f251e98d.diff

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 473348. samitolvanen added a comment. Addressed more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/ https://reviews.llvm.org/D135411 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman marked 4 inline comments as done. dgoldman added a comment. Also LMK if you want more in this change (such as a flag to control it, just not sure where it should live + what it should be called). Comment at: clang-tools-extra/clangd/index/Symbol.h:116 +/// this

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 473347. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review - Swap over IncludeType to IncludeDirective and update the protos accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137458: [clang] Add __decay as a builtin template

troyj added a comment. > Also, it would be nice to have some numbers for the 'measurably faster' claim > :) Sure. Here's an example of a library change that started using builtins for `__make_integer_seq` and `__type_pack_element`

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:42 +namespace { +class KCFIDiagnosticInfo : public DiagnosticInfo { + const Twine If you look at existing DiagnosticInfo subclasses, they

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473341. cor3ntin added a comment. Reopening with subsequent changes merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @abrachet Reverted, sorry again @aaron.ballman @shafik feel free to investigate the issue, i won't have the opportunity over the next two weeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 473340. samitolvanen marked 4 inline comments as done. samitolvanen added a comment. Added `KCFIDiagnosticInfo` and switched from `report_fatal_error` to `LLVMContext::diagnose`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 35a870c - Revert "Implement CWG2631"

Author: Corentin Jabot Date: 2022-11-04T22:10:50+01:00 New Revision: 35a870c30aaa9b16ccb45a9222471433b43ae66c URL: https://github.com/llvm/llvm-project/commit/35a870c30aaa9b16ccb45a9222471433b43ae66c DIFF:

[PATCH] D137458: [clang] Add __decay as a builtin template

royjacobson added a comment. I worry about this mangling issue https://github.com/llvm/llvm-project/issues/54993. For std::make_index_sequence that wasn't that big of a deal, since nobody really uses that as return type of (template) functions, but my guess is that enough people do things like

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Reverting now, just re-running the tests to be sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing list

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Fascinating. Looking more at the error it seems slightly different than what we fixed this morning. I'll revert soon when I'm at a computer. Feel free to do it earlier if it's urgent for you Sorry for the inconvenience. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136554: Implement CWG2631

abrachet added a comment. In D136554#3909198 , @cor3ntin wrote: > In D136554#3909196 , @abrachet > wrote: > >> Hi, we're hitting an assertion failure after this patch >> >>

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3909196 , @abrachet wrote: > Hi, we're hitting an assertion failure after this patch > > llvm-project/clang/lib/Sema/SemaDecl.cpp:15589: Decl > *clang::Sema::ActOnFinishFunctionBody(Decl *, Stmt *, bool): Assertion

[PATCH] D136554: Implement CWG2631

abrachet added a comment. Hi, we're hitting an assertion failure after this patch llvm-project/clang/lib/Sema/SemaDecl.cpp:15589: Decl *clang::Sema::ActOnFinishFunctionBody(Decl *, Stmt *, bool): Assertion `MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking"' failed.

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tra added a comment. In D136919#3909044 , @rjmccall wrote: > If Steve's argument is true, that suggests that it would be a waste for NVPTX > to directly support BF16 arithmetic, at least not the same way it would > support `float` or `double`.

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:61 + if (F.hasFnAttribute("patchable-function-prefix")) +report_fatal_error("-fpatchable-function-entry=N,M, where M>0 is not " + "compatible with -fsanitize=kcfi

[clang] c954cfe - Some uses of the preprocessor can result in multiple target regions on the

Author: Mike Rice Date: 2022-11-04T12:54:22-07:00 New Revision: c954cfeb57a1c8c0996a34da64243bc7f7fe1107 URL: https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107 DIFF: https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107.diff

[PATCH] D134816: [OpenMP] Account for the possibility of multiple target regions per line

This revision was automatically updated to reflect the committed changes. Closed by commit rGc954cfeb57a1: Some uses of the preprocessor can result in multiple target regions on the (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay added a comment. In D137227#3909056 , @sbc100 wrote: >> The asan instrumentation just prepends `__odr_asan_gen_` to the symbol name >> to form a new symbol name. For ELF every byte except `\0` can be used in a >> symbol name, and this is

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:61 + if (F.hasFnAttribute("patchable-function-prefix")) +report_fatal_error("-fpatchable-function-entry=N,M, where M>0 is not " + "compatible with

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 473321. samitolvanen marked 6 inline comments as done. samitolvanen added a comment. Addressed Fangrui's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

jcranmer-intel added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:487 + if (S.inConstantContext()) +return true; + Not sure I understand the conditions that cause `S.inConstantContext()` to be true, which gives me some cause for concern.

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp", "SimdLoopOp","DistributeOp"]>]> { let summary = "loop yield

[PATCH] D137329: [flang] Add -f[no-]associative-math and -mreassociate

clementval added a comment. Herald added a subscriber: jdoerfert. Wouldn't it be good to have a RFC for all these options and what they will do in Flang instead of just adding them all? Or did I miss the RFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. > The asan instrumentation just prepends `__odr_asan_gen_` to the symbol name > to form a new symbol name. For ELF every byte except `\0` can be used in a > symbol name, and this is totally fine. > > I am unfamiliar with WebAssembly. Does the aforementioned parsing tool

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

rjmccall added a comment. On the topic of supporting BF16 arithmetic, note my comment here: https://github.com/itanium-cxx-abi/cxx-abi/pull/147#issuecomment-1254078916. To summarize, according to Steve Canon, we really shouldn't implement arithmetic directly in the BF16 format, because the

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3907235 , @michele.scandale wrote: > In D136786#3903646 , @zahiraam > wrote: > >> The changes in this patch look good to me. >> @michele.scandale please make sure not to

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 473316. tbaeder added a comment. It's not really all that interesting since the current interpreter already does all the work, but it works like this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240

[PATCH] D137458: [clang] Add __decay as a builtin template

troyj created this revision. troyj added a reviewer: bruno. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `__decay(T)` exists as a

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay added a comment. In D137227#3908994 , @sbc100 wrote: > At least for WebAssembly object files, it looks like the symbol table now > contains (what look like) demangled symbols. e.g.: > > $ llvm-nm /tmp/emscripten_temp/command_0.o > 3ef5

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

sbc100 added a comment. At least for WebAssembly object files, it looks like the symbol table now contains (what look like) demangled symbols. e.g.: $ llvm-nm /tmp/emscripten_temp/command_0.o 3ef5 D __odr_asan_gen__numargs 41a6 D __odr_asan_gen__stdcmd<1068>::init 41c3 D

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen updated this revision to Diff 473306. samitolvanen added a comment. Added release notes, grouped together with `-Wcast-function-type-strict`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136790/new/ https://reviews.llvm.org/D136790

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. In D136664#3884796 , @phosek wrote: > In D136664#3882989 , @smeenai wrote: > >> I might be missing it, but

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 473304. gracejennings added a comment. - Add assignment overload codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

beanz added inline comments. Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:49-50 // CHECK-NEXT: ArraySubscriptExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type' lvalue -// CHECK-NEXT: MemberExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type *' lvalue ->h 0x{{[0-9A-Fa-f]+}} -// CHECK-NEXT:

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the request for a comment about `SourceLocation SL`, this LGTM (though we may want to improve the diagnostic behavior in the future). Comment at:

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp",

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + // create a Function instance but not compile the body. That + // will (maybe) happen later.

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); + return

[PATCH] D137240: [clang][Interp] Support alignof()

aaron.ballman added a comment. In D137240#3908229 , @tbaeder wrote: > Oh, this doesn't work: > > void test_alignas_operand() { > alignas(8) char dummy; > static_assert(__alignof(dummy) == 8); > } That's interesting! Based on the code, I

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added a comment. Generally looking good to me aside from a test change that I don't quite understand yet. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} hubert.reinterpretcast wrote: > Perhaps we should normalize on

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D137329: [flang] Add -f[no-]associative-math and -mreassociate

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4dc3c029416: [flang] Add -f[no-]associative-math and -mreassociate (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D137330: [flang] add -f[no-]reciprocal-math

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d4b635786d: [flang] add -f[no-]reciprocal-math (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137328: [flang] Add -f[no-]signed-zeros

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b8a8cfbe1e: [flang] Add -f[no-]signed-zeros (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d0d4b63 - [flang] add -f[no-]reciprocal-math

Author: Tom Eccles Date: 2022-11-04T17:22:35Z New Revision: d0d4b635786d510cd919cadbeb7e5e19983242cf URL: https://github.com/llvm/llvm-project/commit/d0d4b635786d510cd919cadbeb7e5e19983242cf DIFF: https://github.com/llvm/llvm-project/commit/d0d4b635786d510cd919cadbeb7e5e19983242cf.diff LOG:

[clang] c4dc3c0 - [flang] Add -f[no-]associative-math and -mreassociate

Author: Tom Eccles Date: 2022-11-04T17:22:35Z New Revision: c4dc3c029416a25103d631e8dc5422f65c076376 URL: https://github.com/llvm/llvm-project/commit/c4dc3c029416a25103d631e8dc5422f65c076376 DIFF: https://github.com/llvm/llvm-project/commit/c4dc3c029416a25103d631e8dc5422f65c076376.diff LOG:

[PATCH] D137326: [flang] Add -f[no-]approx-func

This revision was automatically updated to reflect the committed changes. Closed by commit rG36b37a1ed561: [flang] Add -f[no-]approx-func (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b5b8a8c - [flang] Add -f[no-]signed-zeros

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273 URL: https://github.com/llvm/llvm-project/commit/b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273 DIFF: https://github.com/llvm/llvm-project/commit/b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273.diff LOG:

[clang] b5e93e3 - [flang] Add -f[no-]honor-nans and -menable-no-nans

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: b5e93e390c06602cb03121ad875e2855253e2937 URL: https://github.com/llvm/llvm-project/commit/b5e93e390c06602cb03121ad875e2855253e2937 DIFF: https://github.com/llvm/llvm-project/commit/b5e93e390c06602cb03121ad875e2855253e2937.diff LOG:

[PATCH] D137325: [flang] Add -f[no-]honor-nans and -menable-no-nans

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e93e390c06: [flang] Add -f[no-]honor-nans and -menable-no-nans (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 36b37a1 - [flang] Add -f[no-]approx-func

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: 36b37a1ed561404a32a4b4b6e2bd92d915894a7c URL: https://github.com/llvm/llvm-project/commit/36b37a1ed561404a32a4b4b6e2bd92d915894a7c DIFF: https://github.com/llvm/llvm-project/commit/36b37a1ed561404a32a4b4b6e2bd92d915894a7c.diff LOG:

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:827 +BUILTIN(__nvvm_reflect, "icC*", "nc") + hdelan wrote: > tra wrote: > > Do we actually need this patch at all. > > > > `extern "C" int __nvvm_reflect(const char *);`

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 473285. reames added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst

[PATCH] D137287: [Test] Fix CHECK typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fa5febaa43: [Test] Fix CHECK typo. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/new/ https://reviews.llvm.org/D137287

[clang] a7fa5fe - [Test] Fix CHECK typo.

Author: Zequan Wu Date: 2022-11-04T10:18:04-07:00 New Revision: a7fa5febaa43d860cbd6a4061f239b283c4d8032 URL: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032 DIFF: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032.diff

[clang-tools-extra] a7fa5fe - [Test] Fix CHECK typo.

Author: Zequan Wu Date: 2022-11-04T10:18:04-07:00 New Revision: a7fa5febaa43d860cbd6a4061f239b283c4d8032 URL: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032 DIFF: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032.diff

[PATCH] D136894: Add clang-doc readme

brettw abandoned this revision. brettw added a comment. Ok thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136894/new/ https://reviews.llvm.org/D136894 ___ cfe-commits mailing list

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136930/new/ https://reviews.llvm.org/D136930

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

hubert.reinterpretcast added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} Perhaps we should normalize on `-aix` while we are

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 473272. reames added a comment. Add a decoder namespace. I did one per vendor - i.e. used a Ventana table rather than a VentanaCondOps one. In theory, we could have a vendor who ships incompatible extensions (in two different pieces of hardware), but if we

[PATCH] D136817: [RISCV] Add H extension

kito-cheng marked an inline comment as done. kito-cheng added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 ___ cfe-commits mailing list

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tra added a comment. > The mangling should be aligned with its semantics. It's fine to use u6__bf16 > if a target doesn't want to support arithmetic operations. We (speaking for CUDA/NVPTX) do want to support math on bfloat, just didn't get to implementing it yet. NVPTX will likely start

[clang] 6ace52e - [Driver][AIX] Change UNSUPPORTED to XFAIL system-aix

Author: Hubert Tong Date: 2022-11-04T12:26:53-04:00 New Revision: 6ace52e5e49cff6664fc301fa4985fc28c88f26f URL: https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f DIFF: https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f.diff

[Diffusion] rGfdab9f1203ee: [Clang] Check for response file existence prior to check for recursion

sepavloff added a comment. Fixed in: https://reviews.llvm.org/rGc14df228ff3c. BRANCHES main Users: sepavloff (Author) https://reviews.llvm.org/rGfdab9f1203ee ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson edited subscribers, added: cfe-commits; removed: clang. probinson added a comment. Try again to add the commits list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/ https://reviews.llvm.org/D137437 ___ cfe-commits

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

ymandel added a comment. Thanks for this patch! Unfortunately, I'm having trouble following the change. Can you expand the description to give a more detailed explantion of the motivation and the key point that are changing? Unfortunately, I don't understand the motivation for the new API

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h:35 +public: + CFGMatchSwitch(std::unique_ptr CurrentElement, + ASTMatchSwitch StmtMS, Why do we need to keep this pointer on the heap?

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

jrtc27 added a comment. In D137350#3906126 , @craig.topper wrote: > Do these need their own DecoderNameSpace? I was going to come here to request that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added inline comments. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND FLANG_TEST_DEPENDS Bye) IIUC, `Bye` is only needed when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement.

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, previously, if the

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added a comment. I still see some review comments not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Ping! Does this need any further change? Seems okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits

[clang] 6875ac6 - [clang] Remove an incorrect assert

Author: Corentin Jabot Date: 2022-11-04T15:46:22+01:00 New Revision: 6875ac69279a3a02fab382a2c8d121558ecbfa91 URL: https://github.com/llvm/llvm-project/commit/6875ac69279a3a02fab382a2c8d121558ecbfa91 DIFF:

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder added a comment. Oh, this doesn't work: void test_alignas_operand() { alignas(8) char dummy; static_assert(__alignof(dummy) == 8); } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240

[clang] 5f87a89 - [clang] Fix assert in SemaEXpr.cpp

Author: Corentin Jabot Date: 2022-11-04T15:37:37+01:00 New Revision: 5f87a892a7bed9cb0599573b9aaf387bc1df9c14 URL: https://github.com/llvm/llvm-project/commit/5f87a892a7bed9cb0599573b9aaf387bc1df9c14 DIFF:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); beanz

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7acfe3629479: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7acfe36 - Implement CWG2631

Author: Corentin Jabot Date: 2022-11-04T14:46:38+01:00 New Revision: 7acfe3629479c8489fc2d7f629994dc200be990c URL: https://github.com/llvm/llvm-project/commit/7acfe3629479c8489fc2d7f629994dc200be990c DIFF:

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3907974 , @stuij wrote: > As for Arm/AAch64, we're still assessing the amount of pain we'd cause with > the name change, but we don't have an issue with letting go of storage-only. Thanks @stuij. Indeed! ABI breaking

  1   2   >