[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

mgehre-amd added a comment. Do other targets not support > 128 bit integers, or is this PR only the first conservative step of lifting the limit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139170/new/ https://reviews.llvm.org/D139170

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG554 is resolved by using the word

[PATCH] D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap

ahatanak created this revision. ahatanak added reviewers: rjmccall, jordan_rose. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. The assertion that is removed in this patch was failing when ObjC dot notation expressions appear in both

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder updated this revision to Diff 479526. tbaeder added a comment. Meh, just use an assert :| CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D139170: [X86][clang] Lift _BitInt() supported max width.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139170 Files: clang/lib/Basic/Targets/X86.h

[clang] 67f3405 - Revert "[clang][modules][deps] Parent module maps are affecting"

Author: Jan Svoboda Date: 2022-12-01T21:39:51-08:00 New Revision: 67f34054d6ea8e40fd10cb74441d5ccab004c75b URL: https://github.com/llvm/llvm-project/commit/67f34054d6ea8e40fd10cb74441d5ccab004c75b DIFF: https://github.com/llvm/llvm-project/commit/67f34054d6ea8e40fd10cb74441d5ccab004c75b.diff

[clang] f0ce827 - Revert "[clang][modules][deps] Including module maps are affecting"

Author: Jan Svoboda Date: 2022-12-01T21:39:51-08:00 New Revision: f0ce827c6972009c5052f8447c6aadf4e4be6113 URL: https://github.com/llvm/llvm-project/commit/f0ce827c6972009c5052f8447c6aadf4e4be6113 DIFF: https://github.com/llvm/llvm-project/commit/f0ce827c6972009c5052f8447c6aadf4e4be6113.diff

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ChuanqiXu added a comment. In D137534#3965012 , @ben.boeckel wrote: > So a few things I see when trying to put this into CMake: > > - P1689 output is only to `stdout`? > - Is there a way to get `-MF` output for the files

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu created this revision. ChuanqiXu added reviewers: ben.boeckel, Bigcheese, jansvoboda11. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Required in https://reviews.llvm.org/D137534. The

[clang] 8ab388e - [clang][deps] Convert file dependency paths to the native style

Author: Jan Svoboda Date: 2022-12-01T21:07:56-08:00 New Revision: 8ab388e158528d9af5eb0376ef698b243d946f19 URL: https://github.com/llvm/llvm-project/commit/8ab388e158528d9af5eb0376ef698b243d946f19 DIFF: https://github.com/llvm/llvm-project/commit/8ab388e158528d9af5eb0376ef698b243d946f19.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. So, some context for how this came up/what I'm trying to address: So I started here: D117616 (for the googlers playing at home, see: b/198958855 for the proximal motivation) - not packing non-POD members of packed structs. That lead

[PATCH] D138702: support for HIP non hostcall printf

vikramRH added a comment. There were some issues reported where it was found that pcie atomics are not available in some environments, as a result hostcall and HIP-Printf were also not available. This Patch is intended to provide an alternative in such scenarios while hostcall based

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. In D139148#3965404 , @shafik wrote: > This looks like the correct thing to do but I see further down there are also > unconditional uses of `Initializer` that should also be guarded with a check. > It would be good to fix

[PATCH] D137206: [clang][modules][deps] Including module maps are affecting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83973cf157f7: [clang][modules][deps] Including module maps are affecting (authored by jansvoboda11). Changed prior to commit:

[clang] 83973cf - [clang][modules][deps] Including module maps are affecting

Author: Jan Svoboda Date: 2022-12-01T20:16:17-08:00 New Revision: 83973cf157f7850eb133a4bbfa0f8b7958bad215 URL: https://github.com/llvm/llvm-project/commit/83973cf157f7850eb133a4bbfa0f8b7958bad215 DIFF: https://github.com/llvm/llvm-project/commit/83973cf157f7850eb133a4bbfa0f8b7958bad215.diff

[PATCH] D137198: [clang][modules][deps] Parent module maps are affecting

This revision was automatically updated to reflect the committed changes. Closed by commit rGf99e5a9106f0: [clang][modules][deps] Parent module maps are affecting (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137198/new/

[PATCH] D137197: [clang][modules][deps] Transitive module maps are not affecting

This revision was automatically updated to reflect the committed changes. Closed by commit rGed07fe71d7bb: [clang][modules][deps] Transitive module maps are not affecting (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f99e5a9 - [clang][modules][deps] Parent module maps are affecting

Author: Jan Svoboda Date: 2022-12-01T20:16:17-08:00 New Revision: f99e5a9106f08ad92a22c3b114d2052e5c502924 URL: https://github.com/llvm/llvm-project/commit/f99e5a9106f08ad92a22c3b114d2052e5c502924 DIFF: https://github.com/llvm/llvm-project/commit/f99e5a9106f08ad92a22c3b114d2052e5c502924.diff

[clang] ed07fe7 - [clang][modules][deps] Transitive module maps are not affecting

Author: Jan Svoboda Date: 2022-12-01T20:16:17-08:00 New Revision: ed07fe71d7bbdd13b113a2073f47e701e41a1001 URL: https://github.com/llvm/llvm-project/commit/ed07fe71d7bbdd13b113a2073f47e701e41a1001 DIFF: https://github.com/llvm/llvm-project/commit/ed07fe71d7bbdd13b113a2073f47e701e41a1001.diff

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

Qfrost911 created this revision. Qfrost911 added reviewers: aaron.ballman, pengfei, JosephTremoulet, efriedma. Herald added a project: All. Qfrost911 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using clang and VS to build Windows

[PATCH] D137192: [clang][serialization] NFCI: Avoid re-reading input file info

This revision was automatically updated to reflect the committed changes. Closed by commit rG66cf61abd849: [clang][serialization] NFCI: Avoid re-reading input file info (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D137192?vs=472393=479513#toc Repository: rG

[clang] 66cf61a - [clang][serialization] NFCI: Avoid re-reading input file info

Author: Jan Svoboda Date: 2022-12-01T20:07:01-08:00 New Revision: 66cf61abd849072d04da96408b122eea436dbc90 URL: https://github.com/llvm/llvm-project/commit/66cf61abd849072d04da96408b122eea436dbc90 DIFF: https://github.com/llvm/llvm-project/commit/66cf61abd849072d04da96408b122eea436dbc90.diff

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool

[clang] 935a07e - [clang][deps][lex] Avoid canonicalization of remapped framework directories

Author: Jan Svoboda Date: 2022-12-01T19:59:54-08:00 New Revision: 935a07ed21434825a96eb6d3acd2163edd0abe88 URL: https://github.com/llvm/llvm-project/commit/935a07ed21434825a96eb6d3acd2163edd0abe88 DIFF: https://github.com/llvm/llvm-project/commit/935a07ed21434825a96eb6d3acd2163edd0abe88.diff

[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG935a07ed2143: [clang][deps][lex] Avoid canonicalization of remapped framework directories (authored by jansvoboda11). Changed prior to commit:

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

shafik added a comment. I agree with @aaron.ballman I expect some more tests for this. Comment at: clang/lib/AST/Interp/Pointer.h:70 Pointer(Block *B, unsigned BaseAndOffset); + Pointer(unsigned Offset); Pointer(const Pointer ); Is the only cast we have

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie added a comment. Don't know that I've got it in me right now to do the more invasive change of updating the LLVM DebugInfo IR metadata to carry the DWARFv6 style language+version stuff (perhaps especially if that's going to go alongside the DWARFv5 and earlier pure language encoding)

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie updated this revision to Diff 479499. dblaikie added a comment. Add llvm testing (but I'm going to rework this a lot, so this is just a snapshot for history) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3964677 , @erichkeane wrote: > In D138939#3964439 , @erichkeane > wrote: > >> In D138939#3964404 , @cjdb wrote: >> >>> In

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb updated this revision to Diff 479492. cjdb marked 4 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138939/new/ https://reviews.llvm.org/D138939 Files:

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Lounarok added a comment. I tried this patch and it's really helpful! However I found that it warns when it comes to `constexpr static` variable. Snippet: `constexpr static int UNDEFINED_ERROR{0};` Warning msg: `warning: global constant 'UNDEFINED_ERROR' should be marked as 'inline'

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

shafik added a comment. This looks like the correct thing to do but I see further down there are also unconditional uses of `Initializer` that should also be guarded with a check. It would be good to fix those as well since we are here. I am guessing the answer is no since this was found using

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem updated this revision to Diff 479474. mnadeem marked 4 inline comments as done. mnadeem added a comment. - Address comments. - Add fc1 tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/ https://reviews.llvm.org/D137995 Files:

[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

benlangmuir added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1331 +auto CanonicalDirEntry = FM.getDirectory(CanonicalDir); +if (CanonicalDirEntry && *CanonicalDirEntry == *DirEntry) { + bool Done = llvm::sys::path::replace_path_prefix(Path, Dir,

[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Please add a comment about why this equality check is necessary. Comment at: clang/lib/Lex/ModuleMap.cpp:1331 +auto CanonicalDirEntry =

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad83bead3d42: [clang-format] Dont move comments if AlignTrailingComments: Leave (authored by mairacanal, committed by owenpan). Repository: rG

[clang] ad83bea - [clang-format] Don't move comments if AlignTrailingComments: Leave

Author: Maíra Canal Date: 2022-12-01T16:07:06-08:00 New Revision: ad83bead3d42082f858d810a5b9f43ed096a6e3c URL: https://github.com/llvm/llvm-project/commit/ad83bead3d42082f858d810a5b9f43ed096a6e3c DIFF: https://github.com/llvm/llvm-project/commit/ad83bead3d42082f858d810a5b9f43ed096a6e3c.diff

[PATCH] D139154: [clang-doc] Add template support

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Decodes the template parameters for both functions and records. For template specializations, records a

[PATCH] D138979: [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbebca2b6d559: [NFC] Cleanup: Replaces BB-getInstList().splice() with BB-splice(). (authored by vporpo). Repository: rG LLVM Github Monorepo

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138255/new/ https://reviews.llvm.org/D138255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] bebca2b - [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice().

Author: Vasileios Porpodas Date: 2022-12-01T15:37:51-08:00 New Revision: bebca2b6d559f545c82047b2071273b4c243d13b URL: https://github.com/llvm/llvm-project/commit/bebca2b6d559f545c82047b2071273b4c243d13b DIFF:

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal updated this revision to Diff 479455. mairacanal marked 8 inline comments as done. mairacanal added a comment. Remove \n from the end of the test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/ https://reviews.llvm.org/D139029 Files:

[PATCH] D128372: [Clang-Tidy] Empty Check

MaskRay added a comment. I just took a glance and the code looks reasonable. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:131 +bool HasClear = !Candidates.empty(); + +if (HasClear) { delete blank line

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:657 +// Tagged global variables shouldn't be merged, as they are assigned unique +// memory tags at runtime. +if (GV.isTagged()) eugenis wrote: > This comment is not

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 479452. hctim marked 2 inline comments as done. hctim added a comment. Rebase now that the parent is submitted, clean up an old comment. New commit message also incoming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139045: [HIP] use detected GPU in --offload-arch

yaxunl added a comment. In D139045#3964875 , @tra wrote: > In any case, I think this is something that may need a wider forum. Ask on > LLVM discourse? RFC opened at discord

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added a comment. To recap, I'm in favor of implementing dllimport constexpr global initializers with a high priority dynamic initializer. I would suggest using init_priority of 201 to run right after the "compiler" initializers. CHANGES SINCE LAST ACTION

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

fcloutier updated this revision to Diff 479427. fcloutier added a comment. Addressed Aaron's comment about fixits, ran clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137603/new/ https://reviews.llvm.org/D137603 Files: clang/docs/ReleaseNotes.rst

[clang-tools-extra] f885ae2 - clangd: Try to fix build with std::optional

Author: Matt Arsenault Date: 2022-12-01T17:59:40-05:00 New Revision: f885ae231033877abcabf921815f75fae310f6bf URL: https://github.com/llvm/llvm-project/commit/f885ae231033877abcabf921815f75fae310f6bf DIFF:

[PATCH] D138393: HIP: Directly call fabs builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138393/new/ https://reviews.llvm.org/D138393 ___ cfe-commits mailing list

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir created this revision. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding nullptr check for 'Initializer' Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139148 Files:

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

ben.boeckel added a comment. So a few things I see when trying to put this into CMake: - P1689 output is only to `stdout`? - Is there a way to get `-MF` output for the files read during scanning? This is useful to know that "header X changed, scanning may have

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

owenpan accepted this revision. owenpan added a comment. Please mark comments as done if you have addressed them. Comment at: clang/unittests/Format/FormatTestComments.cpp:3071 +"\n" +"// comment\n", +format("// do not touch\n"

[clang-tools-extra] f4fb2b3 - [clangd] Fix build after e748db0f7f0971dc258c6631ae1fb0a38cfdf9dd

Author: Fangrui Song Date: 2022-12-01T22:18:34Z New Revision: f4fb2b3048c7e775df7b12a94cc41d490ca3b58e URL: https://github.com/llvm/llvm-project/commit/f4fb2b3048c7e775df7b12a94cc41d490ca3b58e DIFF: https://github.com/llvm/llvm-project/commit/f4fb2b3048c7e775df7b12a94cc41d490ca3b58e.diff LOG:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:835 IsTemporary = true; Ty = E->getType(); } Do we really want to the type of the expression? If we have a `ValueDecl` don't we want that type? I think they should

[clang] e748db0 - Support: Convert Program APIs to std::optional

Author: Matt Arsenault Date: 2022-12-01T17:00:44-05:00 New Revision: e748db0f7f0971dc258c6631ae1fb0a38cfdf9dd URL: https://github.com/llvm/llvm-project/commit/e748db0f7f0971dc258c6631ae1fb0a38cfdf9dd DIFF:

[PATCH] D139045: [HIP] use detected GPU in --offload-arch

tra added a comment. In D139045#3962354 , @yaxunl wrote: > I understand your point. However, when users use gcc or clang and do not > specify target or CPU, the compiled program will execute on their system. > This is because gcc or clang has a default

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2725 NoReturn = true; -if (FD->hasAttr()) +if (FD->hasAttr() || FD->hasAttr()) AddEHEdge = false; erichkeane wrote: >

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

erichkeane added a comment. I'll take a look at rewording the docs if no one else does. I should hopefully have time next week, the rest of the patch is perhaps more important at the moment. Comment at: clang/docs/ReleaseNotes.rst:841 operator. --

[clang] d5fc931 - Remove some trailing WS from the release notes

Author: Erich Keane Date: 2022-12-01T13:37:19-08:00 New Revision: d5fc931ba7d0b8f2bc0f78fe9266ca2bbc468736 URL: https://github.com/llvm/llvm-project/commit/d5fc931ba7d0b8f2bc0f78fe9266ca2bbc468736 DIFF: https://github.com/llvm/llvm-project/commit/d5fc931ba7d0b8f2bc0f78fe9266ca2bbc468736.diff

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 479413. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. @erichkeane thank you for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/docs/ReleaseNotes.rst:841 operator. -- ``clang_Cursor_getNumTemplateArguments``, ``clang_Cursor_getTemplateArgumentKind``, - ``clang_Cursor_getTemplateArgumentType``, ``clang_Cursor_getTemplateArgumentValue`` and +-

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace

carlosgalvezp updated this revision to Diff 479409. carlosgalvezp retitled this revision from "Fix a couple additional cases in misc-use-anonymous-namespace only" to "Fix a couple additional cases in misc-use-anonymous-namespace". carlosgalvezp edited the summary of this revision. carlosgalvezp

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. > The LLVM coding style says to prefer static over anonymous namespaces. Yes, but this is not an LLVM check, it's a `misc` check. Other project are allowed to have other guidelines. Repository: rG LLVM Github

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479403. carlosgalvezp added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files:

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

tschuett added a comment. The LLVM coding style says to prefer static over anonymous namespaces. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:19 +* Functions or variables in header files, since anonymous namespaces in headers + is

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp added a comment. I'm happy with my changes now, ready for a new round of review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 ___

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aaron.ballman if you don't scream, I'll probably try again this week end. I did multiple stage 2 full builds to be sure this time. The fix is pretty small but the investigation took a while... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479397. carlosgalvezp added a comment. Remove accidentally added newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files:

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 479395. cor3ntin added a comment. - Member initializers wwere not marked odr used properly - Fixing that unearthed an other bug: consteval calls in a nested member initializers were not properly detected if the member was list initialized to its default

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479394. carlosgalvezp added a comment. Document ignored cases in the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files:

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added a comment. Ok I added D136811 as a parent revision but I don't think it makes sense to land D136811 before this patch, given that D136811 's documentation does not *yet* reflect

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479391. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Add options for users to define their own header file extensions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479390. v.g.vassilev added a comment. Herald added a subscriber: arphaman. Fixed the diff. I accidentally have added the commits from https://reviews.llvm.org/D139016 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. In D138939#3964439 , @erichkeane wrote: > In D138939#3964404 , @cjdb wrote: > >> In D138939#3963496 , @erichkeane >> wrote: >> >>> In

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a17d059509: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D138296?vs=476473=479387#toc Repository:

[clang] f3a17d0 - [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

Author: Alex Richardson Date: 2022-12-01T20:40:58Z New Revision: f3a17d059509c133d8d90d305c0b40bdcbfc1fef URL: https://github.com/llvm/llvm-project/commit/f3a17d059509c133d8d90d305c0b40bdcbfc1fef DIFF: https://github.com/llvm/llvm-project/commit/f3a17d059509c133d8d90d305c0b40bdcbfc1fef.diff

[PATCH] D139137: add floor library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the floor library

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp marked 2 inline comments as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UseAnonymousNamespaceCheck.cpp:44 + const SourceManager = MatchedDecl->getASTContext().getSourceManager(); + if

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479383. carlosgalvezp added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files:

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:54-55 + bool TraverseDecl(Decl *Node) { +if (!Node) + return true; +if (!match(*Node)) NoQ wrote: > ziqingluo-90 wrote: > > steakhal wrote: > > > Can `Node` be

[PATCH] D138318: [-Wunsafe-buffer-usage] Improve pointer match pattern

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:30-39 + return anyOf( +hasType(pointerType()), +hasType(autoType( +hasDeducedType(hasUnqualifiedDesugaredType(pointerType(), +// DecayedType, e.g., array type in

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UseAnonymousNamespaceCheck.cpp:44 + const SourceManager = MatchedDecl->getASTContext().getSourceManager(); + if (!SM.isWrittenInMainFile(MatchedDecl->getLocation())) +return;

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a reviewer: aeubanks. efriedma added a subscriber: aeubanks. efriedma added a comment. I'm not really familiar with the way constructor priorities work on Windows works... see https://reviews.llvm.org/D131910 ? Adding @aeubanks as a reviewer. CHANGES SINCE LAST ACTION

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:10-13 +void foo(...); + +void * bar(void); +char * baz(void); jkorous wrote: > NoQ wrote: > > ziqingluo-90 wrote: > > > steakhal wrote: > > > > NoQ wrote: > > > > >

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. In D138939#3964404 , @cjdb wrote: > In D138939#3963496 , @erichkeane > wrote: > >> In D138939#3963473 , @tschuett >> wrote: >> >>> Maybe

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank marked an inline comment as done. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb marked 3 inline comments as done. cjdb added a comment. In D138939#3963496 , @erichkeane wrote: > In D138939#3963473 , @tschuett > wrote: > >> Maybe `void FormatDiagnostic(SmallVectorImpl , DiagnosticMode

[PATCH] D139045: [HIP] use detected GPU in --offload-arch

yaxunl updated this revision to Diff 479365. yaxunl added a comment. fix error handling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139045/new/ https://reviews.llvm.org/D139045 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/AMDGPU.h Index:

[PATCH] D138393: HIP: Directly call fabs builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138393/new/ https://reviews.llvm.org/D138393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850defb86164: Add assembler plumbing for sanitize_memtag (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 850defb - Add assembler plumbing for sanitize_memtag

Author: Mitch Phillips Date: 2022-12-01T10:50:34-08:00 New Revision: 850defb86164f1a68816b21f31529d871400a454 URL: https://github.com/llvm/llvm-project/commit/850defb86164f1a68816b21f31529d871400a454 DIFF:

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

tra added inline comments. Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:9 + +__device__ void devicefn() { +} Pierre-vh wrote: > tra wrote: > > We should probably also have a case verifying that actual attempt to use > > `__bf16` in device code is still

[PATCH] D139023: [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in principle. That said, I don't think `StringRef `buys us anything here as none of this code is in the hot path. It also comes with the downside that now one has to worry about lifetimes of

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I think this is fine. Most of the patch is changing calls to `getTargetAddressSpace` to be internal to IRGen, which, as mentioned, I think is the right move. I do think that if we're

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon added a comment. Thank you @gganesh I thought you'd forgotten about us :) Please add znver4 test coverage to: llvm/test/CodeGen/X86/cpus-amd.ll llvm/test/CodeGen/X86/slow-unaligned-mem.ll Comment at: llvm/lib/Target/X86/X86.td:1619

[PATCH] D138822: [clang] Add test for CWG36

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5993fc7757e: [clang] Add test for CWG36 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f5993fc - [clang] Add test for CWG36

Author: Vlad Serebrennikov Date: 2022-12-01T21:10:28+03:00 New Revision: f5993fc7757e37a9076c5cd22de8f275e5c6097e URL: https://github.com/llvm/llvm-project/commit/f5993fc7757e37a9076c5cd22de8f275e5c6097e DIFF:

[PATCH] D128677: [clangd] Support #import insertions

dgoldman updated this revision to Diff 479343. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp

  1   2   3   >