[clang] bfab778 - [clang][modules] Serialize the new RecordID

Author: Jan Svoboda Date: 2022-12-02T23:27:48-08:00 New Revision: bfab778e95004bd71da7685ada25aa420a1a3291 URL: https://github.com/llvm/llvm-project/commit/bfab778e95004bd71da7685ada25aa420a1a3291 DIFF: https://github.com/llvm/llvm-project/commit/bfab778e95004bd71da7685ada25aa420a1a3291.diff

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4889357adb: [clang-repl] Support statements on global scope in incremental mode. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] dc48893 - [clang-repl] Support statements on global scope in incremental mode.

Author: Vassil Vassilev Date: 2022-12-03T07:18:07Z New Revision: dc4889357adb1b909b986b7d2f2a4b9a2cc40c8e URL: https://github.com/llvm/llvm-project/commit/dc4889357adb1b909b986b7d2f2a4b9a2cc40c8e DIFF: https://github.com/llvm/llvm-project/commit/dc4889357adb1b909b986b7d2f2a4b9a2cc40c8e.diff

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

dyung added a comment. @serge-sans-paille, one of our internal tests hit an assertion failure which I bisected back to your change. I have filed issue 59321 with a repro. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. I've been thinking, and it seems to me that explicitly opting into `__attribute__((nounwind))`-provided semantics should override the `__attribute__((nothrow))`/`noexcept` semantics. So looks like i should look into

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc =

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3967397 , @tschuett wrote: > I do not ask you to do anything! I just noticed that you add a lot of > `FormatXXXDiagnostic` functions. An alternativ design is to have one > `FormatDiagnostic` function with a mode

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

This revision was automatically updated to reflect the committed changes. Closed by commit rG7806a928688c: [clang][modules][deps] Serialize inputs into PCMs using the as requested name (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7806a92 - [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

Author: Jan Svoboda Date: 2022-12-02T16:12:16-08:00 New Revision: 7806a928688c12accdf47e7f8dc33d484c295858 URL: https://github.com/llvm/llvm-project/commit/7806a928688c12accdf47e7f8dc33d484c295858 DIFF: https://github.com/llvm/llvm-project/commit/7806a928688c12accdf47e7f8dc33d484c295858.diff

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40472ef14cd3: [clang][modules] Serialize VFS overlay paths into PCMs (authored by jansvoboda11). Changed prior to commit:

[clang] 40472ef - [clang][modules] Serialize VFS overlay paths into PCMs

Author: Jan Svoboda Date: 2022-12-02T16:12:16-08:00 New Revision: 40472ef14cd3bbed665789825b47d055e0a83402 URL: https://github.com/llvm/llvm-project/commit/40472ef14cd3bbed665789825b47d055e0a83402 DIFF: https://github.com/llvm/llvm-project/commit/40472ef14cd3bbed665789825b47d055e0a83402.diff

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 479772. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

benlangmuir added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:194 : Diags(_Diags), HSOpts(HeaderSearchOpts), CodeGenOpts(CGOpts), -TargetOpts(TOpts), LangOpts(LOpts), TheModule(M), +TargetOpts(TOpts), LangOpts(LOpts), TheModule(M),

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabf0c6c0c0b7: Use CTAD on llvm::SaveAndRestore (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] abf0c6c - Use CTAD on llvm::SaveAndRestore

Author: Jan Svoboda Date: 2022-12-02T15:36:12-08:00 New Revision: abf0c6c0c0b7a3493c59858d175a9731eeae0ff5 URL: https://github.com/llvm/llvm-project/commit/abf0c6c0c0b7a3493c59858d175a9731eeae0ff5 DIFF: https://github.com/llvm/llvm-project/commit/abf0c6c0c0b7a3493c59858d175a9731eeae0ff5.diff

[clang-tools-extra] abf0c6c - Use CTAD on llvm::SaveAndRestore

Author: Jan Svoboda Date: 2022-12-02T15:36:12-08:00 New Revision: abf0c6c0c0b7a3493c59858d175a9731eeae0ff5 URL: https://github.com/llvm/llvm-project/commit/abf0c6c0c0b7a3493c59858d175a9731eeae0ff5 DIFF: https://github.com/llvm/llvm-project/commit/abf0c6c0c0b7a3493c59858d175a9731eeae0ff5.diff

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

akyrtzi added inline comments. Comment at: clang/include/clang/CodeGen/BackendUtil.h:14 #include "llvm/IR/ModuleSummaryIndex.h" +#include "llvm/Support/VirtualFileSystem.h" #include Recommend to forward declare instead of including the header.

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139229/new/ https://reviews.llvm.org/D139229

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:581 + Expr *filler = nullptr; + if (auto *ILE = dyn_cast(ExprToVisit)) +filler = ILE->getArrayFiller(); ilya-biryukov wrote: > ilya-biryukov wrote: > > ayzhao wrote: > > >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 479758. ayzhao marked 2 inline comments as done. ayzhao added a comment. implement CXXDefaultInitExpr and ImplicitValueInitExpr, array fillers, and semantic vs syntatic forms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 768107d - [NFC] Remove unneeded #include files.

Author: Bill Wendling Date: 2022-12-02T15:05:29-08:00 New Revision: 768107d77993f3e84517cef8fd8f0c2f5d7c41c7 URL: https://github.com/llvm/llvm-project/commit/768107d77993f3e84517cef8fd8f0c2f5d7c41c7 DIFF: https://github.com/llvm/llvm-project/commit/768107d77993f3e84517cef8fd8f0c2f5d7c41c7.diff

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) rnk wrote: > compnerd wrote: >

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: aaron.ballman, xazax.hun, steakhal, gribozavr, jkorous, NoQ, malavikasamak, t-rasmud. Herald added a subscriber: rnkovacs. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang.

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 479752. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files:

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Anastasia added a comment. In D137652#3957519 , @svenvh wrote: >> @svenvh I remember that we have also discussed the addition of a vendor >> specific header where such feature/extension macro definition can be added >> to avoid the macro pollution but

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

benlangmuir accepted this revision. benlangmuir added a comment. Thanks for the explanation, make sense. LGTM with the documentation tweak! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135634/new/ https://reviews.llvm.org/D135634

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 added a comment. In D135634#3967718 , @benlangmuir wrote: >> If the original HeaderSearchOptions didn't have any VFS overlay files, adopt >> the PCM ones. > > IIUC this is what the patch does, right? Yes, that's correct. >> If the

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. The change to add the assert looks good. I'm eager to see what the testsuite has to say about it :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 ___ cfe-commits

[clang] 642c663 - Reland "[clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas."

Author: Volodymyr Sapsai Date: 2022-12-02T14:30:41-08:00 New Revision: 642c6638a3d78359552f5cf71d24a80a9bd9801f URL: https://github.com/llvm/llvm-project/commit/642c6638a3d78359552f5cf71d24a80a9bd9801f DIFF:

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

benlangmuir added a comment. > If the original HeaderSearchOptions didn't have any VFS overlay files, adopt > the PCM ones. IIUC this is what the patch does, right? > If the original HeaderSearchOptions did have VFS overlay files of its own, > error out if the PCM has different ones. Where

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

dblaikie added a comment. Sorry if this is derailing, but I wonder/worry about a few things here: 1. Compounding structured output with phraseology - it seems like it might be worthwhile for these to be separate issues (doesn't mean the terminal output has to say exactly the same thing - as

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

kazu added a comment. In D139229#3967666 , @jansvoboda11 wrote: > Sorry for the noise, didn't realize this will trigger Herald rules. Wanted to > check with @kazu if this looks fine in principle and if it should be split up > into multiple commits

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

jansvoboda11 added a comment. Herald added a subscriber: jsetoain. Sorry for the noise, didn't realize this will trigger Herald rules. Wanted to check with @kazu if this looks fine in principle and if it should be split up into multiple commits (e.g. per project). Repository: rG LLVM Github

[PATCH] D139173: [clang] Add test for CWG600

shafik added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > aaron.ballman wrote: > > Endill wrote: > > > Endill wrote: > > > > shafik wrote: > > > > > Maybe

[PATCH] D139229: Use CTAD on llvm::SaveAndRestore

jansvoboda11 created this revision. jansvoboda11 added a reviewer: kazu. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, sdasgup3, carlosgalvezp, jeroen.dobbelaere, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 479731. schittir added a comment. Add assert instead of multiple checks in if conditions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index:

[clang] d3804b8 - [clang][deps] Fix test failures on AIX

Author: Jan Svoboda Date: 2022-12-02T13:10:07-08:00 New Revision: d3804b88e96e40300ec9993ed691bf2184932e29 URL: https://github.com/llvm/llvm-project/commit/d3804b88e96e40300ec9993ed691bf2184932e29 DIFF: https://github.com/llvm/llvm-project/commit/d3804b88e96e40300ec9993ed691bf2184932e29.diff

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:447 +SmallString<128> CanonicalPath = FE.getNameAsRequested(); +ModMapInfo.canonicalizeModuleMapPath(CanonicalPath); +

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

jansvoboda11 updated this revision to Diff 479725. jansvoboda11 added a comment. Rebase, remove unnecessary canonicalization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135636/new/ https://reviews.llvm.org/D135636 Files:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl added a comment. Agreeing with @probinson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver added a comment. In D136078#3966187 , @melver wrote: >>> Do you have any other ideas on how to dead with this? >> >> It's strange we've not encountered this elsewhere - this must be some >> special (old?) linker. I'll investigate... > > GNU ld <=

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

rnk added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) compnerd wrote: > aaron.ballman

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 updated this revision to Diff 479723. jansvoboda11 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Move header search paths into unhashed control block. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/test/Sema/gnu-asm-pmf.cpp:1-34 +// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -std=c++2b -fsyntax-only -verify %s -DMICROSOFT_ABI +// RUN: %clang_cc1 -triple

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. I do not ask you to do anything! I just noticed that you add a lot of `FormatXXXDiagnostic` functions. An alternativ design is to have one `FormatDiagnostic` function with a mode parameter. Then you can decide whether to print legacy or user-oriented reasons. If next

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5824-5828 // Handle default initialization. if (Kind.getKind() == InitializationKind::IK_Default) { TryDefaultInitialization(S, Entity, Kind, *this); return; } schittir

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. The clang-ppc64-aix bot ran with these changes here and all results are as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14115 +/// Analyze the given compound assignment for the possible losing of +/// floating-point precision. Moving this function to another spot in the file makes comparing the new

[PATCH] D128372: [Clang-Tidy] Empty Check

denik added a comment. In D128372#3965162 , @MaskRay wrote: > I just took a glance and the code looks reasonable. @MaskRay thanks for the review! I have updated the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5824-5828 // Handle default initialization. if (Kind.getKind() == InitializationKind::IK_Default) { TryDefaultInitialization(S, Entity, Kind, *this); return; } tahonermann

[PATCH] D138970: [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138970/new/ https://reviews.llvm.org/D138970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138970: [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b54697b7aa: [clang][Driver] Dont overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b4b5469 - [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

Author: Volodymyr Sapsai Date: 2022-12-02T11:59:22-08:00 New Revision: b4b54697b7aacda1fabef36d4e74d5ee45641618 URL: https://github.com/llvm/llvm-project/commit/b4b54697b7aacda1fabef36d4e74d5ee45641618 DIFF:

[PATCH] D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG1127e479e850: Dont revisit the subexpressions of PseudoObjectExpr when building a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1127e47 - Don't revisit the subexpressions of PseudoObjectExpr when building a

Author: Akira Hatanaka Date: 2022-12-02T11:41:09-08:00 New Revision: 1127e479e85011b4284dd5097ca2732347198130 URL: https://github.com/llvm/llvm-project/commit/1127e479e85011b4284dd5097ca2732347198130 DIFF:

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

HazardyKnusperkeks added a comment. Looks good to me. And adding a token type is absolutely nothing negative. The more tokens get a type, the better. Comment at: clang/lib/Format/TokenAnnotator.cpp:1630 TemplateArgument, + // C11 _Generic selection +

[PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. In D138792#3966920 , @Hahnfeld wrote: > Hi, I bisected this change to lead to a couple of test failures when building > with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable > initialization order, but

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc414bbefe45a: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES

[clang] c414bbe - Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

Author: Mitch Phillips Date: 2022-12-02T11:29:41-08:00 New Revision: c414bbefe45ace832a0857d508fb4abfae24c5e6 URL: https://github.com/llvm/llvm-project/commit/c414bbefe45ace832a0857d508fb4abfae24c5e6 DIFF:

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though my python skills are weak, so if someone else wants to give this a look that'd be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 479693. hctim added a comment. Lots of places in scudo_standalone depend on GWP-ASan, and it seems far more reasonable to make COMPILER_RT_HAS_GWP_ASAN mean "is GWP-ASan actually going to be built", rather than checking three variables in all the places.

[PATCH] D139173: [clang] Add test for CWG600

Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} aaron.ballman wrote: > Endill wrote: > > Endill wrote: > > > shafik wrote: > > > > Maybe add a comment above this

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/test/Driver/zos-profiling-error.c:3 + +// RUN: not %clang -target s390x-none-zos -p -S %s 2>&1 |

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

MaskRay added inline comments. Comment at: clang/test/Driver/zos-profiling-error.c:3 + +// RUN: not %clang -target s390x-none-zos -p -S %s 2>&1 | FileCheck -check-prefix=FAIL-P-NAME %s +// FAIL-P-NAME: error: unsupported option '-p' for target 's390x-none-zos'

[PATCH] D128372: [Clang-Tidy] Empty Check

denik updated this revision to Diff 479684. denik added a comment. Replaced deprecated [[@LINE-1]] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files:

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f07256a5192: [Driver] -p: change from unused warning to error for most targets (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D138255?vs=476319=479683#toc Repository: rG

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

fcloutier updated this revision to Diff 479658. fcloutier added a comment. Fix new fixit test for Windows, where directory separators are backslashes instead of forward slashes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137603/new/ https://reviews.llvm.org/D137603 Files:

[clang] 9f07256 - [Driver] -p: change from unused warning to error for most targets

Author: Fangrui Song Date: 2022-12-02T18:57:48Z New Revision: 9f07256a51924feabf151b5f5fbbab16af2a76c5 URL: https://github.com/llvm/llvm-project/commit/9f07256a51924feabf151b5f5fbbab16af2a76c5 DIFF: https://github.com/llvm/llvm-project/commit/9f07256a51924feabf151b5f5fbbab16af2a76c5.diff LOG:

[PATCH] D139173: [clang] Add test for CWG600

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > Endill wrote: > > shafik wrote: > > > Maybe add a comment above this saying something like:

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. In D137258#3947181 , @steakhal wrote: > Are you sure about the speedup? > When I looked at the implementation of the `StringSwitch`, it boiled down to > an `if-else` chain

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

arsenm added inline comments. Comment at: llvm/test/Bitcode/upgrade-annotation.ll:14 + +declare i32 @llvm.annotation.i32(i32, i8*, i8*, i32) +; CHECK: declare i32 @llvm.annotation.i32.p0i8(i32, i8*, i8*, i32) New tests should use opaque pointers. For autoupgrade

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

efriedma added a subscriber: steplong. efriedma added a comment. FYI, there's some discussion of /d1nodatetime floating around, even though it isn't formally documented: it disables the definition of the `__DATE__`, `__TIME__`, and `__TIMESTAMP__` macros. (No idea about d1import_no_registry,

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

MaskRay added a comment. Thanks! I think this is better landing before AIX -p patches for clarity, so I am landing it now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138255/new/ https://reviews.llvm.org/D138255

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138255/new/ https://reviews.llvm.org/D138255

[PATCH] D139173: [clang] Add test for CWG600

Endill added a subscriber: aaron.ballman. Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > shafik wrote: > > Maybe add a comment above this saying

[clang] 50fd660 - Reapply "[clang][modules][deps] Including module maps are affecting"

Author: Jan Svoboda Date: 2022-12-02T10:46:48-08:00 New Revision: 50fd6604b76e5fcf5d481a4a551efd50398d9abe URL: https://github.com/llvm/llvm-project/commit/50fd6604b76e5fcf5d481a4a551efd50398d9abe DIFF: https://github.com/llvm/llvm-project/commit/50fd6604b76e5fcf5d481a4a551efd50398d9abe.diff

[PATCH] D128372: [Clang-Tidy] Empty Check

denik updated this revision to Diff 479677. denik marked 2 inline comments as done. denik added a comment. Format changes. Removed blank lines and fixed test types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/

[PATCH] D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139171/new/ https://reviews.llvm.org/D139171

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill added a comment. > @aaron.ballman do you think it is worth it to provide a link to p1787 as > well? I know you can just goto the issue and see that but it feels helpful. I > actually missed this at first b/c I usually goto end of the issue to look for > the resolution and was confused.

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. if none is provided Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139212 Files:

[clang] 4d6483e - Reapply "[clang][modules][deps] Parent module maps are affecting"

Author: Jan Svoboda Date: 2022-12-02T10:32:47-08:00 New Revision: 4d6483e91bb8f4147ff4001e6a11e373d5198e1c URL: https://github.com/llvm/llvm-project/commit/4d6483e91bb8f4147ff4001e6a11e373d5198e1c DIFF: https://github.com/llvm/llvm-project/commit/4d6483e91bb8f4147ff4001e6a11e373d5198e1c.diff

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel added a comment. I put WIP in the title right now because firstly, I still need to write more tests, but also, since I haven't touched the breaking and indenting part of the code before, I want to make sure what I'm doing is sensible. Basically, after making the colons their own type so

[PATCH] D139172: [clang] Mark CWG554 as N/A

aaron.ballman added a comment. In D139172#3966863 , @shafik wrote: > @aaron.ballman do you think it is worth it to provide a link to `p1787` as > well? I know you can just goto the issue and see that but it feels helpful. I > actually missed this at

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch properly recognizes the generic selection

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

aaron.ballman added a comment. In D139095#3966626 , @Endill wrote: >>> We can do it the following way then: // dr405: yes \n // NB: also dup 218. >> >> That would be fine by me! > > Which way should we handle this? I'd prefer to do it without test >

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) aaron.ballman wrote: > rnk

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3966938 , @tschuett wrote: > Maybe the kind/amount of information printed ( `DiagnosticMode` ) and the > output device (console/sarif) are orthogonal issues. > > Still it would nice to be able to toggle the diagnostic

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 479665. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479664. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64e4d03c681a: [lit][AIX] Convert clang tests to use target={{.*}}-aix{{.*}} (authored by probinson). Changed prior to commit:

[clang] 64e4d03 - [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

Author: Paul Robinson Date: 2022-12-02T09:44:15-08:00 New Revision: 64e4d03c681a1c43ec22aee9ce32b784ed5aee9c URL: https://github.com/llvm/llvm-project/commit/64e4d03c681a1c43ec22aee9ce32b784ed5aee9c DIFF: https://github.com/llvm/llvm-project/commit/64e4d03c681a1c43ec22aee9ce32b784ed5aee9c.diff

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3951a73490df: [Flang][Driver] Handle target CPU and features (authored by mnadeem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/

[clang] 3951a73 - [Flang][Driver] Handle target CPU and features

Author: Usman Nadeem Date: 2022-12-02T09:37:53-08:00 New Revision: 3951a73490df0f3dd307e8ea6aa52d2776259a4c URL: https://github.com/llvm/llvm-project/commit/3951a73490df0f3dd307e8ea6aa52d2776259a4c DIFF: https://github.com/llvm/llvm-project/commit/3951a73490df0f3dd307e8ea6aa52d2776259a4c.diff

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. Maybe the kind/amount of information printed ( `DiagnosticMode` ) and the output device (console/sarif) are orthogonal issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138939/new/ https://reviews.llvm.org/D138939

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Old pass manager is dead. There is no point in making improvements to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128677: [clangd] Add support for generating #import edits

dgoldman updated this revision to Diff 479659. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. > This shouldn't be a blocker for this patch though, it's just removing > functionality that belongs in another check. As said, the check is 1 day old > so it's unlikely anyone is relying on it yet :) SGTM in general. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3965985 , @tschuett wrote: > Then Sarif was a distraction. Still to reduce boilerplate and for A/B testing: > > enum class DiagnosticMode { > Legacy, > UserOriented, > Default = Legacy > } It took a fair

[PATCH] D138792: [AArch64] Improve TargetParser API

Hahnfeld added a comment. Hi, I bisected this change to lead to a couple of test failures when building with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is `AARCH64_ARCH` used to define

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >