[clang] c835dca - [Driver][test] Add -Wno-msvc-not-found to %clang_cl -WX tests that don't want the diagnostic

Author: Fangrui Song Date: 2023-07-29T21:45:41-07:00 New Revision: c835dcaccf8ef46a7aa8f535ae7a55a862c426c4 URL: https://github.com/llvm/llvm-project/commit/c835dcaccf8ef46a7aa8f535ae7a55a862c426c4 DIFF: https://github.com/llvm/llvm-project/commit/c835dcaccf8ef46a7aa8f535ae7a55a862c426c4.diff

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && zyounan wrote: > The current heuristic results in the following: > > ``` > struct Base { > void foo(int); > }; >

[clang] 989a5fe - [Driver][test] clang_f_opts.c: unsupport AIX

Author: Fangrui Song Date: 2023-07-29T21:31:15-07:00 New Revision: 989a5feb2ca7d3f63db6c3c33590cfd7596724a8 URL: https://github.com/llvm/llvm-project/commit/989a5feb2ca7d3f63db6c3c33590cfd7596724a8 DIFF: https://github.com/llvm/llvm-project/commit/989a5feb2ca7d3f63db6c3c33590cfd7596724a8.diff

[clang] f92551b - [Driver][test] pgo-sample-use-profi.c: specify --target=

Author: Fangrui Song Date: 2023-07-29T21:25:31-07:00 New Revision: f92551ba6b5aaef28d886ea6b3c4f9774fa8fadd URL: https://github.com/llvm/llvm-project/commit/f92551ba6b5aaef28d886ea6b3c4f9774fa8fadd DIFF: https://github.com/llvm/llvm-project/commit/f92551ba6b5aaef28d886ea6b3c4f9774fa8fadd.diff

[PATCH] D156286: [docs] Bump minimum GCC version to 7.5

MaskRay added a comment. In D156286#4534968 , @aaron.ballman wrote: > There's a mention on the RFC thread that Ubuntu 18.04 still ships with GCC > 7.3. That's an LTS release but it EOLed just last month, so it's not clear > how disruptive this would

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan created this revision. zyounan added reviewers: sammccall, nridge, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman, hazohelet. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before: array.cpp:74:15: error: static assertion expression is

[clang] 0c2cd74 - [Driver][test] Ensure fuzzer.c commands have --target=

Author: Fangrui Song Date: 2023-07-29T20:53:40-07:00 New Revision: 0c2cd74ff85a43a346ee05a2bfb88f07d9e60647 URL: https://github.com/llvm/llvm-project/commit/0c2cd74ff85a43a346ee05a2bfb88f07d9e60647 DIFF: https://github.com/llvm/llvm-project/commit/0c2cd74ff85a43a346ee05a2bfb88f07d9e60647.diff

[clang] 2a1edeb - [Driver] Add -Wno-msvc-not-found to %clang_cl -Werror tests that don't want the diagnostic

Author: Fangrui Song Date: 2023-07-29T20:51:44-07:00 New Revision: 2a1edebdf1a887fdf01f039d60497626576c837b URL: https://github.com/llvm/llvm-project/commit/2a1edebdf1a887fdf01f039d60497626576c837b DIFF: https://github.com/llvm/llvm-project/commit/2a1edebdf1a887fdf01f039d60497626576c837b.diff

[clang] 4dd1467 - [test] Improve visibility.cpp

Author: Fangrui Song Date: 2023-07-29T20:09:38-07:00 New Revision: 4dd1467df8885e61ca6ad42715435916ab26d8cb URL: https://github.com/llvm/llvm-project/commit/4dd1467df8885e61ca6ad42715435916ab26d8cb DIFF: https://github.com/llvm/llvm-project/commit/4dd1467df8885e61ca6ad42715435916ab26d8cb.diff

[clang] 5fe4558 - [test] Add --sysroot= for -fuse-ld=gold test

Author: Fangrui Song Date: 2023-07-29T20:00:34-07:00 New Revision: 5fe45586d9903447a6c0f1645ecd1eabe7882adf URL: https://github.com/llvm/llvm-project/commit/5fe45586d9903447a6c0f1645ecd1eabe7882adf DIFF: https://github.com/llvm/llvm-project/commit/5fe45586d9903447a6c0f1645ecd1eabe7882adf.diff

[clang] 8e39241 - [Driver][test] Remove unneeded REQUIRES: system-darwin

Author: Fangrui Song Date: 2023-07-29T19:38:08-07:00 New Revision: 8e39241fdef07bba2b1293ef187f2c894140c4d6 URL: https://github.com/llvm/llvm-project/commit/8e39241fdef07bba2b1293ef187f2c894140c4d6 DIFF: https://github.com/llvm/llvm-project/commit/8e39241fdef07bba2b1293ef187f2c894140c4d6.diff

[clang] abae53f - [Driver][test] Change some -fuse-ld=lld tests to be agnostic of host ld.lld

Author: Fangrui Song Date: 2023-07-29T19:34:14-07:00 New Revision: abae53f43f0d1da8d8e421f4a628d7ec64d6e365 URL: https://github.com/llvm/llvm-project/commit/abae53f43f0d1da8d8e421f4a628d7ec64d6e365 DIFF: https://github.com/llvm/llvm-project/commit/abae53f43f0d1da8d8e421f4a628d7ec64d6e365.diff

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Oops, my apologies for bothering you. Thanks again for the explanation and your dedication! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

nridge added a comment. Your patience is appreciated. I have a number of patches in my review queue, and 3 days is often not a realistic turnaround time for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 545392. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.py

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545388. fridtjof added a comment. Whoops, forgot to run clang-format on the last diff. Also took the opportunity to just get rid of the template mess now that we're only dealing with AnnotateAttr anyway. CHANGES SINCE LAST ACTION

[PATCH] D154093: [clang-format] Break long strings in Verilog

owenpan added a comment. In D154093#4542339 , @sstwcw wrote: > @owenpan What do you think about this revision especially the replacement > part? See D154093#4544495 . Then we can extend it by using `,` instead

[PATCH] D154093: [clang-format] Break long strings in Verilog

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2152-2154 // FIXME: String literal breaking is currently disabled for C#, Java, Json // and JavaScript, as it requires strings to be merged using "+" which we // don't support.

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4544281 , @glaubitz wrote: > Any update on this? Sorry I was busy on my phd defense (which I passed!) in the past month. I'll get back to this next week. CHANGES SINCE LAST ACTION

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall this check is complicated, simply because it's doing complicated stuff. 1. Add description to all functions (what is their purpose, what is expected outcome, maybe put some

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545379. ccotter added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added a comment. In D140828#4544433 , @Zingam wrote: > Is this going to land soon? There is a libc++ paper I'm interested in that > relies on "deducing this" and I wonder if I should wait for "this" first > before I start working on it? Hard

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Zingam added a comment. Is this going to land soon? There is a libc++ paper I'm interested in that relies on "deducing this" and I wonder if I should wait for "this" first before I start working on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1019 -if (isTokenStringLiteral()) - AssertMessage = ParseUnevaluatedStringLiteralExpression(); -else if (getLangOpts().CPlusPlus26) +bool ParseAsExression = false; +

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015

[PATCH] D156599: [profiling] Move option declarations into headers

tstellar created this revision. tstellar added reviewers: bogner, dnovillo, hoy, huangjd. Herald added subscribers: wlei, Enna1, ormris, wenlei, hiraditya. Herald added a project: All. tstellar requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin updated this revision to Diff 545374. cor3ntin added a comment. Format + Add FixIt tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-constraints.rst:4 +modernize-use-constraints +== + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 545372. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files:

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL updated this revision to Diff 545371. PiotrZSL marked 4 inline comments as done. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Rebase + Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156597 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156596 Files:

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added a comment. Do you want me to squash the patches I abandoned into this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Source.h:63-64 /// Pointer into the code owned by a function. +public: const std::byte *Ptr; }; aaron.ballman wrote: > Any chance we can use friendship here as well, rather than exposing the

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder updated this revision to Diff 545367. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:131 if (T->isFunctionPointerType() || T->isFunctionReferenceType() || - T->isFunctionType()) + T->isFunctionType() || T->isSpecificBuiltinType(BuiltinType::BoundMember)) return

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:240 +return Initializing ? this->visitInitializer(SubExpr) +: this->visit(SubExpr); aaron.ballman wrote: > tbaeder wrote: > > This pattern shows up

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4541063 , @wangpc wrote: > - Rebase. > - Unsupport clang-18. I see the libc++ build failed. It seems like timeouts uploading artifacts, so not related to your patch. Can you rebase and give it another run on the CI?

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

long5hot added inline comments. Comment at: clang/test/Driver/ppc-abi.c:18 // RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s +// RUN: %clang --target=ppc64 -mabi=elfv1 %s -### -o %t.o 2>&1 \ +// RUN: | FileCheck -check-prefix=CHECK-UNKNOWN-ELFv1 %s

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG065da3574b4f: clang driver throws error for -mabi=elfv2 or elfv2 (authored by long5hot). Changed prior to commit:

[clang] 065da35 - clang driver throws error for -mabi=elfv2 or elfv2

Author: Kishan Parmar Date: 2023-07-29T16:10:51+05:30 New Revision: 065da3574b4fe9d4ee6283de2c82b8ce1c08af08 URL: https://github.com/llvm/llvm-project/commit/065da3574b4fe9d4ee6283de2c82b8ce1c08af08 DIFF: https://github.com/llvm/llvm-project/commit/065da3574b4fe9d4ee6283de2c82b8ce1c08af08.diff

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

zkkxu updated this revision to Diff 545358. zkkxu added a comment. - fix wrong ut test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156588/new/ https://reviews.llvm.org/D156588 Files: clang/include/clang/Driver/Distro.h

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

This revision was automatically updated to reflect the committed changes. Closed by commit rG87d0aedaa285: [clang-tidy] Add readability-reference-to-constructed-temporary check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 87d0aed - [clang-tidy] Add readability-reference-to-constructed-temporary check

Author: Piotr Zegar Date: 2023-07-29T10:39:17Z New Revision: 87d0aedaa285cfca92aef67367ce55c476cf444e URL: https://github.com/llvm/llvm-project/commit/87d0aedaa285cfca92aef67367ce55c476cf444e DIFF: https://github.com/llvm/llvm-project/commit/87d0aedaa285cfca92aef67367ce55c476cf444e.diff LOG:

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder updated this revision to Diff 545353. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155165/new/ https://reviews.llvm.org/D155165 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/Disasm.cpp

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added a comment. In D155568#4542764 , @aaron.ballman wrote: > In D155568#4525488 , @tbaeder wrote: > >> This patch is missing the `Ret` part in `InterpBuiltin()` in the >> same file. That needs to

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 545349. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index:

[clang] ff80fc0 - [clang][Interp] Implement __builtin_isnan()

Author: Timm Bäder Date: 2023-07-29T10:48:10+02:00 New Revision: ff80fc0ea2f9ec043d679f343c875bdf43e1395e URL: https://github.com/llvm/llvm-project/commit/ff80fc0ea2f9ec043d679f343c875bdf43e1395e DIFF: https://github.com/llvm/llvm-project/commit/ff80fc0ea2f9ec043d679f343c875bdf43e1395e.diff

[clang] 7dbc7b1 - [Options] Fix a couple of incorrect comments. NFC

Author: Justin Bogner Date: 2023-07-29T01:38:52-07:00 New Revision: 7dbc7b18a0cd02c6a4a74443a8596aba508f12b0 URL: https://github.com/llvm/llvm-project/commit/7dbc7b18a0cd02c6a4a74443a8596aba508f12b0 DIFF: https://github.com/llvm/llvm-project/commit/7dbc7b18a0cd02c6a4a74443a8596aba508f12b0.diff

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545343. danix800 added a comment. Cleanup spaghetti-ish code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156277/new/ https://reviews.llvm.org/D156277 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155710: [clang][Interp] Create a new local variable in VisitCXXDefaultArgExpr

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D156027 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155710/new/ https://reviews.llvm.org/D155710

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4543685 , @hubert.reinterpretcast wrote: > In D105759#4543246 , @aaron.ballman > wrote: > >> I'd recommend we change the diagnostic to be a warning that defaults to an >>

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

tbaeder added a comment. Herald added a subscriber: ormris. @MaskRay Isn't this something we should be doing with config files now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156588/new/ https://reviews.llvm.org/D156588

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545336. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

zkkxu created this revision. zkkxu added reviewers: EricWF, kazu, JDevlieghere. Herald added a project: All. zkkxu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo