https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/70156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Would it be possible to create an issue, or RFC explain in one place what it
the problem you are trying to solve and how?
https://github.com/llvm/llvm-project/pull/70166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chaitanya (skc7)
Changes
This PR has dependency on #68865
---
Full diff: https://github.com/llvm/llvm-project/pull/70166.diff
3 Files Affected:
- (added) clang/test/CodeGen/asan_globals_symbols.cpp (+15)
- (modified)
https://github.com/skc7 created https://github.com/llvm/llvm-project/pull/70166
This PR has dependency on #68865
>From d6f66a73e6ae7684411c246cb3e82a4ab214c0d1 Mon Sep 17 00:00:00 2001
From: skc7
Date: Wed, 25 Oct 2023 10:46:10 +0530
Subject: [PATCH] [ASAN] For Asan instrumented globals, emit
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/70150
>From 1e7ec004102349a67519966bb7111838668ab2b4 Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 24 Oct 2023 16:21:30 -0700
Subject: [PATCH] [Clang] Ensure zero-init is not overridden when intializing a
llvmbot wrote:
@llvm/pr-subscribers-mlir-core
Author: Kazu Hirata (kazutakahirata)
Changes
C++20 comes with std::erase to erase a value from std::vector. This
patch renames llvm::erase_value to llvm::erase for consistency with
C++20.
We could make llvm::erase more similar to std::erase
llvmbot wrote:
@llvm/pr-subscribers-mlir-core
Author: Kazu Hirata (kazutakahirata)
Changes
C++20 comes with std::erase to erase a value from std::vector. This
patch renames llvm::erase_value to llvm::erase for consistency with
C++20.
We could make llvm::erase more similar to std::erase
@@ -617,24 +617,27 @@ void ASTDeclReader::VisitDecl(Decl *D) {
Reader.getContext());
}
D->setLocation(ThisDeclLoc);
- D->InvalidDecl = Record.readInt();
- if (Record.readInt()) { // hasAttrs
+
+ uint64_t DeclBits = Record.readInt();
+
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/69514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -130,26 +130,35 @@
UnusedReturnValueCheck::UnusedReturnValueCheck(llvm::StringRef Name,
"::std::error_condition;"
"::std::errc;"
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fazlay Rabbi (mdfazlay)
Changes
The syntax of the linear clause that specifies its argument and linear-modifier
as linear-modifier(list) was deprecated since OpenMP 5.2 and the step modifier
was added for specifying the linear step.
mdfazlay wrote:
@alexey-bataev, I'll add more tests as soon as we finalize the proper error
message.
https://github.com/llvm/llvm-project/pull/70152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/mdfazlay created
https://github.com/llvm/llvm-project/pull/70152
The syntax of the linear clause that specifies its argument and linear-modifier
as linear-modifier(list) was deprecated since OpenMP 5.2 and the step modifier
was added for specifying the linear step.
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith updated
https://github.com/llvm/llvm-project/pull/68494
>From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001
From: James Smith
Date: Thu, 28 Sep 2023 10:11:15 -0400
Subject: [PATCH 1/7] [libc++] Implement ranges::iota and
https://github.com/jamesETsmith updated
https://github.com/llvm/llvm-project/pull/68494
>From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001
From: James Smith
Date: Thu, 28 Sep 2023 10:11:15 -0400
Subject: [PATCH 1/7] [libc++] Implement ranges::iota and
HaohaiWen wrote:
> > See most recent comments about missing tests. That being said code looks
> > functionally correct to me. Still not 100% sure this is a desirable change.
> > Will defer to @nikic about that.
>
> I'm also skeptical about accepting this optimization. Looking at the
>
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wmissing-format-attribute %s
+
+#include
+#include
+
+va_list args;
aaronpuchert wrote:
This should be in the function
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wmissing-format-attribute %s
+
+#include
+#include
+
+va_list args;
+
+__attribute__((__format__ (__scanf__, 1, 4)))
+void foo(char *out,
https://github.com/aaronpuchert commented:
I assume this is meant to imitate the GCC warning of the same name, which I
found pretty useful. Would be nice to have the same in Clang!
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits
@@ -435,6 +435,86 @@ bool Sema::ConstantFoldAttrArgs(const AttributeCommonInfo
,
return true;
}
+// Warn if parent function does not have builtin function format attribute.
+void Sema::DiagnoseMissingFormatAttributes(NamedDecl *FDecl,
+
https://github.com/aaronpuchert edited
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
oskarwirga wrote:
> Upon function entry the caller guarantees that it has probed the stack (e.g.
> performed a store) at some address [sp, #N], where0 <= N <= 1024.
I haven't been able to produce a minimal, sharable example as of yet, but I'm
encountering a runtime error associated with an
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
Changes
During constant evaluation when value-initializing a class if the base class
was default-initialized it would undue the previously zero-initialized class
members. This fixes the way we handle default
https://github.com/shafik created
https://github.com/llvm/llvm-project/pull/70150
During constant evaluation when value-initializing a class if the base class
was default-initialized it would undue the previously zero-initialized class
members. This fixes the way we handle default
https://github.com/urnathan created
https://github.com/llvm/llvm-project/pull/70149
An assert is better here.
>From 1120a9bd5490dba672898f6902e60e461792b711 Mon Sep 17 00:00:00 2001
From: Nathan Sidwell
Date: Tue, 24 Oct 2023 20:20:18 -0400
Subject: [PATCH] [clang][NFC] Assert not
https://github.com/benlangmuir commented:
Can you clarify how this bug occurs in terms of what information about the
header is stored that causes us to get the wrong module? It seems bad that
passing `nullptr` to `LookupFile` could cause incorrect behaviour and makes me
wonder if we need to
jhuber6 wrote:
> Can this stuff really be generic?
Obviously flags are going to be target dependent, but the actual form,
generation, and iteration of these can be generic. The idea is to put them all
into a single section such that we can filter out the ones that apply to
whatever runtime
shiltian wrote:
Can this stuff really be generic?
https://github.com/llvm/llvm-project/pull/70116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/70144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/70144
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 8add2113864618d310e01bdbb0cf16e1847eb9a8 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 2af5fc3dc871f0bc3bdfeff4ed2c08f6ccd089d5 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
jyknight wrote:
I think we can check whether it's been overridden more easily using an asm
alias like this (when libc++ is built under -fno-exceptions):
```
#include
#include
__attribute__((weak)) void* operator new(std::size_t size) {
void* mem = malloc(size);
if (!mem) abort();
https://github.com/spupyrev updated
https://github.com/llvm/llvm-project/pull/68617
>From ca0e18230d9b61aa8d65113d2ad0292f3b61c8a0 Mon Sep 17 00:00:00 2001
From: spupyrev
Date: Thu, 12 Oct 2023 17:32:36 -0700
Subject: [PATCH 1/4] review
---
llvm/lib/Transforms/Utils/CodeLayout.cpp | 130
https://github.com/spupyrev updated
https://github.com/llvm/llvm-project/pull/68617
>From ca0e18230d9b61aa8d65113d2ad0292f3b61c8a0 Mon Sep 17 00:00:00 2001
From: spupyrev
Date: Thu, 12 Oct 2023 17:32:36 -0700
Subject: [PATCH 1/4] review
---
llvm/lib/Transforms/Utils/CodeLayout.cpp | 130
s1Sharp wrote:
yes, issue with breaking after << is gone. I want to get your point about
functionality clang-format and implementing new option such as
"BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with
"owenca" point?
May be i can do something with this feature
@@ -55,6 +56,7 @@
#include "llvm/Target/TargetOptions.h"
#include "llvm/TargetParser/SubtargetFeature.h"
#include "llvm/TargetParser/Triple.h"
+#include "llvm/Transforms/HipStdPar/HipStdPar.h"
ellishg wrote:
Is this include used?
@@ -24,15 +24,38 @@
using namespace llvm;
-/// Get the __llvm_prf_cnts section.
-Expected getCountersSection(const object::ObjectFile )
{
+namespace llvm {
+// Deprecated. Use -profile-correlate=debug-info.
+cl::opt DebugInfoCorrelate(
+"debug-info-correlate",
+
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/70127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/69283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chris Carlon
Date: 2023-10-24T17:33:00-04:00
New Revision: 3935a29a3e8acf31bb1658265e8f9b977435f6bb
URL:
https://github.com/llvm/llvm-project/commit/3935a29a3e8acf31bb1658265e8f9b977435f6bb
DIFF:
https://github.com/llvm/llvm-project/commit/3935a29a3e8acf31bb1658265e8f9b977435f6bb.diff
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/70127
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/4] [clang][DFP] Add basic builtin type representation
https://github.com/HighCommander4 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/69775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: robozati
Date: 2023-10-24T17:29:43-04:00
New Revision: 2f3d4f6c9829bfc17a3e2d034286c03940d506ec
URL:
https://github.com/llvm/llvm-project/commit/2f3d4f6c9829bfc17a3e2d034286c03940d506ec
DIFF:
https://github.com/llvm/llvm-project/commit/2f3d4f6c9829bfc17a3e2d034286c03940d506ec.diff
https://github.com/HighCommander4 approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/69775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/70116
>From 35347649fe160073e73c3bca96506b6fd96d8a31 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 24 Oct 2023 15:27:21 -0500
Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/70124
None
>From 3b420fcb0a6d74dc034cfdf2d7b28e13e75f0e08 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 24 Oct 2023 13:51:50 -0700
Subject: [PATCH] Add a new attribute value for suppressing WebKit's unsafe
jamesETsmith wrote:
Sorry for the delay, just circling back to this. @philnik777 should I update
the `robust_against_*` tests in both `test/std/algorithms` and
`test/libcxx/algorithms/`?
Probably a simple follow-up question, but you're interested in adding
`ranges::iota` to the
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c780352de961371949333c3eb0d9d55fda39bf7f
93d72202bc5776483eddb9285ab384979caa85f4 --
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
goldsteinn wrote:
Rebased ontop of nikic's patch
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6411,6 +6411,41 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value
*Op0, Value *Op1,
return Constant::getNullValue(ReturnType);
break;
}
+ case Intrinsic::ptrmask: {
+if (isa(Op0) || isa(Op1))
+ return PoisonValue::get(Op0->getType());
+
+
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/67166
>From 9f9f1d20759f6a9d71f9131baa656bfb7d459095 Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Fri, 22 Sep 2023 08:21:21 -0500
Subject: [PATCH 1/6] [InstSimplify] Add tests for simplify `llvm.ptrmask`;
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch is a first step to remove dependencies on the OpenMPIRBuilder
for creating generic offloading entires. This patch changes no
functionality and merely moves the code around. In the
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/70116
Summary:
This patch is a first step to remove dependencies on the OpenMPIRBuilder
for creating generic offloading entires. This patch changes no
functionality and merely moves the code around. In the future the
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/70107
>From 9db10fc83ec3683b1d5b6f8606fc37a83fe224fa Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Tue, 24 Oct 2023 15:15:15 -0400
Subject: [PATCH 1/3] [C23] Use thread_local semantics
When implementing
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
@@ -4076,8 +4076,15 @@ void Parser::ParseDeclarationSpecifiers(
case tok::kw_thread_local:
if (getLangOpts().C23)
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
- isInvalid = DS.SetStorageClassSpecThread(DeclSpec::TSCS_thread_local,
Loc,
-
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-
@@ -5771,84 +5779,63 @@ OpenMPIRBuilder::createTeams(const LocationDescription
,
BasicBlock *AllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "teams.alloca");
+ // Generate the body of teams.
+ InsertPointTy AllocaIP(AllocaBB, AllocaBB->begin());
+ InsertPointTy
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/70107
>From 9db10fc83ec3683b1d5b6f8606fc37a83fe224fa Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Tue, 24 Oct 2023 15:15:15 -0400
Subject: [PATCH 1/2] [C23] Use thread_local semantics
When implementing
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-
@@ -389,10 +391,28 @@ template class LocalScope : public
VariableScope {
if (!Local.Desc->isPrimitive() && !Local.Desc->isPrimitiveArray()) {
this->Ctx->emitGetPtrLocal(Local.Offset, SourceInfo{});
this->Ctx->emitRecordDestruction(Local.Desc);
+
@@ -0,0 +1,27 @@
+// RUN: %clang_cc1 -triple i686-pc-linux-gnu -std=c23 -emit-llvm -o - %s |
FileCheck %s
+
+// Ensure that thread_local and _Thread_local emit the same codegen. See
+// https://github.com/llvm/llvm-project/issues/70068 for details.
+
+void func(void) {
+ static
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c23 %s -verify
+
+// Ensure that thread_local and _Thread_local are synonyms in C23 and both
+// restrict local variables to be explicitly static or extern.
+void func(void) {
+ // FIXME: it would be nice if the diagnostic
https://github.com/cor3ntin commented:
LGTM but I did not review the codegen tests.
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4076,8 +4076,15 @@ void Parser::ParseDeclarationSpecifiers(
case tok::kw_thread_local:
if (getLangOpts().C23)
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
- isInvalid = DS.SetStorageClassSpecThread(DeclSpec::TSCS_thread_local,
Loc,
-
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/70107
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
When implementing thread_local as a keyword in C23, we accidentally started
using C++11 thread_local semantics when using that keyword instead of using C11
_Thread_local semantics.
This oversight is
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/70107
When implementing thread_local as a keyword in C23, we accidentally started
using C++11 thread_local semantics when using that keyword instead of using C11
_Thread_local semantics.
This oversight is fixed
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/70018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2023-10-24T20:42:31+02:00
New Revision: 20d97adfd3e9ba305bf23b13749e2ae0af1069b0
URL:
https://github.com/llvm/llvm-project/commit/20d97adfd3e9ba305bf23b13749e2ae0af1069b0
DIFF:
https://github.com/llvm/llvm-project/commit/20d97adfd3e9ba305bf23b13749e2ae0af1069b0.diff
@@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) {
"int a; // This is unrelated"));
EXPECT_EQ("class C {\n"
" void f() { // This does something ..\n"
-" } // awesome..\n"
+"
@@ -3191,20 +3198,167 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments)
{
"}\n"
"// Comment";
-#if 0
- // FIXME: The following comment is aligned with the namespace comment.
verifyFormat("namespace A {\n"
" int Foo;\n"
HazardyKnusperkeks wrote:
What Owen says. And given that the modified lines were removed, maybe the
issue(s) are also gone?
To the review unrelated, why didn't it get the
@llvm/pr-subscribers-clang-format thing?
https://github.com/llvm/llvm-project/pull/69859
Overhatted wrote:
@MaskRay I can't add reviewers to the PR, not sure if I should tag the code
owner or if I should just wait.
Sorry to bother you in case I was meant to wait.
https://github.com/llvm/llvm-project/pull/69887
___
cfe-commits mailing
https://github.com/antangelo closed
https://github.com/llvm/llvm-project/pull/69676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: antangelo
Date: 2023-10-24T14:07:52-04:00
New Revision: f418319730341e9d41ce8ead6fbfe5603c343985
URL:
https://github.com/llvm/llvm-project/commit/f418319730341e9d41ce8ead6fbfe5603c343985
DIFF:
https://github.com/llvm/llvm-project/commit/f418319730341e9d41ce8ead6fbfe5603c343985.diff
1 - 100 of 325 matches
Mail list logo
