[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -20,6 +20,17 @@ // MCPU-SYNTACORE-SCR1-MAX: "-target-feature" "+zicsr" "-target-feature" "+zifencei" // MCPU-SYNTACORE-SCR1-MAX: "-target-abi" "ilp32" +// RUN: %clang --target=riscv64 -### -c %s 2>&1 -mcpu=xiangshan-nanhu | FileCheck -check-prefix=MCPU-XIANGSHAN-NANHU %s

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Can you separate out the basic processor definition (using NoSchedModel), and > a patch which adds the scheduling model? We can at least get the processor > definition landed while we iterate on the scheduling related pieces. > > edit: For clarity, I'm requesting that the

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -1360,6 +1372,9 @@ void XCOFFObjectWriter::assignAddressesAndIndices(const MCAsmLayout ) { // Calculate indices for undefined symbols. for (auto : UndefinedCsects) { +// AIX does not need to emit for the _$TLSML symbol. +if

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -649,6 +649,14 @@ void XCOFFObjectWriter::recordRelocation(MCAssembler , uint64_t ) { auto getIndex = [this](const MCSymbol *Sym, const MCSectionXCOFF *ContainingCsect) { +// Fixup relocation flag for

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -145,9 +160,78 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-25 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/70294 This PR adds the processor definition for XiangShan-NanHu, an open-source high-performance RISC-V processor. According to the official [documentation](https://xiangshan-doc.readthedocs.io/zh-cn/latest/arch/),

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-25 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-25 Thread via cfe-commits
@@ -650,6 +650,9 @@ Bug Fixes to AST Handling `Issue 64170 `_ - Fixed ``hasAnyBase`` not binding nodes in its submatcher. (`#65421 `_) +- Fixed a bug where

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-25 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl edited https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks for the cleanup! https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -3426,6 +3426,29 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">, MetaVarName<"">, HelpText<"Load pass plugin from a dynamic shared object file (only with new pass manager).">, MarshallingInfoStringVector>; +def mtocdata : Flag<["-"], "mtocdata">, +

[clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -93,6 +93,8 @@ def err_fe_backend_error_attr : def warn_fe_backend_warning_attr : Warning<"call to '%0' declared with 'warning' attribute: %1">, BackendInfo, InGroup; +def warn_toc_unsupported_type : Warning<"The -mtocdata option is ignored " MaskRay

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -525,6 +525,11 @@ // CHECK-VERIFY-INTERMEDIATE-CODE-NOT: "-disable-llvm-verifier" // CHECK-NO-VERIFY-INTERMEDIATE-CODE: "-disable-llvm-verifier" +// RUN: %clang -### -S -fverify-machine-code %s 2>&1 | FileCheck -check-prefix=CHECK-VERIFY-MACHINE-CODE %s +// RUN: %clang

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/70282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/70282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Language to String function (PR #69487)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: What is the intended use for this? https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f5063bf - [clang-tidy][NFC]refactor PreferMemberInitializerCheck for readability

2023-10-25 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-10-26T13:37:50+08:00 New Revision: f5063bf7edbb6368deb7354b4340eb62b8329d2e URL: https://github.com/llvm/llvm-project/commit/f5063bf7edbb6368deb7354b4340eb62b8329d2e DIFF: https://github.com/llvm/llvm-project/commit/f5063bf7edbb6368deb7354b4340eb62b8329d2e.diff

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -x c++ -std=c++14 -fsyntax-only -verify %s + +template +using Type = typename A::NestedType; // expected-error {{type 'float' cannot be used prior to '::' because it has no members}} + +template +void Func() { + using MyType = Type(); //

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Please next time add a detailed description to your PR. This is key for reviewers to fully understand at a glance what the fix is for. This is also key for users of git log to be able to understand changes at a glance without having to dig in. Folks often use git log to track

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From 227a494be06d8cb3b590c78f52f717bd781a8f0e Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder

[clang] [Clang][Sema] Skip RecordDecl when checking scope of declarations (PR #69432)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
@@ -19,4 +19,8 @@ void f2(void) { struct U u; } - +void f3(void) { shafik wrote: So unlike the original test case this one does not seem to cause a crash. Can we add a test case for that as well to verify we are fixing that issue as well.

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

2023-10-25 Thread Piotr Zegar via cfe-commits
@@ -14,3 +14,11 @@ unrelated type ``Z``. This rule is part of the `Type safety (Type.2) `_ profile from the C++ Core Guidelines. + +Options +--- + +.. option:: StrictMode + + When set to

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fd06155 - [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (#69242)

2023-10-25 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-10-26T07:16:25+02:00 New Revision: fd06155acb620b047fa1d586383f8738e17dbec3 URL: https://github.com/llvm/llvm-project/commit/fd06155acb620b047fa1d586383f8738e17dbec3 DIFF: https://github.com/llvm/llvm-project/commit/fd06155acb620b047fa1d586383f8738e17dbec3.diff

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] af07d7b - [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (#69501)

2023-10-25 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-10-26T07:11:01+02:00 New Revision: af07d7ba883b6e4921820d88b6679f294a0b9fa5 URL: https://github.com/llvm/llvm-project/commit/af07d7ba883b6e4921820d88b6679f294a0b9fa5 DIFF: https://github.com/llvm/llvm-project/commit/af07d7ba883b6e4921820d88b6679f294a0b9fa5.diff

[clang-tools-extra] [clang-tidy] Support functional cast in bugprone-dangling-handle (PR #69067)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 1097c71 - [clang-tidy] Support functional cast in bugprone-dangling-handle (#69067)

2023-10-25 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-10-26T07:10:39+02:00 New Revision: 1097c71dbeefaff0c353c90cb57bc07b6ede6383 URL: https://github.com/llvm/llvm-project/commit/1097c71dbeefaff0c353c90cb57bc07b6ede6383 DIFF: https://github.com/llvm/llvm-project/commit/1097c71dbeefaff0c353c90cb57bc07b6ede6383.diff

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From 5119368d060c886c6cb9c4209169604d191e6b4c Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
wsmoses wrote: @jdoerfert added the example test @efriedma-quic I've reworked the mechanism to not create a global variable within LLVM. Here this only applies to clang and enables two things: 1) Users of clang as a library can add a custom passbuilder callback by adding to codegenoptions 2)

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From ad9ed0260b1288efc3e8c7794f4de4592657474b Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 closed https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 13ea114 - [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (#69567)

2023-10-25 Thread via cfe-commits
Author: Rana Pratap Reddy Date: 2023-10-26T10:26:11+05:30 New Revision: 13ea1146a78ef1e00d88b50fd0f903f336751003 URL: https://github.com/llvm/llvm-project/commit/13ea1146a78ef1e00d88b50fd0f903f336751003 DIFF:

[clang] [Clang][Driver][LTO] Change the filename format for LTO'd stats file (PR #70242)

2023-10-25 Thread Fangrui Song via cfe-commits
MaskRay wrote: I can understand the rationale, but adding this special case feels stranger to me.. https://github.com/llvm/llvm-project/pull/70242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Matheus Izvekov via cfe-commits
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From b2006f46ebfd1da17014cf6c577da4700c355d00 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 12:09:15 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control machine instruction

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Matheus Izvekov via cfe-commits
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From 9f3711c112159c57becae105561bc988a0caaeb5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 26 Oct 2023 06:07:57 +0200 Subject: [PATCH 1/2] [clang][driver] remove accidentally added NoXarchOption

[clang] [RISCV] Support predefined macro __riscv_misaligned_[fast,avoid]. (PR #65756)

2023-10-25 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support predefined marcro __riscv_misaligned_[fast,avoid]. (PR #65756)

2023-10-25 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fa18827 - [Driver] Remove some misused NoXarchOption

2023-10-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-10-25T20:59:29-07:00 New Revision: fa18827754ebdd144f41fd4a889016c8ae1caf0c URL: https://github.com/llvm/llvm-project/commit/fa18827754ebdd144f41fd4a889016c8ae1caf0c DIFF: https://github.com/llvm/llvm-project/commit/fa18827754ebdd144f41fd4a889016c8ae1caf0c.diff

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

2023-10-25 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/70283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

2023-10-25 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/70283 >From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 25 Oct 2023 19:17:32 -0700 Subject: [PATCH 1/3] Update Bufferization.md --- mlir/docs/Bufferization.md |

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

2023-10-25 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/70283 >From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 25 Oct 2023 19:17:32 -0700 Subject: [PATCH 1/2] Update Bufferization.md --- mlir/docs/Bufferization.md |

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Chris Carlon (cjc25) Changes Similarly to commit 3935a29, forward spec file arguments to the driver if they appear in the compile database. Spec files can affect the include search path. fixes clangd/clangd#1410 --- Full diff:

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

2023-10-25 Thread Chris Carlon via cfe-commits
https://github.com/cjc25 created https://github.com/llvm/llvm-project/pull/70285 Similarly to commit 3935a29, forward spec file arguments to the driver if they appear in the compile database. Spec files can affect the include search path. fixes clangd/clangd#1410 >From

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-25 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 2e363be5e79e2aeeb219628db0c917e530e04d99 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/3] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-25 Thread Fangrui Song via cfe-commits
MaskRay wrote: > [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. The majority of patches don't add a trailing period in the title. https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list

[clang] f40ed13 - [Driver] Use StringSet::contains (NFC)

2023-10-25 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-25T20:14:35-07:00 New Revision: f40ed134b485db5f950f51a0d175caffe607b2f1 URL: https://github.com/llvm/llvm-project/commit/f40ed134b485db5f950f51a0d175caffe607b2f1 DIFF: https://github.com/llvm/llvm-project/commit/f40ed134b485db5f950f51a0d175caffe607b2f1.diff

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-25 Thread Fangrui Song via cfe-commits
@@ -1228,3 +1228,15 @@ // RUN: -march=rv64i_zve32x_zvkt1p0 -x c -E -dM %s \ // RUN: -o - | FileCheck --check-prefix=CHECK-ZVKT-EXT %s // CHECK-ZVKT-EXT: __riscv_zvkt 100{{$}} + +// RUN: %clang --target=riscv32-unknown-linux-gnu -march=rv32i -x c -E -dM %s \

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-25 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/68846 >From 07007c384ee57a20ad1dd1b0422c93152bb7f18e Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 17 Oct 2023 10:41:18 +0800 Subject: [PATCH] [Docs][Clang] DR status in cxx_status.html ---

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > While the change itself looks neat, I am curious about the reason how this > interact with modules. IIUC modules is incidental to the problem, it is just a way we run into an underlying issue that we are not dealing with full-expressions properly in this case.

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I think this change makes sense but I am not crazy about how we deal w/ full-expressions right now with these `FullExpressionRAII`, it feels very ad-hoc and it takes a bunch of time to understand why they are needed where they are.

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/69567 >From bd6e1449bd098d8348cf1402ad875e79cbc274b5 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Thu, 19 Oct 2023 12:52:13 +0530 Subject: [PATCH] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Please make sure you write a more complete description of the problem and why this solves the problem. The description is usually what goes into the git log and that is very useful for quickly understanding commits and tracking down problems. I know some folks edit the

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
@@ -15604,10 +15604,13 @@ bool Expr::EvaluateAsInitializer(APValue , const ASTContext , LValue LVal; LVal.set(VD); -if (!EvaluateInPlace(Value, Info, LVal, this, - /*AllowNonLiteralTypes=*/true) || -EStatus.HasSideEffects) -

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Oskar Wirga via cfe-commits
oskarwirga wrote: Apologies for still not being able to create a reproducible example I can share but what I am seeing is the stack probe write overwriting the value at the tip of the stack when I step debug execution: ``` str xzr, [sp, #-0x10 {var_70}]! {0x0} ... sturx8, [x29,

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-10-25 Thread Felix via cfe-commits
@@ -649,6 +649,14 @@ void XCOFFObjectWriter::recordRelocation(MCAssembler , uint64_t ) { auto getIndex = [this](const MCSymbol *Sym, const MCSectionXCOFF *ContainingCsect) { +// Fixup relocation flag for

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes Present shortcomings are that this only works for non-LTO builds, and that this new pass doesn't work quite the same as the IR verification flag, as it runs between every machine pass and is thus much

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 04ca1b6bd938646874b6518067f03515d88c3b5b e26572e5cf6ce85221bf25f74a1ace05240e910d --

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-25 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/70282 Present shortcomings are that this only works for non-LTO builds, and that this new pass doesn't work quite the same as the IR verification flag, as it runs between every machine pass and is thus much more

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-10-25 Thread via cfe-commits
https://github.com/knightXun edited https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-10-25 Thread via cfe-commits
https://github.com/knightXun edited https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

2023-10-25 Thread Chuanqi Xu via cfe-commits
@@ -219,6 +219,12 @@ class HeaderSearchOptions { unsigned ModulesValidateDiagnosticOptions : 1; + /// Whether to entirely skip writing diagnostic options. + unsigned ModulesSkipDiagnosticOptions : 1; + + /// Whether to entirely skip writing header search paths.

[clang] [clang][Sema] Resolving Panic Caused by Inconsistent Arguments in Var… (PR #70280)

2023-10-25 Thread via cfe-commits
https://github.com/knightXun edited https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Resolving Panic Caused by Inconsistent Arguments in Var… (PR #70280)

2023-10-25 Thread via cfe-commits
https://github.com/knightXun created https://github.com/llvm/llvm-project/pull/70280 …iadic Template Variables When template variables are variadic, sema may panic, potentially leading to a situation where the number of function variables exceeds the number of template variables. The sema

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Ed Maste via cfe-commits
https://github.com/emaste commented: overall looks fine, no objection from FreeBSD. one open question. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Ed Maste via cfe-commits
@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: why is this part here (before sparc64 is removed from

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Ed Maste via cfe-commits
@@ -163,9 +163,9 @@ // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-mfpu=softvfp" // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-matpcs" -// RUN: %clang --target=sparc-unknown-freebsd -### %s -fpic -no-integrated-as 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s -//

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Ed Maste via cfe-commits
@@ -247,12 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple , switch (os) { case llvm::Triple::Linux: return std::make_unique>(Triple, Opts); -case llvm::Triple::FreeBSD: emaste wrote: OK - there are no supported FreeBSD releases

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-10-25 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/70230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 04ca1b6 - [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (#70230)

2023-10-25 Thread via cfe-commits
Author: Congcong Cai Date: 2023-10-26T09:24:17+08:00 New Revision: 04ca1b6bd938646874b6518067f03515d88c3b5b URL: https://github.com/llvm/llvm-project/commit/04ca1b6bd938646874b6518067f03515d88c3b5b DIFF: https://github.com/llvm/llvm-project/commit/04ca1b6bd938646874b6518067f03515d88c3b5b.diff

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/69242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add StrictMode to cppcoreguidelines-pro-type-static-cast-downcast (PR #69529)

2023-10-25 Thread Congcong Cai via cfe-commits
@@ -14,3 +14,11 @@ unrelated type ``Z``. This rule is part of the `Type safety (Type.2) `_ profile from the C++ Core Guidelines. + +Options +--- + +.. option:: StrictMode + + When set to

[clang-tools-extra] [clang-tidy] Support functional cast in bugprone-dangling-handle (PR #69067)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/69067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-25 Thread Chen Zheng via cfe-commits
@@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { bool IsISA3_0 = false; bool IsISA3_1 = false; bool HasQuadwordAtomics = false; + bool FullRegisterNames = false; chenzheng1030 wrote: Using a target feature bit for

[clang] [OpenMP] Unify the min/max thread/teams pathways (PR #70273)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Johannes Doerfert (jdoerfert) Changes We used to pass the min/max threads/teams values through different paths from the frontend to the middle end. This simplifies the situation by passing the values once, only when

[clang] [OpenMP] Unify the min/max thread/teams pathways (PR #70273)

2023-10-25 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: This contains two other commits that are in two other PRs and will be committed first. https://github.com/llvm/llvm-project/pull/70273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (PR #70230)

2023-10-25 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/70230 >From 7ba5e132f50730b9e9cb392df7a2756066a7e909 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 23 Oct 2023 09:00:26 +0800 Subject: [PATCH 1/2] [clang-tidy]fix misc-unused-using-decls false positive

[clang] 265ed68 - [clang-format] Fix a JavaScript import order bug

2023-10-25 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-25T17:06:53-07:00 New Revision: 265ed6819409a9d76f112a601d48b971904921c8 URL: https://github.com/llvm/llvm-project/commit/265ed6819409a9d76f112a601d48b971904921c8 DIFF: https://github.com/llvm/llvm-project/commit/265ed6819409a9d76f112a601d48b971904921c8.diff

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG265ed6819409: [clang-format] Fix a JavaScript import order bug (authored by owenpan). Changed prior to commit:

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

2023-10-25 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis approved this pull request. Thanks for the fix and also adding a test LGTM  https://github.com/llvm/llvm-project/pull/70268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [mlir] Add config for PDL (PR #69927)

2023-10-25 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Can you expand on the motivation? Why is it a problem that PDL is always included? Your description isn’t very explicit on the impact. https://github.com/llvm/llvm-project/pull/69927 ___ cfe-commits mailing list

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-25 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm updated https://github.com/llvm/llvm-project/pull/70255 >From a561647c59119eb8da82e0468d9158e674102904 Mon Sep 17 00:00:00 2001 From: Stefan Pintilie Date: Wed, 25 Oct 2023 15:21:11 -0500 Subject: [PATCH 1/2] [PowerPC] Add an alias for -mregnames so that full

[clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-25 Thread via cfe-commits
EricWF wrote: @ldionne You've fully convinced me on this approach. Thank you for the explanation. https://github.com/llvm/llvm-project/pull/69498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Shilei Tian via cfe-commits
shiltian wrote: Can you add a small test to check the error message is correctly emitted? You can refer to those diagnosis tests under `clang/test/OpenMP`. https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list

[clang] [Clang][OpenMP] Emit unsupported directive error (PR #70233)

2023-10-25 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-25 Thread Brad Smith via cfe-commits
brad0 wrote: ping. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

2023-10-25 Thread Brad Smith via cfe-commits
brad0 wrote: ping. https://github.com/llvm/llvm-project/pull/69867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Pagan (ddpagan) Changes Fixed assertion failure Basic Block in function 'main' does not have terminator! label %land.end caused by premature setting of CodeGenIP upon entry to emitTargetDataCalls, where subsequent evaluation

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

2023-10-25 Thread David Pagan via cfe-commits
https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/70268 Fixed assertion failure Basic Block in function 'main' does not have terminator! label %land.end caused by premature setting of CodeGenIP upon entry to emitTargetDataCalls, where subsequent evaluation of

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay closed https://github.com/llvm/llvm-project/pull/70152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9237ce4 - [OpenMP 5.2] Deprecate old syntax of linear clause (#70152)

2023-10-25 Thread via cfe-commits
Author: Fazlay Rabbi Date: 2023-10-25T15:36:36-07:00 New Revision: 9237ce46138c311849e7de19a9a3ea930f1dbd6d URL: https://github.com/llvm/llvm-project/commit/9237ce46138c311849e7de19a9a3ea930f1dbd6d DIFF: https://github.com/llvm/llvm-project/commit/9237ce46138c311849e7de19a9a3ea930f1dbd6d.diff

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

2023-10-25 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Besides deps scanning, have you tried to enable these option to compile with > clang modules? I mean, if it is safe to enable such options at compilation > times, it looks a valid optimization for C++20 modules too. I did not. I suspect it won't show in profiles of

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/69975 >From 0270c76e779457486ee89f100db2b7151832c290 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 10 Oct 2023 14:16:13 -0700 Subject: [PATCH 1/4] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable ---

  1   2   3   4   5   6   >