[clang] [AArch64][SME2] Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics (PR #73188)

2023-11-28 Thread David Sherwood via cfe-commits
david-arm wrote: Should the file be renamed to acle_sme2_vector_selx2? This would make it consistent with the existing acle_sme2_vector_add.c file, which also has SVE-like instructions that only operate on SVE vectors.

[clang] [AArch64][SME2] Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics (PR #73188)

2023-11-28 Thread David Sherwood via cfe-commits
david-arm wrote: Should the file be renamed to acle_sme2_vector_selx4? This would make it consistent with the existing acle_sme2_vector_add.c file, which also has SVE-like instructions that only operate on SVE vectors.

[clang] [AArch64][SME2] Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics (PR #73188)

2023-11-28 Thread David Sherwood via cfe-commits
@@ -0,0 +1,384 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +sme2 -S -disable-O0-optnone -Werror -Wall

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
https://github.com/fodinabor edited https://github.com/llvm/llvm-project/pull/73756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (fodinabor) Changes As per https://github.com/AdaptiveCpp/AdaptiveCpp/issues/1256 - we are missing the `fma` long double variant for Cpp20 compact with MS-STL. See also #49853. - I'm wondering if we should include this for all

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-11-28 Thread via cfe-commits
https://github.com/fodinabor created https://github.com/llvm/llvm-project/pull/73756 As per https://github.com/AdaptiveCpp/AdaptiveCpp/issues/1256 - we are missing the `fma` long double variant for Cpp20 compact with MS-STL. See also #49853. -> I'm wondering if we should include this for all

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2023-11-28 Thread Dan Klishch via cfe-commits
DanShaders wrote: @MaskRay, I figured the alternative solution with the completely decoupled driver/frontend flags might actually be better than my initial approach. The only issue I see with it is that it requires `s/-mms-bitfields/-fms-layout-compatibility=microsoft/g` in quite a large

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/73709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes This would also fix the overlapping replacements below: $ clang-format a( #else #endif ) = []() { )} The new replacement overlaps with an existing replacement. New replacement: stdin: 38:+7:" " Existing

[clang] [clang-format] Finalize children after formatting them (PR #73753)

2023-11-28 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/73753 This would also fix the overlapping replacements below: $ clang-format a( #else #endif ) = []() { )} The new replacement overlaps with an existing replacement. New replacement: : 38:+7:" " Existing

[flang] [libcxx] [clang] [llvm] [libc] [compiler-rt] [msan] Intercept mallinfo2 (PR #73729)

2023-11-28 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/73729 >From 0aee7158c8edf7929ba6b0d324edde21eba30093 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 28 Nov 2023 17:04:44 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] [llvm] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-28 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71019 >From 2477ae87e7bb82b4551e42b8255dfe93dadff453 Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Thu, 2 Nov 2023 01:05:35 -0400 Subject: [PATCH 1/6] [AMDGPU] Add code model (#70760) test for amdgpu target.

[libc] [flang] [libcxxabi] [libcxx] [clang] [lld] [llvm] [clang-tools-extra] [lldb] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-11-28 Thread Brad Smith via cfe-commits
brad0 wrote: It would be nice to get this in so Flang is buildable. https://github.com/llvm/llvm-project/pull/73254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-28 Thread Jordan Rupprecht via cfe-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73067 >From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 17:28:30 -0800 Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: LGTM too. Please add a release note though https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables (PR #70280)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @knightXun code looks reasonable, ping me when you have tests and a release note :) https://github.com/llvm/llvm-project/pull/70280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Sema] Don't say "is declared here" for invalid template locations (PR #71264)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: That's a lot of repeated code. Should we have a "NoteTemplateLocation" function(s) of some sort that would do the check and the diag as appropriate? https://github.com/llvm/llvm-project/pull/71264 ___ cfe-commits mailing list

[llvm] [clang] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
NMiehlbradt wrote: @eugenis @ramosian-glider https://github.com/llvm/llvm-project/pull/73611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @tbaederr ping :) https://github.com/llvm/llvm-project/pull/70053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-11-28 Thread via cfe-commits
cor3ntin wrote: @shafik I'll let you have the final say :) https://github.com/llvm/llvm-project/pull/68540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,149 @@ +; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s MaskRay wrote: `llvm/test/Instrumentation/MemorySanitizer/PowerPC/vararg-ppc64.ll` does not follow the convention. I think the new test should follow other tests which follow

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
@@ -0,0 +1,149 @@ +; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s + +target datalayout = "e-m:e-i64:64-n32:64" +target triple = "powerpc64le--linux" + +define void @Store1(ptr %p, i8 %x) sanitize_memory { +entry: + store i8 %x, ptr %p + ret void +} + +;

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
https://github.com/NMiehlbradt updated https://github.com/llvm/llvm-project/pull/73611 >From 9fb1d97a4fd3e9a314780f5961d9c394cd6ae20c Mon Sep 17 00:00:00 2001 From: Nicholas Miehlbradt Date: Thu, 26 Oct 2023 00:45:22 + Subject: [PATCH 1/2] [KMSAN] Enable on PowerPC64 Enable

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -2485,12 +2485,12 @@ bool VarDecl::mightBeUsableInConstantExpressions(const ASTContext ) const { // In C++, const, non-volatile variables of integral or enumeration types // can be used in constant expressions. - if (getType()->isIntegralOrEnumerationType()) + if

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-28 Thread via cfe-commits
@@ -8857,7 +8894,9 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { if (NewVD->isConstexpr() && !T->isDependentType() && RequireLiteralType(NewVD->getLocation(), T, - diag::err_constexpr_var_non_literal)) { +

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2023-11-28 Thread via cfe-commits
@@ -0,0 +1,149 @@ +; RUN: opt < %s -S -msan-kernel=1 -passes=msan 2>&1 | FileCheck %s NMiehlbradt wrote: The other tests in the directory are named this way so I followed the convention. https://github.com/llvm/llvm-project/pull/73611

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

2023-11-28 Thread via cfe-commits
@@ -34,6 +34,19 @@ PrimType getIntPrimType(const InterpState ) { llvm_unreachable("Int isn't 16 or 32 bit?"); } +PrimType getLongPrimType(const InterpState ) { cor3ntin wrote: I don't suppose we can merge with getIntPrimType ?

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. I am happy with the lexing/sema changes. Please give @AaronBallman the opportunity to look at the code gen bits. https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Chuanqi Xu via cfe-commits
@@ -129,14 +129,48 @@ static SmallString<32> buildSuspendPrefixStr(CGCoroData , AwaitKind Kind) { return Prefix; } -static bool memberCallExpressionCanThrow(const Expr *E) { - if (const auto *CE = dyn_cast(E)) -if (const auto *Proto = -

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Missing a release note, otherwise LGTM https://github.com/llvm/llvm-project/pull/73691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
@@ -3639,6 +3639,10 @@ ExprResult Parser::ParseRequiresExpression() { // TryParseParameterDeclarationClause). cor3ntin wrote: Yeah, I think we can remove that https://github.com/llvm/llvm-project/pull/73691

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/73691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/73737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c6d6a57 - [clang][docs] Fix emphasis syntax in attribute documentation (#73737)

2023-11-28 Thread via cfe-commits
Author: Dan Klishch Date: 2023-11-29T05:34:31+01:00 New Revision: c6d6a57c697452e9320acea86f6631a92ab8017c URL: https://github.com/llvm/llvm-project/commit/c6d6a57c697452e9320acea86f6631a92ab8017c DIFF: https://github.com/llvm/llvm-project/commit/c6d6a57c697452e9320acea86f6631a92ab8017c.diff

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/73737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo , SourceLocation NameLoc, } } } -// If typo correction failed or was not performed, fall through -[[fallthrough]]; +Result.suppressDiagnostics(); +return nullptr; + case

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. That looks reasonable to me modulo nit and @shafik comments. Thanks for fixing this! https://github.com/llvm/llvm-project/pull/73018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-28 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/73018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/73709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Refactor suspend emit logic in coroutine codegen (PR #73564)

2023-11-28 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/73564 >From 5f5ebec41c90366bf3c7ec1ee53154ba7afcb849 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Wed, 22 Nov 2023 13:38:54 -0800 Subject: [PATCH] Refactor how we generate RValue vs LValue coawait

[clang] 649e811 - [C++20] [Modules] Handling capturing strucuted bindings

2023-11-28 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-11-29T11:45:31+08:00 New Revision: 649e8111a95ae0d8814576e9ca74823572ee404b URL: https://github.com/llvm/llvm-project/commit/649e8111a95ae0d8814576e9ca74823572ee404b DIFF: https://github.com/llvm/llvm-project/commit/649e8111a95ae0d8814576e9ca74823572ee404b.diff

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-28 Thread Pete Steinfeld via cfe-commits
psteinfeld wrote: > @mjklemm, after this change was integrated, the test Driver/ctofortran no > longer succeeds. This test gets run when you call `make check-flang`. I'm not > sure why the pre- and post-build checks did not run check-flang. I've submitted #73738 to fix this.

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders edited https://github.com/llvm/llvm-project/pull/73737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dan Klishch (DanShaders) Changes This causes CI failure for PRs updating `AttrDocs.td`. CC @llvm-beanz --- Full diff: https://github.com/llvm/llvm-project/pull/73737.diff 1 Files Affected: - (modified)

[clang] [clang][docs] Fix emphasis syntax in attribute documentation (PR #73737)

2023-11-28 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders created https://github.com/llvm/llvm-project/pull/73737 This causes CI failure for PRs updating `AttrDocs.td`. CC @llvm-beanz >From d30a251b2026065de3260f473b34c080102504e9 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Tue, 28 Nov 2023 22:04:47 -0500 Subject:

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 closed https://github.com/llvm/llvm-project/pull/73160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a294b5 - [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (#73160)

2023-11-28 Thread via cfe-commits
Author: Yuxuan Chen Date: 2023-11-28T19:04:29-08:00 New Revision: 4a294b5806417aa88c91aa05735b2d557ea5dfe5 URL: https://github.com/llvm/llvm-project/commit/4a294b5806417aa88c91aa05735b2d557ea5dfe5 DIFF: https://github.com/llvm/llvm-project/commit/4a294b5806417aa88c91aa05735b2d557ea5dfe5.diff

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Yuxuan Chen via cfe-commits
@@ -129,14 +129,48 @@ static SmallString<32> buildSuspendPrefixStr(CGCoroData , AwaitKind Kind) { return Prefix; } -static bool memberCallExpressionCanThrow(const Expr *E) { - if (const auto *CE = dyn_cast(E)) -if (const auto *Proto = -

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2023-11-28 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/71148 >From 1033441efd9e790bdb027824ffa1986cd09c06f2 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Fri, 3 Nov 2023 21:18:06 -0400 Subject: [PATCH 1/7] [clang] Stub out gcc_struct attribute This commit

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2023-11-28 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/71148 >From 1033441efd9e790bdb027824ffa1986cd09c06f2 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Fri, 3 Nov 2023 21:18:06 -0400 Subject: [PATCH 1/6] [clang] Stub out gcc_struct attribute This commit

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-11-28 Thread Yingwei Zheng via cfe-commits
@@ -75,7 +75,8 @@ define void @idom_sign_bit_check_edge_dominates_select(i64 %a, i64 %b) { ; CHECK: land.lhs.true: ; CHECK-NEXT:br label [[LOR_END:%.*]] ; CHECK: lor.rhs: -; CHECK-NEXT:[[CMP3_NOT:%.*]] = icmp eq i64 [[A]], [[B:%.*]] +; CHECK-NEXT:

[clang] [llvm] [ValueTracking] Add dominating condition support in computeKnownBits() (PR #73662)

2023-11-28 Thread Yingwei Zheng via cfe-commits
@@ -0,0 +1,74 @@ +//===- DomConditionCache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Chuanqi Xu via cfe-commits
@@ -129,14 +129,48 @@ static SmallString<32> buildSuspendPrefixStr(CGCoroData , AwaitKind Kind) { return Prefix; } -static bool memberCallExpressionCanThrow(const Expr *E) { - if (const auto *CE = dyn_cast(E)) -if (const auto *Proto = -

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM with nit. https://github.com/llvm/llvm-project/pull/73160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-28 Thread via cfe-commits
lifengxiang1025 wrote: > Yes, you're right. As an alternative can we use the symbol table and find > Bind = LOCAL to add the prefix before hashing? If we choose this method. I think we can't deal with the situation which one symbol is not local linkage type in thin compile, but will be

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/73160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Michael Spencer (Bigcheese) Changes `-ivfsoverlay` files are unused when building most modules. Enable removing them by, * adding a way to visit the filesystem tree with extensible RTTI to access each `RedirectingFileSystem`. *

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2023-11-28 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/73734 `-ivfsoverlay` files are unused when building most modules. Enable removing them by, * adding a way to visit the filesystem tree with extensible RTTI to access each `RedirectingFileSystem`. * Adding tracking

[clang] [clang][ASTImporter] IdentifierInfo of Attribute should be set using 'ToASTContext' (PR #73290)

2023-11-28 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/73290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3287ae8 - [clang][ASTImporter] IdentifierInfo of Attribute should be set using 'ToASTContext' (#73290)

2023-11-28 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-11-29T09:33:37+08:00 New Revision: 3287ae8f6520ef81570377c1fb4c7147782a13ef URL: https://github.com/llvm/llvm-project/commit/3287ae8f6520ef81570377c1fb4c7147782a13ef DIFF: https://github.com/llvm/llvm-project/commit/3287ae8f6520ef81570377c1fb4c7147782a13ef.diff

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/73730 >From 3e500c2a7c6b7895ebe292a1ed50e04409ba149c Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Tue, 28 Nov 2023 17:17:54 -0800 Subject: [PATCH 1/2] [Clang] Generate the GEP instead of adding AST nodes ---

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4eb421192479dbecae2621b868e55aaf6d945b02 3e500c2a7c6b7895ebe292a1ed50e04409ba149c --

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes This is an alternative to https://github.com/llvm/llvm-project/pull/73465. It generates the GEP directly. It's not tested well, but it might be a nicer solution rather than adding AST nodes. PTAL ---

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-11-28 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/73730 This is an alternative to https://github.com/llvm/llvm-project/pull/73465. It generates the GEP directly. It's not tested well, but it might be a nicer solution rather than adding AST nodes. PTAL >From

[libcxx] [clang-tools-extra] [libc] [flang] [lld] [compiler-rt] [llvm] [libunwind] [mlir] [clang] [libcxxabi] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-11-28 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/17] [libc++] Implement ranges::contains Differential

[libcxx] [clang-tools-extra] [libc] [flang] [lld] [compiler-rt] [llvm] [libunwind] [mlir] [clang] [libcxxabi] [lldb] Implement libcxx ranges contains (PR #70258)

2023-11-28 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: I've reopened the old one for you. Let's keep the discussion in one place. https://github.com/llvm/llvm-project/pull/70258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[lld] [clang] [llvm] [clang-tools-extra] [flang] [libunwind] [libc] [libcxxabi] [libcxx] [lldb] [compiler-rt] [mlir] [libc++] Implement ranges::contains (PR #65148)

2023-11-28 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 reopened https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang-tools-extra] [libcxx] [libcxxabi] [libc] [mlir] [flang] [libunwind] [compiler-rt] [clang] [lld] [libc++] Implement ranges::contains (PR #65148)

2023-11-28 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/17] [libc++] Implement ranges::contains Differential Revision:

[clang-tools-extra] [flang] [libunwind] [libcxx] [lldb] [llvm] [mlir] [compiler-rt] [clang] [libcxxabi] [lld] [libc] Implement libcxx ranges contains (PR #70258)

2023-11-28 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/70258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Extend isProto() to also cover LK_TextProto (PR #73582)

2023-11-28 Thread Owen Pan via cfe-commits
owenca wrote: This patch makes `isProto()` a convenience function like `isCpp()`, which doesn't prevent us from handling C++ and Objective-C separately when needed. Although `LK_TextProto` is not always formatted like `LK_Proto`, it's frequent enough (about 16 times in the codebase) that we

[clang] [compiler-rt] [mlir] [llvm] [flang] [clang-tools-extra] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-11-28 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 57a0416 - [clang][CodeGen] Handle template parameter objects with explicit address spaces (#69266)

2023-11-28 Thread via cfe-commits
Author: Alex Voicu Date: 2023-11-29T00:15:18Z New Revision: 57a0416e0e8ccd522d4242dbe5d0d7893864a10a URL: https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a DIFF: https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a.diff LOG:

[clang] [clang][DependencyScanner] Include the working directory in the context hash (PR #73719)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Spencer (Bigcheese) Changes The working directory is included in the PCM, but is not currently part of the context hash. This causes problems because different builds of a PCM with exactly the same command line can end up with

[clang] [clang][DependencyScanner] Include the working directory in the context hash (PR #73719)

2023-11-28 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/73719 The working directory is included in the PCM, but is not currently part of the context hash. This causes problems because different builds of a PCM with exactly the same command line can end up with different

[clang] [openmp] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

2023-11-28 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert edited https://github.com/llvm/llvm-project/pull/70612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

2023-11-28 Thread Johannes Doerfert via cfe-commits
@@ -14633,6 +14633,26 @@ StmtResult Sema::ActOnOpenMPTargetTeamsDirective(ArrayRef Clauses, } setFunctionHasBranchProtectedScope(); + bool HasBareClause = false; + bool HasThreadLimitClause = false; + bool HasNumTeamsClause = false; + OMPClause *BareClause = nullptr;

[openmp] [clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

2023-11-28 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. LG, see the nit. Also, add a runtime test with bare and verify we stick with values we otherwise would not, e.g., 1 teams and 1024 threads. https://github.com/llvm/llvm-project/pull/70612

[clang] Move documentation about -verify from a header to public docs (PR #73694)

2023-11-28 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: Would it make sense to document this more publicly? While it's designed to be an internal tool, it's really useful for people who want to make sure their library produces high quality diagnostics (e.g. `nodiscard`, `static_assert`s etc.). I'm sure you are aware that libc++

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread Jacob Lambert via cfe-commits
lamb-j wrote: For context, these changes reconcile differences between the upstream clang-offload-bundler and the AMD Fork offload bundler (https://github.com/RadeonOpenCompute/llvm-project/tree/amd-stg-open) https://github.com/llvm/llvm-project/pull/73709

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Jacob Lambert (lamb-j) Changes In this patch, we add support for checking a heterogeneous archive. We also significantly improve the clang-offload-bundler documentation. --- Patch is 23.51 KiB,

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j created https://github.com/llvm/llvm-project/pull/73709 In this patch, we add support for checking a heterogeneous archive. We also significantly improve the clang-offload-bundler documentation. >From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001

[clang] [clang-tools-extra] [libcxx] [mlir] [llvm] [flang] [libc] [compiler-rt] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-28 Thread Andres Villegas via cfe-commits
=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: avillega wrote: I've addressed the review comments so far, please re review and leave comments if any. https://github.com/llvm/llvm-project/pull/73194 ___

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-28 Thread Pete Steinfeld via cfe-commits
psteinfeld wrote: @mjklemm, after this change was integrated, the test Driver/ctofortran no longer succeeds. This test gets run when you call `make check-flang`. I'm not sure why the pre- and post-build checks did not run check-flang. https://github.com/llvm/llvm-project/pull/73124

[clang] [clang][DebugInfo] Revert to attaching DW_AT_const_value on static member declarations (PR #73626)

2023-11-28 Thread Michael Buch via cfe-commits
Michael137 wrote: > Looks like LLDB linux buildbot isn't happy, checking... Fix in https://github.com/llvm/llvm-project/pull/73707 https://github.com/llvm/llvm-project/pull/73626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix error in gcc 7.5. on arm32-linux (PR #73702)

2023-11-28 Thread Steven Johnson via cfe-commits
https://github.com/steven-johnson closed https://github.com/llvm/llvm-project/pull/73702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/73160 >From dbd06bc001c0e00436fcacac231d9d80b443edf4 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 21 Nov 2023 21:38:12 -0800 Subject: [PATCH 1/3] add checks for nested noexcept in cxxtempexpr ---

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Yuxuan Chen via cfe-commits
yuxuanchen1997 wrote: @ChuanqiXu9, I updated the check like you suggested, and it should look much nicer now. The only caveat is that the `children()` call isn't going to cover the implicit destructor call in a `CXXBindTemporaryExpr`. That pattern matching case is here to stay and likely

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

2023-11-28 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/73160 >From dbd06bc001c0e00436fcacac231d9d80b443edf4 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 21 Nov 2023 21:38:12 -0800 Subject: [PATCH 1/2] add checks for nested noexcept in cxxtempexpr ---

[clang] [OpenMP] Support for `nothing` in `metadirective` (PR #73690)

2023-11-28 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/73690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Support for `nothing` in `metadirective` (PR #73690)

2023-11-28 Thread Alexey Bataev via cfe-commits
@@ -12,7 +12,6 @@ int mixed() { x=d; } -// expected-error@+2 {{#pragma omp nothing' cannot be an immediate substatement}} alexey-bataev wrote: Ah, ok, I see. Then yes, this check must be removed. https://github.com/llvm/llvm-project/pull/73690

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-28 Thread Michael Klemm via cfe-commits
mjklemm wrote: Thanks all for your reviews and the all the feedback you have provided! Much appreciated! https://github.com/llvm/llvm-project/pull/73124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Lex] Fix parsing of nested requirement to prevent flowing off the end of token stream (PR #73691)

2023-11-28 Thread Luís Ferreira via cfe-commits
https://github.com/ljmf00 approved this pull request. https://github.com/llvm/llvm-project/pull/73691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix error in gcc 7.5. on arm32-linux (PR #73702)

2023-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Johnson (steven-johnson) Changes Apparently the gcc 7.5 compiler for arm32-linux fails to implicitly convert to std::optional; this inserts an explicit constructor to unbreak that compiler. [Injection from

[clang] [clang] Fix error in gcc 7.5. on arm32-linux (PR #73702)

2023-11-28 Thread Steven Johnson via cfe-commits
https://github.com/steven-johnson created https://github.com/llvm/llvm-project/pull/73702 Apparently the gcc 7.5 compiler for arm32-linux fails to implicitly convert to std::optional; this inserts an explicit constructor to unbreak that compiler. [Injection from

[clang] [OpenMP] Support for `nothing` in `metadirective` (PR #73690)

2023-11-28 Thread Deepak Eachempati via cfe-commits
@@ -12,7 +12,6 @@ int mixed() { x=d; } -// expected-error@+2 {{#pragma omp nothing' cannot be an immediate substatement}} dreachem wrote: As I understand it, the `nothing` directive is not the equivalent of a null statement. It is an "ignore me"

  1   2   3   4   >