[lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 58bdef2be75263a9b6bf93faf3baccc76e31e082 c137cd0ba81f82dbca2feb01bb8d088e42f0c524 --

[lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-lldb Author: Jeevan Ghimire (jeevanghimire) Changes removing using namespace std; and assigning the fully qualified name for better naming in codebase --- Full diff: https://github.com/llvm/llvm-project/pull/74814.diff 2

[lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-07 Thread Jeevan Ghimire via cfe-commits
https://github.com/jeevanghimire created https://github.com/llvm/llvm-project/pull/74814 removing using namespace std; and assigning the fully qualified name for better naming in codebase >From c137cd0ba81f82dbca2feb01bb8d088e42f0c524 Mon Sep 17 00:00:00 2001 From: Jeevan Ghimire Date: Fri,

[clang] [clang-tools-extra] [compiler-rt] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Mingming Liu via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [clang-tools-extra] [compiler-rt] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Mingming Liu via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[llvm] [clang] [compiler-rt] [clang-tools-extra] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: done. Sorry about leaving debugging-only stuff in a commit. https://github.com/llvm/llvm-project/pull/74008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [Sema] Implement support for -Wformat-signedness (PR #74440)

2023-12-07 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 updated https://github.com/llvm/llvm-project/pull/74440 >From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001 From: Karl-Johan Karlsson Date: Tue, 5 Dec 2023 10:03:00 +0100 Subject: [PATCH 1/3] [Sema] Implement support for -Wformat-signedness In

[clang] [clang][ASTImporter] Support Importer of BuiltinBitCastExpr (PR #74813)

2023-12-07 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/74813 >From 0cab02331a5f1eb85649ab381d73ddb71d354b5b Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 8 Dec 2023 15:26:01 +0800 Subject: [PATCH] [clang][ASTImporter] Support Importer of BuiltinBitCastExpr ---

[clang] [clang][ASTImporter] Support Importer of BuiltinBitCastExpr (PR #74813)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes This patch aims to fix the [crash](https://github.com/llvm/llvm-project/issues/74774) --- Full diff: https://github.com/llvm/llvm-project/pull/74813.diff 2 Files Affected: - (modified)

[clang] [clang][ASTImporter] Support Importer of BuiltinBitCastExpr (PR #74813)

2023-12-07 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/74813 This patch aims to fix the [crash](https://github.com/llvm/llvm-project/issues/74774) >From 49ec0838ecef753d86562ce4c12b3d84000a859e Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 8 Dec 2023 15:26:01 +0800

[compiler-rt] [llvm] [clang-tools-extra] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread David Li via cfe-commits
david-xl wrote: > > > > > > David says the itanium remapper file was only used once during gcc > > > > > > to llvm transition, so not relevant here. > > > > > > > > > > > > > > > I believe it was actually for the libstdc++ to libc++ transition (see > > > > > https://reviews.llvm.org/D51247

[clang] [Clang][ARM] support arm target attribute, and warning for bad typo (PR #74812)

2023-12-07 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/74812 >From 3e4b7b9da50d742b7bfafa04cdf0c3a64d0d1b9e Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Fri, 8 Dec 2023 14:29:33 +0800 Subject: [PATCH] feat: support arm target attribute, and warning for bad typo ---

[clang] [Clang][ARM] support arm target attribute, and warning for bad typo (PR #74812)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 28a78e2a4a2c358900aaac1a1eb9efce17a7f5a5 8a84eaf11bb76aba7db5243390f246d40b3f9630 --

[clang] [Clang][ARM] support arm target attribute, and warning for bad typo (PR #74812)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-arm Author: None (hstk30-hw) Changes This adds support under ARM for the target("..") attributes like AArch64 https://reviews.llvm.org/D133848 . And warning for bad typo for "arch=". --- Full diff:

[clang] [Clang][ARM] support arm target attribute, and warning for bad typo (PR #74812)

2023-12-07 Thread via cfe-commits
https://github.com/hstk30-hw created https://github.com/llvm/llvm-project/pull/74812 This adds support under ARM for the target("..") attributes like AArch64 https://reviews.llvm.org/D133848 . And warning for bad typo for "arch=". >From 8a84eaf11bb76aba7db5243390f246d40b3f9630 Mon Sep 17

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/74782 >From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Dec 2023 15:15:16 -0800 Subject: [PATCH 1/3] [clang][lex] Fix non-portability diagnostics with

[clang] [Clang][Builtin] add __builtin_exit (PR #74803)

2023-12-07 Thread via cfe-commits
https://github.com/W-50243 updated https://github.com/llvm/llvm-project/pull/74803 >From bcaaab24a927624669200113857fee842103d325 Mon Sep 17 00:00:00 2001 From: W-50243 Date: Thu, 7 Dec 2023 19:42:29 +0800 Subject: [PATCH 1/2] [Clang][Builtin] add __builtin_exit ---

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes https://reviews.llvm.org/D154014 addes glob support and enables it when `#!special-case-list-v2` is the first line. This patch makes the glob support the default (faster than regex after

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-07 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/74809 https://reviews.llvm.org/D154014 addes glob support and enables it when `#!special-case-list-v2` is the first line. This patch makes the glob support the default (faster than regex after

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/74782 >From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Dec 2023 15:15:16 -0800 Subject: [PATCH 1/2] [clang][lex] Fix non-portability diagnostics with

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: It seems reasonable. You may consider adding test to clang/test/Driver/autocomplete.c https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Builtin] add __builtin_exit (PR #74803)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (W-50243) Changes Add __builtin_exit in `clang/include/clang/Basic/Builtins.def` . It works perfectly on arm64be and arm64le. --- Full diff: https://github.com/llvm/llvm-project/pull/74803.diff 2 Files Affected: - (modified)

[clang] [Clang][Builtin] add __builtin_exit (PR #74803)

2023-12-07 Thread via cfe-commits
https://github.com/W-50243 created https://github.com/llvm/llvm-project/pull/74803 Add __builtin_exit in `clang/include/clang/Basic/Builtins.def` . It works perfectly on arm64be and arm64le. >From bcaaab24a927624669200113857fee842103d325 Mon Sep 17 00:00:00 2001 From: W-50243 Date: Thu, 7

[clang] [openmp] [OpenMP][Fix] Fix test initializations (PR #74797)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4162a9bca42a1152cdf4ae92ff7b90351c10f332 144d2ad42f5b8c9b89881d6238684cfd799a8270 --

[clang] [openmp] [OpenMP][Fix] Fix test initializations (PR #74797)

2023-12-07 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 closed https://github.com/llvm/llvm-project/pull/74797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [OpenMP][Fix] Fix test initializations (PR #74797)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Gheorghe-Teodor Bercea (doru1004) Changes Make sure arrays used in test are properly initialized. --- Patch is 20.59 KiB, truncated to 20.00 KiB below, full version:

[openmp] [clang] [OpenMP][Fix] Fix test initializations (PR #74797)

2023-12-07 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 created https://github.com/llvm/llvm-project/pull/74797 Make sure arrays used in test are properly initialized. >From 6712acd1175d1d6d55ce261651a543872a221c9a Mon Sep 17 00:00:00 2001 From: Doru Bercea Date: Wed, 15 Nov 2023 11:07:09 -0500 Subject: [PATCH 1/2] Fix

[clang] [clang][analyzer] Support `fflush` in the StreamChecker (PR #74296)

2023-12-07 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/74296 >From 65ce18117f99056aafcf58151b64f4243f4d5e26 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 4 Dec 2023 15:51:20 +0800 Subject: [PATCH 1/3] [clang][analyzer] Support `fflush` in the StreamChecker ---

[compiler-rt] [clang-tools-extra] [clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Teresa Johnson via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [clang-format][NFC] Clean up the driver and getStyle() in Format.cpp (PR #74794)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/74794.diff 2 Files Affected: - (modified) clang/lib/Format/Format.cpp (+48-47) - (modified) clang/tools/clang-format/ClangFormat.cpp (+17-23)

[clang] [clang-format][NFC] Clean up the driver and getStyle() in Format.cpp (PR #74794)

2023-12-07 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/74794 None >From fb239719267ec97905ebb339176b5f7015de04eb Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 7 Dec 2023 17:42:45 -0800 Subject: [PATCH] [clang-format][NFC] Clean up ClangFormat.cpp and getStyle() in

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2023-12-07 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w closed https://github.com/llvm/llvm-project/pull/74676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e1f191 - [clang][PP] Add extension to predefine target OS macros (#74676)

2023-12-07 Thread via cfe-commits
Author: Zixu Wang Date: 2023-12-07T17:40:58-08:00 New Revision: 6e1f19168bca7e3bd4eefda50ba03eac8441dbbf URL: https://github.com/llvm/llvm-project/commit/6e1f19168bca7e3bd4eefda50ba03eac8441dbbf DIFF: https://github.com/llvm/llvm-project/commit/6e1f19168bca7e3bd4eefda50ba03eac8441dbbf.diff

[clang] [clang] Add partial-inlining options (PR #73210)

2023-12-07 Thread via cfe-commits
Jolyon0202 wrote: This patch is used to adapt to many projects using gcc. https://github.com/llvm/llvm-project/pull/73210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c502a81 - [HLSL] Add helpers to simplify HLSL resource type declarations. NFC

2023-12-07 Thread Justin Bogner via cfe-commits
Author: Justin Bogner Date: 2023-12-07T17:31:35-08:00 New Revision: c502a81b439b68cb029e16ca9d444d897b5e7727 URL: https://github.com/llvm/llvm-project/commit/c502a81b439b68cb029e16ca9d444d897b5e7727 DIFF: https://github.com/llvm/llvm-project/commit/c502a81b439b68cb029e16ca9d444d897b5e7727.diff

[clang] [OpenACC] Implement 'wait' construct parsing (PR #74752)

2023-12-07 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/74752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] df3db03 - [OpenACC] Implement 'wait' construct parsing (#74752)

2023-12-07 Thread via cfe-commits
Author: Erich Keane Date: 2023-12-07T17:29:18-08:00 New Revision: df3db035d60ca2471d46166c08208c12307d20ef URL: https://github.com/llvm/llvm-project/commit/df3db035d60ca2471d46166c08208c12307d20ef DIFF: https://github.com/llvm/llvm-project/commit/df3db035d60ca2471d46166c08208c12307d20ef.diff

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
ebiggers wrote: The `clang-format` warning is from existing code, not from this pull request. https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
ebiggers wrote: > To be safe, I think we should have an experimental tag to guard the > intrinsics, while the extension is ratified and do indeed don't need the > experimental. This is already part of the pull request. I've updated the commit message and pull request description to make it

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-07 Thread Fangrui Song via cfe-commits
@@ -2700,19 +2701,18 @@ bool UnwindCursor::setInfoForSigReturn(Registers_arm64 &) { // [1] https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/vdso/sigreturn.S const pint_t pc = static_cast(this->getReg(UNW_REG_IP)); // The PC might contain an invalid

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
@@ -485,7 +485,7 @@ class RVVIntrinsic { // RVVRequire should be sync'ed with target features, but only // required features used in riscv_vector.td. -enum RVVRequire : uint16_t { +enum RVVRequire : unsigned int { ebiggers wrote: Done. Note, I also changed

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0808be47b8fbf0307d0b6f2eb45ba9bfe1b3ae65 a1e8500757c8fccf819b711414453323bd65b80b --

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
@@ -370,6 +371,10 @@ bool RISCVTargetInfo::handleTargetFeatures(std::vector , ISAInfo = std::move(*ParseResult); } + if (std::find(Features.begin(), Features.end(), "+experimental") != ebiggers wrote: Done using `llvm::is_contained`

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
@@ -28,6 +28,7 @@ class RISCVTargetInfo : public TargetInfo { protected: std::string ABI, CPU; std::unique_ptr ISAInfo; + bool HasExperimental = false; ebiggers wrote: Done https://github.com/llvm/llvm-project/pull/74213

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-07 Thread Eric Biggers via cfe-commits
https://github.com/ebiggers edited https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-07 Thread Fangrui Song via cfe-commits
MaskRay wrote: Current behavior: ``` % clang --target=x86_64-linux-musl -fms-volatile -c a.cc clang: warning: argument unused during compilation: '-fms-volatile' [-Wunused-command-line-argument] % clang --target=x86_64-windows -fms-volatile -c a.cc clang: warning: argument unused during

[llvm] [libcxxabi] [lldb] [compiler-rt] [clang-tools-extra] [clang] [openmp] [flang] [mlir] [libcxx] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace sub register (

2023-12-07 Thread via cfe-commits
DianQK wrote: > Hello. I think that if you removed undef from the first instruction the > result would still be incorrect. With: > > ``` > $x8 = ORRXrs $xzr, $x0, 0, implicit $w0 > $w8 = ORRWrs $wzr, $w0, 0, implicit-def $x8 > ``` I'm also curious about it, but this transformation has been

[clang-tools-extra] [compiler-rt] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Ellis Hoag via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Jordan R AW (ajordanr-google) Changes process_vm_readv is generally considered dangerous from a syscall perspective, and is frequently blanket banned in seccomp filters such as those in Chromium and ChromiumOS. We can get the same

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-07 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google created https://github.com/llvm/llvm-project/pull/74791 process_vm_readv is generally considered dangerous from a syscall perspective, and is frequently blanket banned in seccomp filters such as those in Chromium and ChromiumOS. We can get the same behaviour

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Eli Friedman (efriedma-quic) Changes The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eli Friedman (efriedma-quic) Changes The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This patch

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-07 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/74790 The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This patch adds

[llvm] [clang-tools-extra] [compiler-rt] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Ellis Hoag via cfe-commits
ellishg wrote: Please remember to remove the binaries that are not used. https://github.com/llvm/llvm-project/pull/74008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [compiler-rt] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-07 Thread Ellis Hoag via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-07 Thread Reid Kleckner via cfe-commits
rnk wrote: > @rnk -- what's the best way to check for compilation with microsoft's > stardard C++ library? If Clang is compiling with the MSVC STL headers, it should be defining `_MSC_VER`, usually `-fms-compatibilty` has to be enabled to compile MSVC STL headers. However, I searched, and

[clang] [NFC] Remove unneeded nullptr checks after cast<> (PR #74674)

2023-12-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/74674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0808be4 - [NFC] Remove unneeded nullptr checks after cast<> (#74674)

2023-12-07 Thread via cfe-commits
Author: Mike Rice Date: 2023-12-07T16:20:22-08:00 New Revision: 0808be47b8fbf0307d0b6f2eb45ba9bfe1b3ae65 URL: https://github.com/llvm/llvm-project/commit/0808be47b8fbf0307d0b6f2eb45ba9bfe1b3ae65 DIFF: https://github.com/llvm/llvm-project/commit/0808be47b8fbf0307d0b6f2eb45ba9bfe1b3ae65.diff

[flang] [openmp] [compiler-rt] [libc] [lld] [lldb] [clang-tools-extra] [libcxx] [clang] [mlir] [llvm] [libcxxabi] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via cfe-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74655 >From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 6 Dec 2023 14:03:51 +0100 Subject: [PATCH 01/11] [libc++] Fix `take_view::__sentinel`'s

[clang] [clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread Haopeng Liu via cfe-commits
https://github.com/haopliu edited https://github.com/llvm/llvm-project/pull/74777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-07 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. %T is deprecated in lit. You may want to migrate other `%T` related to AMDGPU. https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CUDA][Win32] Add `fma(long double,..)` to math forward declares. (PR #73756)

2023-12-07 Thread Artem Belevich via cfe-commits
Artem-B wrote: I'm not familiar enough with MSVC. @rnk -- what's the best way to check for compilation with microsoft's stardard C++ library? https://github.com/llvm/llvm-project/pull/73756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Steven Wu via cfe-commits
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Steven Wu via cfe-commits
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. LGTM with small comments. https://github.com/llvm/llvm-project/pull/74782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/74782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
https://github.com/haopliu updated https://github.com/llvm/llvm-project/pull/74777 >From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001 From: Haopeng Liu Date: Thu, 7 Dec 2023 21:25:33 + Subject: [PATCH 1/5] Add size filter for stack auto init ---

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix tests clang-offload-bundler-zlib/zstd.c (PR #74504)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: fix another two tests by https://github.com/llvm/llvm-project/pull/74783 https://github.com/llvm/llvm-project/pull/74504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Use %t in output file name as %T is non-unique. --- Full diff: https://github.com/llvm/llvm-project/pull/74783.diff 2 Files Affected: - (modified) clang/test/Driver/hip-offload-compress-zlib.hip

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes Use %t in output file name as %T is non-unique. --- Full diff: https://github.com/llvm/llvm-project/pull/74783.diff 2 Files Affected: - (modified)

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/74782 >From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Dec 2023 15:15:16 -0800 Subject: [PATCH] [clang][lex] Fix non-portability diagnostics with absolute

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-07 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/74783 Use %t in output file name as %T is non-unique. >From d95bc5d805a5ee267959ee342bc40b02c5fa4c22 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 7 Dec 2023 18:25:33 -0500 Subject: [PATCH] Fix tests

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes The existing code incorrectly assumes that `Path` can be empty. It can't, it always contains at least `` or `"`. On Unix, this patch fixes an incorrect diagnostics that instead of `"/Users/blah"`

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/74782 The existing code incorrectly assumes that `Path` can be empty. It can't, it always contains at least `<` or `"`. On Unix, this patch fixes an incorrect diagnostics that instead of `"/Users/blah"`

[clang] Fix tests clang-offload-bundler-zlib/zstd.c (PR #74504)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > I got this fail just now after doing a pull. > > ``` > FAIL: Clang :: Driver/hip-offload-compress-zstd.hip (477 of 1078) > TEST 'Clang :: Driver/hip-offload-compress-zstd.hip' > FAILED > Exit Code: 1 > > Command Output (stderr): > --

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
https://github.com/haopliu updated https://github.com/llvm/llvm-project/pull/74777 >From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001 From: Haopeng Liu Date: Thu, 7 Dec 2023 21:25:33 + Subject: [PATCH 1/4] Add size filter for stack auto init ---

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
https://github.com/haopliu updated https://github.com/llvm/llvm-project/pull/74777 >From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001 From: Haopeng Liu Date: Thu, 7 Dec 2023 21:25:33 + Subject: [PATCH 1/3] Add size filter for stack auto init ---

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-07 Thread Bill Wendling via cfe-commits
@@ -4022,8 +4169,36 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const ArraySubscriptExpr *E, ArrayLV = EmitArraySubscriptExpr(ASE, /*Accessed*/ true); else ArrayLV = EmitLValue(Array); + auto *Idx = EmitIdxAfterBase(/*Promote*/true); +if

[clang] bfd41c3 - [LinkerWrapper][Obvious] Fix missing use of texture data type

2023-12-07 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-12-07T16:55:14-06:00 New Revision: bfd41c3f8cc70bd65461a6d767f55c14d72150d9 URL: https://github.com/llvm/llvm-project/commit/bfd41c3f8cc70bd65461a6d767f55c14d72150d9 DIFF: https://github.com/llvm/llvm-project/commit/bfd41c3f8cc70bd65461a6d767f55c14d72150d9.diff

[clang] Fix tests clang-offload-bundler-zlib/zstd.c (PR #74504)

2023-12-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I got this fail just now after doing a pull. ``` FAIL: Clang :: Driver/hip-offload-compress-zstd.hip (477 of 1078) TEST 'Clang :: Driver/hip-offload-compress-zstd.hip' FAILED Exit Code: 1 Command Output (stderr): -- RUN: at line 7: rm

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
https://github.com/haopliu edited https://github.com/llvm/llvm-project/pull/74777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to msvc::no_unique_address causing assert when used with __declspec(empty_bases) (PR #74776)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c6805ea44af3bfd57e6b46f2d65ec6b0d0d6c64a c3dedfd535f037fb54a8e04640f9332e655a9a7d --

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c6805ea44af3bfd57e6b46f2d65ec6b0d0d6c64a 00af66353d938c6ce59dada49c8bededb06ac4fc --

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (haopliu) Changes Add a clang flag, "-ftrivial-auto-var-init-size-bound=" so that clang skips auto-init a variable if its size exceeds the flag setting. Note that this skipping doesn't apply to runtime-sized variables like

[clang] Fix to msvc::no_unique_address causing assert when used with __declspec(empty_bases) (PR #74776)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amy Huang (amykhuang) Changes no_unique_address makes it possible for a class to be empty and have non-zero virtual size, so just remove this assert. Bug: https://github.com/llvm/llvm-project/issues/74442 --- Full diff:

[clang] Add size filter for stack auto init (PR #74777)

2023-12-07 Thread via cfe-commits
https://github.com/haopliu created https://github.com/llvm/llvm-project/pull/74777 Add a clang flag, "-ftrivial-auto-var-init-size-bound=" so that clang skips auto-init a variable if its size exceeds the flag setting. Note that this skipping doesn't apply to runtime-sized variables like VLA.

[clang] Fix to msvc::no_unique_address causing assert when used with __declspec(empty_bases) (PR #74776)

2023-12-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/74776 no_unique_address makes it possible for a class to be empty and have non-zero virtual size, so just remove this assert. Bug: https://github.com/llvm/llvm-project/issues/74442 >From

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt updated https://github.com/llvm/llvm-project/pull/71300 >From 3be36c6100801195f8f1f5167bdaa289bc8cb175 Mon Sep 17 00:00:00 2001 From: Richard Dzenis Date: Thu, 20 Jul 2023 00:18:50 +0300 Subject: [PATCH 1/2] [clang-cl] Add support for [[msvc::constexpr]] C++11

[compiler-rt] [clang] [HIP] support 128 bit int division (PR #71978)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > Would it be feasible to consider switching to the new offloading driver > > mode and really link with the library instead? It may be a conveniently > > isolated use case with little/no existing users that would disrupt. > > I've thought a reasonable amount about a

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-07 Thread Eli Friedman via cfe-commits
@@ -4022,8 +4169,36 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const ArraySubscriptExpr *E, ArrayLV = EmitArraySubscriptExpr(ASE, /*Accessed*/ true); else ArrayLV = EmitLValue(Array); + auto *Idx = EmitIdxAfterBase(/*Promote*/true); +if

[clang] [Clang][C++20] Implement constexpr std::bit_cast for bit-fields (& [Sema] Print more static_assert exprs) (PR #74775)

2023-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (sethp) Changes After this commit, clang permits constructions like: ```c++ struct bits { unsigned char : 7; unsigned char flag : 1; } static_assert(std::bit_castbits(0x80).flag); // succeeds on little-endian systems ``` A

[clang] [Clang][C++20] Implement constexpr std::bit_cast for bit-fields (& [Sema] Print more static_assert exprs) (PR #74775)

2023-12-07 Thread via cfe-commits
https://github.com/sethp created https://github.com/llvm/llvm-project/pull/74775 After this commit, clang permits constructions like: ```c++ struct bits { unsigned char : 7; unsigned char flag : 1; } static_assert(std::bit_cast(0x80).flag); // succeeds on little-endian systems ``` A

[compiler-rt] [clang] [HIP] support 128 bit int division (PR #71978)

2023-12-07 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Would it be feasible to consider switching to the new offloading driver mode > and really link with the library instead? It may be a conveniently isolated > use case with little/no existing users that would disrupt. It is needed by an important HIP app for which the new

[libcxx] [llvm] [lldb] [lld] [clang-tools-extra] [flang] [compiler-rt] [libcxxabi] [clang] [mlir] [libc] [openmp] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-07 Thread Jakub Mazurkiewicz via cfe-commits
@@ -183,7 +183,7 @@ class take_view<_View>::__sentinel { template requires sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> _LIBCPP_HIDE_FROM_ABI - friend constexpr bool operator==(const _Iter<_Const>& __lhs, const __sentinel& __rhs) { + friend

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt edited https://github.com/llvm/llvm-project/pull/71300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
@@ -2861,8 +2861,8 @@ def warn_cxx17_compat_constexpr_local_var_no_init : Warning< "is incompatible with C++ standards before C++20">, InGroup, DefaultIgnore; def ext_constexpr_function_never_constant_expr : ExtWarn< - "%select{constexpr|consteval}1

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
@@ -3612,6 +3612,22 @@ an error: }]; } +def MSConstexprDocs : Documentation { + let Category = DocCatStmt; + let Content = [{ +The ``[[msvc::constexpr]]`` attribute can be applied only to a function +definition or a ``return`` statement. It does not impact function

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
@@ -217,6 +217,8 @@ C23 Feature Support Non-comprehensive list of changes in this release - +- The default value of `_MSC_VER` was raised from 1920 to 1933. + MSVC 19.33 added undocumented attribute ``[[msvc::constexpr]]``.

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-07 Thread Richard Dzenis via cfe-commits
@@ -2884,6 +2884,12 @@ def warn_cxx11_compat_constexpr_body_multiple_return : Warning< InGroup, DefaultIgnore; def note_constexpr_body_previous_return : Note< "previous return statement is here">; +def err_ms_constexpr_not_distinct : Error< + "[[msvc::constexpr]] cannot

  1   2   3   4   >