https://github.com/UmeshKalappa0 ready_for_review
https://github.com/llvm/llvm-project/pull/75564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/UmeshKalappa0 updated
https://github.com/llvm/llvm-project/pull/75564
>From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001
From: Umesh Kalappa
Date: Fri, 15 Dec 2023 11:52:52 +0530
Subject: [PATCH 1/2] Problem :For Kernel Modules ,emitting the relocs like
https://github.com/UmeshKalappa0 updated
https://github.com/llvm/llvm-project/pull/75564
>From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001
From: Umesh Kalappa
Date: Fri, 15 Dec 2023 11:52:52 +0530
Subject: [PATCH] Problem :For Kernel Modules ,emitting the relocs like
https://github.com/rjmccall edited
https://github.com/llvm/llvm-project/pull/73730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4073,6 +4221,51 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const
ArraySubscriptExpr *E,
ArrayLV = EmitLValue(Array);
auto *Idx = EmitIdxAfterBase(/*Promote*/true);
+if (SanOpts.has(SanitizerKind::ArrayBounds)) {
+ // If the array being accessed
@@ -4022,8 +4169,36 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const
ArraySubscriptExpr *E,
ArrayLV = EmitArraySubscriptExpr(ASE, /*Accessed*/ true);
else
ArrayLV = EmitLValue(Array);
+
auto *Idx = EmitIdxAfterBase(/*Promote*/true);
+if
https://github.com/UmeshKalappa0 converted_to_draft
https://github.com/llvm/llvm-project/pull/75564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rampitec wrote:
Ping. This one seems obvious to me.
https://github.com/llvm/llvm-project/pull/75249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (UmeshKalappa0)
Changes
For kernel modules (where -fno-pic and no-pie is implicit ) having
"R_X86_64_REX_GOTPCRELX " relocs burden the kernel loader to handle the same
like https://godbolt.org/z/hhh7ozojz.
Solution : Mark the
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/UmeshKalappa0 created
https://github.com/llvm/llvm-project/pull/75564
For kernel modules (where -fno-pic and no-pie is implicit ) having
"R_X86_64_REX_GOTPCRELX " relocs burden the kernel loader to handle the same
like https://godbolt.org/z/hhh7ozojz.
Solution : Mark the
https://github.com/rjmccall edited
https://github.com/llvm/llvm-project/pull/75397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,300 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document descries the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
rjmccall wrote:
> @rjmccall, I'm curious if you have any thoughts on the proposed
> implementation approach here?
>
> The TL;DR for the gnarly bit is to have AST nodes representing parameters
> that need temporary values, and for "output" parameters where there may be
> cast sequences
https://github.com/SunilKuravinakop created
https://github.com/llvm/llvm-project/pull/75562
When building with gcc-7.5 we get the error:
`nochange/openmp/libomptarget/src/PluginManager.cpp: In static member function
'static llvm::Expected >
PluginAdaptorTy::create(const string&)':
`
To
Author: Craig Topper
Date: 2023-12-14T21:54:15-08:00
New Revision: 73beefc5d7608f019e5759c9cfd9105a591df374
URL:
https://github.com/llvm/llvm-project/commit/73beefc5d7608f019e5759c9cfd9105a591df374
DIFF:
https://github.com/llvm/llvm-project/commit/73beefc5d7608f019e5759c9cfd9105a591df374.diff
dtcxzyw wrote:
Ping.
https://github.com/llvm/llvm-project/pull/68485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,6 +35,10 @@ struct __identity {
template <>
struct __is_identity<__identity> : true_type {};
+template <>
var-const wrote:
Can you elaborate on your concerns here?
https://github.com/llvm/llvm-project/pull/65148
@@ -0,0 +1,195 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,61 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -34,6 +35,10 @@ struct __identity {
template <>
struct __is_identity<__identity> : true_type {};
+template <>
EricWF wrote:
I'm not sure these changes are correct. Does reference wrapper work with the
`identity` unary op?
Author: Fangrui Song
Date: 2023-12-14T19:40:09-08:00
New Revision: ce1faec3ad15780f6336ac83047aac6eacd16772
URL:
https://github.com/llvm/llvm-project/commit/ce1faec3ad15780f6336ac83047aac6eacd16772
DIFF:
https://github.com/llvm/llvm-project/commit/ce1faec3ad15780f6336ac83047aac6eacd16772.diff
Author: Chuanqi Xu
Date: 2023-12-15T11:39:20+08:00
New Revision: e55bda06dc2bb1ef11ff4fcc43f90d8bf843f967
URL:
https://github.com/llvm/llvm-project/commit/e55bda06dc2bb1ef11ff4fcc43f90d8bf843f967
DIFF:
https://github.com/llvm/llvm-project/commit/e55bda06dc2bb1ef11ff4fcc43f90d8bf843f967.diff
rupprecht wrote:
Thanks to @MaskRay for handling the revert.
A reduction for the second `typename` breakage looks similar, so may be the
same underlying issue. But here it is anyway, in case it ends up being a second
bug in the patch:
```c++
class Foo {};
template
struct Ptr {};
template
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fred Fu (capfredf)
Changes
---
Patch is 24.20 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/75556.diff
6 Files Affected:
- (modified) clang/include/clang/Interpreter/CodeCompletion.h
https://github.com/capfredf edited
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/capfredf ready_for_review
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
capfredf wrote:
@vgvassilev
https://github.com/llvm/llvm-project/pull/75556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/capfredf updated
https://github.com/llvm/llvm-project/pull/75556
>From 17486783ff2eab10a592eef53f33b1298ff29b49 Mon Sep 17 00:00:00 2001
From: Fred Fu
Date: Wed, 13 Dec 2023 22:07:17 -0500
Subject: [PATCH] [ClangRepl] Semantic Code Completion
This patch piggybacks on
https://github.com/jacquesguan closed
https://github.com/llvm/llvm-project/pull/73489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jianjian Guan
Date: 2023-12-15T11:16:05+08:00
New Revision: 3fe81410b23c4f13954e99c7180fa8a7e1e8ee88
URL:
https://github.com/llvm/llvm-project/commit/3fe81410b23c4f13954e99c7180fa8a7e1e8ee88
DIFF:
https://github.com/llvm/llvm-project/commit/3fe81410b23c4f13954e99c7180fa8a7e1e8ee88.diff
Author: Chuanqi Xu
Date: 2023-12-15T11:12:52+08:00
New Revision: 9cdb825a4f1bf9e75829d03879620c6144d0b7bc
URL:
https://github.com/llvm/llvm-project/commit/9cdb825a4f1bf9e75829d03879620c6144d0b7bc
DIFF:
https://github.com/llvm/llvm-project/commit/9cdb825a4f1bf9e75829d03879620c6144d0b7bc.diff
https://github.com/capfredf created
https://github.com/llvm/llvm-project/pull/75556
None
>From 77b2b39174570f62dec16557b8a539811f64b62c Mon Sep 17 00:00:00 2001
From: Fred Fu
Date: Wed, 13 Dec 2023 22:07:17 -0500
Subject: [PATCH 1/2] WIP
---
.../clang/Interpreter/CodeCompletion.h|
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/75130
>From fb0ea87f212c78b5b39345e534a48b8956a19cc4 Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Mon, 11 Dec 2023 18:35:57 -0800
Subject: [PATCH] [Clang][AST] Fix crash in APValue::LValueBase::getType when
we
@@ -688,6 +688,14 @@ ToolChain::getFallbackAndroidTargetPath(StringRef BaseDir)
const {
unsigned TripleVersion = getTriple().getEnvironmentVersion().getMajor();
unsigned BestVersion = 0;
+ if (TripleVersion == 0) {
+return llvm::createStringError("version " +
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/75373
>From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Wed, 13 Dec 2023 20:07:45 +
Subject: [PATCH 1/7] Make clang report garbage target versions.
Clang always
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/75373
>From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Wed, 13 Dec 2023 20:07:45 +
Subject: [PATCH 1/6] Make clang report garbage target versions.
Clang always
https://github.com/wc00862805aj edited
https://github.com/llvm/llvm-project/pull/75445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/75373
>From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Wed, 13 Dec 2023 20:07:45 +
Subject: [PATCH 1/6] Make clang report garbage target versions.
Clang always
@@ -0,0 +1,35 @@
+;; Check that certain globals are in large sections under x86-64 large code
model (but not in other arches).
+; RUN: opt %s -mtriple=x86_64-unknown-linux -passes=instrprof -S | FileCheck %s
ilovepi wrote:
The comment makes it sound like this
https://github.com/ilovepi approved this pull request.
LGTM modulo one small comment in the test. Thanks for getting this done so
quickly.
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/75542
>From 884347b73d68e2d469b3903f248e72921434 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Thu, 14 Dec 2023 15:41:31 -0800
Subject: [PATCH 1/2] [Instrumentation][X86] Limit setting large section flag
p4vook wrote:
I should probably add a test to fix this behavior, but I haven't figured out
how to run the tests locally yet.
https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
well I guess I should say I thought it would be reliable rather than available,
but I see why it wouldn't be.
https://github.com/llvm/llvm-project/pull/75542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/25] [libc++] Implement ranges::contains
Differential
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/25] [libc++] Implement ranges::contains
Differential
ilovepi wrote:
> Actually I'm going to go down the `Module::getCodeModel()` route. Right now I
> think frontends adding module metadata for the code model is probably not
> common, but we should aim for that. And this will in the short term still
> work for Fuchsia without breaking API for
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH] clang-repl: fix top-level statement declaration context
Change
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ee2deb4cf70e9468510750070435f29ca7482d02
31273597beb9439f4c78123c48f8ecc9bf366e14 --
aeubanks wrote:
Actually I'm going to go down the `Module::getCodeModel()` route. Right now I
think frontends adding module metadata for the code model is probably not
common, but we should aim for that. And this will in the short term still work
for Fuchsia without breaking API for other
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pavel Kalugin (p4vook)
Changes
Change the declaration context where we insert top-level statements to
CurrentContext.
Previously, top-level statement declarations were inserted directly into the
translation unit. This is incorrect, as
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/p4vook created
https://github.com/llvm/llvm-project/pull/75547
Change the declaration context where we insert top-level statements to
CurrentContext.
Previously, top-level statement declarations were inserted directly into the
translation unit. This is incorrect, as it
JonPsson1 wrote:
Thanks for explanations.
Updates to my comments LGTM.
https://github.com/llvm/llvm-project/pull/74625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bwendling wrote:
@efriedma-quic, @nickdesaulniers, @rapidsna:
This is the latest version of this patch. I believe it's ready to submit. I
_really_ tried to implement @efriedma-quic's idea, but there were too corner
cases that made it much trickier than first imagined. I know that it's not
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaraslau (Yaraslaut)
Changes
Closes https://github.com/llvm/llvm-project/issues/64144
Instead of checking for `nullptr` we need to ensure that `JobList` is not
empty to proceed
---
Full diff:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/Yaraslaut created
https://github.com/llvm/llvm-project/pull/75545
Closes https://github.com/llvm/llvm-project/issues/64144
Instead of checking for `nullptr` we need to ensure that `JobList` is not
empty to proceed
>From 052a12dfb78ddc7b1486ca5f8e06002bb55c1d2e Mon Sep 17
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Arthur Eubanks (aeubanks)
Changes
In #74514 and #74778 we marked various instrumentation-added
sections as
large. This causes an extra PT_LOAD segment if using the small code
model. Since people using the small code model
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/75373
>From 74f256d8a77ee2ba8e0d5bbb6519aa2729cf94d5 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Wed, 13 Dec 2023 20:07:45 +
Subject: [PATCH 1/6] Make clang report garbage target versions.
Clang always
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/75542
In #74514 and #74778 we marked various instrumentation-added sections as
large. This causes an extra PT_LOAD segment if using the small code
model. Since people using the small code model presumably aren't
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/24] [libc++] Implement ranges::contains
Differential
robincaloudis wrote:
Ping
https://github.com/llvm/llvm-project/pull/71313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
robincaloudis wrote:
Ping.
https://github.com/llvm/llvm-project/pull/71313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Indeed. Thank you!
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,316 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document describes the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
@@ -0,0 +1,319 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document describes the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
@@ -0,0 +1,319 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document describes the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
@@ -0,0 +1,300 @@
+===
+HLSL Function Calls
+===
+
+.. contents::
+ :local:
+
+Introduction
+
+
+This document descries the design and implementation of HLSL's function call
+semantics in Clang. This includes details related to
ZequanWu wrote:
> Well, seems like someone broke ToT w/ a compiler error. I'll let you know if
> the forward fix fails to address the issue.
The latest build passed:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8761696377585255057/overview.
Author: Fangrui Song
Date: 2023-12-14T14:57:15-08:00
New Revision: 57f42a8765cd3d878be4fb59ad44c85f8a7ca223
URL:
https://github.com/llvm/llvm-project/commit/57f42a8765cd3d878be4fb59ad44c85f8a7ca223
DIFF:
https://github.com/llvm/llvm-project/commit/57f42a8765cd3d878be4fb59ad44c85f8a7ca223.diff
uweigand wrote:
Fixed merge conflicts, updated as described above, and fixed support for i128
parameters in the z/OS XPLINK ABI.
https://github.com/llvm/llvm-project/pull/74625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/24] [libc++] Implement ranges::contains
Differential
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/23] [libc++] Implement ranges::contains
Differential
Fznamznon wrote:
@rupprecht , no, this is not expected. Please feel free to revert since it is
night in my time zone. Otherwise I will revert tomorrow.
https://github.com/llvm/llvm-project/pull/75069
___
cfe-commits mailing list
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/23] [libc++] Implement ranges::contains
Differential
https://github.com/quic-akaryaki closed
https://github.com/llvm/llvm-project/pull/65815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Well, seems like someone broke ToT w/ a compiler error. I'll let you know if
the forward fix fails to address the issue.
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
uweigand wrote:
> I have looked through the changes and made some comments inline.
Thanks for the review!
> Commenting:
Fixed, thanks!
> I happened to notice some cases with room for improvement:
Good catch. I've not addressed these right now, this can be done as a
follow-up. (The memory
ilovepi wrote:
Our next cI run should finish in about 25 minutes, so we'll find out soon.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8761696932167687409/overview
https://github.com/llvm/llvm-project/pull/69493
@@ -1516,48 +1536,206 @@ let Predicates = [FeatureVector] in {
}
}
+//===--===//
+// Support for 128-bit integer values in vector registers
@@ -6481,6 +6737,71 @@ SDValue SystemZTargetLowering::combineLOAD(
SDNode *N, DAGCombinerInfo ) const {
SelectionDAG = DCI.DAG;
EVT LdVT = N->getValueType(0);
+ SDLoc DL(N);
+
+ // Replace an i128 load that is used solely to move its value into GPRs
+ // by
@@ -2918,16 +3049,17 @@ static Comparison getCmp(SelectionDAG , SDValue
CmpOp0, SDValue CmpOp1,
bool IsSignaling = false) {
if (CmpOp1.getOpcode() == ISD::Constant) {
assert(!Chain);
-uint64_t Constant = cast(CmpOp1)->getZExtValue();
@@ -2772,6 +2837,27 @@ static unsigned getTestUnderMaskCond(unsigned BitSize,
unsigned CCMask,
// Update the arguments with the TM version if so.
static void adjustForTestUnderMask(SelectionDAG , const SDLoc ,
Comparison ) {
+ // Use VECTOR
@@ -1466,7 +1509,15 @@ static SDValue convertValVTToLocVT(SelectionDAG ,
const SDLoc ,
static SDValue lowerI128ToGR128(SelectionDAG , SDValue In) {
SDLoc DL(In);
SDValue Lo, Hi;
- std::tie(Lo, Hi) = DAG.SplitScalar(In, DL, MVT::i64, MVT::i64);
+ if
@@ -1183,6 +1187,35 @@ void SystemZDAGToDAGISel::loadVectorConstant(
SelectCode(Op.getNode());
}
+SDNode *SystemZDAGToDAGISel::loadPoolVectorConstant(APInt Val, EVT VT, SDLoc
DL) {
+ SDNode *ResNode;
+ assert (VT.getSizeInBits() == 128);
+
+ SDValue CP =
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/75142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ZequanWu wrote:
> Seems like a mismatch on the diff, so maybe the check is too stringent.
>
> If this will take a while to fix, would you mind reverting until it can be
> addressed?
It passed for me locally on x64. Maybe I should use `diff <(llvm-profdata show
--all-functions --counts
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/74902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/73685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/73685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/74902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs closed
https://github.com/llvm/llvm-project/pull/73688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jon Roelofs
Date: 2023-12-14T14:57:00-07:00
New Revision: 6c12fd91540fe2f86b5032b10f04b74910b4c411
URL:
https://github.com/llvm/llvm-project/commit/6c12fd91540fe2f86b5032b10f04b74910b4c411
DIFF:
https://github.com/llvm/llvm-project/commit/6c12fd91540fe2f86b5032b10f04b74910b4c411.diff
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/73688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 395 matches
Mail list logo
