[clang] [polly] [llvm] [polly][ScheduleOptimizer] Fix long compile time(hang) reported in polly (PR #75141)

2024-01-01 Thread Karthika Devi C via cfe-commits
kartcq wrote: ping @efriedma-quic @xgupta https://github.com/llvm/llvm-project/pull/75141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

2024-01-01 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

2024-01-01 Thread kadir çetinkaya via cfe-commits
@@ -821,7 +821,8 @@ void SymbolCollector::setIncludeLocation(const Symbol , SourceLocation DefLoc, // Use the expansion location to get the #include header since this is // where the symbol is exposed. - IncludeFiles[S.ID] = SM.getDecomposedExpansionLoc(DefLoc).first; +

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

2024-01-01 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks and sorry for leaving this out there, I was busy with other things and then OOO. https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [lld] [llvm] [Propeller] Add new flag option '-basic-block-sections=listwithlabels=' to support to use Propeller iteratively. (PR #76497)

2024-01-01 Thread via cfe-commits
https://github.com/lifengxiang1025 updated https://github.com/llvm/llvm-project/pull/76497 >From 4ae12256cfe621e3051ac4deee60cd1da6c54a65 Mon Sep 17 00:00:00 2001 From: lifengxiang Date: Thu, 28 Dec 2023 16:57:54 +0800 Subject: [PATCH 1/3] [Propeller] Add new flag option

[clang] [llvm] [mlir] [compiler-rt] [clang-tools-extra] [flang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH] [mlir][vector] Fix invalid `LoadOp` indices being created ---

[clang] [llvm] [openmp] [mlir] [libcxx] [libc] [lldb] [compiler-rt] [clang-tools-extra] [flang] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Hristo Hristov via cfe-commits
Zingam wrote: Thank you very much for the review. I'll wait a few days for addional feedback before I land this PR. https://github.com/llvm/llvm-project/pull/74994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[lld] [clang] [llvm] [Propeller] Add new flag option '-basic-block-sections=listwithlabels=' to support to use Propeller iteratively. (PR #76497)

2024-01-01 Thread via cfe-commits
https://github.com/lifengxiang1025 updated https://github.com/llvm/llvm-project/pull/76497 >From 4ae12256cfe621e3051ac4deee60cd1da6c54a65 Mon Sep 17 00:00:00 2001 From: lifengxiang Date: Thu, 28 Dec 2023 16:57:54 +0800 Subject: [PATCH 1/2] [Propeller] Add new flag option

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-01 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay Ping. https://github.com/llvm/llvm-project/pull/71157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-01-01 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall ping~ what's the fate of the patch? https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-01 Thread Petr Hosek via cfe-commits
petrhosek wrote: This appears to have broken the LSan build which is now failing with the following error: ``` FAILED: compiler-rt/lib/lsan/CMakeFiles/clang_rt.lsan_osx_dynamic.dir/lsan_malloc_mac.cpp.o /Volumes/Work/s/w/ir/x/w/llvm_build/./bin/clang++ --target=x86_64-apple-darwin22.6.0

[clang] [clang-format] Fix erroneous BraceWrapping.BeforeLambdaBody column calcs (PR #76673)

2024-01-01 Thread James Grant via cfe-commits
https://github.com/jamesg-nz edited https://github.com/llvm/llvm-project/pull/76673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix erroneous BraceWrapping.BeforeLambdaBody column calcs (PR #76673)

2024-01-01 Thread James Grant via cfe-commits
@@ -366,8 +366,14 @@ bool ContinuationIndenter::mustBreak(const LineState ) { const auto = State.Stack.back(); if (Style.BraceWrapping.BeforeLambdaBody && Current.CanBreakBefore && Current.is(TT_LambdaLBrace) && Previous.isNot(TT_LineComment)) { -auto

[clang] [Clang][LoongArch] Do not pass vector arguments via vector registers (PR #74990)

2024-01-01 Thread Lu Weining via cfe-commits
https://github.com/SixWeining closed https://github.com/llvm/llvm-project/pull/74990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Do not pass vector arguments via vector registers (PR #74990)

2024-01-01 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. https://github.com/llvm/llvm-project/pull/74990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Do not pass vector arguments via vector registers (PR #74990)

2024-01-01 Thread Lu Weining via cfe-commits
https://github.com/SixWeining edited https://github.com/llvm/llvm-project/pull/74990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Do not pass vector arguments via vector registers (PR #74990)

2024-01-01 Thread Lu Weining via cfe-commits
https://github.com/SixWeining edited https://github.com/llvm/llvm-project/pull/74990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [PowerPC] Implement fence builtin (PR #76495)

2024-01-01 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 approved this pull request. LGTM with nits. https://github.com/llvm/llvm-project/pull/76495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [PowerPC] Implement fence builtin (PR #76495)

2024-01-01 Thread Chen Zheng via cfe-commits
@@ -944,6 +944,9 @@ TARGET_BUILTIN(__builtin_pack_vector_int128, "V1LLLiULLiULLi", "", "vsx") // Set the floating point rounding mode BUILTIN(__builtin_setrnd, "di", "") +// Barrier for instruction motion +BUILTIN(__builtin_ppc_fence, "v", "") chenzheng1030

[clang] [llvm] [PowerPC] Implement fence builtin (PR #76495)

2024-01-01 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 edited https://github.com/llvm/llvm-project/pull/76495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [PowerPC] Implement fence builtin (PR #76495)

2024-01-01 Thread Chen Zheng via cfe-commits
@@ -944,6 +944,9 @@ TARGET_BUILTIN(__builtin_pack_vector_int128, "V1LLLiULLiULLi", "", "vsx") // Set the floating point rounding mode BUILTIN(__builtin_setrnd, "di", "") +// Barrier for instruction motion chenzheng1030 wrote: Can we add some comments here

[clang] Avoid printing overly large integer. (PR #75902)

2024-01-01 Thread Nhat Nguyen via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue , QualType T, case BuiltinType::WChar_U: { unsigned TyWidth =

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread Andrew Schenk via cfe-commits
schenka0 wrote: I struggled to rebase my changes around some merges and accidently included additional changes at one point which triggered the llvmbot to add extra tags. Sorry! https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread Andrew Schenk via cfe-commits
@@ -813,6 +813,21 @@ TEST(SourceCodeTests, isKeywords) { EXPECT_FALSE(isKeyword("override", LangOpts)); } +TEST(SourceCodeTests, isSpelledInSource) { + Annotations Test(R"cpp( +int abc = 1; +)cpp"); + + ParsedAST AST = TestTU::withCode(Test.code()).build(); +

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread Andrew Schenk via cfe-commits
https://github.com/schenka0 updated https://github.com/llvm/llvm-project/pull/76668 >From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001 From: schenka0 <154034018+schen...@users.noreply.github.com> Date: Mon, 1 Jan 2024 01:31:05 -0500 Subject: [PATCH 1/3] Check for invalid

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

2024-01-01 Thread Ben Shi via cfe-commits
benshi001 wrote: I am not familiar with swift. So is there an official document for the SWIFT specific ABI on AVR? I think this is necessary, just like C++: https://gcc.gnu.org/wiki/avr-gcc. And what's more, tests are required to be committed with functional changes, this is a requirement

[lld] [clang] [llvm] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Can you please fix or revert > https://lab.llvm.org/buildbot/#/builders/74/builds/24592 ? Should be fixed by https://github.com/llvm/llvm-project/commit/7e405eb722e40c79b7726201d0f76b5dab34ba0f. https://lab.llvm.org/buildbot/#/builders/74/builds/24613

[clang] Avoid printing overly large integer. (PR #75902)

2024-01-01 Thread Nhat Nguyen via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From:

[clang] [clang-format] Don't apply severe penalty if no possible column formats (PR #76675)

2024-01-01 Thread James Grant via cfe-commits
jamesg-nz wrote: > I think that's not the right way to fix the issue. > > Why are the 2 lines formatted differently? It seems to me that this fixes the > symptom, not the cause. Because for the line where brackets are used it meets the condition in the next `if` statement down:

[clang] Avoid printing overly large integer. (PR #75902)

2024-01-01 Thread Nhat Nguyen via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CNhat?= Date: Mon,

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2024-01-01 Thread David Pagan via cfe-commits
ddpagan wrote: Ping. https://github.com/llvm/llvm-project/pull/72417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AVR] Restrict range of assembly constraint 'G' (PR #76561)

2024-01-01 Thread Lu Weining via cfe-commits
SixWeining wrote: LGTM. I have checked with https://gcc.gnu.org/onlinedocs/gccint/Machine-Constraints.html. 'G' stands for "A floating point constant 0.0". But I'd like to wait others' opinion. https://github.com/llvm/llvm-project/pull/76561 ___

[clang] [clang][AVR] Restrict range of assembly constraint 'G' (PR #76561)

2024-01-01 Thread Ben Shi via cfe-commits
https://github.com/benshi001 edited https://github.com/llvm/llvm-project/pull/76561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AVR] Restrict range of assembly constraint 'G' (PR #76561)

2024-01-01 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/76561 >From 75164dccb2697ad5468700a9f23a0bc7d8ab49e8 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 29 Dec 2023 17:58:21 +0800 Subject: [PATCH] [clang][AVR] Restrict range of assembly constraint 'G' According to

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Ben Shi via cfe-commits
benshi001 wrote: > LGTM Thanks for your help! https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix erroneous BraceWrapping.BeforeLambdaBody column calcs (PR #76673)

2024-01-01 Thread James Grant via cfe-commits
@@ -22965,6 +22965,84 @@ TEST_F(FormatTest, EmptyLinesInLambdas) { "};"); } +TEST_F(FormatTest, BreakBeforeLambdaBodyWrapping) { + verifyFormat("connect([]() {\n" + " foo();\n" + " bar();\n" + "});"); + + auto Style

[clang] [clang-format] Fix erroneous BraceWrapping.BeforeLambdaBody column calcs (PR #76673)

2024-01-01 Thread James Grant via cfe-commits
https://github.com/jamesg-nz updated https://github.com/llvm/llvm-project/pull/76673 >From 04885844162b5390d8041a44a1895ad6ac160228 Mon Sep 17 00:00:00 2001 From: James Grant <42079499+jamesg...@users.noreply.github.com> Date: Mon, 1 Jan 2024 20:27:41 +1300 Subject: [PATCH 1/2] [clang-format]

[lld] [llvm] [clang] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > > Yeah, we should skip this inference for functions with the sanitize_memory > > attribute. > > I will post a patch later. Candidate patch: https://github.com/llvm/llvm-project/pull/76691 https://github.com/llvm/llvm-project/pull/76553

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

2024-01-01 Thread John McCall via cfe-commits
rjmccall wrote: > That makes a lot of sense. Thank you John. I guess here are my thoughts. As I > understand it, the `SwiftABIInfo` by default does something like "if > something can be passed in 4 registers or fewer then pass by register, > otherwise pass indirectly"? I think that sweet spot

[llvm] [lld] [clang] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Yeah, we should skip this inference for functions with the sanitize_memory > attribute. I will post a patch later. https://github.com/llvm/llvm-project/pull/76553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [lld] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Nikita Popov via cfe-commits
nikic wrote: Yeah, we should skip this inference for functions with the sanitize_memory attribute. https://github.com/llvm/llvm-project/pull/76553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [lld] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Can you please fix or revert > https://lab.llvm.org/buildbot/#/builders/74/builds/24592 ? Thank you for reporting this! I will check the error log. https://github.com/llvm/llvm-project/pull/76553 ___ cfe-commits mailing list

[llvm] [clang] [lld] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Another problem is that there was assumption that definition and declaration will be consistent, for msan is a part of ABI. Clang will generate them consistently for all modules, with declaration and definition of the function. Is possible that after this patch some

[llvm] [clang] [lld] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ``` This patch deduces noundef attributes for return values. IIUC, a function returns noundef values iff all of its return values are guaranteed not to be undef or poison. ``` https://github.com/llvm/llvm-project/pull/76553 ___

[clang] [llvm] [lld] [FuncAttrs] Deduce `noundef` attributes for return values (PR #76553)

2024-01-01 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Can you please fix or revert https://lab.llvm.org/buildbot/#/builders/74/builds/24592 ? https://github.com/llvm/llvm-project/pull/76553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer][NFC] Take small objects by value (PR #76688)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/76688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Take small objects by value (PR #76688)

2024-01-01 Thread Balazs Benics via cfe-commits
steakhal wrote: Pushed as 7619050cd7c3715f34c1d13ea048c092299037bb and 8ee3dfd74653e30f48dd9f49ba24f43547e6a549 respectively. https://github.com/llvm/llvm-project/pull/76688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 8ee3dfd - [analyzer][NFC] Take SVal and NonLoc by value

2024-01-01 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2024-01-01T22:00:32+01:00 New Revision: 8ee3dfd74653e30f48dd9f49ba24f43547e6a549 URL: https://github.com/llvm/llvm-project/commit/8ee3dfd74653e30f48dd9f49ba24f43547e6a549 DIFF: https://github.com/llvm/llvm-project/commit/8ee3dfd74653e30f48dd9f49ba24f43547e6a549.diff

[clang] 7619050 - [analyzer][NFC] Take StringRef by value

2024-01-01 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2024-01-01T22:00:32+01:00 New Revision: 7619050cd7c3715f34c1d13ea048c092299037bb URL: https://github.com/llvm/llvm-project/commit/7619050cd7c3715f34c1d13ea048c092299037bb DIFF: https://github.com/llvm/llvm-project/commit/7619050cd7c3715f34c1d13ea048c092299037bb.diff

[lldb] [llvm] [openmp] [libc] [libcxx] [clang-tools-extra] [mlir] [flang] [clang] [compiler-rt] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Hristo Hristov via cfe-commits
@@ -0,0 +1,136 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[lldb] [llvm] [openmp] [libc] [libcxx] [clang-tools-extra] [mlir] [flang] [clang] [compiler-rt] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/74994 >From 6e26ca239c49e1b7d9ab72217db7339e92df163f Mon Sep 17 00:00:00 2001 From: Zingam Date: Sun, 10 Dec 2023 14:16:02 +0200 Subject: [PATCH 01/18] [libc++][span] P2821R5: span.at() --- libcxx/include/span

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

2024-01-01 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: @cor3ntin Could you help me in closing this? https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Take small objects by value (PR #76688)

2024-01-01 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM! Thanks! https://github.com/llvm/llvm-project/pull/76688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/76671 >From 0c586914ac977920140472d172ee357dea43f2c5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 1 Jan 2024 18:48:27 +0800 Subject: [PATCH 1/2] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' ---

[lld] [llvm] [clang] [mlir] [libcxx] [flang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
@@ -31,14 +31,14 @@ class InvalidatedIteratorChecker check::PreStmt, check::PreStmt> { - std::unique_ptr InvalidatedBugType; + const BugType InvalidatedBugType{this, "Iterator invalidated", + "Misuse of

[clang] [analyzer][NFC] Take small objects by value (PR #76688)

2024-01-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes --- Patch is 28.26 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/76688.diff 14 Files Affected: - (modified)

[clang] [analyzer][NFC] Take small objects by value (PR #76688)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/76688 None >From 70c03932cad401f477674881050a8f0c4b573cdb Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Mon, 1 Jan 2024 18:59:46 +0100 Subject: [PATCH 1/2] [analyzer][NFC] Take StringRef by value ---

[flang] [lld] [mlir] [llvm] [libcxx] [clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/76655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [lld] [mlir] [llvm] [libcxx] [clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
@@ -52,10 +52,13 @@ class SimpleStreamChecker : public Checker { - CallDescription OpenFn, CloseFn; + const CallDescription OpenFn{{"fopen"}, 2}; + const CallDescription CloseFn{{"fclose"}, 1}; steakhal wrote: Here is why we can't have CallDescriptions

[flang] [lld] [mlir] [llvm] [libcxx] [clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/76655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [lld] [mlir] [llvm] [libcxx] [clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
@@ -52,10 +52,13 @@ class SimpleStreamChecker : public Checker { - CallDescription OpenFn, CloseFn; + const CallDescription OpenFn{{"fopen"}, 2}; + const CallDescription CloseFn{{"fclose"}, 1}; steakhal wrote: Well, it seems like `StringRef` is not constexpr

[clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
@@ -17,19 +17,18 @@ #include "MPITypes.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" +#include "llvm/ADT/StringRef.h" namespace clang { namespace ento { namespace mpi { class MPIBugReporter { public: - MPIBugReporter(const CheckerBase ) { -

[clang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-01 Thread Balazs Benics via cfe-commits
@@ -31,14 +31,14 @@ class InvalidatedIteratorChecker check::PreStmt, check::PreStmt> { - std::unique_ptr InvalidatedBugType; + const BugType InvalidatedBugType{this, "Iterator invalidated", + "Misuse of

[llvm] [compiler-rt] [libcxx] [libc] [openmp] [lldb] [mlir] [clang] [flang] [clang-tools-extra] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,136 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [lldb] [flang] [libcxx] [openmp] [llvm] [compiler-rt] [clang-tools-extra] [mlir] [libc] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/74994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [libcxx] [lldb] [mlir] [llvm] [libc] [openmp] [flang] [clang-tools-extra] [libc++][span] P2821R5: `span.at()` (PR #74994)

2024-01-01 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 approved this pull request. Other than the test this LGTM. https://github.com/llvm/llvm-project/pull/74994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread via cfe-commits
https://github.com/schenka0 updated https://github.com/llvm/llvm-project/pull/76668 >From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001 From: schenka0 <154034018+schen...@users.noreply.github.com> Date: Mon, 1 Jan 2024 01:31:05 -0500 Subject: [PATCH 1/2] Check for invalid

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Bhuminjay Soni via cfe-commits
11happy wrote: I have added the tests as well. https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/76680 >From 3c8dfcf96e732f4546f8019c0111fd873b233162 Mon Sep 17 00:00:00 2001 From: 11happy Date: Mon, 1 Jan 2024 19:53:45 +0530 Subject: [PATCH 1/2] Changed Checks from TriviallyCopyable to

[clang] [clang-format] Don't apply severe penalty if no possible column formats (PR #76675)

2024-01-01 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: I think that's not the right way to fix the issue. Why are the 2 lines formatted differently? It seems to me that this fixes the symptom, not the cause. https://github.com/llvm/llvm-project/pull/76675 ___ cfe-commits

[clang] [clang-format] Fix erroneous BraceWrapping.BeforeLambdaBody column calcs (PR #76673)

2024-01-01 Thread Björn Schäpers via cfe-commits
@@ -22965,6 +22965,84 @@ TEST_F(FormatTest, EmptyLinesInLambdas) { "};"); } +TEST_F(FormatTest, BreakBeforeLambdaBodyWrapping) { + verifyFormat("connect([]() {\n" + " foo();\n" + " bar();\n" + "});"); + + auto Style

[llvm] [libcxx] [flang] [clang] [lld] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-01 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/76632 >From 1165b11477ab59122a4db35221fcefe3c9505387 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 30 Dec 2023 17:34:56 +0200 Subject: [PATCH 01/16] [libc++][streams] P1759R6: Native handles and file streams

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread via cfe-commits
https://github.com/schenka0 updated https://github.com/llvm/llvm-project/pull/76668 >From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001 From: schenka0 <154034018+schen...@users.noreply.github.com> Date: Mon, 1 Jan 2024 01:31:05 -0500 Subject: [PATCH] Check for invalid

[llvm] [libcxx] [flang] [clang] [lld] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-01 Thread Hristo Hristov via cfe-commits
H-G-Hristov wrote: This test is failing but I have no idea how to fix it: @github-actions Build and Test libc++ / stage3 (generic-no-localization, libcxx-runners-8-set, OFF) (pull_request) Failing after 1m

[llvm] [libcxx] [flang] [clang] [lld] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-01 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov ready_for_review https://github.com/llvm/llvm-project/pull/76632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-01 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/75440 >From ce9db667e6567532fe119ff8d793281215f223dc Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Thu, 14 Dec 2023 15:40:03 +0800 Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics ---

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Sure I can , I have also tested the code that was giving erroneous warnings, > so should I add that example as well?? Yes. Clang has a special mode which check which diagnostics are emitted: https://clang.llvm.org/docs/InternalsManual.html#verifying-diagnostics

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Sure I can , I have also tested the code that was giving erroneous warnings, so should I add that example as well?? https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Pol M via cfe-commits
@@ -302,3 +302,64 @@ extern __typeof__(__builtin_expect(0, 0)) bi0; // Strings int array1[__builtin_strlen("ab\0cd")]; int array2[(sizeof(array1)/sizeof(int)) == 2? 1 : -1]; + +typedef double vector4double __attribute__((__vector_size__(32))); +typedef float vector4float

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Pol M via cfe-commits
@@ -302,3 +302,64 @@ extern __typeof__(__builtin_expect(0, 0)) bi0; // Strings int array1[__builtin_strlen("ab\0cd")]; int array2[(sizeof(array1)/sizeof(int)) == 2? 1 : -1]; + +typedef double vector4double __attribute__((__vector_size__(32))); +typedef float vector4float

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Can you add some tests? https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Simon Pilgrim via cfe-commits
@@ -302,3 +302,64 @@ extern __typeof__(__builtin_expect(0, 0)) bi0; // Strings int array1[__builtin_strlen("ab\0cd")]; int array2[(sizeof(array1)/sizeof(int)) == 2? 1 : -1]; + +typedef double vector4double __attribute__((__vector_size__(32))); +typedef float vector4float

[clang-tools-extra] [llvm] [clang] [mlir] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-01 Thread via cfe-commits
https://github.com/schenka0 updated https://github.com/llvm/llvm-project/pull/76668 >From c9e2b9ad57aa9bac52324c91fe6d4ec1aa39ff41 Mon Sep 17 00:00:00 2001 From: schenka0 <154034018+schen...@users.noreply.github.com> Date: Mon, 1 Jan 2024 01:31:05 -0500 Subject: [PATCH 1/2] Check for invalid

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bhuminjay Soni (11happy) Changes **Overview:** This pull request fixes #47355 where in the Clang compiler's range-loop-analysis incorrectly checks for trivial copyability instead of trivial copy constructibility, leading to erroneous

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-01 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy created https://github.com/llvm/llvm-project/pull/76680 **Overview:** This pull request fixes #47355 where in the Clang compiler's range-loop-analysis incorrectly checks for trivial copyability instead of trivial copy constructibility, leading to erroneous warnings.

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Pol M via cfe-commits
@@ -302,3 +302,64 @@ extern __typeof__(__builtin_expect(0, 0)) bi0; // Strings int array1[__builtin_strlen("ab\0cd")]; int array2[(sizeof(array1)/sizeof(int)) == 2? 1 : -1]; + +typedef double vector4double __attribute__((__vector_size__(32))); +typedef float vector4float

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Pol M via cfe-commits
@@ -10895,6 +10899,138 @@ bool VectorExprEvaluator::VisitUnaryOperator(const UnaryOperator *E) { return Success(APValue(ResultElements.data(), ResultElements.size()), E); } +static bool EvaluateVectorOrLValue(APValue , EvalInfo , + const

[lld] [clang] [clang-tools-extra] [libcxx] [compiler-rt] [flang] [llvm] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

2024-01-01 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/73617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [clang-tools-extra] [libcxx] [compiler-rt] [flang] [llvm] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

2024-01-01 Thread Hristo Hristov via cfe-commits
@@ -0,0 +1,71 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations (PR #76677)

2024-01-01 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/76677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations (PR #76677)

2024-01-01 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @erichkeane https://github.com/llvm/llvm-project/pull/76677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations (PR #76677)

2024-01-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes This diagnoses unexpanded packs in the _unqualified-id_ of a function template specialization's _declarator-id_, e.g.: ```cpp templatetypename... Ts struct A { templatetypename U void f();

[clang] [Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations (PR #76677)

2024-01-01 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/76677 This diagnoses unexpanded packs in the _unqualified-id_ of a function template specialization's _declarator-id_, e.g.: ```cpp template struct A { template void f(); template<> void f(); //

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Simon Pilgrim via cfe-commits
@@ -10895,6 +10899,138 @@ bool VectorExprEvaluator::VisitUnaryOperator(const UnaryOperator *E) { return Success(APValue(ResultElements.data(), ResultElements.size()), E); } +static bool EvaluateVectorOrLValue(APValue , EvalInfo , + const

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

2024-01-01 Thread Simon Pilgrim via cfe-commits
@@ -302,3 +302,64 @@ extern __typeof__(__builtin_expect(0, 0)) bi0; // Strings int array1[__builtin_strlen("ab\0cd")]; int array2[(sizeof(array1)/sizeof(int)) == 2? 1 : -1]; + +typedef double vector4double __attribute__((__vector_size__(32))); +typedef float vector4float

  1   2   >