[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-01-09 Thread via cfe-commits
cor3ntin wrote: @AaronBallman this looks sensible. WDYT? https://github.com/llvm/llvm-project/pull/71709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Mark the fallthrough coreturn statement implicit. (PR #77465)

2024-01-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Can you provide more context for this? https://github.com/llvm/llvm-project/pull/77465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_addressof (PR #77303)

2024-01-09 Thread via cfe-commits
@@ -613,15 +615,34 @@ static bool interp__builtin_ffs(InterpState , CodePtr OpPC, return true; } +static bool interp__builtin_addressof(InterpState , CodePtr OpPC, + const InterpFrame *Frame, + const

[clang] [clang][Interp] Implement __builtin_addressof (PR #77303)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/77303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_addressof (PR #77303)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo comment https://github.com/llvm/llvm-project/pull/77303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Mark the fallthrough coreturn statement implicit. (PR #77465)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo nit https://github.com/llvm/llvm-project/pull/77465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Mark the fallthrough coreturn statement implicit. (PR #77465)

2024-01-09 Thread via cfe-commits
@@ -1743,7 +1743,7 @@ bool CoroutineStmtBuilder::makeOnFallthrough() { return false; } else if (HasRVoid) { Fallthrough = S.BuildCoreturnStmt(FD.getLocation(), nullptr, - /*IsImplicit*/false); +

[clang] [AST] Mark the fallthrough coreturn statement implicit. (PR #77465)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/77465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

2024-01-09 Thread Hana Dusíková via cfe-commits
hanickadot wrote: yes please, I don't have merge rights https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

2024-01-09 Thread via cfe-commits
Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= Message-ID: In-Reply-To: https://github.com/cor3ntin approved this pull request. LGTM @hanickadot do you need me to merge that for you? https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing

[clang] [clang] Add tests for DRs about complete-class context (PR #77444)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo comment https://github.com/llvm/llvm-project/pull/77444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > Please add a release note > This change needs a release note. Please add an entry to > `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, > and referencing any Github issue this change fixes. Thanks! Done.

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Jonas Hahnfeld via cfe-commits
@@ -15754,10 +15754,18 @@ bool Expr::EvaluateAsInitializer(APValue , const ASTContext , LValue LVal; LVal.set(VD); -if (!EvaluateInPlace(Value, Info, LVal, this, - /*AllowNonLiteralTypes=*/true) || -EStatus.HasSideEffects) -

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Jonas Hahnfeld via cfe-commits
https://github.com/hahnjo updated https://github.com/llvm/llvm-project/pull/69076 >From a55ca99a373b17501d56d18af9e8aa2dc2cbcea0 Mon Sep 17 00:00:00 2001 From: Jonas Hahnfeld Date: Sat, 14 Oct 2023 20:10:28 +0200 Subject: [PATCH 1/3] Fix crash with modules and constexpr destructor With

[clang] [clang] Add tests for DRs about complete-class context (PR #77444)

2024-01-09 Thread via cfe-commits
@@ -42,6 +42,28 @@ namespace dr1611 { // dr1611: dup 1658 C c; } +namespace dr1626 { // dr1626: no open +// FIXME: current consensus for CWG2335 is that the examples are well-formed. cor3ntin wrote: It is not clear from

[clang] [clang] Add tests for DRs about complete-class context (PR #77444)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/77444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] pop explicitly to keep context stack balance (PR #77312)

2024-01-09 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/77312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] pop explicitly to keep context stack balance (PR #77312)

2024-01-09 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > This looks like a duplicate of #77312 @danix800 The opposite is true. I will close this pr. https://github.com/llvm/llvm-project/pull/77312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread via cfe-commits
cor3ntin wrote: This change needs a release note. Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, and referencing any Github issue this change fixes. Thanks! https://github.com/llvm/llvm-project/pull/69076

[clang] [Clang][Parser] pop explicitly to keep context stack balance (PR #77312)

2024-01-09 Thread via cfe-commits
cor3ntin wrote: This looks like a duplicate of https://github.com/llvm/llvm-project/pull/77312 @danix800 https://github.com/llvm/llvm-project/pull/77312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > address my previous comment: [#69076 > (comment)](https://github.com/llvm/llvm-project/pull/69076#issuecomment-1780327252) I had already expanded the commit message with the full details, now also copied to the PR summary. Is that sufficient to address the comment?

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2024-01-09 Thread Jonas Hahnfeld via cfe-commits
https://github.com/hahnjo edited https://github.com/llvm/llvm-project/pull/69076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [PowerPC] Implement fence builtin (PR #76495)

2024-01-09 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/76495 >From aaa11bc775b9aa3a0398ba2bbca4087e99f04243 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Thu, 28 Dec 2023 16:54:25 +0800 Subject: [PATCH 1/4] [PowerPC] Implement fence builtin ---

[clang] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR #77552)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Do you need me to merge that for you? https://github.com/llvm/llvm-project/pull/77552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] efcf192 - Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (#77194)

2024-01-09 Thread via cfe-commits
Author: Bhuminjay Soni Date: 2024-01-10T08:27:58+01:00 New Revision: efcf192a0a5993165f837ce71250fb6df689634b URL: https://github.com/llvm/llvm-project/commit/efcf192a0a5993165f837ce71250fb6df689634b DIFF:

[clang] [clang] Add tests for CWG1800-1804 (PR #77509)

2024-01-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-09 Thread Luke Lau via cfe-commits
lukel97 wrote: > These names will be used in profiles only, but I don't know if we should add > them to RISCVUsage.rst. Good point, I added them in anyway so we're consistent at least. I couldn't find any other "featureless" extensions that we currently support.

[llvm] [clang] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-09 Thread Luke Lau via cfe-commits
https://github.com/lukel97 updated https://github.com/llvm/llvm-project/pull/77458 >From 53993a1f1eaf0f6dc336d45a94b8638c4119ba2e Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Tue, 9 Jan 2024 19:42:10 +0700 Subject: [PATCH 1/5] [RISCV] Add support for new unprivileged extensions defined in

[clang] [llvm] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-09 Thread Luke Lau via cfe-commits
lukel97 wrote: @asb I got a response from https://github.com/riscv/riscv-profiles/issues/139, looks like Ziccrse, Ziccamoa, Za64rs, and Za128rs don't imply A. https://github.com/llvm/llvm-project/pull/77458 ___ cfe-commits mailing list

[clang] [llvm] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-09 Thread Luke Lau via cfe-commits
https://github.com/lukel97 updated https://github.com/llvm/llvm-project/pull/77458 >From 53993a1f1eaf0f6dc336d45a94b8638c4119ba2e Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Tue, 9 Jan 2024 19:42:10 +0700 Subject: [PATCH 1/4] [RISCV] Add support for new unprivileged extensions defined in

[clang-tools-extra] [libclc] [lld] [flang] [libcxx] [libunwind] [clang] [libcxxabi] [lldb] [libc] [llvm] [compiler-rt] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-09 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/77412 >From 87e1d4acdd87d45f265e590ad135e21f352dc5ad Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Tue, 9 Jan 2024 13:33:56 +0800 Subject: [PATCH 1/3] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 ppc_fp128

[clang-tools-extra] [libclc] [lld] [flang] [mlir] [libcxx] [libunwind] [clang] [lldb] [libc] [llvm] [compiler-rt] [AMDGPU] Fix broken sign-extended subword buffer load combine (PR #77470)

2024-01-09 Thread Jay Foad via cfe-commits
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/77470 >From ae231d88c5b5e2e0996edefd45389992f8e97d05 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Tue, 9 Jan 2024 13:16:24 + Subject: [PATCH 1/3] [AMDGPU] Precommit tests for broken combine Add tests for

[clang-tools-extra] [lld] [flang] [libcxx] [clang] [lldb] [libc] [llvm] [compiler-rt] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2024-01-09 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/67301 >From 92abb76631594dfc2ca586c46c38031610be0548 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 25 Sep 2023 17:08:59 +0800 Subject: [PATCH 1/6] [Legalizer] Expand fmaximum and fminimum According to

[llvm] [clang] riscv vector cc (PR #77560)

2024-01-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7388b7422f9307dd5ae3fe3876a676d83d702daf 3e000d49ecc3769efa2051332c04163b84b0f9ae --

[llvm] [clang] riscv vector cc (PR #77560)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes [RISCV] RISCV vector calling convention (1/2) This is the vector calling convention based on https://github.com/riscv-non-isa/riscv-elf-psabi-doc, the idea is to split between "scalar"

[llvm] [flang] [lld] [clang-tools-extra] [libcxx] [clang] [libc] [compiler-rt] [lldb] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2024-01-09 Thread Qiu Chaofan via cfe-commits
@@ -8262,6 +8262,64 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode *Node, return SDValue(); } +SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N, +SelectionDAG ) const { + SDLoc DL(N); + SDValue LHS =

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-09 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Are there any more changes for this PR required from my end? https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Add support C unions in non C++ parsing mode (PR #77451)

2024-01-09 Thread Erick Velez via cfe-commits
https://github.com/evelez7 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Make "ca" aliased to "xer" (PR #77557)

2024-01-09 Thread Kai Luo via cfe-commits
https://github.com/bzEq updated https://github.com/llvm/llvm-project/pull/77557 >From e1caee46dc81e59b8eab0379e200ca2a709801c3 Mon Sep 17 00:00:00 2001 From: Kai Luo Date: Wed, 10 Jan 2024 05:29:22 + Subject: [PATCH 1/3] Alias --- clang/lib/Basic/Targets/PPC.cpp | 2 +- 1 file changed, 1

[clang] [PowerPC] Make "ca" aliased to "xer" (PR #77557)

2024-01-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff db78c30ba772af1466bb0d0c1d376c8e642ee4a9 aaee97fb9f7bef5ff4e3f845fa29d45e9c7a83b0 --

[clang] [PowerPC] Make "ca" aliased to "xer" (PR #77557)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kai Luo (bzEq) Changes `ca` is not accepted in clobber list of inline assembly right now. Make `ca` aliased to `xer`, so it can be accepted in clobber list. Fixes #77549. --- Full diff:

[clang] [PowerPC] Make "ca" aliased to "xer" (PR #77557)

2024-01-09 Thread Kai Luo via cfe-commits
https://github.com/bzEq created https://github.com/llvm/llvm-project/pull/77557 `ca` is not accepted in clobber list of inline assembly right now. Make `ca` aliased to `xer`, so it can be accepted in clobber list. Fixes #77549. >From e1caee46dc81e59b8eab0379e200ca2a709801c3 Mon Sep 17

[openmp] [lld] [libclc] [flang] [mlir] [libc] [polly] [compiler-rt] [clang] [lldb] [libcxxabi] [llvm] [libunwind] [libcxx] [clang-tools-extra] [WebAssembly] Correctly consider signext/zext arg flags a

2024-01-09 Thread Juneyoung Lee via cfe-commits
https://github.com/aqjune closed https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [polly] [libc] [openmp] [llvm] [mlir] [libunwind] [clang-tools-extra] [compiler-rt] [clang] [lld] [libclc] [flang] [lldb] [libcxxabi] [WebAssembly] Correctly consider signext/zext arg flags a

2024-01-09 Thread Juneyoung Lee via cfe-commits
aqjune wrote: I checked that the CI has passed - thanks all! https://github.com/llvm/llvm-project/pull/77281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c2b57a0 - [clang][Interp][NFC] Make a few pointers const

2024-01-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-10T06:38:28+01:00 New Revision: c2b57a052daee22cb6401bc7bc514d858ea11eb6 URL: https://github.com/llvm/llvm-project/commit/c2b57a052daee22cb6401bc7bc514d858ea11eb6 DIFF: https://github.com/llvm/llvm-project/commit/c2b57a052daee22cb6401bc7bc514d858ea11eb6.diff

[clang] b53628a - Reland "[clang-format] Optimize processing .clang-format-ignore files"

2024-01-09 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-01-09T21:34:21-08:00 New Revision: b53628a52d1947c51e250d6fa4ff5dd12b737aa0 URL: https://github.com/llvm/llvm-project/commit/b53628a52d1947c51e250d6fa4ff5dd12b737aa0 DIFF: https://github.com/llvm/llvm-project/commit/b53628a52d1947c51e250d6fa4ff5dd12b737aa0.diff

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

2024-01-09 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Since Phabricator has been [taken down](https://discourse.llvm.org/t/llvm-phabricator-turndown/76137), I'm resubmitting the patch implementing outgoing calls in call hierarchy that was previously posted at https://reviews.llvm.org/D93829. Previous discussion can still

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

2024-01-09 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/77556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] lsOutgoing calls (PR #77556)

2024-01-09 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (Not sure what happened here, the PR was somehow created while I was still writing the description. Anyways, updating the title now.) https://github.com/llvm/llvm-project/pull/77556 ___ cfe-commits mailing list

[clang-tools-extra] lsOutgoing calls (PR #77556)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) Changes --- Patch is 49.27 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/77556.diff 23 Files Affected: - (modified)

[clang-tools-extra] lsOutgoing calls (PR #77556)

2024-01-09 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/77556 None >From 42d64ab78fe1c001e766fe2b94de167ae7bc6ddf Mon Sep 17 00:00:00 2001 From: Quentin Chateau Date: Mon, 18 Sep 2023 03:01:03 -0400 Subject: [PATCH 1/4] [clangd] Support outgoing calls in call

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/77045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Convert a few options from CACHE PATH to CACHE STRING (PR #77534)

2024-01-09 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/77534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [libcxxabi] [mlir] [libc] [compiler-rt] [lld] [llvm] [polly] [openmp] [flang] [libclc] [lldb] [libunwind] [clang-tools-extra] [WebAssembly] Correctly consider signext/zext arg flags a

2024-01-09 Thread Juneyoung Lee via cfe-commits
https://github.com/aqjune updated https://github.com/llvm/llvm-project/pull/77281 >From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001 From: Juneyoung Lee Date: Mon, 8 Jan 2024 02:01:41 -0600 Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags at

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/77045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/69340 >From b4c8809a948799be51a35b10e4d9d303b78a98db Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Thu, 9 Nov 2023 09:30:24 -0700 Subject: [PATCH 01/10] Revert "Revert "[clang-format] Fix align consecutive

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/77045 >From d9cbbe48b96d27bff3fc926b60d039ed05f00489 Mon Sep 17 00:00:00 2001 From: XDeme Date: Fri, 5 Jan 2024 01:23:16 -0300 Subject: [PATCH 1/9] [clang-format] Fix crash involving array designators and dangling comma

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() { if (Next->is(tok::greater)) return false; } + if (tok::isLiteral(FormatTok->Tok.getKind())) +return false; owenca wrote: You are right! Then how about the

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
https://github.com/XDeme edited https://github.com/llvm/llvm-project/pull/77045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/77045 >From d9cbbe48b96d27bff3fc926b60d039ed05f00489 Mon Sep 17 00:00:00 2001 From: XDeme Date: Fri, 5 Jan 2024 01:23:16 -0300 Subject: [PATCH 1/8] [clang-format] Fix crash involving array designators and dangling comma

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() { if (Next->is(tok::greater)) return false; } + if (tok::isLiteral(FormatTok->Tok.getKind())) +return false; XDeme wrote: With this change, a code like this will

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -1079,6 +1079,7 @@ clang-format - Add ``ObjCPropertyAttributeOrder`` which can be used to sort ObjC property attributes (like ``nonatomic, strong, nullable``). - Add ``.clang-format-ignore`` files. +- Add ``AlignFunctionPointers`` sub-option for

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
https://github.com/XDeme deleted https://github.com/llvm/llvm-project/pull/77045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread via cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() { if (Next->is(tok::greater)) return false; } + if (tok::isLiteral(FormatTok->Tok.getKind())) +return false; XDeme wrote: With this change this code will crash:

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-09 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-09 Thread Wang Pengcheng via cfe-commits
@@ -985,9 +1003,10 @@ void RISCVFrameLowering::determineCalleeSaves(MachineFunction , }; for (auto Reg : CSRegs) - SavedRegs.set(Reg); + if (Reg < RISCV::X16 || !Subtarget.isRVE()) wangpc-pp wrote: The psABI says: > If used with an ISA

[clang] [ClangFormat] Fix formatting bugs. (PR #76245)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion, Style); } +TEST_F(FormatTestMacroExpansion, CommaAsOperator) { + FormatStyle Style = getGoogleStyle(); + Style.ColumnLimit = 42; + Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c"); +

[clang] [ClangFormat] Fix formatting bugs. (PR #76245)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion, Style); } +TEST_F(FormatTestMacroExpansion, CommaAsOperator) { + FormatStyle Style = getGoogleStyle(); + Style.ColumnLimit = 42; + Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c"); +

[clang] [ClangFormat] Fix formatting bugs. (PR #76245)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion, Style); } +TEST_F(FormatTestMacroExpansion, CommaAsOperator) { + FormatStyle Style = getGoogleStyle(); + Style.ColumnLimit = 42; + Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c"); +

[clang] [ClangFormat] Fix formatting bugs. (PR #76245)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion, Style); } +TEST_F(FormatTestMacroExpansion, CommaAsOperator) { + FormatStyle Style = getGoogleStyle(); + Style.ColumnLimit = 42; + Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c"); +

[clang] [ClangFormat] Fix formatting bugs. (PR #76245)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion, Style); } +TEST_F(FormatTestMacroExpansion, CommaAsOperator) { + FormatStyle Style = getGoogleStyle(); + Style.ColumnLimit = 42; owenca wrote: ```suggestion FormatStyle Style

[clang] [llvm] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-09 Thread Wang Pengcheng via cfe-commits
@@ -83,13 +88,14 @@ RISCVRegisterInfo::getCalleeSavedRegs(const MachineFunction *MF) const { } BitVector RISCVRegisterInfo::getReservedRegs(const MachineFunction ) const { + const RISCVSubtarget = MF.getSubtarget(); wangpc-pp wrote: This should be a

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-09 Thread Matt Arsenault via cfe-commits
arsenm wrote: ping @krzysz00 https://github.com/llvm/llvm-project/pull/75647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs (PR #76777)

2024-01-09 Thread Wang Pengcheng via cfe-commits
@@ -17,6 +17,13 @@ def HasStdExtZicsr : Predicate<"Subtarget->hasStdExtZicsr()">, AssemblerPredicate<(all_of FeatureStdExtZicsr), "'Zicsr' (CSRs)">; +def FeatureStdExtI +: SubtargetFeature<"i", "HasStdExtI",

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread Owen Pan via cfe-commits
owenca wrote: Please add an assertion in `WhitespaceManager.h`: ``` --- a/clang/lib/Format/WhitespaceManager.h +++ b/clang/lib/Format/WhitespaceManager.h @@ -282,6 +282,7 @@ private: for (auto PrevIter = Start; PrevIter != End; ++PrevIter) { // If we broke the line the initial spaces

[clang] [clang-format] Fix crash involving array designators (PR #77045)

2024-01-09 Thread Owen Pan via cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() { if (Next->is(tok::greater)) return false; } + if (tok::isLiteral(FormatTok->Tok.getKind())) +return false; owenca wrote: ```suggestion ``` Instead, I would change

[libcxx] [clang] [libclc] [libcxxabi] [lld] [flang] [clang-tools-extra] [libunwind] [llvm] [lldb] [libc] [compiler-rt] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-09 Thread Matt Arsenault via cfe-commits
@@ -68,8 +68,18 @@ define dso_local zeroext i32 @func(double noundef %0, double noundef %1) #0 { ; CHECK-LABEL: __adddf3 } +; To check ppc_fp128 soften without crash +define zeroext i1 @ppcf128_soften(ppc_fp128 %a) #0 { +entry: + %fpclass = tail call i1

[clang] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR #77552)

2024-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes Fixes a crash where the template argument depth computed in the semantic context for a friend FunctionDecl with a constrained parameter is compared against arguments in the lexical context for the purpose of

[clang] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR #77552)

2024-01-09 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/77552 Fixes a crash where the template argument depth computed in the semantic context for a friend FunctionDecl with a constrained parameter is compared against arguments in the lexical context for the purpose of

[clang] [clang-cl] document correct defaults for `-fms-compatibility-version` / `-fmsc-version` (PR #76418)

2024-01-09 Thread via cfe-commits
h-vetinari wrote: Gentle ping @llvm/pr-subscribers-clang, could someone have a look and merge this?  https://github.com/llvm/llvm-project/pull/76418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Use const pointer to eliminate warning with libxml 2.12.0 (PR #76719)

2024-01-09 Thread via cfe-commits
FantasqueX wrote: Gently ping~ https://github.com/llvm/llvm-project/pull/76719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 061e4f24b24a3b59d73a94dc6f2f0d21a2b7beac 557604301ab98d89b5ddf6d857d85326d7d3da3d --

[clang] a828cda - Revert "[PGO] Exposing PGO's Counter Reset and File Dumping APIs (#76471)"

2024-01-09 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-01-09T18:37:04-08:00 New Revision: a828cda9c80282a77b579f8fc9dc17a310173af4 URL: https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4 DIFF: https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4.diff

[clang-tools-extra] a828cda - Revert "[PGO] Exposing PGO's Counter Reset and File Dumping APIs (#76471)"

2024-01-09 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2024-01-09T18:37:04-08:00 New Revision: a828cda9c80282a77b579f8fc9dc17a310173af4 URL: https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4 DIFF: https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4.diff

[libunwind] [clang-tools-extra] [lld] [llvm] [lldb] [compiler-rt] [libclc] [libc] [clang] [libcxxabi] [flang] [libcxx] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-09 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/77412 >From 87e1d4acdd87d45f265e590ad135e21f352dc5ad Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Tue, 9 Jan 2024 13:33:56 +0800 Subject: [PATCH 1/2] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 ppc_fp128

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. https://github.com/llvm/llvm-project/pull/77525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Implement modeling of 'fputc' in the StdLibraryFunctionsChecker (PR #77435)

2024-01-09 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/77435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Implement modeling of 'fputc' in the StdLibraryFunctionsChecker (PR #77435)

2024-01-09 Thread Ben Shi via cfe-commits
benshi001 wrote: > I have already a patch to add these functions: #76979. The conditions for > `fputc` are not the same, this can be clarified at the other patch. I see. It would be better to close this PR, and supplement my parts in your PR. https://github.com/llvm/llvm-project/pull/77435

[openmp] [mlir] [libunwind] [clang-tools-extra] [lld] [llvm] [lldb] [compiler-rt] [libclc] [clang] [flang] [libcxx] [ocaml] Fixed typo error about set_module_identifier in llvm ocaml binding (PR #7747

2024-01-09 Thread via cfe-commits
https://github.com/Yujinmon updated https://github.com/llvm/llvm-project/pull/77479 >From b5586e9935d30a587323699aac2213bae5d14174 Mon Sep 17 00:00:00 2001 From: Yujin <78896558+yujin...@users.noreply.github.com> Date: Tue, 9 Jan 2024 23:14:52 +0900 Subject: [PATCH 1/3] fixed typo error about

[mlir] [clang-tools-extra] [lld] [llvm] [lldb] [compiler-rt] [clang] [libc] [libcxxabi] [flang] [libcxx] [Mips] Fix unable to handle inline assembly ends with compat-branch o… (PR #77291)

2024-01-09 Thread via cfe-commits
yingopq wrote: @topperc Could you help review this patch? Thanks. https://github.com/llvm/llvm-project/pull/77291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/77525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

2024-01-09 Thread Saleem Abdulrasool via cfe-commits
@@ -2210,7 +2219,11 @@ CGObjCGNU::CGObjCGNU(CodeGenModule , unsigned runtimeABIVersion, // void objc_exception_throw(id); ExceptionThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); - ExceptionReThrowFn.init(, "objc_exception_throw", VoidTy, IdTy); + if

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

2024-01-09 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

2024-01-09 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Reformat ia32intrin.h doc to match the other headers (PR #77525)

2024-01-09 Thread Shengchen Kan via cfe-commits
KanRobert wrote: cc @FreddyLeaf https://github.com/llvm/llvm-project/pull/77525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Have you run that patch on bigger workflows? Do we have some performance > numbers to compare? I've tested it functionality in our largest workload about modules. It runs well. But our uses of modules don't have a lot of complexities while it has a large scale. For

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-09 Thread Chuanqi Xu via cfe-commits
@@ -100,6 +100,11 @@ ExternalASTSource::FindExternalVisibleDeclsByName(const DeclContext *DC, return false; } +void ExternalASTSource::LoadExternalSpecializations( +const Decl *D, ArrayRef TemplateArgs) { + return; ChuanqiXu9 wrote: Will do in the

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-09 Thread Alan Zhao via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

  1   2   3   4   5   6   >