[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2024-01-11 Thread via cfe-commits
kon72 wrote: Hello @HighCommander4, Thank you for the review. Since I don't have permission to commit the change, could you merge this on my behalf? https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes Printing the raw symbol is useful in inline asm (e.g. getting the C++ mangled name, referencing a symbol in a custom way while ensuring it is not optimized out even if internal). Similar constraints are

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-llvm-ir Author: Fangrui Song (MaskRay) Changes Printing the raw symbol is useful in inline asm (e.g. getting the C++ mangled name, referencing a symbol in a custom way while ensuring it is not optimized out even if

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/77886 Printing the raw symbol is useful in inline asm (e.g. getting the C++ mangled name, referencing a symbol in a custom way while ensuring it is not optimized out even if internal). Similar constraints are available

[clang] 7e60448 - [test] Improve x86 inline asm tests

2024-01-11 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-01-11T23:35:46-08:00 New Revision: 7e604485e18d40be6ce6310e4a3e583ca0b7df47 URL: https://github.com/llvm/llvm-project/commit/7e604485e18d40be6ce6310e4a3e583ca0b7df47 DIFF: https://github.com/llvm/llvm-project/commit/7e604485e18d40be6ce6310e4a3e583ca0b7df47.diff

[llvm] [clang-tools-extra] [clang] [AMDGPU][GFX12] Default component broadcast store (PR #76212)

2024-01-11 Thread Matt Arsenault via cfe-commits
@@ -719,6 +719,18 @@ def FeatureFlatAtomicFaddF32Inst "Has flat_atomic_add_f32 instruction" >; +def FeatureDefaultComponentZero : SubtargetFeature<"default-component-zero", + "HasDefaultComponentZero", + "true", + "BUFFER/IMAGE store instructions set unspecified

[llvm] [clang] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-11 Thread Matt Arsenault via cfe-commits
@@ -18240,65 +18240,211 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w32: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w64: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu8_w32:

[clang] [llvm] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-11 Thread Matt Arsenault via cfe-commits
@@ -423,6 +423,67 @@ TARGET_BUILTIN(__builtin_amdgcn_s_wakeup_barrier, "vi", "n", "gfx12-insts") TARGET_BUILTIN(__builtin_amdgcn_s_barrier_leave, "b", "n", "gfx12-insts") TARGET_BUILTIN(__builtin_amdgcn_s_get_barrier_state, "Uii", "n", "gfx12-insts")

[llvm] [clang-tools-extra] [clang] [AMDGPU][GFX12] Default component broadcast store (PR #76212)

2024-01-11 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd closed https://github.com/llvm/llvm-project/pull/76212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lldb] [compiler-rt] [openmp] [clang-tools-extra] [libunwind] [lld] [mlir] [flang] [clang] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-11 Thread via cfe-commits
HaohaiWen wrote: > also, you can try to start a `Force Build` with cleaning of the source/build > directories for these builders. It should clean up the current source folder > and reload it. Thanks! I saw it has been forced to do clean up build.

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Konrad Kleine via cfe-commits
kwk wrote: @tstellar thank you for looping me in. When I did my experiments I've used the llvm-test-suite and `test-suite/utils/compare.py --metric exec_time --metric compile_time --metric link_time --lhs-name 16.0.3 --rhs-name 16.0.2-pgo /root/rawhide/results.json vs /root/pgo/results.json`

[clang] Update Clang.cpp (PR #77882)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: hw-1 (hw-1) Changes fix error: .gch' was ignored because it is not a clang PCH file https://github.com/llvm/llvm-project/issues/76923 --- Full diff: https://github.com/llvm/llvm-project/pull/77882.diff

[clang] Update Clang.cpp (PR #77882)

2024-01-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Update Clang.cpp (PR #77882)

2024-01-11 Thread via cfe-commits
https://github.com/hw-1 created https://github.com/llvm/llvm-project/pull/77882 fix error: .gch' was ignored because it is not a clang PCH file https://github.com/llvm/llvm-project/issues/76923 >From d3735b032f8d482b8f362e827f412a26d9121c1d Mon Sep 17 00:00:00 2001 From: hw-1

[mlir] [llvm] [clang] [flang] [clang-tools-extra] [lld] [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation (PR #68551)

2024-01-11 Thread via cfe-commits
Xinlong-Wu wrote: Considering that the LLVM instance of Phabricator has been replaced by a static archive, it is not workable to review on Phabricator anymore. So I reopened this pr and synchronized the latest changes. https://github.com/llvm/llvm-project/pull/68551

[clang] bfb026e - [StaticAnalyzer] Use StringRef::contains_insensitive (NFC)

2024-01-11 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-11T22:48:19-08:00 New Revision: bfb026e17ce288cd446d19f5d6329d08b4f46e04 URL: https://github.com/llvm/llvm-project/commit/bfb026e17ce288cd446d19f5d6329d08b4f46e04 DIFF: https://github.com/llvm/llvm-project/commit/bfb026e17ce288cd446d19f5d6329d08b4f46e04.diff

[clang] [IRGen][AArch64][RISCV] Generalize bitcast between i1 predicate vector and i8 fixed vector. (PR #76548)

2024-01-11 Thread Craig Topper via cfe-commits
topperc wrote: Ping https://github.com/llvm/llvm-project/pull/76548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxxabi] [flang] [mlir] [libc] [libcxx] [lld] [openmp] [compiler-rt] [lldb] [llvm] [libunwind] [clang] static operators should evaluate object argument (PR #68485)

2024-01-11 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea edited https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]fix readability-implicit-bool-conversion false-positives when comparison bool bitfield (PR #77878)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Fixes: #76817 For ignoring comparison and xor operator, it needs to use ImplicitCastFromBool without ignoring exception cases. This patch splits ignoring exception cases logic from

[clang-tools-extra] [clang-tidy]fix readability-implicit-bool-conversion false-positives when comparison bool bitfield (PR #77878)

2024-01-11 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/77878 Fixes: #76817 For ignoring comparison and xor operator, it needs to use ImplicitCastFromBool without ignoring exception cases. This patch splits ignoring exception cases logic from ImplicitCastFromBool and

[clang] [clang-tools-extra] [flang] [mlir] [lld] [openmp] [compiler-rt] [lldb] [llvm] [libunwind] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-11 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: also, you can try to start a `Force Build` with cleaning of the source/build directories for these builders. It should clean up the current source folder and reload it. https://github.com/llvm/llvm-project/pull/77608 ___

[compiler-rt] [lld] [clang-tools-extra] [libcxxabi] [mlir] [libunwind] [flang] [libcxx] [llvm] [libc] [lldb] [openmp] [clang] [clang] static operators should evaluate object argument (PR #68485)

2024-01-11 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea edited https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4b99af3 - [docs] Update doc for C++20 Modules after dc4e85b

2024-01-11 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-01-12T14:16:19+08:00 New Revision: 4b99af34199208e82f6a8806bfae1d3dea007936 URL: https://github.com/llvm/llvm-project/commit/4b99af34199208e82f6a8806bfae1d3dea007936 DIFF: https://github.com/llvm/llvm-project/commit/4b99af34199208e82f6a8806bfae1d3dea007936.diff

[compiler-rt] [lld] [clang-tools-extra] [mlir] [libunwind] [flang] [llvm] [lldb] [openmp] [clang] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-11 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @HaohaiWen >We may need to manually delete LLVM::windows-seh-EHa-PreserveCFG.s on those >machines. ok, got it. I'll do it for those builders. >Do you know who can help us to delete it? if you see some other failed builders because of this problem you can find their owners

[compiler-rt] [lld] [clang-tools-extra] [libcxxabi] [mlir] [libunwind] [flang] [libcxx] [llvm] [libc] [lldb] [openmp] [clang] [clang] static operators should evaluate object argument (PR #68485)

2024-01-11 Thread Tianlan Zhou via cfe-commits
@@ -5678,10 +5678,15 @@ static ImplicitConversionSequence TryObjectArgumentInitialization( assert(FromType->isRecordType()); QualType ClassType = S.Context.getTypeDeclType(ActingContext); - // [class.dtor]p2: A destructor can be invoked for a const, volatile or - //

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/77347 >From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 6 Jan 2024 07:46:01 + Subject: [PATCH 1/6] [CMake][PGO] Use check-clang target to generate profdata for

[clang] dc4e85b - [C++20] [Modules] Remove hardcoded path to imported module in BMIs

2024-01-11 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-01-12T13:47:59+08:00 New Revision: dc4e85bd79ff17014cbbe4a9db1d9b91929e91ce URL: https://github.com/llvm/llvm-project/commit/dc4e85bd79ff17014cbbe4a9db1d9b91929e91ce DIFF: https://github.com/llvm/llvm-project/commit/dc4e85bd79ff17014cbbe4a9db1d9b91929e91ce.diff

[flang] [clang] [lld] [mlir] [compiler-rt] [libcxxabi] [libcxx] [clang-tools-extra] [lldb] [libunwind] [libc] [llvm] [openmp] [clang] static operators should evaluate object argument (PR #68485)

2024-01-11 Thread Shafik Yaghmour via cfe-commits
@@ -5678,10 +5678,15 @@ static ImplicitConversionSequence TryObjectArgumentInitialization( assert(FromType->isRecordType()); QualType ClassType = S.Context.getTypeDeclType(ActingContext); - // [class.dtor]p2: A destructor can be invoked for a const, volatile or - //

[flang] [clang] [lld] [compiler-rt] [libunwind] [mlir] [clang-tools-extra] [lldb] [llvm] [openmp] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-11 Thread via cfe-commits
HaohaiWen wrote: > @HaohaiWen , looks like these changes break some builders with the failed > test `UNRESOLVED: LLVM::windows-seh-EHa-PreserveCFG.s` > > https://lab.llvm.org/buildbot/#/builders/234 > https://lab.llvm.org/buildbot/#/builders/58 > https://lab.llvm.org/buildbot/#/builders/104

[flang] [clang] [lld] [compiler-rt] [libunwind] [mlir] [clang-tools-extra] [lldb] [llvm] [openmp] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-11 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @HaohaiWen , looks like these changes break some builders with the failed test `UNRESOLVED: LLVM::windows-seh-EHa-PreserveCFG.s` https://lab.llvm.org/buildbot/#/builders/234 https://lab.llvm.org/buildbot/#/builders/58 https://lab.llvm.org/buildbot/#/builders/104

[clang-tools-extra] [llvm] [clang] [AArch64][SVE2] Lower OR to SLI/SRI (PR #77555)

2024-01-11 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lld] [clang-tools-extra] [libclc] [llvm] [libcxx] [libcxxabi] [lldb] [flang] [libc] [libunwind] [clang] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/77554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Change required features for Zvfhmin intrinsics from ZvfhminOrZvfh to Zvfhmin (PR #77866)

2024-01-11 Thread Craig Topper via cfe-commits
topperc wrote: > I think this was discussed in > https://reviews.llvm.org/D150253?id=523696#inline-1464348 ? I think the its been clarified since then. https://github.com/llvm/llvm-project/pull/77866 ___ cfe-commits mailing list

[clang] [clang-format] Fix poor spacing in `AlignArrayOfStructures: Left` (PR #77868)

2024-01-11 Thread via cfe-commits
https://github.com/XDeme edited https://github.com/llvm/llvm-project/pull/77868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [libcxx] [mlir] [clang] [asan] Enable StackSafetyAnalysis by default (PR #77210)

2024-01-11 Thread Fangrui Song via cfe-commits
MaskRay wrote: > I guess we we should avoid ClUseStackSafety for -O0 There may be two competing goals. The traditional one that `-O0` should run very few optimizations and a practical one that instrumentations should reduce code size increase. `[asan] Skip promotable allocas to improve

[clang] [RISCV] Change required features for Zvfhmin intrinsics from ZvfhminOrZvfh to Zvfhmin (PR #77866)

2024-01-11 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: I think this was discussed in https://reviews.llvm.org/D150253?id=523696#inline-1464348 https://github.com/llvm/llvm-project/pull/77866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Fix poor spacing in `AlignArrayOfStructures: Left` (PR #77868)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (XDeme) Changes Fixes llvm/llvm-project#62904 We were only setting the first cell of the first row to be against the left brace, now every row will be against the left brace. --- Full diff:

[clang] [clang-format] Fix poor spacing in `AlignArrayOfStructures: Left` (PR #77868)

2024-01-11 Thread via cfe-commits
https://github.com/XDeme created https://github.com/llvm/llvm-project/pull/77868 Fixes llvm/llvm-project#62904 We were only setting the first cell of the first row to be against the left brace, now every row will be against the left brace. >From 9f705be37183ca030e7720707f75ffbf9feb670a Mon

[clang] [llvm] [AMDGPU] Add global_load_tr for GFX12 (PR #77772)

2024-01-11 Thread Matt Arsenault via cfe-commits
@@ -18178,6 +18178,51 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); } + case

[clang] [RISCV] Change required features for Zvfhmin intrinsics from ZvfhminOrZvfh to Zvfhmin (PR #77866)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jim Lin (tclin914) Changes >From #75735, Zvfh implies Zvfhmin. --- Full diff: https://github.com/llvm/llvm-project/pull/77866.diff 4 Files Affected: - (modified) clang/include/clang/Basic/riscv_vector.td (+22-22) - (modified)

[clang] [RISCV] Change required features for Zvfhmin intrinsics from ZvfhminOrZvfh to Zvfhmin (PR #77866)

2024-01-11 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/77866 >From #75735, Zvfh implies Zvfhmin. >From be8d27cf8a3cf511598437a401a2277b36752137 Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Fri, 12 Jan 2024 09:58:49 +0800 Subject: [PATCH] [RISCV] Change required features

[compiler-rt] [libcxxabi] [lld] [lldb] [clang] [llvm] [libc] [libclc] [libunwind] [libcxx] [clang-tools-extra] [flang] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-11 Thread Sean Perry via cfe-commits
perry-ca wrote: Thanks. I don't have write access yet. Would you be able to merge this. https://github.com/llvm/llvm-project/pull/77554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[compiler-rt] [libcxxabi] [lld] [lldb] [clang] [llvm] [libc] [libclc] [libunwind] [libcxx] [clang-tools-extra] [flang] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson approved this pull request. Thanks this looks good to me now and should not change anything for other targets. https://github.com/llvm/llvm-project/pull/77554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Extract Function: add hoisting support (PR #75533)

2024-01-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/75533 >From 4aa436ae184d7a0f1689800796c8dfde1e889a0e Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 21 Jan 2023 14:49:58 +0100 Subject: [PATCH 1/2] [clangd]

[clang] [Driver,sanitizer] Remove RequiresPIE and msan's NeedPIE setting (PR #77689)

2024-01-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/77689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6a0c440 - [Driver,sanitizer] Remove RequiresPIE and msan's NeedPIE setting (#77689)

2024-01-11 Thread via cfe-commits
Author: Fangrui Song Date: 2024-01-11T18:30:16-08:00 New Revision: 6a0c440159aa2b2e895fe6e04af39c91e54733ce URL: https://github.com/llvm/llvm-project/commit/6a0c440159aa2b2e895fe6e04af39c91e54733ce DIFF: https://github.com/llvm/llvm-project/commit/6a0c440159aa2b2e895fe6e04af39c91e54733ce.diff

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-11 Thread Chuanqi Xu via cfe-commits
@@ -297,6 +297,26 @@ struct ReadySuspendResumeResult { bool IsInvalid; }; +// Adds [[clang::coro_wrapper]] and [[clang::coro_disable_lifetimebound]] +// attributes to `get_return_object`. +static void handleGetReturnObject(Sema , MemberExpr *ME) { + if (!ME ||

[clang] [clang-format] Stop aligning the to continuation lines (PR #76378)

2024-01-11 Thread via cfe-commits
sstwcw wrote: Can someone review this please? Did you see it when I opened the pull request 2 weeks ago or only when I added the reviewers just now? I thought reviewers would be added automatically. https://github.com/llvm/llvm-project/pull/76378

[clang] [llvm] New calling convention preserve_none (PR #76868)

2024-01-11 Thread via cfe-commits
@@ -1056,6 +1056,23 @@ def CC_Intel_OCL_BI : CallingConv<[ CCDelegateTo ]>; +def CC_X86_64_Preserve_None : CallingConv<[ + // We don't preserve general registers, so all of them can be used to pass + // arguments except + // - RBPframe pointer + // - R10

[clang] [Clang][Sema] improve sema check of clang::musttail attribute (PR #77727)

2024-01-11 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/77727 >From 0281f6d55865f690d11845005580039dcd80da72 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Thu, 11 Jan 2024 13:02:21 +0800 Subject: [PATCH] [Clang][SemaCXX] improve sema check of clang::musttail attribute ---

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
@@ -6135,6 +6141,42 @@ std::string Driver::GetProgramPath(StringRef Name, const ToolChain ) const { return std::string(Name); } +std::string Driver::GetStdModuleManifestPath(const Compilation , + const ToolChain ) const { + +

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,15 @@ +// Test that -print-library-module-manifest-path finds the correct file. + +// RUN: %clang -print-library-module-manifest-path \ +// RUN: -stdlib=libc++ \ +// RUN: --sysroot=%S/Inputs/cxx23_modules \ +// RUN: --target=x86_64-linux-gnu 2>&1 \ +// RUN:

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
@@ -6135,6 +6141,42 @@ std::string Driver::GetProgramPath(StringRef Name, const ToolChain ) const { return std::string(Name); } +std::string Driver::GetStdModuleManifestPath(const Compilation , + const ToolChain ) const { + +

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: LGTM generally. https://github.com/llvm/llvm-project/pull/76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,9 @@ +// Test that -print-library-module-manifest-path finds the correct file. +// +// Note this file is currently not available on Apple platforms ChuanqiXu9 wrote: I don't get the intention for the test since there is standard library related

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't allow casts in front of ampamp (PR #77704)

2024-01-11 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/77704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 791637e - [clang-format] Don't allow casts in front of ampamp (#77704)

2024-01-11 Thread via cfe-commits
Author: Emilia Kond Date: 2024-01-12T03:47:37+02:00 New Revision: 791637e78236541a871f9474e0c8918354ca310f URL: https://github.com/llvm/llvm-project/commit/791637e78236541a871f9474e0c8918354ca310f DIFF: https://github.com/llvm/llvm-project/commit/791637e78236541a871f9474e0c8918354ca310f.diff

[flang] [libc] [libcxx] [llvm] [clang] [lldb] [lld] [clang-tools-extra] [libcxxabi] [libunwind] [libclc] [compiler-rt] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-11 Thread Sean Perry via cfe-commits
https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/77554 >From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001 From: Sean Perry Date: Tue, 9 Jan 2024 20:59:28 -0600 Subject: [PATCH 1/6] Generate __multc3 for z/OS ---

[flang] [libcxx] [openmp] [llvm] [clang] [lldb] [lld] [mlir] [compiler-rt] [clang-format] SpacesInSquareBrackets not working for Java (PR #77833)

2024-01-11 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/77833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make test Driver/dragonfly.c pass when running with temp dir containing "crt" (PR #77861)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (dyung) Changes Previous commit 67aea3b fixed the test for paths with '/', expand it to include '\' to fix the same problem on Windows. Our internal Windows builder hit the same issue that was previously fixed on linux, but

[clang] [clang] Make test Driver/dragonfly.c pass when running with temp dir containing "crt" (PR #77861)

2024-01-11 Thread via cfe-commits
https://github.com/dyung created https://github.com/llvm/llvm-project/pull/77861 Previous commit 67aea3b fixed the test for paths with '/', expand it to include '\' to fix the same problem on Windows. Our internal Windows builder hit the same issue that was previously fixed on linux, but on

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-01-11 Thread via cfe-commits
@@ -1125,6 +1130,10 @@ Register SparcTargetLowering::getRegisterByName(const char* RegName, LLT VT, .Case("g4", SP::G4).Case("g5", SP::G5).Case("g6", SP::G6).Case("g7", SP::G7) .Default(0); + const SparcRegisterInfo *TRI = Subtarget->getRegisterInfo(); + if

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-01-11 Thread via cfe-commits
https://github.com/koachan updated https://github.com/llvm/llvm-project/pull/74927 >From 956ca7e210a438caac7c5dda8c9945305a53de39 Mon Sep 17 00:00:00 2001 From: Koakuma Date: Wed, 29 Nov 2023 08:08:29 +0700 Subject: [PATCH 1/4] [SPARC] Support reserving arbitrary general purpose registers

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/14] Add SpaceInParensOption for __attribute__ keyword The

[clang] [CMake][Release] Add option for enabling LTO to cache file (PR #77035)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/77035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ef20e3 - [CMake][Release] Add option for enabling LTO to cache file (#77035)

2024-01-11 Thread via cfe-commits
Author: Tom Stellard Date: 2024-01-11T17:05:28-08:00 New Revision: 3ef20e3fc1910977630b0392558731b199cf38e5 URL: https://github.com/llvm/llvm-project/commit/3ef20e3fc1910977630b0392558731b199cf38e5 DIFF: https://github.com/llvm/llvm-project/commit/3ef20e3fc1910977630b0392558731b199cf38e5.diff

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/13] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/12] Add SpaceInParensOption for __attribute__ keyword The

[llvm] [clang] New calling convention preserve_none (PR #76868)

2024-01-11 Thread via cfe-commits
@@ -2868,6 +2868,11 @@ def M68kRTD: DeclOrTypeAttr { let Documentation = [M68kRTDDocs]; } +def PreserveNone : DeclOrTypeAttr { + let Spellings = [Clang<"preserve_none">]; weiguozhi wrote: FunctionLike works for me. Thanks!

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris closed https://github.com/llvm/llvm-project/pull/77829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f626b1f - [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver

2024-01-11 Thread Matthew Voss via cfe-commits
Author: Matthew Voss Date: 2024-01-11T16:52:35-08:00 New Revision: f626b1f4ca2a6fd2b6c5eea3b53c15c4502d29fa URL: https://github.com/llvm/llvm-project/commit/f626b1f4ca2a6fd2b6c5eea3b53c15c4502d29fa DIFF: https://github.com/llvm/llvm-project/commit/f626b1f4ca2a6fd2b6c5eea3b53c15c4502d29fa.diff

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris updated https://github.com/llvm/llvm-project/pull/77829 >From f626b1f4ca2a6fd2b6c5eea3b53c15c4502d29fa Mon Sep 17 00:00:00 2001 From: Matthew Voss Date: Thu, 11 Jan 2024 12:18:03 -0800 Subject: [PATCH] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris updated https://github.com/llvm/llvm-project/pull/77829 >From b8d3ec5cde2b311747aec83d316af370202b37c1 Mon Sep 17 00:00:00 2001 From: Matthew Voss Date: Thu, 11 Jan 2024 12:18:03 -0800 Subject: [PATCH] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/11] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
ormris wrote: Thanks! I'll make sure to include that review in the commit message. Unified LTO is using the ThinLTO pre-link pipeline, regardless of what's passed to the driver. Since the ThinLTO pre-link pipeline doesn't provide this pass, this option should be required when Unified LTO is

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
gedare wrote: > > The __attribute((specifier-list)) currently is formatted based on the > > SpacesInParensOptions.Other (previously, SpacesInParentheses). This change > > allows finer control over addition of spaces between the consecutive > > parens, and between the inner parens and the list

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare edited https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/77347 >From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 6 Jan 2024 07:46:01 + Subject: [PATCH 1/5] [CMake][PGO] Use check-clang target to generate profdata for

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

2024-01-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/10] Add SpaceInParensOption for __attribute__ keyword The

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
tstellar wrote: cc @zmodem Since I borrowed your idea from #71067. https://github.com/llvm/llvm-project/pull/77347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

2024-01-11 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Once @ymand's comment is resolved, it looks good to me. Thanks! https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-11 Thread Nico Weber via cfe-commits
nico wrote: (The bot uses regular grep 3.1 that comes with `git bash` afaict.) https://github.com/llvm/llvm-project/pull/76733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dc61ebb - [clang] Mark clang-format-ignore.cpp as unsupported on Windows

2024-01-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-01-11T19:26:24-05:00 New Revision: dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e URL: https://github.com/llvm/llvm-project/commit/dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e DIFF: https://github.com/llvm/llvm-project/commit/dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e.diff

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-11 Thread Nico Weber via cfe-commits
nico wrote: Any reason the test can't use FileCheck like all the other tests? https://github.com/llvm/llvm-project/pull/76733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-11 Thread Julian Schmidt via cfe-commits
5chmidti wrote: LLVM uses `CamelCase` instead of `camelCase`. This is enforced by the top-level `.clang-tidy` file so you don't need to do this by hand, run clang-tidy and let it apply the fix-its on your file (clangd should provide these fixes as well, but currently only per var, not all at

[clang] [llvm] [lld] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-01-11 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3c6f47d - [llvm-driver] Fix usage of `InitLLVM` on Windows (#76306)

2024-01-11 Thread via cfe-commits
Author: Alexandre Ganea Date: 2024-01-11T19:08:28-05:00 New Revision: 3c6f47d6b879ddd2842925d2e5da54657d9e5631 URL: https://github.com/llvm/llvm-project/commit/3c6f47d6b879ddd2842925d2e5da54657d9e5631 DIFF:

[clang] [llvm] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
tstellar wrote: I was able to figure out how to generate profile data by compiling Sema.cpp from the clang source tree, so I switched that to the default and added an option so that users can override this with an external CMake project, like the LLVM Test Suite.

[clang] [llvm] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/77347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [clang] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-01-11 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [clang] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-01-11 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/77347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CMake][PGO] Use check targets to generate profdata for PGO builds (PR #77347)

2024-01-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/77347 >From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 6 Jan 2024 07:46:01 + Subject: [PATCH 1/4] [CMake][PGO] Use check-clang target to generate profdata for

[lld] [clang] [libc] [lldb] [libunwind] [llvm] [compiler-rt] [libcxxabi] [flang] [libcxx] [clang-tools-extra] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR

2024-01-11 Thread via cfe-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/77552 >From f9e35231207090afcda91d3cd3551d7d1639598b Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Tue, 9 Jan 2024 20:20:30 -0500 Subject: [PATCH] [Sema] Use lexical DC for friend functions when getting

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Fangrui Song via cfe-commits
MaskRay wrote: The description should mention https://reviews.llvm.org/D153583 ("[ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin"). I think this is correct when used in the ThinLTO mode, but it's not clear whether regular LTO mode is correct.

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/77829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-01-11 Thread Fangrui Song via cfe-commits
@@ -819,6 +819,43 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public X86TargetInfo { } }; +// x86-64 UEFI target +class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo +: public UEFITargetInfo { +public: + UEFIX86_64TargetInfo(const llvm::Triple , const

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-01-11 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,115 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-01-11 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,115 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

  1   2   3   4   5   6   >