[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-26 Thread via cfe-commits
cor3ntin wrote: > Don't think I can get the Windows+libcxx pre-commit CI working :| > > `libcxx/gdb/gdb_pretty_printer_test.sh.cpp` has `UNSUPPORTED` lines for clang > 16-18 but 19 is missing now. Not sure how this works for others. We have this issue on other PRs, I think we can ignore.

[clang] fe35d72 - [Driver] Use StringRef::consume_back (NFC)

2024-01-26 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-26T23:46:29-08:00 New Revision: fe35d72d8e248f1d29f9c5e503463bb1c4d6f8c6 URL: https://github.com/llvm/llvm-project/commit/fe35d72d8e248f1d29f9c5e503463bb1c4d6f8c6 DIFF: https://github.com/llvm/llvm-project/commit/fe35d72d8e248f1d29f9c5e503463bb1c4d6f8c6.diff

[clang-tools-extra] 2b00d44 - [clang-tools-extra] Use SmallString::operator std::string (NFC)

2024-01-26 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-26T23:46:24-08:00 New Revision: 2b00d449d2ed09cd0364038115f90a3eb4fd15b5 URL: https://github.com/llvm/llvm-project/commit/2b00d449d2ed09cd0364038115f90a3eb4fd15b5 DIFF: https://github.com/llvm/llvm-project/commit/2b00d449d2ed09cd0364038115f90a3eb4fd15b5.diff

[llvm] [clang] [clang-tools-extra] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/79568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e6c506 - [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (#79568)

2024-01-26 Thread via cfe-commits
Author: Younan Zhang Date: 2024-01-27T15:42:52+08:00 New Revision: 6e6c506f3caeafc25925b811b9cd205e2e213dd6 URL: https://github.com/llvm/llvm-project/commit/6e6c506f3caeafc25925b811b9cd205e2e213dd6 DIFF: https://github.com/llvm/llvm-project/commit/6e6c506f3caeafc25925b811b9cd205e2e213dd6.diff

[llvm] [clang] [clang-tools-extra] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread Younan Zhang via cfe-commits
zyn0217 wrote: The failing libcxx test `libcxx/gdb/gdb_pretty_printer_test.sh.cpp` doesn't appear to relate to this patch, so I'm landing it anyway. https://github.com/llvm/llvm-project/pull/79568 ___ cfe-commits mailing list

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
owenca wrote: This would break polly: ``` $ ninja polly-check-format [27/105] Checking format of /Users/Owe...ude/polly/CodeGen/BlockGenerators.h... FAILED: tools/polly/polly-check-format1 /Users/Owen/llvm-project/build/tools/polly/polly-check-format1 cd

[clang-tools-extra] [llvm] [clang] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/79568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: Don't think I can get the Windows+libcxx pre-commit CI working :| `libcxx/gdb/gdb_pretty_printer_test.sh.cpp` has `UNSUPPORTED` lines for clang 16-18 but 19 is missing now. Not sure how this works for others. https://github.com/llvm/llvm-project/pull/66514

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Shourya Goel via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected

[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

2024-01-26 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78720 >From 7a08876edcbae41cfbc1595348cd0c66ea813d7c Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 19 Jan 2024 08:37:21 -0500 Subject: [PATCH] [Clang][Sema] Allow elaborated-type-specifiers that

[clang] [clang-tools-extra] [llvm] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79568 >From 386c17d55f68155b711672f87d803eb934372a70 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 26 Jan 2024 18:03:37 +0800 Subject: [PATCH 1/2] [Concepts] Traverse the instantiation chain for parameter

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-26 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78595 >From 75524a1f443c86787f0605d7890a1caa01c5ebf5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 17 Jan 2024 10:13:29 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose use of template keyword

[clang] [Clang][Parse] Diagnose member template declarations with multiple declarators (PR #78243)

2024-01-26 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78243 >From c84243067045958d1d3007bd07bd49b7d4bfc642 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 12 Jan 2024 13:45:15 -0500 Subject: [PATCH 1/2] [Clang][Parse] Diagnose member template

[clang] [clang-tools-extra] [llvm] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-26 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: @MaskRay Would be glad to see your comments on changes addressing your comments https://github.com/llvm/llvm-project/pull/72714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-26 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/72714 >From c493d78e6c482bb530189de05b79e7082a224fab Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Thu, 28 Sep 2023 03:14:35 +0300 Subject: [PATCH 1/6] [lld][AArch64][ELF][PAC] Support AUTH relocations and

[clang] [Coverage] Map regions from system headers (PR #76950)

2024-01-26 Thread NAKAMURA Takumi via cfe-commits
chapuni wrote: Excuse me, I've reverted this. I posted a reduced testcase in #78920. Reproducible w/o `-fcoverage-mcdc`. https://github.com/llvm/llvm-project/pull/76950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] faef68b - Revert "[Coverage] Map regions from system headers (#76950)"

2024-01-26 Thread NAKAMURA Takumi via cfe-commits
Author: NAKAMURA Takumi Date: 2024-01-27T15:11:37+09:00 New Revision: faef68bca852d08511ea0311d8a0d221cb202e73 URL: https://github.com/llvm/llvm-project/commit/faef68bca852d08511ea0311d8a0d221cb202e73 DIFF:

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-26 Thread Konstantin Varlamov via cfe-commits
var-const wrote: > Yes, please, unless there's a strong reason not to, consider `-fhardened`. `-fhardened` also enables a few compiler flags. I think it would be better to have a separate flag that only affects the library and hopefully in the future start supporting `-fhardened` flag that

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-26 Thread Bhuminjay Soni via cfe-commits
11happy wrote: why the test maybe failing on windows build? https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass"" (PR #74056)

2024-01-26 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/74056 >From 9be777d5b39852cf3c0b2538fd5f712922672caa Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Fri, 1 Dec 2023 18:00:13 +0900 Subject: [PATCH] Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass""

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-26 Thread Konstantin Varlamov via cfe-commits
https://github.com/var-const approved this pull request. LGTM from the libc++ perspective, thanks a lot for working on this! https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-26 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; +

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
rmarker wrote: Addressed feedback. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [compiler-rt] [llvm] [clang-tools-extra] [clang] [libcxxabi] [openmp] [mlir] [libcxx] [libc] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-26 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/78632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -146,7 +146,7 @@ the configuration (without a prefix: ``Auto``). .. _BasedOnStyle: -**BasedOnStyle** (``String``) :ref:`¶ ` +**BasedOnStyle** (``String``) :ref:`¶ ` rmarker wrote: Yes it was generated on Windows. My guess is the platform is causing it

[flang] [compiler-rt] [llvm] [clang-tools-extra] [clang] [libcxxabi] [openmp] [mlir] [libcxx] [libc] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-26 Thread Yingchi Long via cfe-commits
@@ -21248,6 +21297,51 @@ static SDValue foldTruncStoreOfExt(SelectionDAG , SDNode *N) { return SDValue(); } +// A custom combine to lower load <3 x i8> as the more efficient sequence +// below: +//ldrb wX, [x0, #2] +//ldrh wY, [x0] +//orr wX, wY, wX, lsl #16

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -326,11 +326,13 @@ bool ContinuationIndenter::canBreak(const LineState ) { return false; } - // Don't break after very short return types (e.g. "void") as that is often - // unexpected. - if (Current.is(TT_FunctionDeclarationName) && State.Column < 6) { -if

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -9938,12 +9980,19 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { "return 1;\n" " }\n" " int g();\n" + " long\n" + " " + "fooo::"

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -9920,13 +9955,20 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class C {\n" " int f() { return 1; }\n" " int g();\n" + " long\n" + " " +

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -9906,12 +9934,19 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class B {\n" " int f() { return 1; }\n" " int g();\n" + " long\n" + " " +

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -9891,13 +9912,20 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { " }\n" " int\n" " g();\n" + " long\n" + " " + "fooo::"

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -9872,9 +9872,30 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class A {\n" " int f() { return 1; }\n" " int g();\n" + " long fooo::\n" + "

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
@@ -587,7 +589,9 @@ bool ContinuationIndenter::mustBreak(const LineState ) { !State.Line->ReturnTypeWrapped && // Don't break before a C# function when no break after return type. (!Style.isCSharp() || - Style.AlwaysBreakAfterReturnType !=

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread via cfe-commits
https://github.com/rmarker updated https://github.com/llvm/llvm-project/pull/78011 >From a1312a0a463bb946f336977b5b01ef7afbede678 Mon Sep 17 00:00:00 2001 From: rmarker Date: Thu, 11 Jan 2024 15:01:18 +1030 Subject: [PATCH 1/5] [clang-format] Add ShortReturnTypeColumn option. ---

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: @legrosbuffle This should be ready to again when you have a chance to take a look. Thanks! https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-26 Thread Qizhi Hu via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/jcsxky approved this pull request. https://github.com/llvm/llvm-project/pull/78284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-26 Thread Qizhi Hu via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: jcsxky wrote: I have tested the code locally and testcase from this [issue](https://github.com/llvm/llvm-project/issues/75114) and all works fine. So, I approve this patch. https://github.com/llvm/llvm-project/pull/78284

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/4] [llvm-exegesis] Add middle half repetition mode This

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -455,6 +466,26 @@ static void runBenchmarkConfigurations( Measurement.PerSnippetValue, NewMeasurement.PerSnippetValue); } } +} else if (RepetitionMode == boomanaiden154 wrote: Moved them to `ResultAggregator.cpp` and added

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/3] [llvm-exegesis] Add middle half repetition mode This

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 55c3537800b0a310999f58e2b410dc5c1a6f91e4 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to

[llvm] [clang] [libunwind] [mlir] [libc] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 1bd90e6a300dc8fd0b21a5a8dda2b40a41e6b128 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears

[flang] [compiler-rt] [llvm] [clang-tools-extra] [clang] [lld] [libcxxabi] [lldb] [mlir] [libcxx] [libc] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

2024-01-26 Thread Kai Sasaki via cfe-commits
https://github.com/Lewuathe closed https://github.com/llvm/llvm-project/pull/76316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libunwind] [libc] [clang] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 1bd90e6a300dc8fd0b21a5a8dda2b40a41e6b128 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 1bd90e6a300dc8fd0b21a5a8dda2b40a41e6b128 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears

[llvm] [clang-tools-extra] ValueTracking: Merge fcmpImpliesClass and fcmpToClassTest (PR #66522)

2024-01-26 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/66522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] ValueTracking: Merge fcmpImpliesClass and fcmpToClassTest (PR #66522)

2024-01-26 Thread Matt Arsenault via cfe-commits
@@ -2641,8 +2641,8 @@ define float @assume_false_smallest_normal(float %arg) { } define float @clamp_false_nan(float %arg) { -; CHECK-LABEL: define float @clamp_false_nan( -; CHECK-SAME: float returned [[ARG:%.*]]) #[[ATTR2]] { +; CHECK-LABEL: define nofpclass(nan inf nzero

[clang-tools-extra] [libc] [llvm] [clang] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/2] [llvm-exegesis] Add middle half repetition mode This

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -156,24 +161,19 @@ bool Sema::isSimpleTypeSpecifier(tok::TokenKind Kind) const { #define TRANSFORM_TYPE_TRAIT_DEF(_, Trait) case tok::kw___##Trait: #include "clang/Basic/TransformTypeTraits.def" case tok::kw___auto_type: -return true; - - case tok::annot_typename: +

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -196,6 +196,13 @@ class Token { PtrData = (void*) II; } + bool hasIdentifierInfo() { +if (is(tok::raw_identifier) || isAnnotation() || isLiteral() || +is(tok::eof)) + return false; +return true; + } + owenca wrote: IMO we

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -128,10 +128,15 @@ class TypeNameValidatorCCC final : public CorrectionCandidateCallback { } // end anonymous namespace /// Determine whether the token kind starts a simple-type-specifier. -bool Sema::isSimpleTypeSpecifier(tok::TokenKind Kind) const { +bool

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -2636,7 +2636,7 @@ class Sema final { void DiagnoseUseOfUnimplementedSelectors(); - bool isSimpleTypeSpecifier(tok::TokenKind Kind) const; + bool isSimpleTypeSpecifier(Token ) const; owenca wrote: ```suggestion bool isSimpleTypeSpecifier(const

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -156,24 +161,19 @@ bool Sema::isSimpleTypeSpecifier(tok::TokenKind Kind) const { #define TRANSFORM_TYPE_TRAIT_DEF(_, Trait) case tok::kw___##Trait: #include "clang/Basic/TransformTypeTraits.def" case tok::kw___auto_type: -return true; - - case tok::annot_typename: +

[clang] [clang][analyzer] Simplify code of StreamChecker (NFC). (PR #79312)

2024-01-26 Thread Ben Shi via cfe-commits
benshi001 wrote: For the part in the end of most `evalXX` functions, ``` StateFailed = ... StateNotFailed = ... ``` They are quite similar but not identical, so we can generalize them with helper functions. https://github.com/llvm/llvm-project/pull/79312

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

2024-01-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f826f55 - [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (#79549)

2024-01-26 Thread via cfe-commits
Author: Owen Pan Date: 2024-01-26T18:32:03-08:00 New Revision: f826f55b2ab68c2515fae751dc2d6ef77f37b172 URL: https://github.com/llvm/llvm-project/commit/f826f55b2ab68c2515fae751dc2d6ef77f37b172 DIFF: https://github.com/llvm/llvm-project/commit/f826f55b2ab68c2515fae751dc2d6ef77f37b172.diff

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -326,11 +326,13 @@ bool ContinuationIndenter::canBreak(const LineState ) { return false; } - // Don't break after very short return types (e.g. "void") as that is often - // unexpected. - if (Current.is(TT_FunctionDeclarationName) && State.Column < 6) { -if

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -146,7 +146,7 @@ the configuration (without a prefix: ``Auto``). .. _BasedOnStyle: -**BasedOnStyle** (``String``) :ref:`¶ ` +**BasedOnStyle** (``String``) :ref:`¶ ` owenca wrote: ```suggestion **BasedOnStyle** (``String``) :ref:`¶ ` ``` Was this

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -9938,12 +9980,19 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { "return 1;\n" " }\n" " int g();\n" + " long\n" + " " + "fooo::"

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -9920,13 +9955,20 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class C {\n" " int f() { return 1; }\n" " int g();\n" + " long\n" + " " +

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -9891,13 +9912,20 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { " }\n" " int\n" " g();\n" + " long\n" + " " + "fooo::"

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -587,7 +589,9 @@ bool ContinuationIndenter::mustBreak(const LineState ) { !State.Line->ReturnTypeWrapped && // Don't break before a C# function when no break after return type. (!Style.isCSharp() || - Style.AlwaysBreakAfterReturnType !=

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -9906,12 +9934,19 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class B {\n" " int f() { return 1; }\n" " int g();\n" + " long\n" + " " +

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-26 Thread Owen Pan via cfe-commits
@@ -9872,9 +9872,30 @@ TEST_F(FormatTest, ReturnTypeBreakingStyle) { verifyFormat("class A {\n" " int f() { return 1; }\n" " int g();\n" + " long fooo::\n" + "

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > LGTM. AFAIK only device libs compile OpenCL code without -mcpu. I don't think > it uses any of these predefined macros. That's what I figured from a cursory look at the ROCm-Device-Libs. The goal is to formalize this more to make more generic LLVM-IR.

[clang] [clang][ExprConst] allow single element access of vector object to be constant expression (PR #72607)

2024-01-26 Thread Yuanfang Chen via cfe-commits
@@ -144,6 +144,9 @@ sections with improvements to Clang's support for those languages. C++ Language Changes +- Allow single element access of vector object to be constant expression. + Supports the `V.xyzw` syntax and other tidbits as seen in OpenCL.

[libcxx] [clang-tools-extra] [llvm] [clang] [libc] [lld] [lldb] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via cfe-commits
RamaMalladiAWS wrote: Unable to get Windows build target machine allocated. Will reattempt another submission. https://github.com/llvm/llvm-project/pull/79655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libc] [lld] [lldb] [libcxx] [llvm] [clang] [clang-tools-extra] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via cfe-commits
https://github.com/RamaMalladiAWS closed https://github.com/llvm/llvm-project/pull/79655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [lld] [libcxx] [libcxxabi] [compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-26 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/79090 >From 54784e26f33178efd21b0289a1f673d66ea26cc3 Mon Sep 17 00:00:00 2001 From: wlei Date: Mon, 22 Jan 2024 19:16:26 -0800 Subject: [PATCH 1/3] [CSSPGO] Support post-match profile staleness metrics ---

[clang] [clang][analyzer] Improve modeling of 'popen' and 'pclose' in StdLibraryFunctionsChecker (PR #78895)

2024-01-26 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/78895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ff05c30 - [clang][analyzer] Improve modeling of 'popen' and 'pclose' in StdLibraryFunctionsChecker (#78895)

2024-01-26 Thread via cfe-commits
Author: Ben Shi Date: 2024-01-27T09:46:05+08:00 New Revision: ff05c3087b4b7e0121125d7f6860b3d9383ca91d URL: https://github.com/llvm/llvm-project/commit/ff05c3087b4b7e0121125d7f6860b3d9383ca91d DIFF: https://github.com/llvm/llvm-project/commit/ff05c3087b4b7e0121125d7f6860b3d9383ca91d.diff LOG:

[clang] [clang][analyzer] Simplify code of StreamChecker (NFC). (PR #79312)

2024-01-26 Thread Ben Shi via cfe-commits
benshi001 wrote: I do not like too long lambda either. In my opinion lambda should be short/compact. And I do not think the redundancy is serious, except the common part ``` ProgramStateRef State = C.getState(); SymbolRef StreamSym = getStreamArg(Desc, Call).getAsSymbol(); if

[libcxx] [clang-tools-extra] [lldb] [llvm] [lld] [libc] [clang] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via cfe-commits
https://github.com/RamaMalladiAWS updated https://github.com/llvm/llvm-project/pull/79655 >From 96aba7076392fb7f7479ec3a313ced5cfb714f81 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Fri, 26 Jan 2024 18:56:32 + Subject: [PATCH 1/2] intrinsic to generate a bfi instruction ---

[clang] [libcxx] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

2024-01-26 Thread via cfe-commits
alexfh wrote: > > As I understood the author, more time was needed to prepare the tests and > > the fix. I just tried to bring the tip of the tree to a good state soon > > (our internal release process was blocked on this) without putting any > > pressure on the author. > > Typically when

[clang] [Clang][Parse] Diagnose member template declarations with multiple declarators (PR #78243)

2024-01-26 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @erichkeane I have refactored `ParseSingleDeclarationAfterTemplate` (now named `ParseDeclarationAfterTemplate`) to call `ParseDeclGroup` and return the resultant `DeclGroup`. With respect to moving the point of diagnosis to `FinalizeDeclaratorGroup`: as of now, the

[clang] [Clang][Parse] Diagnose member template declarations with multiple declarators (PR #78243)

2024-01-26 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78243 >From 357d4665dac2da1d7899b72f1249de7bc8760342 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 12 Jan 2024 13:45:15 -0500 Subject: [PATCH 1/2] [Clang][Parse] Diagnose member template

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-26 Thread Devin Coughlin via cfe-commits
@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, devincoughlin wrote: With the name `stdlib_hardening`, are we worried

[flang] [lldb] [clang] [libcxxabi] [libc] [llvm] [compiler-rt] [lld] [clang-tools-extra] [libcxx] [llvm] Set emulated-tls by default for x86_64-windows-gnu target (PR #79542)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79542 >From 1039a36b2891f72192e77f2ef96736b1ab4315d8 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Thu, 25 Jan 2024 21:47:43 -0500 Subject: [PATCH] [llvm] set emulated-tls by default for MinGW x86_64-windows-gnu

[mlir] [lldb] [compiler-rt] [lld] [llvm] [libc] [clang-tools-extra] [clang] [libcxx] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired closed https://github.com/llvm/llvm-project/pull/77216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 1bd90e6a300dc8fd0b21a5a8dda2b40a41e6b128 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
trcrsired wrote: Fix partial formatting https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 04d9c984e5ed86b013fbe0b0df2037fbf1aaeea9 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to

[libcxx] [libunwind] [lldb] [clang] [llvm] [libc] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 39bc0171e7c07e367446dd1abdc56fd918013a9d Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears

[lldb] [libc] [libcxx] [clang] [llvm] [libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 39bc0171e7c07e367446dd1abdc56fd918013a9d Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
trcrsired wrote: i do not know whether old code should be formatted or not, because the LLVM dev said do not format old code https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 55c6d9103444aaf70bf680c3768c14e8649bf580 39bc0171e7c07e367446dd1abdc56fd918013a9d --

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: cqwrteur (trcrsired) Changes The wasm unwind build appears to be dysfunctional, likely because the author has only supplied a customized LLVM build on request, rather than a fully functional patch. This patch fixes the build ---

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired created https://github.com/llvm/llvm-project/pull/79667 The wasm unwind build appears to be dysfunctional, likely because the author has only supplied a customized LLVM build on request, rather than a fully functional patch. This patch fixes the build >From

[clang] [-Wunsafe-buffer-usage] Add a new warning for uses of std::span two-parameter constructors (PR #77148)

2024-01-26 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/77148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9816863 - [-Wunsafe-buffer-usage] Add a new warning for uses of std::span two-parameter constructors (#77148)

2024-01-26 Thread via cfe-commits
Author: Ziqing Luo Date: 2024-01-26T15:43:46-08:00 New Revision: 9816863dd439cd60c96d5764c4c21ca1a7f3d8da URL: https://github.com/llvm/llvm-project/commit/9816863dd439cd60c96d5764c4c21ca1a7f3d8da DIFF: https://github.com/llvm/llvm-project/commit/9816863dd439cd60c96d5764c4c21ca1a7f3d8da.diff

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/79660 >From ba04b20709cbf76ef6f1490081aecc125bdafec7 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 26 Jan 2024 16:25:30 -0600 Subject: [PATCH 1/2] [AMDGPU] Do not emit arch dependent macros with unspecified

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: LGTM. AFAIK only device libs compile OpenCL code without -mcpu. I don't think it uses any of these predefined macros. https://github.com/llvm/llvm-project/pull/79660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Yaxun Liu via cfe-commits
@@ -274,30 +274,31 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions , else Builder.defineMacro("__R600__"); - if (GPUKind != llvm::AMDGPU::GK_NONE) { -StringRef CanonName = isAMDGCN(getTriple()) ? - getArchNameAMDGCN(GPUKind) :

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; jrtc27 wrote: This looks like it needs

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected

  1   2   3   4   >