[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

Endilll wrote: I've built doxygen documentation locally. Now I see what I expected so see (proper member groups). https://github.com/llvm/llvm-project/pull/82217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/82217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] CXXConstructExpr may be immediate calls. (PR #82179)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/82179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9d3d6ec - [Clang] CXXConstructExpr may be immediate calls. (#82179)

Author: cor3ntin Date: 2024-02-19T08:45:38+01:00 New Revision: 9d3d6ec665d6284b6ba8c51a57a4a618d67a1697 URL: https://github.com/llvm/llvm-project/commit/9d3d6ec665d6284b6ba8c51a57a4a618d67a1697 DIFF: https://github.com/llvm/llvm-project/commit/9d3d6ec665d6284b6ba8c51a57a4a618d67a1697.diff

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

@@ -167,6 +167,10 @@ def FeatureCuMode : SubtargetFeature<"cumode", "Enable CU wavefront execution mode" >; +def FeaturePreciseMemory Pierre-vh wrote: The extra overhead is just 3 lines in `clang/lib/Driver/ToolChains/AMDGPU.cpp`, it's negligible. We

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

@@ -355,6 +356,18 @@ class SICacheControl { MachineBasicBlock::iterator ) const { return false; } + +public: + // The following is for supporting precise memory mode. When the option + // amdgpu-precise-memory is enabled, an s_waitcnt

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

https://github.com/Pierre-vh edited https://github.com/llvm/llvm-project/pull/79236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

https://github.com/Pierre-vh requested changes to this pull request. Did you try to move this to SIInsertWaitCnt, as suggested? https://github.com/llvm/llvm-project/pull/79236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clangd] Fix C++20 modules crash (PR #81919)

h-vetinari wrote: > A test will be helpful for us to understand what happened. There's a reproducer in https://github.com/llvm/llvm-project/issues/80570 https://github.com/llvm/llvm-project/pull/81919 ___ cfe-commits mailing list

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

https://github.com/saiislam commented: May be merge the two PRs in one? They both are not independent. https://github.com/llvm/llvm-project/pull/82220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/82217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Animesh Kumar (animeshk-amd) Changes This patch fixes the #67002 ([OpenMP][Clang] Scan Directive not supported for Generic types). It disables the Sema checks/analysis that are run on the helper arrays which go into the implementation of

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

https://github.com/animeshk-amd created https://github.com/llvm/llvm-project/pull/82220 This patch fixes the #67002 ([OpenMP][Clang] Scan Directive not supported for Generic types). It disables the Sema checks/analysis that are run on the helper arrays which go into the implementation of the

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/82217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd7386d85f11cf6ad911b9827c7018fb08c6c205 681cecc15a472aede4c6d4bf1e75c755fdcce3e5 --

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/82217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch regroups declarations in `Sema` based on the file they are implemented in (e.g. `SemaChecking.cpp`). This allows to logically split `Sema` in 42 groups. Table of contents added at the very

[clang] [Serialization] Load Specializations Lazily (PR #76774)

vgvassilev wrote: > > Let's zoom out a little. The approach in D41416 shows that it is feasible > > to store _a_ hash of the template arguments to delay eager > > deserializations. The ODR hash approach is a second order problem because > > we can swap it with something better once we need

[clang] [Analyzer] Support RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed (PR #82209)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82209 >From 196ab7a875040a6b653a118b88d3e892d2256b46 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 18 Feb 2024 21:47:48 -0800 Subject: [PATCH] [Analyzer] Support RefAllowingPartiallyDestroyed and

[clang] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to WTF's container methods (PR #82156)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82156 >From d169fddf3896bd334bc4776059258116ac08096a Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 18 Feb 2024 01:32:00 -0800 Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to WTF's

[clang] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to WTF's container methods (PR #82156)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82156 >From 51b65a767eee7bae07932c073702502a701d4ef2 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 18 Feb 2024 01:32:00 -0800 Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore calls to WTF's

[clang] [Analyzer] Support RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed (PR #82209)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ead0a9777f8ccb5c26d50d96bade6cd5b47f496b d26f41816f443922569fc713d1cd919fd96ba124 --

[clang] [Analyzer] Support RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed (PR #82209)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes This PR adds the support for WebKit's RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed, which are smart pointer types which may be used after the destructor had started running. --- Full

[clang] [Analyzer] Support RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed (PR #82209)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/82209 This PR adds the support for WebKit's RefAllowingPartiallyDestroyed and RefPtrAllowingPartiallyDestroyed, which are smart pointer types which may be used after the destructor had started running. >From

[clang] [compiler-rt] [llvm] [InstrProf] Single byte counters in coverage (PR #75425)

https://github.com/evodius96 approved this pull request. LGTM. I would like to see this broadened to include branch coverage as well! https://github.com/llvm/llvm-project/pull/75425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

brad0 wrote: > What's the issue? GNU ld has had -Bsymbolic-functions since 2007 and for > quite a few releases LLVM has been using `-Bsymbolic-functions`. This is binutils 2.17. We've had patches for awhile in our tree too specifically for the exceptions not using LLD.

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

Atousa wrote: @AaronBallman @tbaederr, Do you have any further comments? https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

wheatman wrote: I believe I have correct implementations added for N3029 and N3030. I also tried to add tests. One thing I was not sure about was how to add tests that have different expected behavior for different versions. I just used `#if __STDC_VERSION__ < 202311L` but please let me

[clang] [Clang] CXXConstructExpr may be immediate calls. (PR #82179)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/82179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Load Specializations Lazily (PR #76774)

ChuanqiXu9 wrote: > Let's zoom out a little. The approach in D41416 shows that it is feasible to > store _a_ hash of the template arguments to delay eager deserializations. The > ODR hash approach is a second order problem because we can swap it with > something better once we need to. In

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

@@ -0,0 +1,38 @@ +// Test that -print-library-module-manifest-path finds the correct file. + +// REQUIRES: x86-registered-target ChuanqiXu9 wrote: ```suggestion // FIXME: // REQUIRES: x86-registered-target ``` I feel better with a FIXME to remind us to

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/82160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/82160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

https://github.com/HerrCai0907 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

@@ -42,10 +43,28 @@ void AvoidReturnWithVoidValueCheck::check( const auto *VoidReturn = Result.Nodes.getNodeAs("void_return"); if (IgnoreMacros && VoidReturn->getBeginLoc().isMacroID()) return; - if (!StrictMode && !Result.Nodes.getNodeAs("compound_parent")) + const

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeCoverage] Fix conditional-operator test (PR #82192)

https://github.com/dtellenbach closed https://github.com/llvm/llvm-project/pull/82192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7970949 - [clang][CodeCoverage] Fix conditional-operator test (#82192)

Author: David Tellenbach Date: 2024-02-18T15:11:08-08:00 New Revision: 79709498eaa57095a9888b882e94f6d15a244d4b URL: https://github.com/llvm/llvm-project/commit/79709498eaa57095a9888b882e94f6d15a244d4b DIFF:

[clang] [clang][CodeCoverage] Fix conditional-operator test (PR #82192)

llvmbot wrote: @llvm/pr-subscribers-clang Author: David Tellenbach (dtellenbach) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/82192.diff 1 Files Affected: - (modified) clang/test/CoverageMapping/conditional-operator.c (+1-1) ``diff diff --git

[clang] [clang][CodeCoverage] Fix conditional-operator test (PR #82192)

https://github.com/dtellenbach created https://github.com/llvm/llvm-project/pull/82192 None >From 23b311470d4609fa394bc51b6fce8af83aeff022 Mon Sep 17 00:00:00 2001 From: David Tellenbach Date: Sun, 18 Feb 2024 14:46:43 -0800 Subject: [PATCH] [clang][CodeCoverage] Fix conditional-operator test

[clang] [clang][CodeCoverage] Fix CoverageMapping for binary conditionals ops (PR #82141)

https://github.com/dtellenbach closed https://github.com/llvm/llvm-project/pull/82141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dc94eb5 - [clang][CodeCoverage] Fix CoverageMapping for binary conditionals ops (#82141)

Author: David Tellenbach Date: 2024-02-18T14:34:35-08:00 New Revision: dc94eb57e39a925a9672bfc4d7cba0fb0da874d8 URL: https://github.com/llvm/llvm-project/commit/dc94eb57e39a925a9672bfc4d7cba0fb0da874d8 DIFF:

[clang] [clang][CodeCoverage] Fix CoverageMapping for binary conditionals ops (PR #82141)

@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -mllvm -emptyline-comment-coverage=false -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping -emit-llvm-only %s | FileCheck %s + +// CHECK-LABEL: binary_conditional: +// CHECK-NEXT: File 0, [[@LINE+4]]:31 ->

[clang] [clang][CodeCoverage] Fix CoverageMapping for binary conditionals ops (PR #82141)

https://github.com/dtellenbach updated https://github.com/llvm/llvm-project/pull/82141 >From f8e11fed8b4b6b0cc359e2915e4f2f32c3f08bb5 Mon Sep 17 00:00:00 2001 From: David Tellenbach Date: Sat, 17 Feb 2024 15:16:39 -0800 Subject: [PATCH 1/2] [clang][CodeCoverage] Fix CoverageMapping for binary

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

https://github.com/SimplyDanny closed https://github.com/llvm/llvm-project/pull/82166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 5e83b26 - [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (#82166)

Author: Danny Mösch Date: 2024-02-18T22:42:17+01:00 New Revision: 5e83b26584c9a02f8a2923651d08cad2dcc8479a URL: https://github.com/llvm/llvm-project/commit/5e83b26584c9a02f8a2923651d08cad2dcc8479a DIFF: https://github.com/llvm/llvm-project/commit/5e83b26584c9a02f8a2923651d08cad2dcc8479a.diff

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

https://github.com/SimplyDanny updated https://github.com/llvm/llvm-project/pull/81420 From b99fe4bcec7ac74f6511538959fe2e14689b1cdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danny=20M=C3=B6sch?= Date: Sun, 11 Feb 2024 17:04:12 +0100 Subject: [PATCH] [clang-tidy] Add fix-its to

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

https://github.com/SimplyDanny updated https://github.com/llvm/llvm-project/pull/82166 From 7aa267d752408fedcf14b62cd015d90de6719459 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danny=20M=C3=B6sch?= Date: Sun, 18 Feb 2024 14:46:54 +0100 Subject: [PATCH 1/5] [clang-tidy] Keep parentheses when

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= Message-ID: In-Reply-To: @@ -1,4 +1,6 @@ -// RUN: %check_clang_tidy %s modernize-loop-convert %t -- -- -I %S/Inputs/loop-convert +// RUN: %check_clang_tidy %s modernize-loop-convert %t -- -- -I %S/Inputs/loop-convert -isystem

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= Message-ID: In-Reply-To: https://github.com/PiotrZSL approved this pull request. Overall, LGTM. https://github.com/llvm/llvm-project/pull/82166 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= Message-ID: In-Reply-To: @@ -706,13 +706,17 @@ void LoopConvertCheck::doConversion( ReplaceText = Usage.Kind == Usage::UK_MemberThroughArrow ? VarNameOrStructuredBinding + "."

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= Message-ID: In-Reply-To: https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/82166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Thread safety analysis: provide printSCFG definition. (PR #80277)

aaronpuchert wrote: It might have been commented out so that it doesn't take up space in the compiled binary. I'd like seeing it compiled, just to make sure it doesn't break. But I'd also like if it doesn't appear in the final binary. Perhaps we can change visibility so that `--gc-sections`

[clang] cc2fe7b - [clang][Interp][NFC] Make Record::{Base,Field} member pointers const

Author: Timm Bäder Date: 2024-02-18T18:07:29+01:00 New Revision: cc2fe7b516c1dbf1f8747ade0f17891f9990dede URL: https://github.com/llvm/llvm-project/commit/cc2fe7b516c1dbf1f8747ade0f17891f9990dede DIFF: https://github.com/llvm/llvm-project/commit/cc2fe7b516c1dbf1f8747ade0f17891f9990dede.diff

[clang] [Clang] CXXConstructExpr may be immediate calls. (PR #82179)

llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes A CXXConstructExpr may refer to an immediate constructor, in which case it should be substituted in the enclosing default init expression. Fixes #82154 --- Full diff:

[clang] [Clang] CXXConstructExpr may be immediate calls. (PR #82179)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/82179 A CXXConstructExpr may refer to an immediate constructor, in which case it should be substituted in the enclosing default init expression. Fixes #82154 >From c44bc36631c0b36f4a8e91f50221cc0f6d85038d Mon Sep

[clang] 4136405 - [clang][Interp] Not all record bases are of RecordType

Author: Timm Bäder Date: 2024-02-18T18:07:29+01:00 New Revision: 41364051ac9380a6b62f61c794fc5978b2e703c9 URL: https://github.com/llvm/llvm-project/commit/41364051ac9380a6b62f61c794fc5978b2e703c9 DIFF: https://github.com/llvm/llvm-project/commit/41364051ac9380a6b62f61c794fc5978b2e703c9.diff

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

https://github.com/SimplyDanny updated https://github.com/llvm/llvm-project/pull/82166 From cd3c0d0d4b3133927a830c249a541510bacfabf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danny=20M=C3=B6sch?= Date: Sun, 18 Feb 2024 14:46:54 +0100 Subject: [PATCH 1/3] [clang-tidy] Keep parentheses when

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

https://github.com/SimplyDanny updated https://github.com/llvm/llvm-project/pull/82166 From cd3c0d0d4b3133927a830c249a541510bacfabf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danny=20M=C3=B6sch?= Date: Sun, 18 Feb 2024 14:46:54 +0100 Subject: [PATCH 1/2] [clang-tidy] Keep parentheses when

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

@@ -711,8 +711,12 @@ void LoopConvertCheck::doConversion( if (const auto *Paren = Parents[0].get()) { // Usage.Expression will be replaced with the new index variable, // and parenthesis around a simple DeclRefExpr can always be -

[clang] ba27c39 - [clang][Interp] Classify correct type for compound shifts

Author: Timm Bäder Date: 2024-02-18T16:31:40+01:00 New Revision: ba27c3963d785a023cc8963ec3b6f508fe31527e URL: https://github.com/llvm/llvm-project/commit/ba27c3963d785a023cc8963ec3b6f508fe31527e DIFF: https://github.com/llvm/llvm-project/commit/ba27c3963d785a023cc8963ec3b6f508fe31527e.diff

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

https://github.com/s-barannikov closed https://github.com/llvm/llvm-project/pull/68550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2d0137d - [clang] Differentiate between identifier and string EnumArgument (#68550)

Author: Sergei Barannikov Date: 2024-02-18T17:44:19+03:00 New Revision: 2d0137dd64017c34101f8a763fd8958c20acd6bb URL: https://github.com/llvm/llvm-project/commit/2d0137dd64017c34101f8a763fd8958c20acd6bb DIFF:

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

https://github.com/s-barannikov updated https://github.com/llvm/llvm-project/pull/68550 >From 96dd0121b095f92cc66fcfc3ef08a19d0b2d6bec Mon Sep 17 00:00:00 2001 From: Sergei Barannikov Date: Mon, 9 Oct 2023 01:38:33 +0300 Subject: [PATCH 1/2] [clang] Differentiate between identifier and string

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Danny Mösch (SimplyDanny) Changes Fixes #56021. --- Full diff: https://github.com/llvm/llvm-project/pull/82166.diff 3 Files Affected: - (modified)

[clang-tools-extra] [clang-tidy] Keep parentheses when replacing index access in `sizeof` calls (PR #82166)

https://github.com/SimplyDanny created https://github.com/llvm/llvm-project/pull/82166 Fixes #56021. From cd3c0d0d4b3133927a830c249a541510bacfabf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danny=20M=C3=B6sch?= Date: Sun, 18 Feb 2024 14:46:54 +0100 Subject: [PATCH] [clang-tidy] Keep parentheses

[clang] [Clang] Fix looking for immediate calls in default arguments. (PR #80690)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/80690 >From 77556982a14dc7969a5ab6dc19ce0bfc8a0a763c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 5 Feb 2024 15:42:21 +0100 Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/78742 >From 6bbd4953ff86a120097fae7bb83e00989392c14f Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Fri, 19 Jan 2024 11:13:33 -0500 Subject: [PATCH] [clang][Sema] Fix for enums overflowing (#24667) Enums which

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/8] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/78742 >From 88a908062d5d217d529b48028bd861bdf6fa9e76 Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Fri, 19 Jan 2024 11:13:33 -0500 Subject: [PATCH] [clang][Sema] Fix for enums overflowing (#24667) Enums which

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/4] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/3] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: Done. File removed, and a FIXME comment added for the existing test. https://github.com/llvm/llvm-project/pull/77178 ___

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ Abhinkop wrote: Didn't have to do it as the

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/3] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/2] [clang] move -Wcast-function-type under -Wextra ---

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

vinayakdsci wrote: OK, it looks like there should not be a warning in C++11 and 14 too, as copy initialization with side effects appears to be permitted sine C++11. Could you direct me to the functions that Clang uses internally for implicit type conversion? I am sure that using that I will be

[clang] [Clang][Sema] Remove invalid ctor (NFC) (PR #82161)

https://github.com/Smertig edited https://github.com/llvm/llvm-project/pull/82161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Remove invalid ctor (NFC) (PR #82161)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander (Smertig) Changes `TemplateArgumentLocInventIterator` default constructor should not exists https://github.com/llvm/llvm-project/blob/3496927edcd0685807351ba88a7e2cfb006e1c0d/clang/lib/Sema/TreeTransform.h#L4742 because it

[clang] [Clang][Sema] Remove invalid ctor (NFC) (PR #82161)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [Clang][Sema] Remove invalid ctor (NFC) (PR #82161)

https://github.com/Smertig created https://github.com/llvm/llvm-project/pull/82161 `TemplateArgumentLocInventIterator` default constructor should not exists https://github.com/llvm/llvm-project/blob/3496927edcd0685807351ba88a7e2cfb006e1c0d/clang/lib/Sema/TreeTransform.h#L4742 because it

[clang] [clang][modules] Print library module manifest path. (PR #76451)

mordante wrote: > (This is another example that the github review can't work well with the > reverted patches...) > > @mordante I think you can add `// REQUIRES: x86-registered-target` to the > test if @kaz7 can't respond quickly. It will skip the test on targets other > than x86. And it

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Mark de Wever (mordante) Changes This implements a way for the compiler to find the modules.json associated with the C++23 Standard library modules. This is based on a discussion in SG15. At the moment no Standard library installs this

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/82160 This implements a way for the compiler to find the modules.json associated with the C++23 Standard library modules. This is based on a discussion in SG15. At the moment no Standard library installs this

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

cor3ntin wrote: @AaronBallman does not handling c++11 make sense to you? Thanks! https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement `__is_layout_compatible` (PR #81506)

https://github.com/cor3ntin approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/81506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement `__is_layout_compatible` (PR #81506)

@@ -90,6 +90,12 @@ C++20 Feature Support behavior can use the flag '-Xclang -fno-skip-odr-check-in-gmf'. (`#79240 `_). +- Implemented `__is_layout_compatible` intrinsic, which backs up + `P0466R5: Layout-compatibility

[clang] [clang] Implement `__is_layout_compatible` (PR #81506)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/81506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

vinayakdsci wrote: @cor3ntin gentle ping. Could you direct on what other changes are required? Thanks! https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Fixes to readability-implicit-bool-conversion (PR #72050)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/72050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 3496927 - [clang-tidy] Fixes to readability-implicit-bool-conversion (#72050)

Author: Piotr Zegar Date: 2024-02-18T12:30:43+01:00 New Revision: 3496927edcd0685807351ba88a7e2cfb006e1c0d URL: https://github.com/llvm/llvm-project/commit/3496927edcd0685807351ba88a7e2cfb006e1c0d DIFF: https://github.com/llvm/llvm-project/commit/3496927edcd0685807351ba88a7e2cfb006e1c0d.diff

[clang] [NVPTX][AMDGPU][CodeGen] Fix `local_space nullptr` handling for NVPTX and local/private `nullptr` value for AMDGPU. (PR #78759)

https://github.com/mmoadeli updated https://github.com/llvm/llvm-project/pull/78759 >From 9d743cbf91dd727dc32e994e82205f8114a44d7b Mon Sep 17 00:00:00 2001 From: m moadeli Date: Fri, 19 Jan 2024 18:42:24 + Subject: [PATCH 1/2] - Address space cast of a `local_space` specialized `nullptr`

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

https://github.com/tom-anders updated https://github.com/llvm/llvm-project/pull/78454 >From 3a1ef6006764bd4d307ceec74199ed81a18aba2d Mon Sep 17 00:00:00 2001 From: tom-anders <13141438+tom-and...@users.noreply.github.com> Date: Wed, 17 Jan 2024 15:36:02 +0100 Subject: [PATCH] [clangd] forward

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

tom-anders wrote: > Something else I noticed while trying out the patch locally: before the > patch, the description of the code action in the editor is "change 'foo' to > 'Foo'", i.e. a description of what the code action will do. > > After the patch, the description of the code action is

[clang] [Serialization] Load Specializations Lazily (PR #76774)

vgvassilev wrote: Let's zoom out a little. The approach in D41416 shows that it is feasible to store *a* hash of the template arguments to delay eager deserializations. The ODR hash approach is a second order problem because we can swap it with something better once we need to. In order to

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

@@ -648,6 +649,27 @@ tweakSelection(const Range , const InputsAndAST , return std::move(Result); } +// Some fixes may perform local renaming, we want to convert those to clangd +// rename commands, such that we can leverage the index for more accurate +// results.

[clang-tools-extra] [clang-tidy] Fixes to readability-implicit-bool-conversion (PR #72050)

https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/72050 >From f77e3fce830166cdc9ffce42db6599c407147ba3 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Sun, 12 Nov 2023 11:31:21 + Subject: [PATCH] [clang-tidy] Fixes to readability-implicit-bool-conversion -

[clang] [Serialization] Load Specializations Lazily (PR #76774)

ChuanqiXu9 wrote: > > But my point is that we can't land that if we don't understand what's going > > wrong without that patch. > > We understand that very well and it's described in > https://reviews.llvm.org/D153003 as well as the surrounding discussions: > because of the way that

[clang] [Serialization] Load Specializations Lazily (PR #76774)

hahnjo wrote: > But my point is that we can't land that if we don't understand what's going > wrong without that patch. We understand that very well and it's described in https://reviews.llvm.org/D153003 as well as the surrounding discussions: because of the way that `ODRHash` works,

  1   2   >