[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-09 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/84599 >From 43238d58ff490073c13ff621faddceb89b05b22e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 8 Mar 2024 19:47:54 -0800 Subject: [PATCH 1/2] [clang-format][NFC] Eliminate the IsCpp parameter in all functions

[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-09 Thread Owen Pan via cfe-commits
owenca wrote: > That's okay for clang-format, but you couldn't use libFormat with different > languages at once anymore. I believe we still could because `IsCpp` is set to `Style.isCpp()` every time new instances of the classes are constructed. I'll add a couple of test cases to demonstrate

[clang] [clang-format] Fix a bug in annotating function declaration names (PR #76206)

2024-03-09 Thread Owen Pan via cfe-commits
owenca wrote: > Thanks for doing this. Does it mean we would have to add every type we use to > our config? It would be much more convenient if clang-format treated the > argument list the same way that it treats in definitions. For example > > ```shell > printf "int\niso_time(time_t) {

[clang] [clang][Interp] Implement __builtin_popcountg (PR #84500)

2024-03-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/84500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e95040f - [clang][Interp] Implement __builtin_popcountg (#84500)

2024-03-09 Thread via cfe-commits
Author: OverMighty Date: 2024-03-10T06:54:03+01:00 New Revision: e95040f0f05b74406e9d7ee02b110470588cc5f0 URL: https://github.com/llvm/llvm-project/commit/e95040f0f05b74406e9d7ee02b110470588cc5f0 DIFF: https://github.com/llvm/llvm-project/commit/e95040f0f05b74406e9d7ee02b110470588cc5f0.diff

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-09 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin Message-ID: In-Reply-To: https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-09 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin Message-ID: In-Reply-To: @@ -342,3 +342,21 @@ typedef int InExternCPP; // CHECK-FIXES: using InExternCPP = int; } + +namespace ISSUE_72179 +{ + void foo() + { +typedef int a; +//

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-09 Thread Piotr Zegar via cfe-commits
=?utf-8?q?F=C3=A9lix-Antoine?= Constantin, =?utf-8?q?F=C3=A9lix-Antoine?= Constantin Message-ID: In-Reply-To: https://github.com/PiotrZSL approved this pull request. Overall fine. https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-09 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Félix-Antoine?= Constantin, =?utf-8?q?Félix-Antoine?= Constantin Message-ID: In-Reply-To: @@ -183,6 +183,9 @@ Changes in existing checks ` check to also remove any trailing whitespace when deleting the ``virtual`` keyword. +- Improved :doc:`modernize-use-using

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2024-03-09 Thread via cfe-commits
@@ -123,6 +123,15 @@ // CHECK-CHAR8_T_: "-fno-char8_t" +// RUN: %clang_cl /TC /dev/null /E -Xclang -dM 2> /dev/null | FileCheck -match-full-lines %s --check-prefix=NOSTDC xbjfk wrote: Moved to clang/test/Preprocessor, thanks!

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2024-03-09 Thread via cfe-commits
https://github.com/xbjfk updated https://github.com/llvm/llvm-project/pull/68690 >From 391eb28dbf4d2e912d072893ff7c57077c718bca Mon Sep 17 00:00:00 2001 From: Reagan Bohan Date: Sun, 10 Mar 2024 01:49:37 + Subject: [PATCH] [clang] Add /Zc:__STDC__ flag to clang-cl This commit adds the

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-09 Thread Kees Cook via cfe-commits
kees wrote: > Left my comment on the main list, but I don't see this as a well motivated > change, and even if GCC supported it, it would still be a very difficult to > motivate extension without massive historical workloads already using it. This is needed by the Linux kernel, and is in

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-09 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82947 From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 20:20:59 -0500 Subject: [PATCH 1/3] [clang-tidy] Improved

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2024-03-09 Thread via cfe-commits
https://github.com/xbjfk updated https://github.com/llvm/llvm-project/pull/68690 >From adfced08cd4c150b02345629e1bd9c5bc4681f09 Mon Sep 17 00:00:00 2001 From: Reagan Bohan Date: Sun, 10 Mar 2024 01:49:37 + Subject: [PATCH] [clang] Add /Zc:__STDC__ flag to clang-cl This commit adds the

[clang] Document runtime config directory options (PR #66593)

2024-03-09 Thread via cfe-commits
https://github.com/xbjfk updated https://github.com/llvm/llvm-project/pull/66593 >From 0d50e2892bd055053e0e61615911928371106e17 Mon Sep 17 00:00:00 2001 From: Reagan Bohan Date: Sun, 17 Sep 2023 21:19:33 +1200 Subject: [PATCH] Document runtime config directory options ---

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane requested changes to this pull request. Left my comment on the main list, but I don't see this as a well motivated change, and even if GCC supported it, it would still be a very difficult to motivate extension without massive historical workloads already using it.

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-09 Thread Erich Keane via cfe-commits
erichkeane wrote: I'm pretty unmotivated here, I don't think it is worth allowing this all the time thanks to it not really being a conforming extension, and I don't think it is sufficiently worth creating a dialect over with the flag. >From what I can see, the GCC folks are equally as

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

2024-03-09 Thread Lei Wang via cfe-commits
wlei-llvm wrote: ``` clang++ -std=gnu++20 test.cpp clang-18: /../llvm-project/llvm/include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = clang::CXXRecordDecl, From = clang::DeclContext]: Assertion `isa(Val) && "cast() argument of incompatible type!"' failed. PLEASE

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-03-09 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 edited https://github.com/llvm/llvm-project/pull/84651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

2024-03-09 Thread Lei Wang via cfe-commits
wlei-llvm wrote: Here is the repro from our side. It's reduced by creduce, there are some unrelated error, the assertion is the real issue. ``` typedef a; template < typename b, b c > struct d { static constexpr b e = c; }; typedef d< bool, true > f; typedef d< bool, false > g; template <

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-03-09 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Max Winkler (MaxEW707) Changes Hit this when trying upgrade an old project of mine. I couldn't find a corresponding existing issue for this when spelunking the open issues here on github. Thankfully I can work-around it today with the

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Max Winkler (MaxEW707) Changes Hit this when trying upgrade an old project of mine. I couldn't find a corresponding existing issue for this when spelunking the open issues here on github. Thankfully I can work-around it today

[clang] [Clang][CodeGen] Fix `CanSkipVTablePointerInitialization` for dynamic classes with a trivial anonymous union (PR #84651)

2024-03-09 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 created https://github.com/llvm/llvm-project/pull/84651 Hit this when trying upgrade an old project of mine. I couldn't find a corresponding existing issue for this when spelunking the open issues here on github. Thankfully I can work-around it today with the

[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-09 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: That's okay for clang-format, but you couldn't use libFormat with different languages at once anymore. I dislike global state in libraries. https://github.com/llvm/llvm-project/pull/84599 ___ cfe-commits mailing list

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-09 Thread Heejin Ahn via cfe-commits
aheejin wrote: > > > In terms of getting this landed and tested, I wonder which path we should > > > take: > > > > > > 1. Land this now, without tests, then update emscripten then come back > > > and flip the default, at which point the existing tests will get updated. > > > 2.

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/84621 >From 2603e170c127aa614d499e5d527db8503a55c651 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 2 Mar 2024 15:37:33 +0330 Subject: [PATCH] [clang][Sema] Track trivial-relocatability as a type trait To

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/77092 >From ed94371b8e2293642731b72948883c2ec20bd09d Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Wed, 3 Jan 2024 23:23:14 +0330 Subject: [PATCH 1/2] [clang] Fix behavior of

[clang] [NFC] Eliminate trailing white space causing CI build failure (PR #84632)

2024-03-09 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/84632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b4001e3 - [NFC] Eliminate trailing white space causing CI build failure (#84632)

2024-03-09 Thread via cfe-commits
Author: Amirreza Ashouri Date: 2024-03-10T01:17:29+08:00 New Revision: b4001e32b1aa4df07dc6babefba19f2b77f487c6 URL: https://github.com/llvm/llvm-project/commit/b4001e32b1aa4df07dc6babefba19f2b77f487c6 DIFF:

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2024-03-09 Thread via cfe-commits
hoyhoy wrote: cmake is broken as well. It includes zlib internally. https://gitlab.kitware.com/cmake/cmake/-/issues/25755 https://github.com/llvm/llvm-project/pull/74676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Diego A. Estrada Rivera (diego-est) Changes >From issue #73088. I changed `NodeBuilderContext` into a class. >Additionally, there were some other mentions of the former being a struct >which I

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-09 Thread Diego A. Estrada Rivera via cfe-commits
https://github.com/diego-est created https://github.com/llvm/llvm-project/pull/84638 >From issue #73088. I changed `NodeBuilderContext` into a class. Additionally, >there were some other mentions of the former being a struct which I also >changed into a class. This is my first time working

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-09 Thread Sam Clegg via cfe-commits
sbc100 wrote: > > In terms of getting this landed and tested, I wonder which path we should > > take: > > > > 1. Land this now, without tests, then update emscripten then come back and > > flip the default, at which point the existing tests will get updated. > > 2. Duplicate/update the the

[clang] [Clang][Sema] Allow access to a public template alias declaration that refers to friend's private nested type (PR #83847)

2024-03-09 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/83847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Allow access to a public template alias declaration that refers to friend's private nested type (PR #83847)

2024-03-09 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/83847 >From 8541506bdbe26b9f24e47e5a372fe89124eaff47 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Mon, 4 Mar 2024 21:51:07 +0800 Subject: [PATCH] [Clang][Sema] Allow access to a public template alias declaration that

[clang] [Clang][Sema] Allow access to a public template alias declaration that refers to friend's private nested type (PR #83847)

2024-03-09 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/83847 >From 76c7e3e19a1d5e3f35f1d3e9d9c99b76e973ff00 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Mon, 4 Mar 2024 21:51:07 +0800 Subject: [PATCH] [Clang][Sema] Allow access to a public template alias declaration that

[clang] [NFC] Eliminate trailing white space causing CI build failure (PR #84632)

2024-03-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/84632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]avoid bugprone-unused-return-value false positive for assignment operator overloading (PR #84489)

2024-03-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/84489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4fdf10f - [clang-tidy]avoid bugprone-unused-return-value false positive for assignment operator overloading (#84489)

2024-03-09 Thread via cfe-commits
Author: Congcong Cai Date: 2024-03-09T23:08:51+08:00 New Revision: 4fdf10faf2b45f4bbbd2ddfb07272d19a47cc531 URL: https://github.com/llvm/llvm-project/commit/4fdf10faf2b45f4bbbd2ddfb07272d19a47cc531 DIFF: https://github.com/llvm/llvm-project/commit/4fdf10faf2b45f4bbbd2ddfb07272d19a47cc531.diff

[clang] e733d7e - Fix test clang-offload-bundler-zstd.c

2024-03-09 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2024-03-09T10:07:57-05:00 New Revision: e733d7e23f6553c55c85edd55511b133d2064677 URL: https://github.com/llvm/llvm-project/commit/e733d7e23f6553c55c85edd55511b133d2064677 DIFF:

[clang] [NFC] Eliminate trailing white space causing CI build failure (PR #84632)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amirreza Ashouri (AMP999) Changes To resolve the following issue in the CI build: ``` *** Checking for trailing whitespace left in Clang source files *** + grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs

[clang] [NFC] Eliminate trailing white space causing CI build failure (PR #84632)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 created https://github.com/llvm/llvm-project/pull/84632 To resolve the following issue in the CI build: ``` *** Checking for trailing whitespace left in Clang source files *** + grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-09 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 124d0b7 - [HIP] add --offload-compression-level= option (#83605)

2024-03-09 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2024-03-09T09:45:48-05:00 New Revision: 124d0b787b5d1ff4aa06bbd61a98d3fc344d0cc6 URL: https://github.com/llvm/llvm-project/commit/124d0b787b5d1ff4aa06bbd61a98d3fc344d0cc6 DIFF:

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/84621 >From 2603e170c127aa614d499e5d527db8503a55c651 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 2 Mar 2024 15:37:33 +0330 Subject: [PATCH] [clang][Sema] Track trivial-relocatability as a type trait To

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
AMP999 wrote: @mordante Thank you! I've resolved merge conflicts. I've also added an NFC commit to remove empty messages from `static_assert`s for consistency with the rest of the file. https://github.com/llvm/llvm-project/pull/77092 ___ cfe-commits

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/77092 >From ed94371b8e2293642731b72948883c2ec20bd09d Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Wed, 3 Jan 2024 23:23:14 +0330 Subject: [PATCH 1/2] [clang] Fix behavior of

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

2024-03-09 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/83938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

2024-03-09 Thread Xiang Li via cfe-commits
@@ -69,6 +69,21 @@ LangStandard::Kind LangStandard::getLangKind(StringRef Name) { .Default(lang_unspecified); } +LangStandard::Kind LangStandard::getHLSLLangKind(StringRef Name) { + if (Name == "2016") python3kgae wrote: Maybe a StringSwitch here.

[clang] [Clang] [Parser] Support [[omp::assume]] (PR #84582)

2024-03-09 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/84582 >From d436f7fefb967f050220a8ede6d05c8e26f363b3 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Fri, 8 Mar 2024 23:54:14 +0100 Subject: [PATCH 1/2] [Clang] [Parser] Support [[omp::assume]] ---

[clang] [clang][Interp] Implement __builtin_popcountg (PR #84500)

2024-03-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/84500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-09 Thread Mark de Wever via cfe-commits
mordante wrote: @AMP999 I wanted to merge this for you but there are merge conflicts. Can you resolve these? https://github.com/llvm/llvm-project/pull/77092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 83fe0b1 - [clang] Fix -Wunused-lambda-capture in TokenAnnotator.cpp (NFC)

2024-03-09 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-03-09T20:26:10+08:00 New Revision: 83fe0b13824bc419092bad47727aa1c8ca69330a URL: https://github.com/llvm/llvm-project/commit/83fe0b13824bc419092bad47727aa1c8ca69330a DIFF: https://github.com/llvm/llvm-project/commit/83fe0b13824bc419092bad47727aa1c8ca69330a.diff LOG:

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-09 Thread Mark de Wever via cfe-commits
https://github.com/mordante approved this pull request. I have only reviewed the libc++ changes and they LGTM. https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-09 Thread via cfe-commits
@@ -1398,11 +1398,16 @@ void Sema::ActOnEndOfTranslationUnit() { if (FD->getDescribedFunctionTemplate()) Diag(DiagD->getLocation(), diag::warn_unused_template) << /*function=*/0 << DiagD << DiagRange; - else -

[clang] [Clang] Only check for error in C++20 mode (PR #84624)

2024-03-09 Thread via cfe-commits
Sirraide wrote: Merged this w/o review to fix the bots. Should be a trivial change. https://github.com/llvm/llvm-project/pull/84624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Only check for error in C++20 mode (PR #84624)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Fix a test that was added in #81014 and which caused buildbots to fail. Only check for the ‘never produces a constant expression error’ in C++20 mode. This fixes #84623. --- Full diff:

[clang] 5630dc6 - [Clang] Only check for error in C++20 mode (#84624)

2024-03-09 Thread via cfe-commits
Author: Sirraide Date: 2024-03-09T12:39:55+01:00 New Revision: 5630dc66369ccec925f27151b495c9f9818638f1 URL: https://github.com/llvm/llvm-project/commit/5630dc66369ccec925f27151b495c9f9818638f1 DIFF: https://github.com/llvm/llvm-project/commit/5630dc66369ccec925f27151b495c9f9818638f1.diff

[clang] [Clang] Only check for error in C++20 mode (PR #84624)

2024-03-09 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/84624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Only check for error in C++20 mode (PR #84624)

2024-03-09 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/84624 Fix a test that was added in #81014 and which caused buildbots to fail. Only check for the ‘never produces a constant expression error’ in C++20 mode. This fixes #84623. >From

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-09 Thread via cfe-commits
https://github.com/cor3ntin commented: Can we add a changelog entry for that? https://github.com/llvm/llvm-project/pull/84519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-09 Thread via cfe-commits
@@ -596,8 +596,21 @@ VarDecl *Sema::buildCoroutinePromise(SourceLocation Loc) { // Add implicit object parameter. if (auto *MD = dyn_cast(FD)) { -if (MD->isImplicitObjectMemberFunction() && !isLambdaCallOperator(MD)) { - ExprResult ThisExpr = ActOnCXXThis(Loc); +

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-09 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/84519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ceaf4a0 - [Clang] Fix status of P1774 Portable assumptions

2024-03-09 Thread via cfe-commits
Author: cor3ntin Date: 2024-03-09T12:22:40+01:00 New Revision: ceaf4a0aab86f10199e16a825c1bdabe59d07eb3 URL: https://github.com/llvm/llvm-project/commit/ceaf4a0aab86f10199e16a825c1bdabe59d07eb3 DIFF: https://github.com/llvm/llvm-project/commit/ceaf4a0aab86f10199e16a825c1bdabe59d07eb3.diff

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/84621 >From 71502300d47f3d5492e6073a3959fe32b0c9cf65 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 2 Mar 2024 15:37:33 +0330 Subject: [PATCH] [clang][Sema] Track trivial-relocatability as a type trait To

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-09 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/81014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2b5f68a - [Clang][C++23] Implement P1774R8: Portable assumptions (#81014)

2024-03-09 Thread via cfe-commits
Author: Sirraide Date: 2024-03-09T12:07:16+01:00 New Revision: 2b5f68a5f63d2342a056bf9f86bd116c100fd81a URL: https://github.com/llvm/llvm-project/commit/2b5f68a5f63d2342a056bf9f86bd116c100fd81a DIFF: https://github.com/llvm/llvm-project/commit/2b5f68a5f63d2342a056bf9f86bd116c100fd81a.diff

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amirreza Ashouri (AMP999) Changes To resolve llvm#69394, this patch separates trivial-relocatability's logic from `canPassInRegisters` to decide if a type is trivial-relocatable. A type passed in registers doesn't necessarily mean

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-09 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 created https://github.com/llvm/llvm-project/pull/84621 To resolve llvm#69394, this patch separates trivial-relocatability's logic from `canPassInRegisters` to decide if a type is trivial-relocatable. A type passed in registers doesn't necessarily mean

[clang] [Clang][Driver] Merge the different strategies of how libc++ is included (PR #83721)

2024-03-09 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/83721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[clang] Revert "[clang] Fix crash when declaring invalid lambda member" (PR #84615)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/84615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] def038b - Revert "[clang] Fix crash when declaring invalid lambda member" (#84615)

2024-03-09 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-03-09T00:33:21-08:00 New Revision: def038bc40fae7d6756dde9c41677d76ad0387d2 URL: https://github.com/llvm/llvm-project/commit/def038bc40fae7d6756dde9c41677d76ad0387d2 DIFF: https://github.com/llvm/llvm-project/commit/def038bc40fae7d6756dde9c41677d76ad0387d2.diff

[clang] Revert "[clang] Fix crash when declaring invalid lambda member" (PR #84615)

2024-03-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Reverts llvm/llvm-project#74110 Fails on many bots: https://lab.llvm.org/buildbot/#/builders/5/builds/41633 --- Full diff: https://github.com/llvm/llvm-project/pull/84615.diff 3 Files Affected: -

[clang] Revert "[clang] Fix crash when declaring invalid lambda member" (PR #84615)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/84615 Reverts llvm/llvm-project#74110 Fails on many bots: https://lab.llvm.org/buildbot/#/builders/5/builds/41633 >From 780ee1d80aa1b8cf54bd642e7c2a7e59c2dc9e11 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date:

[clang] [clang] Add optional pass to remove UBSAN traps using PGO (PR #84214)

2024-03-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/84214 >From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 6 Mar 2024 10:03:46 -0800 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=