[clang] [clang-format] Fix FormatToken::isSimpleTypeSpecifier() (PR #85564)

2024-03-17 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/85564 >From 3b9e25b8509aa6847838148fd2959569c94c4a0f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 17 Mar 2024 01:08:07 -0700 Subject: [PATCH 1/3] [clang-format] Fix FormatToken::isSimpleTypeSpecifier() ---

[clang] 55a02d1 - [clang-format][NFC] Minor changes to a unit test in 8e5de66af3da

2024-03-17 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-03-17T21:37:32-07:00 New Revision: 55a02d10d9819b485f67546c6c1aee856a3cd62c URL: https://github.com/llvm/llvm-project/commit/55a02d10d9819b485f67546c6c1aee856a3cd62c DIFF: https://github.com/llvm/llvm-project/commit/55a02d10d9819b485f67546c6c1aee856a3cd62c.diff

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-17 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: I forgot to submit my review. https://github.com/llvm/llvm-project/pull/85470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-17 Thread Owen Pan via cfe-commits
@@ -11450,6 +11450,11 @@ TEST_F(FormatTest, UnderstandsNewAndDelete) { "void new (link p);\n" "void delete (link p);"); + verifyFormat("{ p->delete(); }\n" + "{ p->new(); }", + "{ p->delete (); }\n" + "{

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-17 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/85470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Support RISC-V Profiles in -march option (PR #76357)

2024-03-17 Thread Wang Pengcheng via cfe-commits
@@ -854,6 +854,81 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension, "string must be lowercase"); } + bool IsProfile = Arch.starts_with("rvi") || Arch.starts_with("rva") || +

[clang] [llvm] [RISCV] Support RISC-V Profiles in -march option (PR #76357)

2024-03-17 Thread Wang Pengcheng via cfe-commits
@@ -854,6 +854,81 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension, "string must be lowercase"); } + bool IsProfile = Arch.starts_with("rvi") || Arch.starts_with("rva") || +

[clang] [llvm] [RISCV] Support RISC-V Profiles in -march option (PR #76357)

2024-03-17 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/76357 >From 28000eb88b54b02993107d4f222acc5d733c623f Mon Sep 17 00:00:00 2001 From: wangpc Date: Mon, 25 Dec 2023 18:52:36 +0800 Subject: [PATCH] [RISCV] Support RISC-V Profiles in -march option This PR implements

[clang] [llvm] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

2024-03-17 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson commented: Thanks, this looks great once all of @jrtc27's comments have been addressed. https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired edited https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 6b4c4bba21ec209f1f2834728db97182129e05a3 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 13abdadd182069f87949d5a8770f498e2103fb67 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for

[clang] [llvm] [PowerPC] Fix behavior of rldimi/rlwimi/rlwnm builtins (PR #85040)

2024-03-17 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/85040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Fix behavior of rldimi/rlwimi/rlwnm builtins (PR #85040)

2024-03-17 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/85040 >From 4977659b16a7f220e1a738a0b9841102fe9f1d07 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Wed, 13 Mar 2024 15:46:51 +0800 Subject: [PATCH 1/4] [PowerPC] Fix behavior of rldimi/rlwimi/rlwnm builtins

[clang] [Clang][Sema] Fix a crash in lambda instantiation (PR #85565)

2024-03-17 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/85565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86_64] fix arg pass error in struct. (PR #85394)

2024-03-17 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/85394 >From 1ca19591fa11a53559fdfe7e4bf6b298b7658628 Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 15 Mar 2024 20:50:54 +0800 Subject: [PATCH] [X86_64] fix arg pass error in struct. typedef long long

[clang] [Clang][Sema] Fix a crash in lambda instantiation (PR #85565)

2024-03-17 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/85565 >From 535617d786799c7657155e6e2cfa34fd3070f840 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 17 Mar 2024 17:48:05 +0800 Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation ---

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-17 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: @PiotrZSL I've squashed my changed. When you'll have time, I think we can merge this PR. https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-17 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82947 From e67122cb2c17395e863725cc25d99afe6c7bb48c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 20:20:59 -0500 Subject: [PATCH] [clang-tidy] Improved

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Improved --verify-config when using literal style in config file (PR #85591)

2024-03-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Félix-Antoine Constantin (felix642) Changes Specifying checks using the literal style (|) in the clang-tidy config file is currently supported but was not implemented for the --verify-config options. This means that clang-tidy would

[clang-tools-extra] [clang-tidy] Improved --verify-config when using literal style in config file (PR #85591)

2024-03-17 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 created https://github.com/llvm/llvm-project/pull/85591 Specifying checks using the literal style (|) in the clang-tidy config file is currently supported but was not implemented for the --verify-config options. This means that clang-tidy would work properly but,

[clang] Reland Print library module manifest path again (PR #84881)

2024-03-17 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > The file we're looking for is `modules.json`; Renaming it > `libc++.modules.json` like `.so` / `.a` file might be a better idea which > could avoid name clashes when installed in `/usr/lib`. BTW, how do you feel about the paragraph. I thought it as a defect in some level.

[clang] Resolve FIXME: Look at E, not M (PR #85541)

2024-03-17 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85541 >From c0f8be4fcfb725d53841d4b17a68685e2a79 Mon Sep 17 00:00:00 2001 From: Rose Date: Sat, 16 Mar 2024 12:07:21 -0400 Subject: [PATCH] Resolve FIXME: Look at E, not M --- clang/lib/CodeGen/CGExpr.cpp |

[clang] Resolve FIXME: Look at E, not M (PR #85541)

2024-03-17 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/85541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-17 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Ah, I see. That is addressed in #85454 but I have already expressed a concern. https://github.com/llvm/llvm-project/pull/84405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-17 Thread Jon Roelofs via cfe-commits
jroelofs wrote: I'm referring to: ``` // This should generate a normal function. int __attribute__((target_version("rdm"))) unused_without_default(void); ``` and: ``` // CHECK: Function Attrs: noinline nounwind optnone + // CHECK-LABEL: define {{[^@]+}}@unused_without_default + //

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-17 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: > In the current patch, it just gets the non-mangled name. And the fact that we > get a not-mangled function that uses `feature` without going through a > resolver is concerning to me. I am not sure I understand. Are you refering to the StringSet I added which keeps

[clang] [Clang] Ignore assumptions with side effects at compile time (PR #85534)

2024-03-17 Thread via cfe-commits
Sirraide wrote: The standard also says that ‘The expression is not evaluated’ [[dcl.attr.assume]](https://eel.is/c++draft/dcl.attr.assume#sentence-3), so we can only really get away with evaluating it by the as-if rule iff it has no side-effects, so this is just bringing compile-time in line

[clang] [Clang] Ignore assumptions with side effects at compile time (PR #85534)

2024-03-17 Thread via cfe-commits
Sirraide wrote: > Is it expected that a failed assumption with side effects does not result in > an error? Yes, because it can’t evaluate the assumption without causing side effects, so the assumption isn’t checked at all; I’ve thought about this a bit too, but unless there’s already some

[clang] [FMV] Allow fmv without default declaration. (PR #85454)

2024-03-17 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Hmm, I am now having second thoughts about this change. All is well without a default declaration as long as we don't have a caller in the TU. In that case (if there is a caller) a resolver is needed, but without a default declaration we can't create a complete resolver (the

[clang] [clang-format] Fix FormatToken::isSimpleTypeSpecifier() (PR #85564)

2024-03-17 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/85564 >From 3b9e25b8509aa6847838148fd2959569c94c4a0f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 17 Mar 2024 01:08:07 -0700 Subject: [PATCH 1/2] [clang-format] Fix FormatToken::isSimpleTypeSpecifier() ---

[clang] [llvm] [AArch64] Add support for Cortex-A520AE and Cortex-A720AE CPUs (PR #85401)

2024-03-17 Thread Jonathan Thackray via cfe-commits
@@ -58,6 +58,7 @@ class AArch64Subtarget final : public AArch64GenSubtargetInfo { CortexA55, CortexA510, CortexA520, +CortexA520AE, jthackray wrote: Yes, good idea. Amended. https://github.com/llvm/llvm-project/pull/85401

[clang] [llvm] [AArch64] Add support for Cortex-A520AE and Cortex-A720AE CPUs (PR #85401)

2024-03-17 Thread Jonathan Thackray via cfe-commits
@@ -67,6 +67,8 @@ Changes to Interprocedural Optimizations Changes to the AArch64 Backend -- +* Added support for Cortex-A520AE and Cortex-A720AE CPUs. jthackray wrote: Sure, now fixed.

[clang] [llvm] [AArch64] Add support for Cortex-A520AE and Cortex-A720AE CPUs (PR #85401)

2024-03-17 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/85401 >From 4faf1f908c0c7ddef2833be3dd1b87b3abf302d8 Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Thu, 14 Mar 2024 09:26:34 + Subject: [PATCH 1/2] [AArch64] Add support for Cortex-A520AE and

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-17 Thread via cfe-commits
github-actions[bot] wrote: @scythris Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-17 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/85470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8e5de66 - [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (#85470)

2024-03-17 Thread via cfe-commits
Author: scythris Date: 2024-03-17T21:06:32+01:00 New Revision: 8e5de66af3da8c2fc79b8fe2cbc26f94b677434d URL: https://github.com/llvm/llvm-project/commit/8e5de66af3da8c2fc79b8fe2cbc26f94b677434d DIFF: https://github.com/llvm/llvm-project/commit/8e5de66af3da8c2fc79b8fe2cbc26f94b677434d.diff

[clang] [clang] Accept lambdas in C++03 as an extensions (PR #73376)

2024-03-17 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/73376 >From 3caa29d68939fec7fcd11bc699c01a74ab1f7d2a Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sat, 25 Nov 2023 04:00:57 +0100 Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions This is a

[clang] [clang-format] Add Options to break inside the TableGen DAGArg. (PR #83149)

2024-03-17 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/83149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Accept lambdas in C++03 as an extensions (PR #73376)

2024-03-17 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/73376 >From 9bd0146b3f058499b82bdb88fe5bd045c3c07caf Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sat, 25 Nov 2023 04:00:57 +0100 Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions This is a

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Tests are also missing. https://github.com/llvm/llvm-project/pull/85572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,58 @@ +//===--- MinMaxUseInitializerListCheck.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,58 @@ +//===--- MinMaxUseInitializerListCheck.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Some comments, and check documentation file is not added. https://github.com/llvm/llvm-project/pull/85572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/85572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,138 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Reland Print library module manifest path again (PR #84881)

2024-03-17 Thread Mark de Wever via cfe-commits
mordante wrote: The file we're looking for is `modules.json`; Renaming it `libc++.modules.json` like `.so` / `.a` file might be a better idea which could avoid name clashes when installed in `/usr/lib`. https://github.com/llvm/llvm-project/pull/84881

[clang] 5143a12 - [clang][Interp] Add __builtin_is_constant_evaluated warnings

2024-03-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-17T18:07:51+01:00 New Revision: 5143a1241362616840af826d18c067025dae URL: https://github.com/llvm/llvm-project/commit/5143a1241362616840af826d18c067025dae DIFF: https://github.com/llvm/llvm-project/commit/5143a1241362616840af826d18c067025dae.diff

[clang] ca87671 - [clang][Interp][NFC] Make local pointer const

2024-03-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-17T18:07:51+01:00 New Revision: ca876711aee31e5ec7f4f6f0210de664c8ec7ce4 URL: https://github.com/llvm/llvm-project/commit/ca876711aee31e5ec7f4f6f0210de664c8ec7ce4 DIFF: https://github.com/llvm/llvm-project/commit/ca876711aee31e5ec7f4f6f0210de664c8ec7ce4.diff

[clang] dff3e28 - [clang][Interp][NFC] Print qualified name of Descriptor sources

2024-03-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-17T18:07:51+01:00 New Revision: dff3e28df9b92e4d3102a0f8012352cebfc9461d URL: https://github.com/llvm/llvm-project/commit/dff3e28df9b92e4d3102a0f8012352cebfc9461d DIFF: https://github.com/llvm/llvm-project/commit/dff3e28df9b92e4d3102a0f8012352cebfc9461d.diff

[clang] a4b39f6 - [clang][Interp] Lazily visit const-qualified static data members in C++

2024-03-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-17T18:07:51+01:00 New Revision: a4b39f651536c5cd8835a93cdea61039db004252 URL: https://github.com/llvm/llvm-project/commit/a4b39f651536c5cd8835a93cdea61039db004252 DIFF: https://github.com/llvm/llvm-project/commit/a4b39f651536c5cd8835a93cdea61039db004252.diff

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
https://github.com/sopyb updated https://github.com/llvm/llvm-project/pull/85572 >From f016e3ad661455d18536d7bcb086c4d33ef0c291 Mon Sep 17 00:00:00 2001 From: sopy Date: Sun, 17 Mar 2024 17:30:27 +0200 Subject: [PATCH] [clang-tidy] add check to suggest replacement of nested std::min or

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
sopyb wrote: Since I don't have permission to assign reviewers I will just ping @njames93 https://github.com/llvm/llvm-project/pull/85572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] fix: constexpr bit_cast with empty base classes (PR #82383)

2024-03-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/82383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 192be3c - fix: constexpr bit_cast with empty base classes (#82383)

2024-03-17 Thread via cfe-commits
Author: sethp Date: 2024-03-17T17:35:13+01:00 New Revision: 192be3c9c13363847d176f2c4bba2bd4be5e822f URL: https://github.com/llvm/llvm-project/commit/192be3c9c13363847d176f2c4bba2bd4be5e822f DIFF: https://github.com/llvm/llvm-project/commit/192be3c9c13363847d176f2c4bba2bd4be5e822f.diff LOG:

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Sopy (sopyb) Changes closes #25340 Identifies cases where `std::min` or `std::max` is used to find the minimum or maximum value among more than two items through repeated calls. The check replaces these calls with a single call to

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-17 Thread via cfe-commits
https://github.com/sopyb created https://github.com/llvm/llvm-project/pull/85572 closes #25340 Identifies cases where `std::min` or `std::max` is used to find the minimum or maximum value among more than two items through repeated calls. The check replaces these calls with a single call to

[clang] [llvm] [AArch64] Add support for Cortex-A520AE and Cortex-A720AE CPUs (PR #85401)

2024-03-17 Thread David Green via cfe-commits
@@ -58,6 +58,7 @@ class AArch64Subtarget final : public AArch64GenSubtargetInfo { CortexA55, CortexA510, CortexA520, +CortexA520AE, davemgreen wrote: These might not be worth adding, considering they should be the same as CortexA520, and

[clang] [llvm] [AArch64] Add support for Cortex-A520AE and Cortex-A720AE CPUs (PR #85401)

2024-03-17 Thread David Green via cfe-commits
@@ -67,6 +67,8 @@ Changes to Interprocedural Optimizations Changes to the AArch64 Backend -- +* Added support for Cortex-A520AE and Cortex-A720AE CPUs. davemgreen wrote: Could this have Cortex-A78AE too?

[clang] Reland Print library module manifest path again (PR #84881)

2024-03-17 Thread Arthur Laurent via cfe-commits
Arthapz wrote: How do we use this ? i tried ``` > /opt/llvm-git/usr/bin/clang -std=c++23 -stdlib=libc++ > -print-library-module-manifest-path ``` and ``` > /opt/llvm-git/usr/bin/clang -std=c++23 -stdlib=libc++ > -print-library-module-manifest-path -resource-dir=/opt/llvm-git/usr/lib ```

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-17 Thread Jon Roelofs via cfe-commits
jroelofs wrote: The current patch looks mostly good, but I'm still hung up on this: > I'd like to support FMV in existing codebases as lean as possible, so the > default version attribute would be optional to write as not all > version/toolchain will support it. smallest possible codebase

[clang] add some missing Kinds to libclang python bindings (PR #85571)

2024-03-17 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM

[clang] add some missing Kinds to libclang python bindings (PR #85571)

2024-03-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: ykiko (16bit-ykiko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/85571.diff 2 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+172-1) - (modified) clang/include/clang-c/Index.h (+1-1)

[clang] add some missing Kinds to libclang python bindings (PR #85571)

2024-03-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] add some missing Kinds to libclang python bindings (PR #85571)

2024-03-17 Thread via cfe-commits
https://github.com/16bit-ykiko created https://github.com/llvm/llvm-project/pull/85571 None >From e61c6511b274c2503c02a8eb6c2c1d8bf902c106 Mon Sep 17 00:00:00 2001 From: ykiko <486685...@qq.com> Date: Mon, 18 Mar 2024 00:01:47 +0800 Subject: [PATCH 1/2] add some missing CursorKinds in libclang

[clang] fix: constexpr bit_cast with empty base classes (PR #82383)

2024-03-17 Thread via cfe-commits
sethp wrote: Ah, got it, thank you: I am once again wishing for a `.gitattributes` "keep both" merge strategy more usable than `union` for the release notes. > Do you not have the necessary permissions to merge it yourself? No, I don't have write permissions on the LLVM repo: I think I will

[clang] fix: constexpr bit_cast with empty base classes (PR #82383)

2024-03-17 Thread via cfe-commits
https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/82383 >From ed6a576ba0c9492f8aa4c995ea7316263a979fae Mon Sep 17 00:00:00 2001 From: sethp Date: Tue, 20 Feb 2024 08:57:13 -0800 Subject: [PATCH 1/2] fix: constexpr bit_cast with empty base classes Prior to this commit,

[clang] [ObjC] Fix jmp_buf sizing for ObjC exceptions (PR #85481)

2024-03-17 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85481 >From 26f0da257911cfe8998f6daf84a61557acc9d0bd Mon Sep 17 00:00:00 2001 From: Rose Date: Fri, 15 Mar 2024 18:45:48 -0400 Subject: [PATCH] [ObjC] Fix jmp_buf sizing for ObjC exceptions The size of 18 only

[clang] [ObjC] Add reserved field in 64-bit ABI mode (PR #85487)

2024-03-17 Thread via cfe-commits
https://github.com/AtariDreams converted_to_draft https://github.com/llvm/llvm-project/pull/85487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0211389 - [clang][Interp] Handle __datasizeof.

2024-03-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-17T16:33:39+01:00 New Revision: 0211389064a1d493e826512a54ae547cb9859223 URL: https://github.com/llvm/llvm-project/commit/0211389064a1d493e826512a54ae547cb9859223 DIFF: https://github.com/llvm/llvm-project/commit/0211389064a1d493e826512a54ae547cb9859223.diff

[clang] [Clang][Sema] Fix a crash in lambda instantiation (PR #85565)

2024-03-17 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/85565 >From 6aebe68afc9930b080d5a5690799a3689de2d055 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 17 Mar 2024 17:48:05 +0800 Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation ---

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/84621 >From 6e127e5794efafaabf82b6c3d5e0634ddcfee977 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 2 Mar 2024 15:37:33 +0330 Subject: [PATCH 1/5] [clang][Sema] Track trivial-relocatability as a type trait

[clang] [Clang][Sema] Fix a crash in lambda instantiation (PR #85565)

2024-03-17 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/85565 >From edaea6b244e9e35998421e551fb757e6ba099668 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 17 Mar 2024 17:48:05 +0800 Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation ---

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Timm Baeder via cfe-commits
@@ -2680,8 +2680,8 @@ bool QualType::isTriviallyRelocatableType(const ASTContext ) const { return false; } else if (!BaseElementType->isObjectType()) { return false; - } else if (const auto *RD = BaseElementType->getAsRecordDecl()) { -return

[clang] [Clang] Ignore assumptions with side effects at compile time (PR #85534)

2024-03-17 Thread Timm Baeder via cfe-commits
tbaederr wrote: Is it expected that a failed assumption with side effects does not result in an error? ```c++ constexpr bool f(int ) { a = 10; return false; } constexpr int c() { int a = 0; [[assume(f(a))]]; return a; } static_assert(c() == 0); ```

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Amirreza Ashouri via cfe-commits
@@ -826,6 +842,14 @@ void CXXRecordDecl::addedMember(Decl *D) { ? !Constructor->isImplicit() : (Constructor->isUserProvided() || Constructor->isExplicit())) data().Aggregate = false; + + // A trivially relocatable class is a class: +

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 edited https://github.com/llvm/llvm-project/pull/84621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Can't be past an invalid LValue designator (PR #84293)

2024-03-17 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/84293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Amirreza Ashouri via cfe-commits
@@ -857,8 +881,13 @@ void CXXRecordDecl::addedMember(Decl *D) { data().HasDeclaredCopyAssignmentWithConstParam = true; } -if (Method->isMoveAssignmentOperator()) +if (Method->isMoveAssignmentOperator()) { SMKind |= SMF_MoveAssignment; +}

[clang] Reland Print library module manifest path again (PR #84881)

2024-03-17 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'll backport this tomorrow if no revert request shows up. https://github.com/llvm/llvm-project/pull/84881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland Print library module manifest path again (PR #84881)

2024-03-17 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/84881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0e1e1fc - Reland Print library module manifest path again (#84881)

2024-03-17 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-03-17T21:14:53+08:00 New Revision: 0e1e1fc8f0eae6ebdce40ef2154aa90e35e5bed7 URL: https://github.com/llvm/llvm-project/commit/0e1e1fc8f0eae6ebdce40ef2154aa90e35e5bed7 DIFF: https://github.com/llvm/llvm-project/commit/0e1e1fc8f0eae6ebdce40ef2154aa90e35e5bed7.diff

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-17 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/84621 >From 6e127e5794efafaabf82b6c3d5e0634ddcfee977 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Sat, 2 Mar 2024 15:37:33 +0330 Subject: [PATCH 1/4] [clang][Sema] Track trivial-relocatability as a type trait

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
trcrsired wrote: @ldionne Hi. I think i have fixed as many issues as I can. can you review it again? Thank you so much! https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 13abdadd182069f87949d5a8770f498e2103fb67 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
@@ -36,7 +36,12 @@ struct __cxa_exception; _LIBCPP_OVERRIDABLE_FUNC_VIS __cxa_exception* __cxa_init_primary_exception( void*, std::type_info*, -void( +# if defined(__USING_WASM_EXCEPTIONS__) trcrsired wrote: Fixed

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From de59577fd6244027e1c2fff32ab5b673ae5b299c Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From b5fee4962c347016a732a1310275651a8c74f23a Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/6] [libunwind] Fix build for wasm The wasm unwind build appears

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From b5fee4962c347016a732a1310275651a8c74f23a Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/5] [libunwind] Fix build for wasm The wasm unwind build appears

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-03-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From b5fee4962c347016a732a1310275651a8c74f23a Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/4] [libunwind] Fix build for wasm The wasm unwind build appears

  1   2   >