[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-03-29 Thread via cfe-commits
@@ -12,6 +12,7 @@ #include #include "config.h" +#ifndef __wasm__ trcrsired wrote: > I feel like we could detect `__wasm__` or similar in CMake. And it feels like > the right tool, though maybe not the most trivial to implement. Tbh i would always avoid

[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

2024-03-29 Thread Tom Stellard via cfe-commits
https://github.com/tstellar requested changes to this pull request. I'm going to NAK this change for now. Given the recent [developments](https://www.openwall.com/lists/oss-security/2024/03/29/4) with the xz project and considering this feature was requested by a user associated with the

[clang] [X86_64] fix arg pass error in struct. (PR #86902)

2024-03-29 Thread Longsheng Mou via cfe-commits
CoTinker wrote: @DavidSpickett why my buildkite always fail, while check-all success in local environment. Could you please take a look at it? https://github.com/llvm/llvm-project/pull/86902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [coroutine] Fix type of an ImplicitParamDecl used in generateAwaitSuspendWrapper (PR #87134)

2024-03-29 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: I don't have a test case yet. I'll see if I can come up with one. https://github.com/llvm/llvm-project/pull/87134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-03-29 Thread Akira Hatanaka via cfe-commits
@@ -338,6 +409,69 @@ static QualType getCoroutineSuspendExprReturnType(const ASTContext , } #endif +llvm::Function * +CodeGenFunction::generateAwaitSuspendWrapper(Twine const , + Twine const , +

[clang] [coroutine] Fix type of an ImplicitParamDecl used in generateAwaitSuspendWrapper (PR #87134)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Akira Hatanaka (ahatanak) Changes Use the correct type for AwaiterDecl instead of using `void *`. See the discussion here: https://github.com/llvm/llvm-project/pull/79712#discussion_r1544153100 --- Full

[clang] [coroutine] Fix type of an ImplicitParamDecl used in generateAwaitSuspendWrapper (PR #87134)

2024-03-29 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/87134 Use the correct type for AwaiterDecl instead of using `void *`. See the discussion here: https://github.com/llvm/llvm-project/pull/79712#discussion_r1544153100 >From 0f3f51dfe8a63c76c7d006511a8f329526123f54

[clang] [clang][HLSL] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Marc Auberer via cfe-commits
https://github.com/marcauberer edited https://github.com/llvm/llvm-project/pull/87131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Marc Auberer via cfe-commits
https://github.com/marcauberer updated https://github.com/llvm/llvm-project/pull/87131 >From 283fe4ea57765077bc9453adeec66ce8832c68c3 Mon Sep 17 00:00:00 2001 From: Marc Auberer Date: Sat, 30 Mar 2024 01:52:52 +0100 Subject: [PATCH] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/79382 >From bd74d7db681cd07fda56f26e79e047c6d1a41f6b Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Thu, 29 Feb 2024 15:37:50 -0600 Subject: [PATCH 1/8] [HLSL] Pass arrays by value HLSL constant sized array

[clang] [clang]Treat arguments to builtin type traits as template type arguments (PR #87132)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amirreza Ashouri (AMP999) Changes This change improves error messages for builtins in case of empty parentheses. Fixes llvm#86997 --- Full diff: https://github.com/llvm/llvm-project/pull/87132.diff 4 Files Affected: - (modified)

[clang] [clang]Treat arguments to builtin type traits as template type arguments (PR #87132)

2024-03-29 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 created https://github.com/llvm/llvm-project/pull/87132 This change improves error messages for builtins in case of empty parentheses. Fixes llvm#86997 >From f8cc36bd3706cc5744eb3223b0c32df2f6f871f9 Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Fri, 29 Mar

[clang] [llvm] [openmp] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-03-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/87009 >From d9e2231c179e3ae321883203ad4799971a982110 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 27 Mar 2024 15:27:16 -0500 Subject: [PATCH 1/3] [Libomptarget] Rename `libomptarget.rtl.x86_64` to

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Farzon Lotfi via cfe-commits
@@ -18317,6 +18307,14 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID, /*ReturnType=*/Op0->getType(), Intrinsic::dx_rsqrt, ArrayRef{Op0}, nullptr, "dx.rsqrt"); } + case Builtin::BI__builtin_hlsl_wave_get_lane_index: { +auto *CI =

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Marc Auberer via cfe-commits
https://github.com/marcauberer converted_to_draft https://github.com/llvm/llvm-project/pull/87131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Farzon Lotfi via cfe-commits
@@ -18317,6 +18307,14 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID, /*ReturnType=*/Op0->getType(), Intrinsic::dx_rsqrt, ArrayRef{Op0}, nullptr, "dx.rsqrt"); } + case Builtin::BI__builtin_hlsl_wave_get_lane_index: { +auto *CI =

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Marc Auberer (marcauberer) Changes Resolves #87109 --- Full diff: https://github.com/llvm/llvm-project/pull/87131.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+8-10) ``diff diff --git

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Marc Auberer (marcauberer) Changes Resolves #87109 --- Full diff: https://github.com/llvm/llvm-project/pull/87131.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+8-10) ``diff diff --git

[clang] [Clang] Move hlsl_wave_get_lane_index to EmitHLSLBuiltinExpr (PR #87131)

2024-03-29 Thread Marc Auberer via cfe-commits
https://github.com/marcauberer created https://github.com/llvm/llvm-project/pull/87131 Resolves #87109 >From 68d12152e79f3507accb3887f275a98a7976ad5e Mon Sep 17 00:00:00 2001 From: Marc Auberer Date: Sat, 30 Mar 2024 01:52:52 +0100 Subject: [PATCH] [Clang] Move hlsl_wave_get_lane_index to

[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes https://reviews.llvm.org/D54188 marked "alias" targets as used in C to fix -Wunused false positives. This patch extends the approach to handle mangled names to support global scope names in C++. We fix false

[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)

2024-03-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/87130 https://reviews.llvm.org/D54188 marked "alias" targets as used in C to fix -Wunused false positives. This patch extends the approach to handle mangled names to support global scope names in C++. We fix false

[clang] [clang-format] Add SpacesInParensOption for attributes and filtering for repeated parens (PR #77522)

2024-03-29 Thread Alibek Omarov via cfe-commits
a1batross wrote: I have built clang-format with these changes. On current commit, it sadly doesn't remove the space in these patterns: ```c memset( g_used, 0, sizeof( g_used ) ); if( FBitSet( ent->curstate.effects, EF_INVLIGHT ) ) ``` After reverting last commit, it got somewhat closer: ```c

[clang] [llvm] [openmp] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-03-29 Thread Joseph Huber via cfe-commits
@@ -3043,10 +3043,6 @@ struct AMDGPUPluginTy final : public GenericPluginTy { // HSA functions from now on, e.g., hsa_shut_down. Initialized = true; -#ifdef OMPT_SUPPORT -ompt::connectLibrary(); jhuber6 wrote: Ah, well that can be a follow-up

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-29 Thread via cfe-commits
justdan96 wrote: No problem, I have wasi-sdk all working in a Docker container now with your latest version of wasm-component-ld so I should be thanking you! https://github.com/llvm/llvm-project/pull/84569 ___ cfe-commits mailing list

[clang] [CMake] Update CMake cache file for the Win-to-Arm cross toolchains. NFC. (PR #87113)

2024-03-29 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/87113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b4693e0 - [CMake] Update CMake cache file for the Win-to-Arm cross toolchains. NFC. (#87113)

2024-03-29 Thread via cfe-commits
Author: Vladimir Vereschaka Date: 2024-03-29T15:31:31-07:00 New Revision: b4693e0d7da8f7f1f1365ab97ecc0e33ad459943 URL: https://github.com/llvm/llvm-project/commit/b4693e0d7da8f7f1f1365ab97ecc0e33ad459943 DIFF:

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -1362,8 +1372,8 @@ remapSamples(const sampleprof::FunctionSamples , BodySample.second.getSamples()); for (const auto : BodySample.second.getCallTargets()) { Result.addCalledTargetSamples(BodySample.first.LineOffset, -

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,145 @@ +// REQUIRES: lld-available + +// RUN: rm -rf %t && split-file %s %t && cd %t minglotus-6 wrote: done. https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,145 @@ +// REQUIRES: lld-available + +// RUN: rm -rf %t && split-file %s %t && cd %t +// +// RUN: %clangxx_pgogen -fuse-ld=lld -O2 -g -fprofile-generate=. -mllvm -enable-vtable-value-profiling test.cpp -o test +// RUN: env LLVM_PROFILE_FILE=test.profraw ./test + +//

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -676,24 +722,66 @@ TEST_P(InstrProfReaderWriterTest, icall_data_read_write) { Expected R = Reader->getInstrProfRecord("caller", 0x1234); ASSERT_THAT_ERROR(R.takeError(), Succeeded()); + + // Test the number of instrumented indirect call sites and the number of + //

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,145 @@ +// REQUIRES: lld-available + +// RUN: rm -rf %t && split-file %s %t && cd %t +// +// RUN: %clangxx_pgogen -fuse-ld=lld -O2 -g -fprofile-generate=. -mllvm -enable-vtable-value-profiling test.cpp -o test +// RUN: env LLVM_PROFILE_FILE=test.profraw ./test + +//

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -676,24 +722,66 @@ TEST_P(InstrProfReaderWriterTest, icall_data_read_write) { Expected R = Reader->getInstrProfRecord("caller", 0x1234); ASSERT_THAT_ERROR(R.takeError(), Succeeded()); + + // Test the number of instrumented indirect call sites and the number of + //

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -431,23 +441,34 @@ class InstrProfSymtab { using AddrHashMap = std::vector>; private: + using AddrIntervalMap = + IntervalMap>; StringRef Data; uint64_t Address = 0; - // Unique name strings. + // Unique name strings. Used to ensure entries in MD5NameMap (a

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-03-29 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,145 @@ +// REQUIRES: lld-available + +// RUN: rm -rf %t && split-file %s %t && cd %t +// +// RUN: %clangxx_pgogen -fuse-ld=lld -O2 -g -fprofile-generate=. -mllvm -enable-vtable-value-profiling test.cpp -o test +// RUN: env LLVM_PROFILE_FILE=test.profraw ./test

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Cooper Partin via cfe-commits
https://github.com/coopp approved this pull request. WOW.. This was pretty big. I went through it twice and didn't see anything that jumped out. Looks good to me. https://github.com/llvm/llvm-project/pull/79382 ___ cfe-commits mailing list

[clang] [llvm] [openmp] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-03-29 Thread via cfe-commits
@@ -3043,10 +3043,6 @@ struct AMDGPUPluginTy final : public GenericPluginTy { // HSA functions from now on, e.g., hsa_shut_down. Initialized = true; -#ifdef OMPT_SUPPORT -ompt::connectLibrary(); dhruvachak wrote: There is a connectLibrary

[clang] [CMake] Update CMake cache file for the Win-to-Arm cross toolchains. NFC. (PR #87113)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladimir Vereschaka (vvereschaka) Changes Review the actual component parameters and update the cache file accordingly. Also fixed the C++ test builds for the compiler-rt component. --- Full diff:

[clang] [CMake] Update CMake cache file for the Win-to-Arm cross toolchains. NFC. (PR #87113)

2024-03-29 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/87113 Review the actual component parameters and update the cache file accordingly. Also fixed the C++ test builds for the compiler-rt component. >From bf660e351d605db3062d782c6f526ac062548803 Mon Sep 17 00:00:00

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-03-29 Thread Jun Wang via cfe-commits
@@ -2326,6 +2326,20 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction , } #endif +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + AMDGPU::Waitcnt Wait; + if (ST->hasExtendedWaitCounts()) +Wait = AMDGPU::Waitcnt(0, 0, 0,

[clang] [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} not always being evaluated (PR #86742)

2024-03-29 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/86742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cf73f13 - [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} not always being evaluated (#86742)

2024-03-29 Thread via cfe-commits
Author: OverMighty Date: 2024-03-29T14:01:19-07:00 New Revision: cf73f136c5e22e7e4090fc762456ace47752a898 URL: https://github.com/llvm/llvm-project/commit/cf73f136c5e22e7e4090fc762456ace47752a898 DIFF: https://github.com/llvm/llvm-project/commit/cf73f136c5e22e7e4090fc762456ace47752a898.diff

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix incorrect line numbers with -E and raw string (#47577) (PR #77021)

2024-03-29 Thread Steve Cornett via cfe-commits
stevecor wrote: Ping https://github.com/llvm/llvm-project/pull/77021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Handle reexported library arguments in driver (PR #86980)

2024-03-29 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/86980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 12fdf04 - [clang][Darwin] Handle reexported library arguments in driver (#86980)

2024-03-29 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-03-29T13:44:22-07:00 New Revision: 12fdf04ff8962c9e902669a1b600b27a960f0c11 URL: https://github.com/llvm/llvm-project/commit/12fdf04ff8962c9e902669a1b600b27a960f0c11 DIFF: https://github.com/llvm/llvm-project/commit/12fdf04ff8962c9e902669a1b600b27a960f0c11.diff

[clang] [llvm] [HLSL][DXIL][SPIRV] Intrinsic unification PR (PR #87034)

2024-03-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/87034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-03-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Some OMPT variables with the same name used to be present in both > libomptarget and the common plugin interface. These should probably be > re-worked in the new scheme of static linking? e.g. > llvm::omp::target::ompt::Initialized Unsure, there was an issue where each

[clang] [OpenMP] Use loaded offloading toolchains to add libraries (PR #87108)

2024-03-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/87108 >From 4415c4d4b9c72e963d4c483440598933d59e19cc Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 29 Mar 2024 15:25:00 -0500 Subject: [PATCH] [OpenMP] Use loaded offloading toolchains to add libraries

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

2024-03-29 Thread David Peixotto via cfe-commits
dmpots wrote: I did not see any discussion of local root signatures here. It is probably good to consider those as well when thinking about this design. There is alternate syntax for specifying both local root signatues and global root signatures starting in SM 6.3

[clang] [llvm] [openmp] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-03-29 Thread via cfe-commits
dhruvachak wrote: Some OMPT variables with the same name used to be present in both libomptarget and the common plugin interface. These should probably be re-worked in the new scheme of static linking? e.g. llvm::omp::target::ompt::Initialized https://github.com/llvm/llvm-project/pull/87009

[clang] [OpenMP] Use loaded offloading toolchains to add libraries (PR #87108)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: We want to pass these GPU libraries by default if a certain offloading toolchain is loaded for OpenMP. Previously I parsed this from the arguments because it's only available in the compilation. This

[clang] [OpenMP] Use loaded offloading toolchains to add libraries (PR #87108)

2024-03-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/87108 Summary: We want to pass these GPU libraries by default if a certain offloading toolchain is loaded for OpenMP. Previously I parsed this from the arguments because it's only available in the compilation. This

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-03-29 Thread Jay Foad via cfe-commits
@@ -2326,6 +2326,20 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction , } #endif +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + AMDGPU::Waitcnt Wait; + if (ST->hasExtendedWaitCounts()) +Wait = AMDGPU::Waitcnt(0, 0, 0,

[clang] [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} not always being evaluated (PR #86742)

2024-03-29 Thread via cfe-commits
overmighty wrote: Could someone merge this for me if it looks good to everyone? https://github.com/llvm/llvm-project/pull/86742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/79382 >From bd74d7db681cd07fda56f26e79e047c6d1a41f6b Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Thu, 29 Feb 2024 15:37:50 -0600 Subject: [PATCH 1/7] [HLSL] Pass arrays by value HLSL constant sized array

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread Craig Topper via cfe-commits
https://github.com/topperc reopened https://github.com/llvm/llvm-project/pull/86967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread Craig Topper via cfe-commits
topperc wrote: I believe this has been tried in the past and reverted. Have we resolved the issues from the past? https://github.com/llvm/llvm-project/pull/86967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/86967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/79382 >From bd74d7db681cd07fda56f26e79e047c6d1a41f6b Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Thu, 29 Feb 2024 15:37:50 -0600 Subject: [PATCH 1/6] [HLSL] Pass arrays by value HLSL constant sized array

[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

2024-03-29 Thread via cfe-commits
sopyb wrote: Hey there, I've hit a bit of a wall. I'm trying to figure out if a location is inside a comment. The check generates faulty diagnostics, as it is now, if there are comments including '(', '{', '}', and ','. If I could check if the match is inside a comment this issue could be

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread via cfe-commits
https://github.com/AtariDreams converted_to_draft https://github.com/llvm/llvm-project/pull/86967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move tailclipping to bitfield allocation (PR #87090)

2024-03-29 Thread Nathan Sidwell via cfe-commits
urnathan wrote: Sigh, clipTailPadding is still needed, because of no_unique_address and empty base placement. Will update. https://github.com/llvm/llvm-project/pull/87090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [ObjC] Add reserved field in 64-bit ABI mode (PR #85487)

2024-03-29 Thread via cfe-commits
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/85487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/86967 >From 5d8873d4c296a839674f4ad1a51c779df9c68fab Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 28 Mar 2024 12:12:57 -0400 Subject: [PATCH] [CGBuiltin] Use freeze instruction to create an undef value instead

[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)

2024-03-29 Thread via cfe-commits
https://github.com/AtariDreams reopened https://github.com/llvm/llvm-project/pull/86967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-03-29 Thread Jun Wang via cfe-commits
@@ -0,0 +1,618 @@ +; RUN: llc -mtriple=amdgcn -mcpu=gfx900 -mattr=+precise-memory < %s | FileCheck %s -check-prefixes=GFX9 +; RUN: llc -mtriple=amdgcn -mcpu=gfx90a -mattr=+precise-memory < %s | FileCheck %s -check-prefixes=GFX90A +; RUN: llc -mtriple=amdgcn -mcpu=gfx1010

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/87099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ee3a302 - [clang] Move state out of `PreprocessorOptions` (2/n) (#87099)

2024-03-29 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-03-29T12:07:47-07:00 New Revision: ee3a302abaa091e550a80f79694e963d1b5d0b7b URL: https://github.com/llvm/llvm-project/commit/ee3a302abaa091e550a80f79694e963d1b5d0b7b DIFF: https://github.com/llvm/llvm-project/commit/ee3a302abaa091e550a80f79694e963d1b5d0b7b.diff

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/87099 >From aa4f75ab41f5bc018c8c5a6352e8b9688249fb21 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 22 Mar 2024 15:08:07 -0700 Subject: [PATCH 1/2] [clang] Move state out of `PreprocessorOptions` (2/n) An

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/87099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 407a2f231a81862e20d80059870c48d818b61ec2 aa4f75ab41f5bc018c8c5a6352e8b9688249fb21 --

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes An instance of `PreprocessorOptions` is part of `CompilerInvocation` which is supposed to be a value type. The `FailedModules` member is problematic, since it's essentially a shared state used by

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-29 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: I do wonder if we could have the broader builtin headers discussion independent of this patch? Is everyone happy with this patch? We can keep talking about the builtin headers in here independent of merging right? https://github.com/llvm/llvm-project/pull/86748

[clang] [clang] Move state out of `PreprocessorOptions` (2/n) (PR #87099)

2024-03-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/87099 An instance of `PreprocessorOptions` is part of `CompilerInvocation` which is supposed to be a value type. The `FailedModules` member is problematic, since it's essentially a shared state used by multiple

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-29 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: @ldionne @AaronBallman is there anything I need to do before merging this? https://github.com/llvm/llvm-project/pull/86748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Move state out of `PreprocessorOptions` (1/n) (PR #86358)

2024-03-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/86358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 407a2f2 - [clang] Move state out of `PreprocessorOptions` (1/n) (#86358)

2024-03-29 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-03-29T11:20:55-07:00 New Revision: 407a2f231a81862e20d80059870c48d818b61ec2 URL: https://github.com/llvm/llvm-project/commit/407a2f231a81862e20d80059870c48d818b61ec2 DIFF: https://github.com/llvm/llvm-project/commit/407a2f231a81862e20d80059870c48d818b61ec2.diff

[clang] [clang] Move state out of `PreprocessorOptions` (1/n) (PR #86358)

2024-03-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/86358 >From 109e6039abe8bd3b598f1fdc2dbd7bca783ff4e6 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 22 Mar 2024 15:54:14 -0700 Subject: [PATCH 1/5] [clang] Move state out of `PreprocessorOptions` (1/n) An

[clang] [llvm] [HLSL][DXIL][SPIRV] Intrinsic unification PR (PR #87034)

2024-03-29 Thread Justin Bogner via cfe-commits
bogner wrote: I have some misgivings about abusing the target intrinsic infrastructure like this to create "target" intrinsics for a non-existent target. IMO this is morally equivalent to just putting all of these intrinsics as generic llvm intrinsics (`llvm.thread_id` or `llvm.all`), just

[clang] [M68k] Change gcc register name from a7 to sp. (PR #87095)

2024-03-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d3bc9cc99b3d45e1fb8d65a57e308e899439fe26 dec6021133f67304bfc9942a1a4985cce6a15645 --

[clang] [clang-repl] Minor cleanups in Value.cpp (NFC) (PR #87066)

2024-03-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/87066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [M68k] Change gcc register name from a7 to sp. (PR #87095)

2024-03-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jim Lin (tclin914) Changes In M68kRegisterInfo.td, register SP is defined with name sp and alternate name a7. Fixes: https://github.com/llvm/llvm-project/issues/78620 --- Full diff: https://github.com/llvm/llvm-project/pull/87095.diff

[clang] [M68k] Change gcc register name from a7 to sp. (PR #87095)

2024-03-29 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/87095 In M68kRegisterInfo.td, register SP is defined with name sp and alternate name a7. Fixes: https://github.com/llvm/llvm-project/issues/78620 >From dec6021133f67304bfc9942a1a4985cce6a15645 Mon Sep 17 00:00:00

[clang] [clang-repl] Expose markUserCodeStart() in extended Interpreter interface (PR #87064)

2024-03-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Would it make sense to pass the eventual builtin includes (as string or similar) to the interpreter constructor? https://github.com/llvm/llvm-project/pull/87064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Eli Friedman via cfe-commits
@@ -10926,6 +10965,10 @@ QualType ASTContext::mergeTypes(QualType LHS, QualType RHS, bool OfBlockPointer, assert(LHS != RHS && "Equivalent pipe types should have already been handled!"); return {}; + case Type::ArrayParameter: +assert(LHS != RHS && +

[clang] [HLSL] Implement array temporary support (PR #79382)

2024-03-29 Thread Eli Friedman via cfe-commits
@@ -2331,6 +2332,11 @@ void CodeGenFunction::EmitVariablyModifiedType(QualType type) { type = cast(ty)->getPointeeType(); break; +case Type::ArrayParameter: efriedma-quic wrote: Can we just use the existing "case" for ConstantArray?

[clang] [ObjC] Fix jmp_buf sizing for ObjC exceptions (PR #85481)

2024-03-29 Thread via cfe-commits
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/85481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-29 Thread Michael Jones via cfe-commits
michaelrj-google wrote: I'm fine with changing our definition to better coordinate with libc++, though we should probably discuss that on someplace other than this patch. https://github.com/llvm/llvm-project/pull/86748 ___ cfe-commits mailing list

[clang] bdb60e6 - [InstallAPI][test] Add requires x86_64 for hardcoded target test

2024-03-29 Thread Cyndy Ishida via cfe-commits
Author: Cyndy Ishida Date: 2024-03-29T10:34:35-07:00 New Revision: bdb60e6f0c8e89abf9bdf36411348db304ca65ba URL: https://github.com/llvm/llvm-project/commit/bdb60e6f0c8e89abf9bdf36411348db304ca65ba DIFF: https://github.com/llvm/llvm-project/commit/bdb60e6f0c8e89abf9bdf36411348db304ca65ba.diff

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-29 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > Re: there being observable differences between a header in C vs C++ mode, > that's already a thing. > > The definition for `isinf` in math.h is specified to be a macro in C, but > specified to be a function in C++. We're already doing `#ifdef __cplusplus` > for that (see

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-03-29 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,86 @@ +//===--- MathMissingParenthesesCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-03-29 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,86 @@ +//===--- MathMissingParenthesesCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-03-29 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,86 @@ +//===--- MathMissingParenthesesCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-03-29 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/84481 >From 8fdf6306085ed4cf0f77b7e718e374e9f65fedf9 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 8 Mar 2024 19:02:47 +0530 Subject: [PATCH 1/9] add clang-tidy check readability-math-missing-parentheses

[clang] [llvm] [HLSL][DXIL] HLSL's `round` should follow `roundeven` behavior (PR #87078)

2024-03-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/87078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e74332a - [HLSL][DXIL] HLSL's `round` should follow `roundeven` behavior (#87078)

2024-03-29 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-03-29T13:19:28-04:00 New Revision: e74332a266e5f81411fb333bde56bf471f0a7ba6 URL: https://github.com/llvm/llvm-project/commit/e74332a266e5f81411fb333bde56bf471f0a7ba6 DIFF: https://github.com/llvm/llvm-project/commit/e74332a266e5f81411fb333bde56bf471f0a7ba6.diff

[clang] [clang][Darwin] Handle reexported library arguments in driver (PR #86980)

2024-03-29 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. https://github.com/llvm/llvm-project/pull/86980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} not always being evaluated (PR #86742)

2024-03-29 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/86742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers] Don't declare unreachable() from stddef.h in C++ (PR #86748)

2024-03-29 Thread Michael Jones via cfe-commits
michaelrj-google wrote: Re: there being observable differences between a header in C vs C++ mode, that's already a thing. The definition for `isinf` in math.h is specified to be a macro in C, but specified to be a function in C++. We're already doing `#ifdef __cplusplus` for that (see

[clang] [Clang] Coroutines: Properly Check if `await_suspend` return type is a `std::coroutine_handle` (PR #85684)

2024-03-29 Thread Yuxuan Chen via cfe-commits
@@ -418,39 +448,60 @@ static ReadySuspendResumeResult buildCoawaitCalls(Sema , VarDecl *CoroPromise, return Calls; } Expr *CoroHandle = CoroHandleRes.get(); - CallExpr *AwaitSuspend = cast_or_null( - BuildSubExpr(ACT::ACT_Suspend, "await_suspend", CoroHandle));

  1   2   3   >