[clang] [flang] [Flang][Driver] Add -print-resource-dir command line flag to emit Flang's resource directory (PR #90886)

2024-05-02 Thread Michael Klemm via cfe-commits
mjklemm wrote: > What's the definition of "resource dir" for Fortran? I'd like to at least have it point to where the MODULE files live. When I look at what clang emits, then Flang's resource directory should rather point to the place, where Flang has its `lib` and `include` directories. So,

[clang] [clang][tools] Adjust the dependency libraries of c-arcmt-test and c-index-test to meet LLVM_BUILD_STATIC=ON. (PR #89946)

2024-05-02 Thread via cfe-commits
lateautumn233 wrote: Ping https://github.com/llvm/llvm-project/pull/89946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[OpenMP][TR12] change property of map-type modifier." (PR #90935)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jyu2-git) Changes Reland llvm/llvm-project#90499 --- Patch is 28.99 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/90935.diff 4 Files Affected: - (modified)

[clang] Reland "[OpenMP][TR12] change property of map-type modifier." (PR #90935)

2024-05-02 Thread via cfe-commits
https://github.com/jyu2-git created https://github.com/llvm/llvm-project/pull/90935 Reland llvm/llvm-project#90499 >From 7c28408e39f83dd44a59caf7b8539e7920504277 Mon Sep 17 00:00:00 2001 From: jyu2-git Date: Thu, 2 May 2024 20:55:18 -0700 Subject: [PATCH] Revert "Revert "[OpenMP][TR12] change

[clang] Fix sanitize problem. (PR #90800)

2024-05-02 Thread via cfe-commits
https://github.com/jyu2-git closed https://github.com/llvm/llvm-project/pull/90800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b62c45c - Fix sanitize problem. (#90800)

2024-05-02 Thread via cfe-commits
Author: jyu2-git Date: 2024-05-02T20:54:20-07:00 New Revision: b62c45cfe514237f71a7f461ba283dd13a92bfe0 URL: https://github.com/llvm/llvm-project/commit/b62c45cfe514237f71a7f461ba283dd13a92bfe0 DIFF: https://github.com/llvm/llvm-project/commit/b62c45cfe514237f71a7f461ba283dd13a92bfe0.diff

[clang] [llvm] [InstallAPI] Support mutually exclusive parse options (PR #90686)

2024-05-02 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/90686 >From faabe7752dbb596f13e0e676b5c8db9fb8ad9258 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Thu, 18 Apr 2024 07:28:44 -0700 Subject: [PATCH] [InstallAPI] Support mutually exclusive parse options

[clang] [lld] [llvm] [CGData] Clang Options (PR #90304)

2024-05-02 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com edited https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-05-02 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com edited https://github.com/llvm/llvm-project/pull/90933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [CGData][ThinLTO]Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-05-02 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com edited https://github.com/llvm/llvm-project/pull/90933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d2af1ea - [clang-format][NFC] Minor improvement to parseLabel()

2024-05-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-05-02T19:42:01-07:00 New Revision: d2af1ea81dd0170133c53ebd67c9a9be125dfd31 URL: https://github.com/llvm/llvm-project/commit/d2af1ea81dd0170133c53ebd67c9a9be125dfd31 DIFF: https://github.com/llvm/llvm-project/commit/d2af1ea81dd0170133c53ebd67c9a9be125dfd31.diff

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-05-02 Thread via cfe-commits
Sirraide wrote: > I think this is now as complete as I can make it without further feedback. > Should I update the description and make it no longer a draft? Squash and > make a new PR? Hmm, that’s a good question; I think updating the description and removing the draft status is probably

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-02 Thread Gábor Horváth via cfe-commits
@@ -3479,13 +3479,24 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, // original reference count is positive, we should not report use-after-frees // on objects deleted in such destructors. This can probably be improved // through better

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-02 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LG! https://github.com/llvm/llvm-project/pull/90918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-02 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/90918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][AArch64] Don't optimize backward compatible features in resolver. (PR #90928)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Pavel Iliin (ilinpv) Changes For arch64 features, such as Branch Target Identification or MTE (Memory Tagging Extension), compatible with targets that lack their support we may encounter scenarios where

[clang] [FMV][AArch64] Don't optimize backward compatible features in resolver. (PR #90928)

2024-05-02 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv created https://github.com/llvm/llvm-project/pull/90928 For arch64 features, such as Branch Target Identification or MTE (Memory Tagging Extension), compatible with targets that lack their support we may encounter scenarios where a binary compiled with MTE for

[clang] [clang][CodeGen] Fix MSVC ABI for classes with a deleted copy assignment operator (PR #90547)

2024-05-02 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 edited https://github.com/llvm/llvm-project/pull/90547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Heejin Ahn via cfe-commits
@@ -38,6 +38,13 @@ multiclass RELAXED_I; } +multiclass HALF_PRECISION_I pattern_r, string asmstr_r = "", +string asmstr_s = "", bits<32> simdop = -1> { + defm "" : ABSTRACT_SIMD_I; +} + aheejin wrote: Is this used in this PR? If

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Heejin Ahn via cfe-commits
@@ -321,6 +321,18 @@ def int_wasm_relaxed_dot_bf16x8_add_f32: [llvm_v8i16_ty, llvm_v8i16_ty, llvm_v4f32_ty], [IntrNoMem, IntrSpeculatable]>; +//===--===// +//

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin commented: Given that this uses `LOADPAT`, how about adding offset tests like other loads in https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/WebAssembly/offset.ll ? https://github.com/llvm/llvm-project/pull/90906

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/90906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-05-02 Thread Max Winkler via cfe-commits
@@ -1131,13 +1132,18 @@ static bool isTrivialForMSVC(const CXXRecordDecl *RD, QualType Ty, return false; if (RD->hasNonTrivialCopyAssignment()) return false; + if (RD->needsImplicitCopyAssignment() && !RD->hasSimpleCopyAssignment()) MaxEW707 wrote:

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-05-02 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/90547 >From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Mon, 29 Apr 2024 22:09:52 -0400 Subject: [PATCH 1/4] [clang][CodeGen] Fix MS ABI for classes with non static data

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

2024-05-02 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. Please fix the commit message before you merge; otherwise LGTM https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. Overall this looks good, and I think it makes sense to model this as short* for now. I think it will be interesting to see if that ends up causing issues. Out of curiosity does this work if you try `_fp16`?

[clang] [Modules] Detect ODR mismatches for enums in non-C++ like in C++. (PR #90298)

2024-05-02 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai closed https://github.com/llvm/llvm-project/pull/90298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6d7d8e5 - [Modules] Detect ODR mismatches for enums in non-C++ like in C++. (#90298)

2024-05-02 Thread via cfe-commits
Author: Volodymyr Sapsai Date: 2024-05-02T18:10:36-07:00 New Revision: 6d7d8e5b59cb0a66765ccf657814ae6039e27931 URL: https://github.com/llvm/llvm-project/commit/6d7d8e5b59cb0a66765ccf657814ae6039e27931 DIFF:

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

2024-05-02 Thread Nikita Popov via cfe-commits
@@ -1699,8 +1701,12 @@ Expected BitcodeReader::materializeValue(unsigned StartValID, I = GetElementPtrInst::Create(BC->SrcElemTy, Ops[0], ArrayRef(Ops).drop_front(), "constexpr", InsertBB); -

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

2024-05-02 Thread Nikita Popov via cfe-commits
@@ -316,3 +316,82 @@ define <2 x i32> @test_trunc_both_reversed_vector(<2 x i64> %a) { %res = trunc nsw nuw <2 x i64> %a to <2 x i32> ret <2 x i32> %res } + +define ptr @gep_nuw(ptr %p, i64 %idx) { +; CHECK: %gep = getelementptr nuw i8, ptr %p, i64 %idx + %gep =

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

2024-05-02 Thread Nikita Popov via cfe-commits
@@ -11295,27 +11297,46 @@ memory though, even if it happens to point into allocated storage. See the :ref:`Pointer Aliasing Rules ` section for more information. -If the ``inbounds`` keyword is present, the result value of a -``getelementptr`` with any non-zero indices is a

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

2024-05-02 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/90824 >From eb27a1b94ec807323d204b51d5c01cc22056e1c7 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 2 May 2024 12:11:18 +0900 Subject: [PATCH 1/4] Add support for getelementptr nusw and nuw ---

[clang] [llvm] [IR] Add getelementptr nusw and nuw flags (PR #90824)

2024-05-02 Thread Nikita Popov via cfe-commits
nikic wrote: > Are the TODOs encompassing all the cases? Why we don't want to set the flags > in `PHITransAddr` as well? No, the TODOs are only for places where I had to modify code, but the used implementation is obviously non-optimal to minimize initial impact. There are many more places

[clang] [modules] Accept equivalent module caches from different symlink (PR #90925)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Ellis Hoag (ellishg) Changes Use `fs::equivalent()`, which follows symlinks, to check if two module cache paths are equivalent. This prevents a PCH error when building from a different path that is a symlink of the original. ```

[clang] [modules] Accept equivalent module caches from different symlink (PR #90925)

2024-05-02 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/90925 Use `fs::equivalent()`, which follows symlinks, to check if two module cache paths are equivalent. This prevents a PCH error when building from a different path that is a symlink of the original. ``` error:

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: Thanks for all your analysis. I agree this is a rocThrust bug. I will open an issue to rocThrust. https://github.com/llvm/llvm-project/pull/90152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [BoundsSafety] Allow 'counted_by' attribute on pointers in structs in C (PR #90786)

2024-05-02 Thread Henrik G. Olsson via cfe-commits
@@ -8588,31 +8588,71 @@ static const RecordDecl *GetEnclosingNamedOrTopAnonRecord(const FieldDecl *FD) { return RD; } -static bool -CheckCountExpr(Sema , FieldDecl *FD, Expr *E, - llvm::SmallVectorImpl ) { +enum class CountedByInvalidPointeeTypeKind { +

[clang] [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (PR #90717)

2024-05-02 Thread Michael Buch via cfe-commits
Michael137 wrote: `18707f53d6d2665634373847a0e9bdcbcac88c57` https://github.com/llvm/llvm-project/pull/90717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PGO][test] Relax FileCheck patterns in debug-info-instr_profile_switch.cpp (PR #90916)

2024-05-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/90916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18707f5 - [clang][PGO][test] Relax FileCheck patterns in debug-info-instr_profile_switch.cpp (#90916)

2024-05-02 Thread via cfe-commits
Author: Michael Buch Date: 2024-05-03T01:18:18+01:00 New Revision: 18707f53d6d2665634373847a0e9bdcbcac88c57 URL: https://github.com/llvm/llvm-project/commit/18707f53d6d2665634373847a0e9bdcbcac88c57 DIFF: https://github.com/llvm/llvm-project/commit/18707f53d6d2665634373847a0e9bdcbcac88c57.diff

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: Another possibility to consider: when [transforming a member access](https://github.com/llvm/llvm-project/blob/ff210b94d449de8ebe1f32cf0d7763ba63b27b39/clang/lib/Sema/TreeTransform.h#L11950), strip off any implicit member accesses from the base expression

[clang] ff210b9 - [FMV][NFC] Add test for bti and mte check in resolver.

2024-05-02 Thread Pavel Iliin via cfe-commits
Author: Pavel Iliin Date: 2024-05-03T00:58:17+01:00 New Revision: ff210b94d449de8ebe1f32cf0d7763ba63b27b39 URL: https://github.com/llvm/llvm-project/commit/ff210b94d449de8ebe1f32cf0d7763ba63b27b39 DIFF: https://github.com/llvm/llvm-project/commit/ff210b94d449de8ebe1f32cf0d7763ba63b27b39.diff

[clang] [llvm] [ARM] Armv8-R does not require fp64 or neon. (PR #88287)

2024-05-02 Thread Chris Copeland via cfe-commits
chrisnc wrote: Understood. FWIW, `arm-none-eabi-gcc` does not enable any FPU features by default with `-march=armv8-r` (and will error out if you combine that with `-mfloat-abi=hard`), which is what the first pass of this PR went for, but I think where we landed is a decent middle ground.

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Artem Dergachev (haoNoQ) Changes Fixes #90498. Same as 5337efc69cdd5 for atomic builtins, but for `std::atomic` this time. This is useful because even though the actual builtin atomic is still there, it may be buried

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-02 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ created https://github.com/llvm/llvm-project/pull/90918 Fixes #90498. Same as 5337efc69cdd5 for atomic builtins, but for `std::atomic` this time. This is useful because even though the actual builtin atomic is still there, it may be buried beyond the inlining depth

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-05-02 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > @alexey-bataev see [#90152 > (comment)](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2089786180) > @alexey-bataev see [#90152 > (comment)](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2089786180) Thanks for the link

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @alexey-bataev see https://github.com/llvm/llvm-project/pull/90152#issuecomment-2089786180 https://github.com/llvm/llvm-project/pull/84050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][PGO][test] Relax FileCheck patterns in debug-info-instr_profile_switch.cpp (PR #90916)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes Caused build-bot failures on various platforms. --- Full diff: https://github.com/llvm/llvm-project/pull/90916.diff 1 Files Affected: - (modified) clang/test/Profile/debug-info-instr_profile_switch.cpp

[clang] [clang][PGO][test] Relax FileCheck patterns in debug-info-instr_profile_switch.cpp (PR #90916)

2024-05-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/90916 Caused build-bot failures on various platforms. >From 062311676d54dadeae4f463fcf5dcc9ef8d1d971 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 3 May 2024 00:25:24 +0100 Subject: [PATCH]

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @dyung It's a bit difficult to tell what the code is intended to do. An expression naming a non-static member function must either be the postfix-expression of a call, or be the terminal name of a qualified-id that is the operand of unary `&`.

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-05-02 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: I think this breaks the build of SPEC2017/xalancbmk https://github.com/llvm/llvm-project/pull/84050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (PR #90717)

2024-05-02 Thread Michael Buch via cfe-commits
Michael137 wrote: Broke some build bots. Fixing... https://github.com/llvm/llvm-project/pull/90717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @yxsamliu The call to `this->construct` in the `emplace` member of the partial specialization `class optional` _is_ a bug -- unlike the primary class template, the partial specialization for `T&` does _not_ inherit from `optional_operations_base` (which declares the

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/90676 >From 12964a3632d81d500b76c1a8a5c83a6367c66e00 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Tue, 30 Apr 2024 15:16:38 -0700 Subject: [PATCH] [clang][modules] stdarg.h and stddef.h shouldn't

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Erich Keane via cfe-commits
erichkeane wrote: > @yxsamliu The type of `this` is always a pointer. The class member access > operator may only be overloaded for operands of class type. In your reduced > example, could you provide a value of `T` that would instantiate to a valid > specialization? Agreed, this is another

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Brendan Dahl via cfe-commits
brendandahl wrote: /cc @tlively @dschuff (I guess I can't assign reviewers since I don't have commit access.) https://github.com/llvm/llvm-project/pull/90906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @yxsamliu The type of `this` is always a pointer. The class member access operator may only be overloaded for operands of class type. In your reduced example, could you provide a value of `T` that would instantiate to a valid specialization?

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl updated https://github.com/llvm/llvm-project/pull/90906 >From 14313fa9ef33b4cbc8cf18f280ee885b38015ca4 Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Wed, 1 May 2024 21:53:39 + Subject: [PATCH 1/2] [WebAssembly] Implement prototype f32.load_f16

[clang] [llvm] [RISCV] Make parseArchString only accept [a-z0-9_]. (PR #90879)

2024-05-02 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat approved this pull request. LGTM~ https://github.com/llvm/llvm-project/pull/90879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > I think I like this as a solution, although I wonder if > __stdarg_guard_macro.h would be a better name. The name now somewhat implies > that it contains the macros that stddef and stdarg define. But the macros don't actually guard anything. _macro isn't the best

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Ian Anderson via cfe-commits
@@ -15,9 +15,11 @@ const HeaderMapCollector::RegexHeaderMap *getSTLPostfixHeaderMap() { static const HeaderMapCollector::RegexHeaderMap STLPostfixHeaderMap = { {"include/__stdarg___gnuc_va_list.h$", ""}, {"include/__stdarg___va_copy.h$", ""}, +

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Michael Spencer via cfe-commits
@@ -15,9 +15,11 @@ const HeaderMapCollector::RegexHeaderMap *getSTLPostfixHeaderMap() { static const HeaderMapCollector::RegexHeaderMap STLPostfixHeaderMap = { {"include/__stdarg___gnuc_va_list.h$", ""}, {"include/__stdarg___va_copy.h$", ""}, +

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese commented: I think I like this as a solution, although I wonder if __stdarg_guard_macro.h would be a better name. The name now somewhat implies that it contains the macros that stddef and stdarg define. https://github.com/llvm/llvm-project/pull/90676

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-02 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/90676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

2024-05-02 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks. Can you add a test? Possibly `clang/test/Driver/msvc-link.c`. `linux-cross.cpp` has a good example about how to test the default `-L` paths. https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list

[clang] 4113e15 - [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (#90717)

2024-05-02 Thread via cfe-commits
Author: Michael Buch Date: 2024-05-02T23:18:16+01:00 New Revision: 4113e15153d5af39a12c6bcf16e6b35614dc13a2 URL: https://github.com/llvm/llvm-project/commit/4113e15153d5af39a12c6bcf16e6b35614dc13a2 DIFF: https://github.com/llvm/llvm-project/commit/4113e15153d5af39a12c6bcf16e6b35614dc13a2.diff

[clang] [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (PR #90717)

2024-05-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/90717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Cleanup TargetInfo handling (PR #90694)

2024-05-02 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/90694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 39172bc - [HLSL] Cleanup TargetInfo handling (#90694)

2024-05-02 Thread via cfe-commits
Author: Chris B Date: 2024-05-02T17:15:57-05:00 New Revision: 39172bcfe4ca6f4db09da0f76a3e324dd3888a51 URL: https://github.com/llvm/llvm-project/commit/39172bcfe4ca6f4db09da0f76a3e324dd3888a51 DIFF: https://github.com/llvm/llvm-project/commit/39172bcfe4ca6f4db09da0f76a3e324dd3888a51.diff LOG:

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: This patch seems to cause a regression for rocThrust: https://github.com/ROCm/rocThrust/blob/f3a28e43355b0f439fb99a2210bd497ca59c8003/thrust/optional.h#L2756 rocThrust/thrust/../thrust/optional.h:2756:11: error: no member named 'construct' in 'optional' A reduced test case is

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-05-02 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/85672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-05-02 Thread Doug Wyatt via cfe-commits
dougsonos wrote: I think this is now as complete as I can make it without further feedback. Should I update the description and make it no longer a draft? Squash and make a new PR? Thanks for all the help @Sirraide ! https://github.com/llvm/llvm-project/pull/84983

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-05-02 Thread Jacob Lambert via cfe-commits
lamb-j wrote: Switched the option from a cl::opt to a Clang/CodeGen option. Also added a LIT test which tests both -mlink-builtin-bitcode-postopt and -mno-link-builtin-bitcode-postopt https://github.com/llvm/llvm-project/pull/85672 ___ cfe-commits

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-05-02 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/6] [clang][CodeGen] Omit pre-opt link when post-opt link

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-05-02 Thread Doug Wyatt via cfe-commits
@@ -7973,3 +7973,20 @@ requirement: } }]; } + +def NoLockNoAllocDocs : Documentation { + let Category = DocCatType; + let Content = [{ +The ``nolock`` and ``noalloc`` attributes can be attached to functions, blocks, +function pointers, lambdas, and member functions.

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-05-02 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/5] [clang][CodeGen] Omit pre-opt link when post-opt link

[clang] [CIR] Add CIRGenerator and plug it via CIRGenAction (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/90831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes commented: Perhaps add a `-emit-cir` testcase that doesn't test anything but just proves the wiring works. More comments inline. https://github.com/llvm/llvm-project/pull/90831 ___ cfe-commits mailing list

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,28 @@ +//===--- CIRGenTypeCache.h - Commonly used LLVM types and info -*- C++ --*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,62 @@ +//=== CIRGenAction.h - CIR Code Generation Frontend Action -*- C++ -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,42 @@ +//===--- CIRGenModule.h - Per-Module state for CIR gen --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,62 @@ +//=== CIRGenAction.h - CIR Code Generation Frontend Action -*- C++ -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/90831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Brendan Dahl (brendandahl) Changes Adds a builtin and intrinsic for the f32.load_f16 instruction. The instruction loads an f16 value from memory and puts it in an f32. Specified at:

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-02 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl created https://github.com/llvm/llvm-project/pull/90906 Adds a builtin and intrinsic for the f32.load_f16 instruction. The instruction loads an f16 value from memory and puts it in an f32. Specified at:

[clang] [clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions (PR #90717)

2024-05-02 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/90717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Note there is a `BuildAnonymousStructUnionMemberReference`, I am not sure it solves your problem. https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread via cfe-commits
dyung wrote: We are also seeing a build break internally which I bisected back to this change. In our case, I was able to reduce it to the following code: ```c++ #include template class b { b operator=(b) { return operator=<>; } template ::d>> void operator=(b); }; ``` After this

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Sam Clegg via cfe-commits
sbc100 wrote: This change recently rolled into the emscripten SDK and seems to be breaking the build of regal. I've not invistigated this yet, and its not our code: ``` em++ -c /usr/local/google/home/sbc/dev/wasm/emscripten/cache/ports/regal/regal-version_7/src/regal/RegalIff.cpp -o

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Erich Keane via cfe-commits
erichkeane wrote: >This is the option I've decided to go with here. There's a slight wrinkle in >that we create a LookupResult that claims we looked up the unnamed field for >the anonymous class -- even though we would obviously never be able to look up >an unnamed field. I think this is

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Shafik Yaghmour via cfe-commits
@@ -2876,10 +2876,21 @@ class TreeTransform { return ExprError(); Base = BaseResult.get(); + // We want to use `BuildMemberReferenceExpr()` so we can use its logic + // that materializes `Base` into a temporary if it's a prvalue. + // To do so, we

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for this fix. You should reference the issue that this fixes in your summary. This also need a release note. https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] solve crash due to function overloading. (PR #90255)

2024-05-02 Thread via cfe-commits
https://github.com/lolloz98 updated https://github.com/llvm/llvm-project/pull/90255 >From 0d473873057b094c8cf112f7075c4a578e54a4f5 Mon Sep 17 00:00:00 2001 From: lolloz98 Date: Fri, 26 Apr 2024 20:31:32 +0100 Subject: [PATCH 1/2] [clang] solve crash due to function overloading. ---

[clang] [clang] solve crash due to function overloading. (PR #90255)

2024-05-02 Thread via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -emit-llvm < %s lolloz98 wrote: Hello, I apologize, but could I ask some pointers to some docs for creating tests for llvm? I didn't find any very good resource about it :) https://github.com/llvm/llvm-project/pull/90255

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-05-02 Thread Bill Wendling via cfe-commits
bwendling wrote: The code looks fine to me. But you should wait for @efriedma-quic to chime in as he had concerns over the feature. https://github.com/llvm/llvm-project/pull/86618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-05-02 Thread Aaron Liu via cfe-commits
aaronliu0130 wrote: As mentioned in https://github.com/clangd/clangd/issues/529#issuecomment-1938730781, they're [here](https://aur.archlinux.org/cgit/aur.git/tree/hover-doxygen-trunk.patch?h=clangd-opt-git). Hopefully you can follow [the build

[clang] [clang] Use constant rounding mode for floating literals (PR #90877)

2024-05-02 Thread Erich Keane via cfe-commits
erichkeane wrote: Also, test failures are related to this patch! https://github.com/llvm/llvm-project/pull/90877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use constant rounding mode for floating literals (PR #90877)

2024-05-02 Thread Erich Keane via cfe-commits
@@ -3858,7 +3858,8 @@ static Expr *BuildFloatingLiteral(Sema , NumericLiteralParser , using llvm::APFloat; APFloat Val(Format); - APFloat::opStatus result = Literal.GetFloatValue(Val); + APFloat::opStatus result = erichkeane wrote: Does this work

[clang] [clang] Use constant rounding mode for floating literals (PR #90877)

2024-05-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: probably needs a release note https://github.com/llvm/llvm-project/pull/90877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >