[clang] 05f4448 - [clang][Interp][NFC] Add eval-order test

2024-05-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-07T07:58:42+02:00 New Revision: 05f4448d40f00b9fb2447e1c32cd18a7a9b8b011 URL: https://github.com/llvm/llvm-project/commit/05f4448d40f00b9fb2447e1c32cd18a7a9b8b011 DIFF: https://github.com/llvm/llvm-project/commit/05f4448d40f00b9fb2447e1c32cd18a7a9b8b011.diff

[clang] [WebAssembly] Make EH depend on multivalue and reference-types (PR #91299)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Heejin Ahn (aheejin) Changes This PR turns on multivalue and reference-types features when exception-handling feature is turned on, and errors out when disabling of those dependent features is explicitly requested. I think doing this

[clang] [WebAssembly] Make EH depend on multivalue and reference-types (PR #91299)

2024-05-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin created https://github.com/llvm/llvm-project/pull/91299 This PR turns on multivalue and reference-types features when exception-handling feature is turned on, and errors out when disabling of those dependent features is explicitly requested. I think doing this

[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-05-06 Thread Patrick Reisert via cfe-commits
Boddlnagg wrote: Regarding the positioning of Doxygen comments, I just saw this and was wondering if it's possible to also support parsing of Doxygen comments that come after the signature, which happens to be the preferred style in our codebase ... ```c++ static int doSomething(int foobar)

[clang-tools-extra] [clang-tidy] support expect no diagnosis test (PR #91293)

2024-05-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/91293 >From 55aecbedf3e10207eaef1d4c7913086a32e16b1e Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 7 May 2024 10:55:45 +0800 Subject: [PATCH 1/2] [clang-tidy] support expect no diagnosis test ---

[clang] ad9f38d - [NFC] Fix Modules/no-transitive-source-location-change.cppm after dfa7ff97b2

2024-05-06 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-05-07T13:25:42+08:00 New Revision: ad9f38d0e3a5e7e06c39dbd7da88a921a49aa805 URL: https://github.com/llvm/llvm-project/commit/ad9f38d0e3a5e7e06c39dbd7da88a921a49aa805 DIFF: https://github.com/llvm/llvm-project/commit/ad9f38d0e3a5e7e06c39dbd7da88a921a49aa805.diff

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-05-06 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/18] Add profiling functions to libomptarget

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-06 Thread Balazs Benics via cfe-commits
@@ -3479,13 +3479,24 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, // original reference count is positive, we should not report use-after-frees // on objects deleted in such destructors. This can probably be improved // through better

[clang-tools-extra] [clangd] Support callHierarchy/outgoingCalls (PR #91191)

2024-05-06 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: If I'm understanding correctly, the implementation approach in this PR only finds callees in the current translation unit. The approach in #77556 uses the project's index to find callees across translation unit boundaries. Regarding reviews: yes, it seems quite

[clang] dfa7ff9 - [C++20] [Modules] [Reduced BMI] Combine the signature of used modules

2024-05-06 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-05-07T11:41:08+08:00 New Revision: dfa7ff97b24dc5a3dd714b45af288812c13d0110 URL: https://github.com/llvm/llvm-project/commit/dfa7ff97b24dc5a3dd714b45af288812c13d0110 DIFF: https://github.com/llvm/llvm-project/commit/dfa7ff97b24dc5a3dd714b45af288812c13d0110.diff

[clang] [Arm64EC] Fix compilation of arm_acle.h (PR #91281)

2024-05-06 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/91281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4cce9fb - [Arm64EC] Fix compilation of arm_acle.h (#91281)

2024-05-06 Thread via cfe-commits
Author: Eli Friedman Date: 2024-05-06T20:04:55-07:00 New Revision: 4cce9fbb4e086170f69bfc8766f9613673b441c9 URL: https://github.com/llvm/llvm-project/commit/4cce9fbb4e086170f69bfc8766f9613673b441c9 DIFF: https://github.com/llvm/llvm-project/commit/4cce9fbb4e086170f69bfc8766f9613673b441c9.diff

[clang] f9d7619 - [ASTContext] Profile Dependently-sized array types that do not have a specified number

2024-05-06 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-05-07T10:59:34+08:00 New Revision: f9d76197ff0099502cf001abe3f5310c5bc4532d URL: https://github.com/llvm/llvm-project/commit/f9d76197ff0099502cf001abe3f5310c5bc4532d DIFF: https://github.com/llvm/llvm-project/commit/f9d76197ff0099502cf001abe3f5310c5bc4532d.diff

[clang-tools-extra] [clang-tidy] support expect no diagnosis test (PR #91293)

2024-05-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ddecadabebdd4b301bd65534b58009e57ac1bbe5...55aecbedf3e10207eaef1d4c7913086a32e16b1e

[clang-tools-extra] [clang-tidy] support expect no diagnosis test (PR #91293)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91293.diff 3 Files Affected: - (modified) clang-tools-extra/test/clang-tidy/check_clang_tidy.py (+11-2) - (added)

[clang-tools-extra] [clang-tidy] support expect no diagnosis test (PR #91293)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91293.diff 3 Files Affected: - (modified) clang-tools-extra/test/clang-tidy/check_clang_tidy.py (+11-2) - (added)

[clang-tools-extra] [clang-tidy] support expect no diagnosis test (PR #91293)

2024-05-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/91293 None >From 55aecbedf3e10207eaef1d4c7913086a32e16b1e Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 7 May 2024 10:55:45 +0800 Subject: [PATCH] [clang-tidy] support expect no diagnosis test ---

[clang] [clang-format] Handle Java switch expressions (PR #91112)

2024-05-06 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/91112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 236b3e1 - [clang-format] Handle Java switch expressions (#91112)

2024-05-06 Thread via cfe-commits
Author: Owen Pan Date: 2024-05-06T19:55:55-07:00 New Revision: 236b3e1aad45e2bab8ede0da6397b7b01f9cc9d8 URL: https://github.com/llvm/llvm-project/commit/236b3e1aad45e2bab8ede0da6397b7b01f9cc9d8 DIFF: https://github.com/llvm/llvm-project/commit/236b3e1aad45e2bab8ede0da6397b7b01f9cc9d8.diff

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-05-06 Thread Owen Pan via cfe-commits
@@ -3850,6 +3850,7 @@ LangOptions getFormattingLangOpts(const FormatStyle ) { // the sequence "<::" will be unconditionally treated as "[:". // Cf. Lexer::LexTokenInternal. LangOpts.Digraphs = LexingStd >= FormatStyle::LS_Cpp11; + LangOpts.RawStringLiterals = LexingStd

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-06 Thread via cfe-commits
sharkautarch wrote: > Yeah I think it's not sufficient to model the atomics. It's a good idea to > model them anyway, but even when atomics aren't used (eg. the custom smart > pointer never needed to be thread-safe), the fundamental problem is that we > still don't know the _initial_ value

[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-05-06 Thread via cfe-commits
dhruvachak wrote: I think OmptCallback.cpp can be completely removed from the plugin since that functionality is subsumed by offload. As in ``` diff --git a/offload/plugins-nextgen/common/CMakeLists.txt b/offload/plugins-nextgen/common/CMakeLists.txt index acf0af63f050..dc942db826bf 100644

[clang] [llvm] Revert "[DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version" (PR #91290)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy closed https://github.com/llvm/llvm-project/pull/91290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 178ff39 - Revert "[DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version" (#91290)

2024-05-06 Thread via cfe-commits
Author: S. Bharadwaj Yadavalli Date: 2024-05-06T22:21:37-04:00 New Revision: 178ff395006f204265b4f6fe72a3dbb2b9a79b47 URL: https://github.com/llvm/llvm-project/commit/178ff395006f204265b4f6fe72a3dbb2b9a79b47 DIFF:

[clang] [llvm] Revert "[DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version" (PR #91290)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: S. Bharadwaj Yadavalli (bharadwajy) Changes Reverts llvm/llvm-project#90809 Need to investigate ASAN failures. --- Full diff: https://github.com/llvm/llvm-project/pull/91290.diff 10 Files Affected: - (modified)

[clang] [llvm] Revert "[DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version" (PR #91290)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy created https://github.com/llvm/llvm-project/pull/91290 Reverts llvm/llvm-project#90809 Need to investigate ASAN failures. >From 3be739599982371e6151561758928007d4dc2762 Mon Sep 17 00:00:00 2001 From: "S. Bharadwaj Yadavalli" Date: Mon, 6 May 2024 22:16:35 -0400

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-06 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: > I've just left here what my thought process was when I dig into a similar > case. It might be useful, who knows. Medium-to-long-term I think an attribute-based approach might make sense there: - Either annotate reference-counting pointers as "hey I'm a smart pointer (I'm

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-06 Thread Artem Dergachev via cfe-commits
@@ -3479,13 +3479,24 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, // original reference count is positive, we should not report use-after-frees // on objects deleted in such destructors. This can probably be improved // through better

[clang] [analyzer] MallocChecker: Recognize std::atomics in smart pointer suppression. (PR #90918)

2024-05-06 Thread Artem Dergachev via cfe-commits
@@ -3479,13 +3479,24 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, // original reference count is positive, we should not report use-after-frees // on objects deleted in such destructors. This can probably be improved // through better

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-06 Thread via cfe-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/91046 >From 767173a0dfde9858c90867cc5d476da90e5ba898 Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Tue, 30 Apr 2024 22:58:18 -0400 Subject: [PATCH 1/5] [AArch64] Support preserve_none calling convention

[clang] [llvm] [WebAssembly] Implement prototype f32.load_f16 instruction. (PR #90906)

2024-05-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin approved this pull request. https://github.com/llvm/llvm-project/pull/90906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/91275 >From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Mon, 6 May 2024 14:39:37 -0700 Subject: [PATCH 1/5] Use cmake to find perl executable --- clang/CMakeLists.txt

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
@@ -1,4 +1,4 @@ -REQUIRES: shell +REQUIRES: perl MatzeB wrote: Seems there is `rm` but no `ls`: https://github.com/MatzeB/llvm-project/blob/5e5b18a31057f0d086ce9731d2b58aa70d55eef5/llvm/utils/lit/lit/TestRunner.py?plain=1#L714

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/91275 >From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Mon, 6 May 2024 14:39:37 -0700 Subject: [PATCH 1/4] Use cmake to find perl executable --- clang/CMakeLists.txt

[clang] [Arm64EC] Fix compilation of arm_acle.h (PR #91281)

2024-05-06 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello approved this pull request. https://github.com/llvm/llvm-project/pull/91281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Fangrui Song via cfe-commits
@@ -1,5 +1,4 @@ -// FIXME: Actually, "perl". MaskRay wrote: Instead of `REQUIRES: perl` in (almost?) every scan-build/ test, update `clang/test/Analysis/scan-build/lit.local.cfg` instead? There are some `if ... not config.xxx: config.unsupported = True`

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Set DXIL Version using shader model version in compilation target profile (PR #89823)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
bharadwajy wrote: > Now the #90809 has landed, is this PR still relevant? No. I was just about to close it. Thanks! Closing as an expanded implementation has been merged. https://github.com/llvm/llvm-project/pull/89823 ___ cfe-commits mailing list

[clang] [llvm] [DirectX] Set DXIL Version using shader model version in compilation target profile (PR #89823)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy closed https://github.com/llvm/llvm-project/pull/89823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Set DXIL Version using shader model version in compilation target profile (PR #89823)

2024-05-06 Thread Damyan Pepper via cfe-commits
damyanp wrote: Now the #90809 has landed, is this PR still relevant? https://github.com/llvm/llvm-project/pull/89823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Ignore WTF::RefCounted and its variants missing virtual destructor (PR #91009)

2024-05-06 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thanks for the reviews! https://github.com/llvm/llvm-project/pull/91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Ignore WTF::RefCounted and its variants missing virtual destructor (PR #91009)

2024-05-06 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6d6693e - [webkit.RefCntblBaseVirtualDtor] Ignore WTF::RefCounted and its variants missing virtual destructor (#91009)

2024-05-06 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-05-06T16:01:45-07:00 New Revision: 6d6693e9f5376ac8c809a36e1ba4a8c47f311a70 URL: https://github.com/llvm/llvm-project/commit/6d6693e9f5376ac8c809a36e1ba4a8c47f311a70 DIFF: https://github.com/llvm/llvm-project/commit/6d6693e9f5376ac8c809a36e1ba4a8c47f311a70.diff

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-06 Thread Wei Zhao via cfe-commits
@@ -85,6 +85,10 @@ def SMEUnsupported : AArch64Unsupported { SME2Unsupported.F); } +def MTEUnsupported : AArch64Unsupported { + let F = [HasMTE]; +} + wxz2020 wrote: It is referenced in AArch64SchedOryon.td on line 33. The Oryon CPU

[clang] b86accc - [alpha.webkit.UncountedCallArgsChecker] Treat (foo())->bar() like foo()->bar(). (#91052)

2024-05-06 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-05-06T15:59:08-07:00 New Revision: b86accceee0c7c5d36ecdc1629d00e6303f29955 URL: https://github.com/llvm/llvm-project/commit/b86accceee0c7c5d36ecdc1629d00e6303f29955 DIFF: https://github.com/llvm/llvm-project/commit/b86accceee0c7c5d36ecdc1629d00e6303f29955.diff

[clang] [alpha.webkit.UncountedCallArgsChecker] Treat (foo())->bar() like foo()->bar(). (PR #91052)

2024-05-06 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/91052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-06 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/90676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 29d447a - [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (#90676)

2024-05-06 Thread via cfe-commits
Author: Ian Anderson Date: 2024-05-06T15:55:41-07:00 New Revision: 29d447a6e446e7fd78bd28af28bbf7dd377ade10 URL: https://github.com/llvm/llvm-project/commit/29d447a6e446e7fd78bd28af28bbf7dd377ade10 DIFF: https://github.com/llvm/llvm-project/commit/29d447a6e446e7fd78bd28af28bbf7dd377ade10.diff

[clang-tools-extra] 29d447a - [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (#90676)

2024-05-06 Thread via cfe-commits
Author: Ian Anderson Date: 2024-05-06T15:55:41-07:00 New Revision: 29d447a6e446e7fd78bd28af28bbf7dd377ade10 URL: https://github.com/llvm/llvm-project/commit/29d447a6e446e7fd78bd28af28bbf7dd377ade10 DIFF: https://github.com/llvm/llvm-project/commit/29d447a6e446e7fd78bd28af28bbf7dd377ade10.diff

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support packoffset attribute in AST (PR #89836)

2024-05-06 Thread Xiang Li via cfe-commits
python3kgae wrote: > I'm marking this as requesting changes because I don't think we should land > this as-is. Switched to warning. https://github.com/llvm/llvm-project/pull/89836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Artem Dergachev via cfe-commits
@@ -1,4 +1,4 @@ -REQUIRES: shell +REQUIRES: perl haoNoQ wrote: A few of those require `rm` and `ls` but these don't count as shell right? https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. Looks great thanks a lot!! I can confirm that it works for me on a mac too. @jroelofs's comment is on point. https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list

[clang] [analyzer] Support determining origins in a conditional operator in WebKit checkers. (PR #91143)

2024-05-06 Thread Artem Dergachev via cfe-commits
@@ -27,12 +28,18 @@ tryToFindPtrOrigin(const Expr *E, bool StopAtFirstRefCountedObj) { E = tempExpr->getSubExpr(); continue; } +if (auto *Expr = dyn_cast(E)) { + return tryToFindPtrOrigin(Expr->getTrueExpr(), StopAtFirstRefCountedObj, +

[clang] [HLSL] Support packoffset attribute in AST (PR #89836)

2024-05-06 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/89836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support packoffset attribute in AST (PR #89836)

2024-05-06 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/89836 >From 4d8c72688656fe3b2ce8817087d8cf7352b5876b Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Tue, 23 Apr 2024 17:49:02 -0400 Subject: [PATCH 1/7] [HLSL] Support packoffset attribute in AST Add

[clang] [analyzer] Ignore system headers in WebKit checkers. (PR #91103)

2024-05-06 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: > Aha, this looks like a more traditional solution! Looks great. You can make > tests for this by feeding the compiler fake system headers with the help of > > ``` > #pragma clang system_header > ``` > > ! oh, that's neat! https://github.com/llvm/llvm-project/pull/91103

[clang] [analyzer] Ignore system headers in WebKit checkers. (PR #91103)

2024-05-06 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: Aha, this looks like a more traditional solution! Looks great. You can make tests for this by feeding the compiler fake system headers with the help of ``` #pragma clang system_header ``` ! https://github.com/llvm/llvm-project/pull/91103

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow trivial operator++ (PR #91102)

2024-05-06 Thread Artem Dergachev via cfe-commits
@@ -316,10 +316,15 @@ class TrivialFunctionAnalysisVisitor if (UO->isIncrementOp() || UO->isDecrementOp()) { // Allow increment or decrement of a POD type. - if (auto *RefExpr = dyn_cast(UO->getSubExpr())) { + auto *SubExpr = UO->getSubExpr(); + if

[clang] [Arm64EC] Fix compilation of arm_acle.h (PR #91281)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eli Friedman (efriedma-quic) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91281.diff 2 Files Affected: - (modified) clang/lib/Headers/arm_acle.h (+1-1) - (modified) clang/test/Headers/arm-acle-header.c (+1)

[clang] [Arm64EC] Fix compilation of arm_acle.h (PR #91281)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Eli Friedman (efriedma-quic) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91281.diff 2 Files Affected: - (modified) clang/lib/Headers/arm_acle.h (+1-1) - (modified) clang/test/Headers/arm-acle-header.c (+1)

[clang] [Arm64EC] Fix compilation of arm_acle.h (PR #91281)

2024-05-06 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/91281 None >From 5a5512aa5a84e2c89efd9e9ade043061d73d25fb Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Fri, 3 May 2024 21:13:32 -0700 Subject: [PATCH] [Arm64EC] Fix compilation of arm_acle.h ---

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/91275 >From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Mon, 6 May 2024 14:39:37 -0700 Subject: [PATCH 1/3] Use cmake to find perl executable --- clang/CMakeLists.txt

[clang] [llvm] [MC,clang,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes CREL is a compact relocation format for the ELF object file format. This patch adds integrated assembler support (using the RELA form), which can be enabled with `clang -c

[clang] [llvm] [MC,clang,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Fangrui Song (MaskRay) Changes CREL is a compact relocation format for the ELF object file format. This patch adds integrated assembler support (using the RELA form), which can be enabled with `clang -c -Wa,--crel,--experimental-crel`.

[clang] [llvm] [MC,clang,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-05-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/91280 CREL is a compact relocation format for the ELF object file format. This patch adds integrated assembler support (using the RELA form), which can be enabled with `clang -c -Wa,--crel,--experimental-crel`.

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/91275 >From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Mon, 6 May 2024 14:39:37 -0700 Subject: [PATCH 1/2] Use cmake to find perl executable --- clang/CMakeLists.txt

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthias Braun (MatzeB) Changes `clang/tools/scan-build` is implemented in `perl`. However given `perl` is not mentioned as a required dependency in `GettingStarted.rst` we should make this optional. This adds a `find_package(Perl)`

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB ready_for_review https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy closed https://github.com/llvm/llvm-project/pull/90809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 080978d - [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (#90809)

2024-05-06 Thread via cfe-commits
Author: S. Bharadwaj Yadavalli Date: 2024-05-06T18:33:57-04:00 New Revision: 080978dd2067d0c9ea7e229aa7696c2480d89ef1 URL: https://github.com/llvm/llvm-project/commit/080978dd2067d0c9ea7e229aa7696c2480d89ef1 DIFF:

[clang] Duplicate condition (PR #91279)

2024-05-06 Thread via cfe-commits
jyu2-git wrote: Sorry, I don't why to patch merge to one. I am trying again. https://github.com/llvm/llvm-project/pull/91279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Duplicate condition (PR #91279)

2024-05-06 Thread via cfe-commits
https://github.com/jyu2-git converted_to_draft https://github.com/llvm/llvm-project/pull/91279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Duplicate condition (PR #91279)

2024-05-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jyu2-git) Changes --- Patch is 30.49 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91279.diff 5 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticParseKinds.td (+5)

[clang] Duplicate condition (PR #91279)

2024-05-06 Thread via cfe-commits
https://github.com/jyu2-git created https://github.com/llvm/llvm-project/pull/91279 None >From 563c1254162d7b42fd7579514f45df326216f508 Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Sun, 5 May 2024 10:44:40 -0700 Subject: [PATCH 1/2] Revert "Revert "[OpenMP][TR12] change property of

[clang] [alpha.webkit.UncountedCallArgsChecker] Treat (foo())->bar() like foo()->bar(). (PR #91052)

2024-05-06 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. LGTM! Yeah I really don't know why `ParenExpr` needed to be a thing in the AST. https://github.com/llvm/llvm-project/pull/91052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [webkit.RefCntblBaseVirtualDtor] Ignore WTF::RefCounted and its variants missing virtual destructor (PR #91009)

2024-05-06 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-05-06 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/90676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Jon Roelofs via cfe-commits
@@ -1,4 +1,4 @@ -REQUIRES: shell +REQUIRES: perl jroelofs wrote: (the rest of them seem fine though) https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Jon Roelofs via cfe-commits
@@ -1,4 +1,4 @@ -REQUIRES: shell +REQUIRES: perl jroelofs wrote: should be: ``` REQUIRES: perl, shell ``` right? https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
MatzeB wrote: I checked that: - scan-build tests run fine by default on my machine. - scan-build tests are skipped when using `cmake -DCMAKE_DISBALE_FIND_PACKAGE_Perl=ON ...`. https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing

[clang] [Modules] Detect ODR mismatches for enums in non-C++ like in C++. (PR #90298)

2024-05-06 Thread David Blaikie via cfe-commits
dwblaikie wrote: > Though we detect when the types aren't identical and don't try to use them > interchangeably. The change extends the existing behavior for structs/unions > to enums. OK, still a bit confused though - "like in C++", I assume in C++ we reject mismatched types coming from

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/91275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-05-06 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I did not build upstream but looking at downstream, I think for some reason > they don't show up as duplicate symbols. But looking at the code, they should > be removed. There are uses of those variables in the plugin, so there should > be only 1 definition. Does this apply

[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)

2024-05-06 Thread via cfe-commits
dhruvachak wrote: > > There are duplicate definitions of the following > > ``` > > bool llvm::omp::target::ompt::Initialized = false; > > > > ompt_get_callback_t llvm::omp::target::ompt::lookupCallbackByCode = nullptr; > > ompt_function_lookup_t llvm::omp::target::ompt::lookupCallbackByName =

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy updated https://github.com/llvm/llvm-project/pull/90809 >From 3b74e41492aeb916487105b05316f8db255c57c3 Mon Sep 17 00:00:00 2001 From: Bharadwaj Yadavalli Date: Wed, 1 May 2024 14:42:42 -0400 Subject: [PATCH 1/7] Set DXIL Version in DXIL target triple based on

[clang] Use cmake to find perl executable (PR #91275)

2024-05-06 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB created https://github.com/llvm/llvm-project/pull/91275 None >From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Mon, 6 May 2024 14:39:37 -0700 Subject: [PATCH] Use cmake to find perl executable ---

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -932,6 +932,12 @@ def warn_module_conflict : Warning< InGroup; // C++20 modules +def err_module_decl_cannot_be_macros : Error< + "the name of a module%select{| partition}0 declaration cannot contains " + "an object-like macro %1, and the macro will not expand" +

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token ) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -932,6 +932,12 @@ def warn_module_conflict : Warning< InGroup; // C++20 modules +def err_module_decl_cannot_be_macros : Error< + "the name of a module%select{| partition}0 declaration cannot contains " + "an object-like macro %1, and the macro will not expand" +

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token ) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token ) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,87 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 %t/A.cppm -triple x86_64-linux-gnu -verify +// RUN: %clang_cc1 -std=c++20 %t/B.cppm -triple x86_64-linux-gnu -verify +// RUN: %clang_cc1 -std=c++20 %t/C.cppm

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-06 Thread Michael Spencer via cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token ) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

2024-05-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 94204f59e92473bb19333f40a2250b64a398191a e739a33712f15e0d1fe1d9a121a564418a449437 --

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

2024-05-06 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy updated https://github.com/llvm/llvm-project/pull/90809 >From 3b74e41492aeb916487105b05316f8db255c57c3 Mon Sep 17 00:00:00 2001 From: Bharadwaj Yadavalli Date: Wed, 1 May 2024 14:42:42 -0400 Subject: [PATCH 1/6] Set DXIL Version in DXIL target triple based on

  1   2   3   4   >