[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ebfba68b9a: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0. (authored by AMDChirag). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363625. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363624. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363542. AMDChirag added a comment. minor fix in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 362319. AMDChirag added a comment. Rebased. Verified, this patch is not causing any test failures for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361605. AMDChirag added a comment. Minor test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361598. AMDChirag added a comment. Removed parent line in summary, it was not longer relevant and caused build failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 361597. AMDChirag added a comment. Rebase to current main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files:

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @jdoerfert Could you please take a look at this patch as well? (especially for the clang part) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @kiranchandramohan The tests passed now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___ cfe-commits mailing list

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 354839. AMDChirag added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @kiranchandramohan It failed again. Apparently, it automatically attempted to add a patch D93105 which is already merged. I removed that patch as dependency before (edit related revisions), but it seems to have been added again. Am I

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. Oh great! That triggered it! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___ cfe-commits mailing list

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 353579. AMDChirag added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. In D93373#2832533 , @kiranchandramohan wrote: > It could be because you are not the author. Can you commandeer the patch > (option available in the Add Action menu below)? Just did that. Still the same error: You do not

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. Hi @kiranchandramohan How do I restart the build? It says I don't have permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 353548. AMDChirag added a comment. Rebased to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 353379. AMDChirag added a comment. Herald added a reviewer: sscalpone. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes the clang test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

AMDChirag added a comment. LGTM. I'll let someone else take a look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102849/new/ https://reviews.llvm.org/D102849 ___ cfe-commits mailing list

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

This revision was automatically updated to reflect the committed changes. Closed by commit rGc20410618827: [Clang][OpenMP] Frontend work for sections - D89671 (authored by AMDChirag). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 341503. AMDChirag added a comment. Rebase to retrigger build The build failed previously - seemingly with a test case that has nothing to do with this patch. Retriggering and Rebasing the commit to ensure the same. Repository: rG LLVM Github Monorepo

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 341436. AMDChirag added a comment. Rebased to HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. In D91054#2708873 , @jdoerfert wrote: > What is missing or not working in the IRBuilder impl that prevents us from > turning it on by default? Per the `TODO` in this patch (`CGStmtOpenMP.cpp - 3775`), `PrivatizationCallback`

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. For D89671 , Johannes had some comments which have been taken care of. I am just waiting for him to get back on it. I'll ping him there. This patch is done from my end unless someone has some comment/thought. Repository: rG LLVM

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. In D91054#2693514 , @fghanim wrote: > You can update the tests as long as long as the output is correct. for > example the difference is only in names, ordering of basicblocks and > instructions that doesn't affect

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 337654. AMDChirag added a comment. Herald added a subscriber: jfb. Fixed cancel construct and applied updates to its test cases The test cases are updated so that the IR generated with and without IRBuilder are considered as they are different. The

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3579 +SectionCBVector.push_back(SectionCB); + } +} else { jdoerfert wrote: > Why do we unpack the children here instead of making a single call back for > the

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added a comment. LGTM. I'll let someone else review the patch if required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___ cfe-commits mailing list

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions ) { + assert(opts.programAction_ !=

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions ) { + assert(opts.programAction_ !=

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. @fghanim @jdoerfert please review the code if/when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 319095. AMDChirag added a comment. Added FIXME comment for cancellation construct not working with sections construct Also updated the lit test cases to reflect this change. The lit test case modification will be removed once this issue is resolved.

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 315708. AMDChirag added a comment. Added OMP delegating code for `createSection` (`EmitOMPSectionDirective`). @fghanim working on clang lit test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 313307. AMDChirag added a comment. Updated `BGenCallbackTy` to `StorableBodyGenCallbackTy`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 Files:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 313303. AMDChirag marked an inline comment as done. AMDChirag added a comment. Updated code according to the changes in LLVM side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3576 +} else { + auto SectionCB = [this, CS](InsertPointTy AllocaIP, + InsertPointTy CodeGenIP, Meinersbur wrote: > In what situation would

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 307022. AMDChirag added a comment. Fixed usage of BodyGenCallbackTy Removed ArrayRef variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 Files:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added a comment. The test case will also be added here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing list

[PATCH] D91054: [LLVM][OpenMP] Frontend work for sections - D89671

AMDChirag created this revision. AMDChirag added reviewers: anchu-rajendran, fghanim, jdoerfert, kiranchandramohan, kiranktp, SouraVX, AlexisPerry, Meinersbur. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. AMDChirag requested review of this revision.