[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b7bd911d9e: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images (authored by airlied). Repository: rG LLVM Github

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364919. airlied added a comment. fixed issues with check-clang, might need some follow up changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files:

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1854db74c549: opencl-c.h: add 3.0 optional extension support for a few more bits (authored by airlied). Repository: rG LLVM Github Monorepo

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364396. airlied added a comment. missed a couple of hunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files: clang/lib/Headers/opencl-c.h Index:

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364395. airlied added a comment. found a few more places to replace these and fix them up. there might still be some strays in there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files:

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied added a subscriber: azabaznov. airlied added a comment. Add @azabaznov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 ___ cfe-commits mailing list

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This wraps the image and rw images usages in the correct macros Repository: rG LLVM Github

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 364372. airlied added a comment. Added a comment on the subgroups difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files:

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14cb67862a72: [OpenCL] allow generic address and non-generic defs for CL3.0 (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied added a comment. @azabaznov no bad effects here in my initial basic testing with CL 3.0, I'll land this tomorrow or next day when I get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/ https://reviews.llvm.org/D107318

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied added a subscriber: azabaznov. airlied added a comment. @azabaznov is this what you meant? I haven't tested this yet as my clang dev box died, but I'll get to it as soon as I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This allows both sets of definitions to exist on CL 3.0 Repository: rG LLVM Github Monorepo

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c7d2f1b67d1: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics (authored by airlied). Repository: rG LLVM Github Monorepo

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13678 +uintptr_t __ovld atomic_fetch_sub_explicit(volatile __local atomic_uintptr_t *object, ptrdiff_t operand, memory_order order, memory_scope scope); +#endif +#endif Anastasia wrote: >

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied updated this revision to Diff 362587. airlied added a comment. added comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106778/new/ https://reviews.llvm.org/D106778 Files: clang/lib/Headers/opencl-c.h Index:

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied added a comment. In D106778#2904509 , @Anastasia wrote: > Generally LGTM, but I think we should guard the `else` blocks with > CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards > because the spec says: > > The C11

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied added a comment. In D106778#2904509 , @Anastasia wrote: > Generally LGTM, but I think we should guard the `else` blocks with > CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards > because the spec says: > > The C11

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. CL 2.0 interdocued atomics and generic address space so there were only one set of APIs for

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9451403c5f8c: [OPENCL] opencl-c.h: add initial CL 3.0 conditionals for atomic operations. (authored by airlied). Changed prior to commit:

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

airlied updated this revision to Diff 360349. airlied added a comment. add conditional around memory_order_seq_cst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111 Files:

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This adds the optional wrappers around things, however this isn't sufficient yet for CL 3.0

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied marked an inline comment as done. airlied added a comment. yeah I agree I'll drop those two changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 359166. airlied added a comment. leave version checks alone since they are inside the outer extension check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files:

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 359114. airlied added a comment. fixed up missing cl_khr_subgroups checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde79ba9f9a2d: [OpenCL] opencl-c.h: CL3.0 generic address space (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105601: opencl-c.h: reorder atomic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG090f007e3481: [OpenCL][NFC] opencl-c.h: reorder atomic operations (authored by airlied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. These 3 are fairly simple, pipes, workgroups and subgroups. Repository: rG LLVM Github

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 358005. airlied added a comment. full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/opencl-c.h

[PATCH] D105601: opencl-c.h: reorder atomic operations

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This just reorders the atomics, it doesn't change anything except their layout in the

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 357100. airlied added a comment. I've dropped the __SPIR__ change in the base header until things are resolved for library SPIR users to disable extension defines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); Anastasia wrote: > This one is not generic address space pointer though but

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 356992. airlied added a comment. updated to full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h Index:

[PATCH] D105526: opencl-c.h: some CL3.0 compat bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This is some of the easier pieces of making the opencl-c.h header CL 3.0 compatible.

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. I'll have to rebase/rebuild my build env, I'll try and have something rebasing this cleaner soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92004/new/ https://reviews.llvm.org/D92004

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. In D92004#2413560 , @Anastasia wrote: > Btw how about making some checks simpler. We could always define feature > macros `__opencl_c_atomic_scope_device`, `__opencl_c_generic_address_space` > for OpenCL 2.0 or C++ for OpenCL .

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. this file has never been clang-format clean, happy to make changes if reviewer decides they are needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92004/new/ https://reviews.llvm.org/D92004