[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I'd like to also address https://github.com/llvm/llvm-project/issues/47815, > but I wasn't able to find the right path to answer "is this M-profile" from > TargetInfo. Any ARM folks know if there are existing M profile only warnings to learn from?

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -544,6 +548,14 @@ Improvements to Clang's diagnostics - Clang no longer emits a "declared here" note for a builtin function that has no declaration in source. Fixes #GH93369. +- On ARM, Clang no longer suggests adding ``__attribute__((interrupt))`` to

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -384,6 +384,10 @@ Modified Compiler Flags evaluating to ``true`` and an empty body such as ``while(1);``) are considered infinite, even when the ``-ffinite-loop`` flag is set. +- Removed "arm interrupt calling convention" warning that was included in

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
@@ -336,9 +336,10 @@ def warn_anyx86_excessive_regsave : Warning< " with attribute 'no_caller_saved_registers'" " or be compiled with '-mgeneral-regs-only'">, InGroup>; -def warn_arm_interrupt_calling_convention : Warning< - "call to function without interrupt

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: I can't fully approve this, I leave that to other members of @llvm/pr-subscribers-arm . 2 overall comments: * Calling a function marked interrupt from a function marked interrupt is still UB isn't it? Should there be another warning to cover that

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c324281 - [clang][test] Update link for Arm clang-repl test disable

2024-06-10 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-06-10T16:14:53+01:00 New Revision: c32428151678f05fa3a9b5996e07f1e67094626c URL: https://github.com/llvm/llvm-project/commit/c32428151678f05fa3a9b5996e07f1e67094626c DIFF:

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-10 Thread David Spickett via cfe-commits
DavidSpickett wrote: You can debug it by cross-compiling a debug build, then running the unit tests binary and connecting to qemu's built in gdbserver. The Arm toolchain might have a copy of gdb in it already, but if not, gdb multiarch and lldb would also work (which are both installable from

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Looks like this fixed things: https://lab.llvm.org/buildbot/#/builders/245/builds/25578 Thanks for working with me on this. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Actually, as someone pointed out, I've been conflating clang-repl with the constant expression interpreter. So the issue covers the latter and this must be something else. https://github.com/llvm/llvm-project/pull/89811 ___

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I will get you instructions on how to do that (will be tomorrow at this > point). https://github.com/llvm/llvm-project/issues/94741#issuecomment-2154656315 There is some underlying issue (https://github.com/llvm/llvm-project/issues/94741), so if you want to try and

[clang] 54c5dbe - [clang][test] Skip interpreter value test on Arm 32 bit

2024-06-07 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-06-07T10:38:25Z New Revision: 54c5dbe7c3812461decbccb6ed122e41777e02bd URL: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd DIFF: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd.diff

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Ok, this new version passes `check-llvm` and `check-clang` (ignoring the pre-existing failure), using the exact config from [clang-armv8-quick](https://lab.llvm.org/buildbot/#/builders/245). https://github.com/llvm/llvm-project/pull/94603

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Sure I'll test it now. BTW if you see `Clang-Unit::ClangReplInterpreterTests/InterpreterTest/Value` failing on one of our bots, that's not due to your change. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: > My feeling is the latter but how can we get a debug build and debug? I'm going to try a UBSAN build on the chance it pinpoints the issue right away, but failing that it'll be cross compiling to Arm 32 bit and using qemu-user to run the unit test binary. I will get you

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: It is a 32 bit container running on an arm64 host. As far as the compiler and tests know, it's a 32 bit system. > But in either case the width of the int type should be the same, right? Yes. So I am wondering if someone of the assumptions about types being larger than

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: I have bisected a 32 bit Arm failure down to this change: https://lab.llvm.org/buildbot/#/builders/245/builds/25526 Is it possible that something in this code is truncating a value when interpreting types intended for a 64 bit system, on a 32 bit system? I don't see this

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: I tested locally and this fixes all the test failures. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Thanks. Reproduced. But it surprised me that I can't run the commands you > mentioned, but I need to run: > ./bin/lldb-dotest -p TestTemplateWithSameArg.py -G gmodules Running the tests as modules is perhaps opt in, we have the ability to run them with different debug

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-04 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/94271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/94325 will get us past the compiler error. Some things I noticed testing that: * There is an lld installed on the machine but it's in a path with spaces so lit can't run it. Generally we'd build lld along with lldb and use that in

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: Maybe you can run individual tests with lit but generally I use `lldb-dotest` instead: ``` ./bin/lldb-dotest.py -p TestTemplateWithSameArg.py ``` (you only need the filename) https://github.com/llvm/llvm-project/pull/92083 ___

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: I think the issue is https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897 which appears to have been fixed in 19.32 (https://godbolt.org/z/P594qGrc9). But @slydiman reports 14.29.30133 which is earlier than that. Perhaps

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: > MSVC 14.29.30133 is VS 2019. We are using VS 2022 with the latest Windows SDK > to build lldb w/o problems. I also couldn't reproduce it locally with `19.34.31937`, but I may still be able to reproduce by making my own version of this PR so I can use the CI's version.

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I'll do that, but I think LLDB should follow the example of MLIR here https://github.com/llvm/llvm-project/pull/94220 https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > First Windows CI results: LLDB unit tests do not even build. Linaro's Windows bot uses clang-cl, but I do remember something like this there too. I will do a local build with msvc and see what I can do. https://github.com/llvm/llvm-project/pull/94208

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: And I would bet that a majority of the unresolved are due to: ``` ModuleNotFoundError: No module named 'pexpect' ``` You can either install it with `pip` or pass `-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` to CMake. https://github.com/llvm/llvm-project/pull/94208

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > lldb-shell :: SymbolFile/DWARF/x86/module-ownership.mm This is due to https://github.com/llvm/llvm-project/pull/92083, it's been reverted now. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: This also broke an lldb test: https://lab.llvm.org/buildbot/#/builders/96/builds/58449 `lldb-test: ../llvm-project/clang/lib/AST/DeclBase.cpp:132: void clang::Decl::setOwningModuleID(unsigned int): Assertion `!((*IDAddress) >> 48) && "We should only set the module ID

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: If this is split out from the other larger PR, should there be `clang/` changes in here? I've copied your commit message into the PR description, because with the way llvm is setup, we use the PR's description as the commit message for a squashed version of the changes.

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LLDB changes look good to me. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-13 Thread David Spickett via cfe-commits
DavidSpickett wrote: LLVM uses a GitHub setting where the PR is squashed, and the commit message is taken from the PR description rather than the commits themselves. So all you have to do here is copy the commit message you updated into the PR's description.

[clang] fb1c2db - Revert "Reapply "[clang][Interp] Create full type info for dummy pointers""

2024-05-03 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-05-03T09:56:23Z New Revision: fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b URL: https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b DIFF: https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b.diff

[clang] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-02 Thread David Spickett via cfe-commits
DavidSpickett wrote: @wzssyqa thanks for working with us on this. Bare metal is always a wild card but I think in the end we'll all have cleaner builds because of these changes. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing

[clang] [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (PR #90734)

2024-05-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (PR #90734)

2024-05-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Add release note for *-none-* triple normalization changes (PR #90734)

2024-05-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90734 That were implemented by https://github.com/llvm/llvm-project/pull/89638. >From 2d4d5e1885cc8e722b9ebaab81caf2d39c9994da Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 15:39:31 +0100

[clang] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: libcxx is sorted, and I will write up the release note given that I suggested it and have been fixing some builds myself. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also this change should be release noted with a tip that build scripts may want to change to asking clang for the triple instead. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
@@ -217,7 +217,7 @@ function test-armv7m-picolibc() { "${@}" ${NINJA} -vC "${BUILD_DIR}/compiler-rt" install -mv "${BUILD_DIR}/install/lib/armv7m-none-unknown-eabi"/* "${BUILD_DIR}/install/lib" +mv "${BUILD_DIR}/install/lib/armv7m-unknown-none-eabi"/*

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: I'm checking the picolib libcxx build right now so please hold off on landing this. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [llvm][RISCV] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][RISCV] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][RISC-V] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90468 Previously you got: clang: error: invalid arch name 'rv64v', first letter should be 'e', 'i' or 'g' Which to me, unfamiliar with riscv, reads as if I should have used "[eig]rv64v". Which is not what clang

[clang] [libcxx] [lld] [llvm] Triple::normalize: Set OS for 3-component triple with none as middle (PR #89638)

2024-04-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Ohh, there is so many -none-unknown- in current code. I guess it may be > widely used. Do we really want to change all of them? In current test cases, which were likely generated using clang. So they are likely not relying on that exact form of the triple, it's just

[clang] [compiler-rt] [llvm] Revert "[FMV] Remove useless features according the latest ACLE spec." (PR #89184)

2024-04-18 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. The changes themselves LGTM, thanks for fixing this. https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The docbrief strings already use %Program/GlobalDocumentation.Program which > seems to work and made me think that HelpTextForVariants was actually > unnecessary. Would you like me to introduce DocBriefForVariants? IIRC it was unnessecary for the documentation because

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Clang is also mentioned for the diagnostic warnings reference, which mostly > applies to C/C++/Obj-C, not Fortran. > https://github.com/llvm/llvm-project/pull/81726 already tried to fix this, > and I don't know a better solution. Do you mean that this PR fixes this, or

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-17 Thread David Spickett via cfe-commits
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"], "gcc-install-dir=">, "Note: executables (e.g. ld) used by the compiler are not overridden by the selected GCC installation">; def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>,

[clang-tools-extra] aff197f - Reland "[flang][clang] Add Visibility specific help text for options (#81869)"

2024-04-05 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-04-05T08:27:59Z New Revision: aff197ff2163a4b7732d08b833906cc21f4a5c89 URL: https://github.com/llvm/llvm-project/commit/aff197ff2163a4b7732d08b833906cc21f4a5c89 DIFF: https://github.com/llvm/llvm-project/commit/aff197ff2163a4b7732d08b833906cc21f4a5c89.diff

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-04-05 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-14 Thread David Spickett via cfe-commits
@@ -191,6 +191,60 @@ static MarshallingInfo createMarshallingInfo(const Record ) { return Ret; } +static void EmitHelpTextsForVariants( +raw_ostream , std::vector, StringRef>> + HelpTextsForVariants) { + // OptTable must be constexpr so it

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-13 Thread David Spickett via cfe-commits
DavidSpickett wrote: I've also tested this with increased array sizes. You can check the .inc files to see that they are intialised properly, `/lib/ToolDrivers/llvm-lib/Options.inc` is one. https://github.com/llvm/llvm-project/pull/81869 ___

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 01/12] [flang][clang] Add Visibility specific help text

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
@@ -93,6 +93,11 @@ class OptionGroup { // Define the option class. +class HelpTextForVisibility { DavidSpickett wrote: I've changed it to: HelpTextForVariants (for a single entry in the list, which is many variants to one string) Help**Texts**ForVariants

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/9] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/8] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/7] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/6] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
@@ -3382,10 +3382,19 @@ def fopenmp : Flag<["-"], "fopenmp">, Group, HelpText<"Parse OpenMP pragmas and generate parallel code.">; def fno_openmp : Flag<["-"], "fno-openmp">, Group, Flags<[NoArgumentUnused]>; +class OpenMPVersionHelp { + string str = !strconcat( +"Set

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/5] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-12 Thread David Spickett via cfe-commits
@@ -3382,10 +3382,19 @@ def fopenmp : Flag<["-"], "fopenmp">, Group, HelpText<"Parse OpenMP pragmas and generate parallel code.">; def fno_openmp : Flag<["-"], "fno-openmp">, Group, Flags<[NoArgumentUnused]>; +class OpenMPVersionHelp { + string str = !strconcat( +"Set

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I've added a host id (0xd42) to llvm/lib/TargetParser/Host.cpp, so I think so > (unless there's something else required). Right, of course, somehow I skipped right over that. https://github.com/llvm/llvm-project/pull/84485 ___

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also does this address the -mcpu=native part of https://github.com/llvm/llvm-project/issues/84450 as well? https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Should this be added to the release notes? (so it doesn't get forgotten in a mad scramble in a few months time) https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-05 Thread David Spickett via cfe-commits
DavidSpickett wrote: @banach-space Your thoughts as the Flang driver owner? https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-27 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/4] [flang][clang] Add Visibility specific help text for

[clang] [clang][NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM, thanks. https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/3] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-21 Thread David Spickett via cfe-commits
@@ -3391,7 +3391,10 @@ def fno_openmp : Flag<["-"], "fno-openmp">, Group, def fopenmp_version_EQ : Joined<["-"], "fopenmp-version=">, Group, Flags<[NoArgumentUnused]>, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, - HelpText<"Set OpenMP version (e.g. 45

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From a996499580066213c3437cbb96735b7404291c3d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/3] [flang][clang] Add Visibility specific help text for

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-21 Thread David Spickett via cfe-commits
@@ -3391,7 +3391,10 @@ def fno_openmp : Flag<["-"], "fno-openmp">, Group, def fopenmp_version_EQ : Joined<["-"], "fopenmp-version=">, Group, Flags<[NoArgumentUnused]>, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, - HelpText<"Set OpenMP version (e.g. 45

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-15 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81869 >From a996499580066213c3437cbb96735b7404291c3d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Feb 2024 09:52:22 + Subject: [PATCH 1/2] [flang][clang] Add Visibility specific help text for

[clang] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-15 Thread David Spickett via cfe-commits
DavidSpickett wrote: This is a bit of an RFC given that there's only one flang option that requires this that I know of. So this could be too much complication now. Since I was in the area I figured I'd try it anyway, we can always attach this to an issue for later use if necessary.

[clang] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-02-15 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/81869 And use it to print the correct default OpenMP version for flang. This change adds an optional HelpTextForVisibility to options. This allows you to change the help text (shown in documentation and --help)

[clang] 9f2d8cd - [flang][clang][docs] Split out Clang specific doc text for -mrvv-vector-bits

2024-02-15 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-02-15T11:49:59Z New Revision: 9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5 URL: https://github.com/llvm/llvm-project/commit/9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5 DIFF: https://github.com/llvm/llvm-project/commit/9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5.diff

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-15 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/81726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81726 >From 101fb01100873cb69e1d3bb4e7cadf6a45e42d83 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 14 Feb 2024 11:20:51 + Subject: [PATCH 1/2] [clang][flang][driver] Correct program names in

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: Fixed the warning. https://github.com/llvm/llvm-project/pull/81726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/81726 >From 74fe9a47aecac7f7d16485d11781c9cc92229429 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 14 Feb 2024 11:20:51 + Subject: [PATCH 1/2] [clang][flang][driver] Correct program names in

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: Yes I had to disable sphix -Werr for that, I will try to fix it. https://github.com/llvm/llvm-project/pull/81726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c5e1384 - [clang][docs] Remove trailing whitespace

2024-02-14 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-02-14T12:51:30Z New Revision: c5e13840fdc20adce51673a63d5703bf1ed02aba URL: https://github.com/llvm/llvm-project/commit/c5e13840fdc20adce51673a63d5703bf1ed02aba DIFF: https://github.com/llvm/llvm-project/commit/c5e13840fdc20adce51673a63d5703bf1ed02aba.diff

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: @llvm/pr-subscribers-flang-driver https://github.com/llvm/llvm-project/pull/81726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: To add program specific option help, my idea is to store mutliple strings in the driver and select based on who's asking for the help. I think that warrants its own change so I'm not attempting that here. Also, there's only 2 flang options that refer to clang so it's not

[clang] [flang] [clang][flang][driver] Correct program names in option group descriptions (PR #81726)

2024-02-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/81726 Currently https://flang.llvm.org/docs/FlangCommandLineReference.html refers to "Clang" in several of the group descriptions for example: ``` Compilation options Flags controlling the behavior of Clang

[clang] 7a5c1a4 - [clang][docs] Fix warning in LanguageExtensions

2024-02-13 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-02-13T16:39:59Z New Revision: 7a5c1a4abc750fef335c2ee5191d59ebe9e4bf18 URL: https://github.com/llvm/llvm-project/commit/7a5c1a4abc750fef335c2ee5191d59ebe9e4bf18 DIFF: https://github.com/llvm/llvm-project/commit/7a5c1a4abc750fef335c2ee5191d59ebe9e4bf18.diff

[clang] 1d84792 - [clang][Driver] Small correction to print-runtime-dir

2024-02-13 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-02-13T16:14:03Z New Revision: 1d8479225a8c1efc8c90511e6c7fe608ff38163c URL: https://github.com/llvm/llvm-project/commit/1d8479225a8c1efc8c90511e6c7fe608ff38163c DIFF: https://github.com/llvm/llvm-project/commit/1d8479225a8c1efc8c90511e6c7fe608ff38163c.diff

[clang] 381a00d - [clang][Driver][HLSL] Fix formatting of clang-dxc options group title

2024-02-13 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-02-13T16:05:03Z New Revision: 381a00de4fdcccd904dac6a0856fb44f12ba0abb URL: https://github.com/llvm/llvm-project/commit/381a00de4fdcccd904dac6a0856fb44f12ba0abb DIFF: https://github.com/llvm/llvm-project/commit/381a00de4fdcccd904dac6a0856fb44f12ba0abb.diff

[clang] [flang] [flang][Driver] Add -masm option to flang (PR #81490)

2024-02-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/81490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Add -masm option to flang (PR #81490)

2024-02-13 Thread David Spickett via cfe-commits
@@ -0,0 +1,13 @@ +// RUN: %flang -target x86_64-unknown-linux -masm=intel -S %s -### 2>&1 | FileCheck --check-prefix=CHECK-INTEL %s DavidSpickett wrote: 1. Done, I forgot this wasn't actually parsing the file. So I've removed the function as well, it's not

  1   2   3   4   >