[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. The issues highlighted here have been partially (one could argue mostly) solved by D105821 . That patch hasn't been merged because it needs more tests and also needs to be split. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dee50111c13: [analyzer] Move docs of SmartPtr to correct subcategory (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

RedDocMD created this revision. RedDocMD added reviewers: NoQ, teemperor, xazax.hun, vsavchenko. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this revision.

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

RedDocMD added a comment. In D108912#2982201 , @Szelethus wrote: > In D108912#2982169 , @RedDocMD > wrote: > >> I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't >> be added since

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

RedDocMD added a comment. I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't be added since they only involve an alpha checker. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108912/new/ https://reviews.llvm.org/D108912

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG198e6771e24f: [analyzer] Add option to SATest.py for extra checkers (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 366558. RedDocMD added a comment. Connecting to MallocChecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:440 + State, {std::make_pair(CC->getCXXThisVal(), ArgVal)}, + C.getLocationContext(), PSK_DirectEscapeOnCall, ); It seems to me that this

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 365031. RedDocMD added a comment. Further pointer escape Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364490. RedDocMD added a comment. Never gonna give you up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364486. RedDocMD added a comment. Bug fix in modelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. I have incorporated the bug-fixes suggested last meeting (except the pointer escape one). And it seems to have had dramatic results - now the only extra errors being reported are the pointer escape ones (5 of them, from 3 different projects). Some projects are

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364074. RedDocMD added a comment. Better modelling, bug fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. Well some of them are exactly the same type as the `Lame` class example above. Like: `simbody/report-TestArray.cpp-testMoveConstructionAndAssignment-27-1.html#EndPath`. (So the incomplete modelling of the destructor is at least one cause. The other reason that you

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 363138. RedDocMD added a comment. Invalidating using inner pointer destructor call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. In D106739#2907647 , @ASDenysPetrov wrote: > @RedDocMD Could you, please, explain the motivation and add at least one test > to verify it works. Motivation: I need to run these projects with the SmartPtrChecker enabled

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. On running this patch on the `projects` directory, a bunch of projects emit false-positives: mostly of the form `Potential memory leak`. This points to the fact that without calling the destructor of the pointee type, we are going to have a lot of false positives (408

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 362741. RedDocMD added a comment. Put in a TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:381 +const MemRegion *ThisRegion = DC->getCXXThisVal().getAsRegion(); +assert(ThisRegion && "We do not support explicit calls to destructor"); +const auto *InnerPtrVal

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 362738. RedDocMD added a comment. Bug fixes, some cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:143 +llvm::ArrayRef ValidNames(STD_PTR_NAMES); +return llvm::is_contained(ValidNames, Name); } vsavchenko wrote: > And why can't we pass `STD_PTR_NAMES`

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:421-422 const auto *TrackingExpr = Call.getArgExpr(0); - assert(TrackingExpr->getType()->isPointerType() && - "Adding a non pointer value to

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. Ah I see. As a side note, without the "redundant" invalidation that is being done, the analyzer crashes on `shared_ptr`. (Because the `State` essentially remains the same and that's what causes the crash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 362310. RedDocMD added a comment. Invalidating via the CallEvent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 361581. RedDocMD added a comment. Removed a fatal bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. @vsavchenko is this okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/ https://reviews.llvm.org/D106739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. In D105821#2897006 , @NoQ wrote: >> the following code doesn't emit any warnings > > This code doesn't seem to have any `unique_ptr`s in it? It's not like you're > modeling this custom class as well? Can you try the same with

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD added a comment. It turns out that there is already an option called `extra-analyzer-config` to pass analyzer configs, like setting `ModelSmartPtrDereference` to true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106739/new/

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

RedDocMD created this revision. RedDocMD added reviewers: vsavchenko, NoQ, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this revision.

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. > But before we go there we should decide whether we want to actually go for > inlining (or otherwise default-evaluating) these destructors. If we do, we > should probably not spend too much time on improving invalidation in the > checker, because default evaluation

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:291 // we can try this function - if (Call.getNumArgs() == 2 && - Call.getDecl()->getDeclContext()->isStdNamespace()) -if (smartptr::isStdSmartPtr(Call.getArgExpr(0))

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80068ca6232b: [analyzer] Fix for faulty namespace test in SmartPtrModelling (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. This is a minimal model of destructors in smart-ptr. Other than the need to probably model the destructor of the pointee, is there anything else to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360218. RedDocMD added a comment. Minimal modelling of destructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360202. RedDocMD added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360199. RedDocMD added a comment. Retrieving patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360064. RedDocMD added a comment. Removed unnecessary white space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252 +static bool isStdFunctionCall(const CallEvent ) { + return Call.getDecl() && Call.getDecl() ->getDeclContext()->isStdNamespace(); +} vsavchenko wrote: > nit:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252-255 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + return Decl->getDeclContext()->isStdNamespace(); vsavchenko wrote: > Can we use a

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360061. RedDocMD added a comment. More refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360051. RedDocMD added a comment. Refactored out check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added a comment. Would this test do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360027. RedDocMD added a comment. Added a simple test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files:

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:275 +return false; + const auto *Decl = Call.getDecl(); + if (!Decl) xazax.hun wrote: > Can we model a function call without a declaration? I wonder if we

[PATCH] D106296: [analyer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 359865. RedDocMD added a comment. Reformatted patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D106296: [analyer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: martong, rnkovacs. RedDocMD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch: - Fixes how the

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD closed this revision. RedDocMD added a comment. For some reason this revision did not get automatically closed after commit, manually merging it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd825309352b4: [analyzer] Handle std::make_unique (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359627. RedDocMD added a comment. Marked test with FIXME notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359625. RedDocMD added a comment. Fixed up tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359605. RedDocMD added a comment. Post-rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd98bef1b6f: [analyzer] Handle std::swap for std::unique_ptr (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 359600. RedDocMD added a comment. Post rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 359211. RedDocMD added a comment. Post rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG48688257c52d: [analyzer] Model comparision methods of std::unique_ptr (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 358998. RedDocMD added a comment. Removed one bug, many more to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 358839. RedDocMD added a comment. Cleanup, still doesn't work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. Is the syntax of specifying expected notes and warnings documented somewhere? I could not find the note-specific syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 358267. RedDocMD added a comment. Fixing up tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 358204. RedDocMD added a comment. Removed stupid mistakes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357724. RedDocMD added a comment. Little refactors, one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files:

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:195 +const SmallVector BasicOstreamName = {"basic_ostream"}; + vsavchenko wrote: > Same here + don't call it "Name"

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357422. RedDocMD added a comment. Tests implemented Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD added a comment. I will be figuring out some tests tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 ___ cfe-commits mailing list

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357307. RedDocMD added a comment. Little refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:218-219 + + if (isStdOstreamOperatorCall(Call)) +return true; + NoQ wrote: > When you're doing `evalCall` you're responsible for modeling *all* aspects of >

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357031. RedDocMD added a comment. Invalidating regions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356526. RedDocMD added a comment. Major bug fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356371. RedDocMD added a comment. Little refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:316 + +class OperatorKind { + union { NoQ wrote: > One good place to put this may be `CheckerHelpers.h`. This is where

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356226. RedDocMD added a comment. Simplify SVal on state split, other refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD marked 3 inline comments as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:484 + clang_analyzer_eval(nullPtr != nullptr);// expected-warning{{FALSE}} + clang_analyzer_eval(nullptr <= unknownPtr); // expected-warning{{TRUE}} +}

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356128. RedDocMD added a comment. Performing state split on normal comparision ops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:443-446 + auto RetVal = C.getSValBuilder().evalBinOp( + State, BOK, FirstPtrVal, SecondPtrVal, Call.getResultType()); + State = State->BindExpr(Call.getOriginExpr(),

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 355458. RedDocMD added a comment. Refactored out common block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 355445. RedDocMD added a comment. Fixed bug in enum conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD added a comment. Sorry for not updating. Was down with fever. This patch does *not* work now. `operationKindFromOverloadedOperator` is broken because the maps don't get populated. I am not entirely sure why this is happening. Will try to fix tomorrow. @NoQ, @vsavchenko, @xazax.hun,

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354695. RedDocMD added a comment. First try at implementing conversion function from OverloadedOperatorKind to BinaryOperatorKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:466 + + clang_analyzer_eval(ptr == ptr); // expected-warning{{TRUE}} + clang_analyzer_eval(ptr > ptr); // expected-warning{{FALSE}} xazax.hun wrote: > RedDocMD wrote: > > xazax.hun

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354460. RedDocMD added a comment. Removed dump statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:466 + + clang_analyzer_eval(ptr == ptr); // expected-warning{{TRUE}} + clang_analyzer_eval(ptr > ptr); // expected-warning{{FALSE}} xazax.hun wrote: > Putting tests like this on the

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354459. RedDocMD added a comment. Refactored code, removed duplications, fixed tests, added some more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + const OverloadedOperatorKind OOK = FD->getOverloadedOperator(); + if (!(OOK == OO_Equal || OOK == OO_ExclaimEqual || OOK ==

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. We have a failing test here (test at line 473). Which makes me wonder if the `handleComparision` function is at all called. This is something I need to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354323. RedDocMD added a comment. Removed re-invention, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2835061 , @xazax.hun wrote: > In D104616#2835030 , @RedDocMD > wrote: > >> Looks like I have wasted a good deal of effort. :( > > Sorry about that! :( If we learned anything

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2834770 , @xazax.hun wrote: > In D104616#2834714 , @NoQ wrote: > >> Why not simply delegate this job to `assume(evalBinOp(...))` over raw >> pointer values, which already has

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 353709. RedDocMD added a comment. Logic for handling special cases, when both are unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. The only method that I think can be realistically modelled is `==` (and thus `!=`). If both the operands refer to the same `unique_ptr`, we know `==` returns true. If they are not the same, the only way `==` can return true if the two smart pointers were initialized

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2827548 , @RedDocMD wrote: > In D103750#2825342 , @NoQ wrote: > >> Do the above tests pass when your new `evalCall` modeling is enabled? > > The analyzer doesn't seem to be

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD abandoned this revision. RedDocMD added a comment. I am closing this since it has been addressed much better by the patches from @vsavchenko. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103434/new/ https://reviews.llvm.org/D103434

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 353068. RedDocMD added a comment. Some more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files:

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD marked 5 inline comments as done. RedDocMD added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:435 + void markNotInteresting(SymbolRef sym); + xazax.hun wrote: > Bikeshedding: I wonder if we prefer

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2825823 , @xazax.hun wrote: > I believe there are a couple of comments that are done but not marked > accordingly. > I agree with Artem, if we could craft code that fails due to not calling > ctors, we should

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 353048. RedDocMD added a comment. Little changes, a failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2825342 , @NoQ wrote: > In D103750#2823741 , @RedDocMD > wrote: > >> I would suppose that constructor calls are properly handled. (ie, member >> constructors are called

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:3 +// RUN: -analyzer-checker=core,cplusplus.Move,alpha.cplusplus.SmartPtr\ +// RUN: -analyzer-config

  1   2   3   >