[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b95d17da1f0: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for… (authored by fwolff). Repository: rG LLVM Github

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263f45ba649: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions`… (authored by fwolff). Repository: rG LLVM Github

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

fwolff updated this revision to Diff 548347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157436/new/ https://reviews.llvm.org/D157436 Files: clang-tools-extra/clang-tidy/performance/FasterStringFindCheck.cpp

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff marked an inline comment as done. fwolff added a comment. Thanks for reviewing this @PiotrZSL! In D157428#4570497 , @PiotrZSL wrote: > What about switchStmt ? The `AllowIntegerConditions` and `AllowPointerConditions` options only apply to `int

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548342. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548334. fwolff added a comment. Mention this change in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files:

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

fwolff created this revision. fwolff added reviewers: PiotrZSL, carlosgalvezp. fwolff added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber:

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff created this revision. fwolff added reviewers: PiotrZSL, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

fwolff added a comment. I suppose it sounds sensible to have the option of ignoring certain containers in this check; though I haven't needed it myself so far, which is also why I'm leaning against ignoring `std::array` by default. But I do not claim ultimate authority on this question, of

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

fwolff updated this revision to Diff 434283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127036/new/ https://reviews.llvm.org/D127036 Files: clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

fwolff created this revision. fwolff added reviewers: aaron.ballman, njames93, alexfh. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

This revision was automatically updated to reflect the committed changes. Closed by commit rG95d77383f2ba: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D113804?vs=400677=424172#toc

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff added a comment. Ping @aaron.ballman. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcce79514ff40: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent… (authored by fwolff). Herald added a project: All. Changed prior to commit:

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb3b3f76bf75: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers (authored by fwolff). Herald added a project: All. Changed prior to commit:

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGf25935a00091: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D114292?vs=400634=423908#toc Repository: rG

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18634b74fc0: [clang-tidy] Never consider assignments as equivalent in `misc-redundant… (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122535?vs=418420=42#toc Repository:

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, njames93. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Attempts to

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG528e6eba2f79: [clang] Improve diagnostic for reopened inline namespace (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122278?vs=417455=417749#toc Repository: rG LLVM Github

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

fwolff created this revision. fwolff added reviewers: rsmith, cor3ntin, mizvekov. fwolff added a project: clang. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes #50794 .

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rG07675b0b38e9: [clang-tidy] Fix false positives in `misc-redundant-expression` check (authored by fwolff). Changed prior to commit:

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

fwolff marked an inline comment as done. fwolff added a comment. Thanks for the quick review @aaron.ballman! I think I've addressed your comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605 + unless(isMacro()),

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

fwolff updated this revision to Diff 417054. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122111/new/ https://reviews.llvm.org/D122111 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

fwolff created this revision. fwolff added reviewers: alexfh, aaron.ballman, pavelkryukov. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rGd3b188a2d72f: [clang-tidy] Include constructor initializers in `bugprone-exception-escape`… (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7b7138a6264: [clang-tidy] Make `readability-container-data-pointer` more robust (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 400680. fwolff added a comment. Fixed the nits. Thanks for the review @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files:

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 400677. fwolff added a comment. Rebased and ping @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff added a comment. @aaron.ballman Ping? I think I've responded to all comments so far; let me know if you still have concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 ___ cfe-commits

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff marked an inline comment as done. fwolff added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp:291-293 +struct super_throws { + super_throws() noexcept(false) { throw 42; } +}; aaron.ballman wrote: >

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff updated this revision to Diff 400668. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113507/new/ https://reviews.llvm.org/D113507 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp Index:

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff updated this revision to Diff 400634. fwolff added a comment. I've added the `static_cast` and an entry in the release notes. I'm not sure how to handle `[[no_unique_address]]`, so I'd rather leave this to future work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/new/

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

fwolff updated this revision to Diff 400625. fwolff added a comment. In D115124#3209199 , @Sockke wrote: > Could you please add a test case where the smart pointer object is > dereferenced before calling `size()`? E.g. `return (*ptr).size() == 0;`. I >

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd2accc61ea: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional… (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D114197?vs=391850=400618#toc

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG42bc3275d368: [clang-tidy] Fix `readability-redundant-declaration` false positive for… (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

fwolff created this revision. fwolff added reviewers: mizvekov, compnerd. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51776

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, JonasToth, lebedev.ri. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52254

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

fwolff created this revision. fwolff added reviewers: aaron.ballman, simon.giesecke, jcking1034. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 391871. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff marked 3 inline comments as done. fwolff added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:76 +arraySubscriptExpr(hasLHS(ContainerExpr), hasRHS(Zero)) + .bind(AddressOfName),

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 391869. fwolff marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 391852. fwolff added a comment. Thanks for your comments @whisperity! They should all be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files:

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff marked 2 inline comments as done. fwolff added a comment. Thanks for your comments @whisperity. I think I've addressed them, could you have another look? Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:151 + using Alias3

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff updated this revision to Diff 391850. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/ https://reviews.llvm.org/D114197 Files: clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff marked 2 inline comments as done. fwolff added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4524-4525 if (!Dependent) { -if (Context.hasSameUnqualifiedType(QualType(ClassDecl->getTypeForDecl(),0), - BaseType)) +

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG987a21522f2c: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff added a comment. In D114299#3164127 , @aaron.ballman wrote: > Hmm, the test case you added passes without the patch applied: > https://godbolt.org/z/T9TerMYGz You are right; I have fixed the test now, and I've also added your other example as

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff updated this revision to Diff 391163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114299/new/ https://reviews.llvm.org/D114299 Files: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

fwolff updated this revision to Diff 391102. fwolff added a comment. In D113828#3164016 , @aaron.ballman wrote: > LGTM! Can you add a release note about the bug fix? Done. Thank you for the review! Can you also commit it for me? You can use name and

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

fwolff created this revision. fwolff added reviewers: Eugene.Zelenko, alexfh, Szelethus. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#48086

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff created this revision. fwolff added reviewers: alexfh, whisperity, hokein. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51620

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff added a comment. Thanks for the quick review! Can you also commit it for me? You can use name and email as in commit `738e7f1231949ec248c1d8d154783338215613d1`. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

fwolff created this revision. fwolff added reviewers: aaron.ballman, alexfh, whisperity, mizvekov. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, jeroen.dobbelaere, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber:

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff updated this revision to Diff 387401. fwolff added a comment. Thanks again for your feedback @salman-javed-nz! I think I've addressed all of your comments now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113830/new/ https://reviews.llvm.org/D113830 Files:

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff added a comment. In D113585#3132810 , @aaron.ballman wrote: > In D113585#3132793 , @fwolff wrote: > >> Thanks for reviewing this! Can you also commit it for me? > > Sure can! What name and email address

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff marked an inline comment as done. fwolff added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:20-23 +static const char ContainerExprName[] = "container-expr"; +static const char DerefContainerExprName[] =

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387384. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff added a comment. Thanks for reviewing this! Can you also commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113585/new/ https://reviews.llvm.org/D113585 ___ cfe-commits mailing list

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 387377. fwolff added a comment. Thanks for your suggestions @whisperity! I have fixed both of them now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files:

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387133. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff created this revision. fwolff added reviewers: compnerd, alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52245. I've also added a

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff updated this revision to Diff 387121. fwolff added a comment. Thanks for your comments @salman-javed-nz! I have expanded the tests now according to your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113830/new/ https://reviews.llvm.org/D113830 Files:

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

fwolff updated this revision to Diff 387116. fwolff added a comment. Thanks for reviewing this @carlosgalvezp! I have removed the "dead" test and put it into a follow-up issue (PR#52502). If you are otherwise happy with the changes, could you commit them for me? CHANGES SINCE LAST ACTION

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff created this revision. fwolff added reviewers: alexfh, salman-javed-nz. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes part of PR#45815. Overriding

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

fwolff created this revision. fwolff added reviewers: alexfh, aaron.ballman, mizvekov. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, abrachet, phosek, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#47614.

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff created this revision. fwolff added reviewers: alexfh, whisperity. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#50990. Repository: rG

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

fwolff created this revision. fwolff added reviewers: alexfh, carlosgalvezp. fwolff added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#38187. Constructors are actually already

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:374 { PositiveSelfInitialization() : PositiveSelfInitialization() {} }; carlosgalvezp wrote: > fwolff wrote: > > carlosgalvezp

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff updated this revision to Diff 386620. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 Files: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp clang/lib/Sema/SemaDeclCXX.cpp Index:

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff marked 2 inline comments as done. fwolff added a comment. Thanks for your review @carlosgalvezp! I have addressed your inline comments. I'm not sure about the failing test, but it looks like a regression test internal to libFuzzer? Maybe it goes away with the rebuild.

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff updated this revision to Diff 386297. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 Files: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp clang/lib/Sema/SemaDeclCXX.cpp Index:

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

fwolff updated this revision to Diff 386244. fwolff added a comment. The test failed on Windows. I don't have a machine to reproduce this, but maybe adding `-fno-delayed-template-parsing` helps. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113499/new/ https://reviews.llvm.org/D113499

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff created this revision. fwolff added reviewers: steveire, alexfh, Eugene.Zelenko. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52400. The tests for

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff created this revision. fwolff added reviewers: rsmith, dblaikie, carlosgalvezp. fwolff added a project: clang. Herald added subscribers: kbarton, nemanjai. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Herald added a project: clang-tools-extra. This

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff created this revision. fwolff added reviewers: alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52435. Repository: rG LLVM

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

fwolff created this revision. fwolff added reviewers: alexfh, klimek, djasper. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52081 by attempting to detect

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

fwolff added a comment. Thanks for reviewing this! Can you (or someone else) commit this for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113429/new/ https://reviews.llvm.org/D113429

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

fwolff created this revision. fwolff added reviewers: simon.giesecke, alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52217.