[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. In D149162#4404271 , @agozillon wrote: > I have hopefully fixed the sanitizer issue (the incorrect assert, thank you > again for the catch) with the following patch: >

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5201-5204 + if (auto EC = sys::fs::getUniqueID(FileName, ID)) { +assert(EC && + "Unable to get unique ID for file, during getTargetEntryUniqueInfo"); + } This

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. This triggered an MSAN error: https://lab.llvm.org/buildbot/#/builders/237/builds/3127/steps/13/logs/stdio 1: ==1184292==WARNING: MemorySanitizer: use-of-uninitialized-value check:6'0 X~~~

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2684acfb61d: [HWASan] use hwasan linker for Android 14+ (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

fmayer created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. fmayer requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This will allow to compile binaries that use hwasan to run on a non-HWASan

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

fmayer added a comment. This seems to have broken our buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/16797/steps/8/logs/stdio CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

fmayer accepted this revision. fmayer added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); fmayer

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

fmayer added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); Is the story here that on

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

fmayer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25 + +using namespace llvm; + why don't we put this into the llvm namespace rather than using? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

fmayer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60 + // gadgets. + if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) { +Meta.Memtag = false; not necessarily in this CL: do we want some

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > vitalybuka wrote: > > > maybe we should pop

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > vitalybuka wrote: > > maybe we should pop everything up to "pc"

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added a comment. In D103562#3702962 , @smd wrote: > Hi folks, > > I've been working on support hwasan for risc-v and I believe I've found an > issue with the existing lit tests this commit causes. > Tests stack-{oob,uar,uas}.c check for correct

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

fmayer added a comment. This CL seems to have an MSAN violation: https://lab.llvm.org/buildbot/#/builders/74/builds/12529/steps/11/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

fmayer added a comment. FWIW this is not really NFC, I found this as the culprit in bisecting the Android LLVM toolchain build, causing the following error: FAILED: tools/clang/tools/extra/pseudo/include/CXXBNF.inc

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fmayer marked an inline comment as done. Closed by commit rG1d730d80ce59: [HWASAN] erase lifetime intrinsics if tag is outside. (authored by fmayer). Repository: rG

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer marked 2 inline comments as done. fmayer added inline comments. Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \ //

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer updated this revision to Diff 412183. fmayer added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120437/new/ https://reviews.llvm.org/D120437 Files: clang/test/CodeGen/lifetime-sanitizer.c

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer added inline comments. Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \ // RUN: FileCheck %s

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer updated this revision to Diff 411448. fmayer added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120437/new/ https://reviews.llvm.org/D120437

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

fmayer added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:842 + if (!Args.hasArg(options::OPT_shared)) +SharedRuntimes.push_back("hwasan-preinit"); } pcc wrote: > morehouse wrote: > > eugenis wrote: > > > pcc wrote: >

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:812 bool runOnFunction(Function ) override { +if (ClUseStackSafety) { + report_fatal_error("Stack safety analysis is not supported " kstoimenov wrote:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added a comment. I think you also want to use `SSI->isSafe(AllocaInst*)` in `isInterestingAlloca` to prevent use-after-scope instrumentation if all accesses are safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + fmayer wrote: > Should this file be in llvm/test/Instrumentation/ instead? Also consider > porting some of the tests from HWASan >

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + Should this file be in llvm/test/Instrumentation/ instead? Also consider porting some of the tests from HWASan

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1499-1502 + if (ClUseStackSafety && findAllocaForValue(Ptr)) { +if (SSI && SSI->stackAccessIsSafe(*Inst)) { + return true; +} Doesn't need nested if.

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

fmayer accepted this revision. fmayer added a comment. This revision is now accepted and ready to land. Thanks LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/ https://reviews.llvm.org/D108241

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. This broke the UBsan buildbot: https://lab.llvm.org/buildbot/#/builders/85/builds/6103/steps/10/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106858: [hwasan] Fix stack safety test for old PM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG835ef6f93d57: [hwasan] Fix stack safety test for old PM. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106858: [hwasan] Fix stack safety test for old PM.

fmayer created this revision. fmayer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the old PM, the stub for __hwasan_generate_tag is still generated in the IR, but never called. Repository: rG LLVM Github Monorepo

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Sorry. broke a buildbot again: https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c I am not sure why I cannot reproduce this locally. Pass

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fmayer marked 4 inline comments as done. Closed by commit rGbde9415fef25: [hwasan] Use stack safety analysis. (authored by fmayer). Changed prior to commit:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360735. fmayer added a comment. formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); fmayer wrote: > vitalybuka

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360623. fmayer added a comment. more flag parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); vitalybuka wrote: > Why not

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. This broke https://lab.llvm.org/buildbot/#/builders/105/builds/12584. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360076. fmayer added a comment. fix required analysis logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Made some buildbot unhappy again. Sorry :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c63ed10b3b: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360054. fmayer marked an inline comment as done. fmayer added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. I removed the stack-safety-analysis-asm.c test because I don't think it really adds anything and it caused problems. SGTY? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359749. fmayer added a comment. remove stack safety asm test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Broke some postsubmit bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12268fe14a1a: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359726. fmayer added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll:27 + +attributes #0 = { mustprogress nofree nounwind uwtable willreturn "frame-pointer"="non-leaf" "min-legal-vector-width"="0" "no-trapping-math"="true"

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359716. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359715. fmayer added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359714. fmayer marked 6 inline comments as done. fmayer added a comment. improve test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359376. fmayer marked 3 inline comments as done. fmayer added a comment. fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359373. fmayer added a comment. don't use stack analysis for opt null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; fmayer wrote: > eugenis wrote: > > No need to pass this down, just look at OptimizeNone function attribute.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 2 inline comments as done. fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; eugenis wrote: > No need to pass this down, just look at

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 3 inline comments as done. fmayer added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1 +// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359326. fmayer added a comment. add llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359263. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module , ModuleAnalysisManager ); static bool isRequired() { return true; }

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358885. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. Thanks! Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka wrote: > fmayer wrote: > > vitalybuka wrote: > > > this patch mostly change code under llvm/ so

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358884. fmayer marked 7 inline comments as done. fmayer added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358579. fmayer marked an inline comment as done. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked an inline comment as done and an inline comment as not done. fmayer added a comment. Addressed inline comments. Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358577. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358567. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358565. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358564. fmayer marked 2 inline comments as done. fmayer added a comment. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files:

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358043. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer created this revision. Herald added subscribers: ormris, hiraditya. fmayer updated this revision to Diff 357514. fmayer added a comment. fmayer edited the summary of this revision. fmayer updated this revision to Diff 357544. fmayer edited the summary of this revision. fmayer updated this

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. I do not have commit access. Could someone submit this patch please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. I am not very experienced with Phabricator, but I think this needs another approval for the latest revision :) Thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry-custom-macro.c:25 +void with_custom_macro() { + MY_TEMP_FAILURE_RETRY((foo())); + MY_TEMP_FAILURE_RETRY((int)(foo() == 1)); alexfh

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer updated this revision to Diff 291520. fmayer added a comment. Added more simple cases to the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 Files: clang-tools-extra/clang-tidy/android/ComparisonInTempFailureRetryCheck.cpp

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. Should I wait for Alex to take a look, or is it fine like this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer updated this revision to Diff 291297. fmayer added a comment. Added new file for the tests. This way, we keep the tests for the normal case as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 Files:

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry.c:1 -// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t +// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. Hey, any updates on this? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer created this revision. fmayer added a reviewer: george.burgess.iv. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some projects do not use the TEMP_FAILURE_RETRY macro but define their own one, as not to depend on glibc / Bionic details. By allowing the user to