[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); MaskRay wrote: > FreddyYe

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13317 + continue; +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( Don't quite understand why we need to change

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); Will function multi version

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:167 + FEATURE_WP, + FEATURE_LZCNT = 57, + FEATURE_MOVBE, ` = 57` redundant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158046: [X86] Support -march=gracemont

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acff5390d05: [X86] Support -march=gracemont (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > FreddyYe wrote: > > RKSimon wrote: > > > Why not handle this above (below tremont) as the next

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe updated this revision to Diff 551350. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046 Files:

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > Why not handle this above (below tremont) as the next

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. gracemont has some

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d92e66387b: [X86] Support -march=arrowlake,arrowlake-s,lunarlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544625. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files:

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544314. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files:

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN:

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN:

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544159. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files:

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d23a3faa4e6: [X86] Support -march=graniterapids-d and update -march=graniterapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543826. FreddyYe added a comment. rebase and fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc4b1059b28: [X86] Update features for sierraforest, grandridge (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543797. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543344. FreddyYe added a comment. Update cpu_specific required features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512,

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543342. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512,

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

FreddyYe updated this revision to Diff 542476. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 Files:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542446. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files:

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1922 +// RUN: --target=x86_64 \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_GNRD_M64 // CHECK_GNR_M64: #define __AES__ 1 RKSimon wrote: > Maybe

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542360. FreddyYe added a comment. add clang releasenote Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155148: [X86] Add SM4 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG049d6a3f428e: [X86] Add SM4 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 542305. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

FreddyYe added a comment. ping... Anyone help accept? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155147: [X86] Add SM3 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6f66de21af0: [X86] Add SM3 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 542274. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155146: [X86] Add SHA512 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3b7874b6c9: [X86] Add SHA512 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 542267. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541824. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541815. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. I think we can discuss this issue first in https://reviews.llvm.org/D155662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541793. FreddyYe added a comment. Add missing doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:230 +/// \endcode +#define _mm_sm3rnds2_epi32(A, B, C, D) \ + (__m128i) __builtin_ia32_vsm3rnds2((__v4su)A, (__v4su)B, (__v4su)C, (int)D) pengfei

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541792. FreddyYe marked 5 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541787. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files:

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541503. FreddyYe added a comment. Remove -x86-asm-syntax=intel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541502. FreddyYe added a comment. Split assembly tests and cover more registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files:

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541496. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files:

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541495. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541392. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files:

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541373. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files:

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541343. FreddyYe added a comment. Refine doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541340. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address commments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155148: Add SM4 instructions.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/sm4-builtins.c:5 +#include +#include + RKSimon wrote: > what is stddef.h needed for? Good catch! probably be copy paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155146: Add SHA512 instructions.

FreddyYe updated this revision to Diff 540951. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155148: Add SM4 instructions.

FreddyYe updated this revision to Diff 540950. FreddyYe marked an inline comment as done. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files:

[PATCH] D155147: Add SM3 instructions.

FreddyYe updated this revision to Diff 540949. FreddyYe added a comment. Remove #include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155146: Add SHA512 instructions.

FreddyYe updated this revision to Diff 540909. FreddyYe added a comment. Remove `-check-prefix=CHECK` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155148: Add SM4 instructions.

FreddyYe updated this revision to Diff 540900. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files:

[PATCH] D155148: Add SM4 instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8308 +RC:$src2))]>, + Sched<[WriteVecIMul]>; +def rm : I<0xda, MRMSrcMem, (outs RC:$dst), skan wrote: >

[PATCH] D155147: Add SM3 instructions.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8331 +VR128:$src2, (loadv4i32 addr:$src3), timm:$src4))]>, + Sched<[WriteVecIMul]>; + } skan wrote: > Is the schedule appropriate? I referred to

[PATCH] D155146: Add SHA512 instructions.

FreddyYe updated this revision to Diff 540893. FreddyYe added a comment. Added FIXME for schedule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155147: Add SM3 instructions.

FreddyYe updated this revision to Diff 540892. FreddyYe marked 5 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files:

[PATCH] D155146: Add SHA512 instructions.

FreddyYe updated this revision to Diff 540885. FreddyYe marked 15 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files:

[PATCH] D155145: Add AVX-VNNI-INT16 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint16-intrinsics.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding

[PATCH] D155148: Add SM4 instructions.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer

[PATCH] D155147: Add SM3 instructions.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer

[PATCH] D155146: Add SHA512 instructions.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about this instruction, please refer to

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa10dccf2712f: [X86] Support some Intel CPUs for cpu_specific/dispatch feature (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe updated this revision to Diff 537980. FreddyYe added a comment. Tune test as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154493/new/ https://reviews.llvm.org/D154493 Files: clang/test/CodeGen/attr-cpuspecific-cpus.c

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:419 // Sapphire Rapids microarchitecture based processors. - { {"sapphirerapids"}, CK_SapphireRapids, FEATURE_AVX512BF16, FeaturesSapphireRapids, '\0', false }, + { {"sapphirerapids"},

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe updated this revision to Diff 537957. FreddyYe marked an inline comment as done. FreddyYe added a comment. Tuned some manglings. SPR should create a new mangling for its feature list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333 { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false }, { {"pentium-mmx"}, CK_PentiumMMX, ~0U, FeaturesPentiumMMX,

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. Thank so much on all your comments/review to make this happen. Cheers~! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7717c0071d7c: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 537065. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Add comments about Mangling and OnlyForCPUDispatchSpecific, and remove the supporting more/new CPU names for cpu_specific/dispatch feature. Repository: rG LLVM Github Monorepo

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){}

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping. If no objections, I'll merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536645. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase, especially for D151696 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb026c9eb1051: [X86] Add missing features for ivybridge, sandybridge and knl in… (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe added a comment. In D154209#4466304 , @RKSimon wrote: > LGTM - but it would be good to fix silvermont / westmere cases as well with > suitable test coverage Thanks review! After D151696 landed, they can be

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe updated this revision to Diff 536495. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment, thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 Files:

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt")

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -//

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is also a pre-commit change for D151696 Repository: rG LLVM

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536118. FreddyYe added a comment. changes according to the new RULE3, pls review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files:

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536116. FreddyYe added a comment. Rebase for D154181 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files:

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

FreddyYe added a comment. Thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154181/new/ https://reviews.llvm.org/D154181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9256a2e0450: [x86] Add missing FeatureCMOV in frontend targets. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. > Yes, it looks like it would be best to split off and commit some of the fixes > (cmov / the isa changes causing the attr-cpuspecific.c diffs etc.) first, > before this refactor patch. Done in https://reviews.llvm.org/D154181 Repository: rG LLVM Github Monorepo

[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The missing info is gathered from X86.td. Repository:

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. In D151696#4458435 , @pengfei wrote: > I have some concerns for RULE 3, especially `core_aes_pclmulqdq -> westmere` > and `atom_sse4_2_movbe -> silvermont`. > Sometimes, we have minor feature differences in the same generation

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added a comment. In D151696#4458443 , @pengfei wrote: > It looks to me the failed unit tests might be related to this patch, please > take a look. This is due to FeatureCMOV adding. Should I split

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:56 // WINDOWS: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4

  1   2   3   4   >